QAston
a409cc226c
Core/Spells: Fix Vanish's stealth trigger and Demonic Empowerment's invisibility trigger
...
Those spells were failing to pass default effect trigger spell due to their custom implementation (changing triggered_spell_id instead of adding serverside spells with proper targeting).
2011-09-27 00:36:23 +02:00
QAston
a2633bf7fc
Scripts: fix spell_generic_quest_update_entry script after e949ad3adb.
2011-09-27 00:12:45 +02:00
Machiavelli
c095cbb0ed
Make recent added Spellscript conform to hook name changes in e949ad3adb
2011-09-26 22:00:12 +03:00
Machiavelli
7ec351a79d
Scripts/Ulduar/Flame Leviathan: Fix Pursue spell (target selection/filtering, emote, and aggro), and clean up some atrocities in the script.
2011-09-26 20:47:51 +02:00
Machiavelli
f4ec95c752
Fixed a typo in pull request. (Edit via Github)
2011-09-26 21:05:16 +03:00
Chaplain
5bbd8dcf33
Core/Spell: Hymn of Hope fix.
...
*fixed mess with temporary increase max/current power (percent).
*thx Shocker for advice
2011-09-26 20:12:25 +03:00
Machiavelli
6a37c4056e
Merge pull request #3215 from Kapoeira/master
...
Core/Spells: Fixed glyph of Fire Blast
2011-09-26 08:49:35 -07:00
Shocker
6dc09248fd
Merge pull request #3162 from megamage/master
...
Fix incorrect logic in PetAI. Solve #3155 .
2011-09-26 06:44:33 -07:00
megamage
780747f5d3
Missing part of the previous commit.
2011-09-26 09:14:12 -04:00
megamage
a35deba186
Fix some crashes caused by spell scripts without checking unit type. Fix #3216 and #3217 .
2011-09-26 09:03:33 -04:00
Spp
7b68a6bf69
Core/Logging: Add new function to include full stacktrace.
...
Note: It only has use for devs but makes it easier to get the error with a full trace
2011-09-26 14:34:50 +02:00
Spp
8484b004dd
Core/Handler: Move couple of msgs to Debug
2011-09-26 09:52:17 +02:00
Cron
8622bedeac
Core/Spells: Fixed glyph of Fire Blast.
2011-09-25 15:53:31 -03:00
QAston
210a770958
Core/Spells: Fix totem passive area auras stacking bug.
2011-09-25 19:00:37 +03:00
Chaplain
224bb96deb
Core/Spells: Fix talent Sword Specialization.
2011-09-25 16:42:12 +03:00
Shauren
062e645637
Scripts/Spells: Bloodlust/Heroism handling changed, it is now possible to use these spells even if caster is under Sated/Exhaustion debuff
2011-09-25 15:08:48 +02:00
QAston
e949ad3adb
Core/Spells: spell effect handling improvements
...
* Call spell effect handlers in 4 modes:
- SPELL_EFFECT_HANDLE_LAUNCH - called when spell is launched (cast just finished)
- SPELL_EFFECT_HANDLE_LAUNCH_TARGET - called when spell is launched for each target in spell target map
- SPELL_EFFECT_HANDLE_HIT - called when spell hits its destination
- SPELL_EFFECT_HANDLE_HIT_TARGET - called when spell hits it's target from spell target map
*Correctly implement SPELL_EFFECT_TRIGGER_SPELL, SPELL_EFFECT_TRIGGER_SPELL_WITH_VALUE, SPELL_EFFECT_TRIGGER_MISSILE_SPELL_WITH_VALUE, SPELL_EFFECT_TRIGGER_MISSILE_SPELL
*Remove spell system hacks which became obsolete with this commit
Core/SpellScripts:
add OnEffectLaunch, OnEffectLaunchTarget, OnEffectHit, OnEffectHitTarget hooks for new effect handle modes and remove OnEffect hook.
A generic rule of thumb how to update your scripts (will work for nearly all cases) for spell system noobs:
if your spell script used GetHitXXXX function, you need to use OnEffectHitTarget, otherwise use
OnEffectHit
2011-09-25 13:29:50 +02:00
Chaplain
877579d386
Revert "Core/Spells: Fix talent Sword Specialization for melee abilities"
...
This reverts commit cdd4160157 .
2011-09-25 14:20:41 +03:00
Shauren
b07cc3751f
Core/Scripts: Added NULL checks to new target selectors, threat references aren't guaranteed to be valid always, also added (default true) player typeid check to NonTankTargetSelector
2011-09-24 23:30:11 +02:00
Shauren
da0229da8f
Core/Scripts: Implemented 2 new target selectors, one specialized for spells, checking auras, range and attributes; and the other is a very simple non-tank selection what is sufficient for most cases
2011-09-24 19:40:57 +02:00
QAston
cd7060c65a
Core/Spells: Add more generic overload for Unit::CastSpell function and make all cast functions use it as a base.
2011-09-24 16:41:50 +02:00
Machiavelli
911c7ce3cc
Scripts/Ulduar/Flame Leviathan: Fix RX-214 Repair-o-matic station.
...
Note: Due to an aura system bug, the dummy cooldown aura is refreshed every time the trap spell is cast instead of expiring like it should.
2011-09-24 13:13:15 +02:00
Shauren
29ba648fa3
Scripts/Icecrown Citadel: Fixed possible crash in npc_darnavanAI
...
Closes #3188
2011-09-24 11:29:49 +02:00
QAston
d01a761f53
Core/Spells: Drop EFFECT_IMPLICIT_TARGET_PET and use EFFECT_IMPLICIT_TARGET_EXPLICIT instead.
2011-09-24 02:02:39 +02:00
QAston
71bbbaa21b
Merge pull request #3146 from Havenard/fix0001
...
Reimplement WorldObject::IsInBetween() to work as intented.
2011-09-23 06:04:17 -07:00
Machiavelli
9692be4cbb
Scripts/Ulduar/XT-002: Add gameobject handling for XT-002 door and boundary checking during the encounter.
2011-09-23 13:20:43 +02:00
QAston
413b542cd9
Add a tempfix for trigger missile spell effects after rev 13a1d90130.
2011-09-23 13:09:31 +02:00
QAston
13a1d90130
Core/Spells: Improvements in selecting default targets based on effect type.
2011-09-23 11:58:40 +02:00
Spp
ab023e847a
Core/Misc: Add <GM> tag to GMs in Who list
2011-09-23 11:23:22 +02:00
Souler
99c63e86ae
Scripts/Ulduar: Make XT-002 and Ignis enter evade mode if pulled out from their fight areas.
...
Also implement a default case for EnterEvadeIfOutOfCombatArea.
2011-09-22 22:14:52 +02:00
Machiavelli
9ea40a4746
Scripts/Ulduar/Kologarn:
...
- Fix arm respawn and reinstall events
- Fix possible erratic event timers
- Fix Focused Eyebeams after recent spell system changes
- Fix looting the chest after the encounter
2011-09-22 21:19:26 +02:00
Shauren
154c7ce79c
Core/Spells: Fixed Brewfest - Attack Keg spell damage
2011-09-22 20:16:47 +02:00
Machiavelli
c909da08cd
Scripts/Ulduar/XT-002: Fix erratic timer issues and stand/submerge spell script targets.
...
Fixes #2961
2011-09-22 20:13:40 +02:00
QAston
29fef71137
Merge pull request #2915 from idostyle/armorPen
...
Core/Mechanics: Cap armorPen to maxArmorPen - prevents having armor penetration rating greater than 100%.
2011-09-22 02:03:14 -07:00
megamage
738f94eed3
Fix incorrect logic in PetAI. Solve #3155 .
2011-09-21 12:53:29 -04:00
Rochet2
a0a22ecbc8
Scripts/Commands: Added .dev command to show <Dev> tag in nickname
2011-09-21 11:35:29 -03:00
QAston
a0030ef334
Really fix build (sorry for that:()
2011-09-21 11:06:31 +02:00
QAston
87d9a1d384
Scripts/TwinValkyr: Fix build.
2011-09-21 10:40:11 +02:00
QAston
e2e784e7ea
Merge pull request #3086 from LihO/master
...
Core/Groups: Refactored sending of update packets.
Closes #1042 .
2011-09-21 01:05:53 -07:00
QAston
d628145d95
Merge pull request #3143 from megamage/master
...
Threat manager. Fix crashes #2396 and #2992 .
2011-09-21 01:03:53 -07:00
kiper
cdb4f60a14
Merge pull request #3040
...
Core/Spell: Fix spell related to reputation in Oracle and Frenzy faction
2011-09-21 10:02:30 +02:00
QAston
82bc917265
Merge pull request #2908 from Drethek/TwinsValk
...
Scripts:
Twins Valk - Cleanup / Remove Hardcoded Bullet Spawn (Need DB Support - Stalkers Spawns)
Acidmaw - Use Correct Submerge Spell
Trial Of Crusader - Correct Coordinate Spawn
Trial Of Crusader - Correct Open/Close Main Door Timer
Trial Of Crusader - Open/Close On Boss EnterEvadeMode
2011-09-21 00:27:20 -07:00
Havenard
c298d09417
Reimplement WorldObject::IsInBetween() to work as intented.
...
Closes #2163 and #1329
2011-09-20 17:48:13 -03:00
Rat
0ab9dd3f9f
Core/SmartAI: Re-apply accidentally removed crash fix, whoops
2011-09-20 17:56:47 +02:00
Rat
41ad855bdf
Core/SmartAI: fixed SMART_ACTION_SOUND, note: target(s) must be player(s)
...
Signed-off-by: Rat <gmstreetrat@gmail.com >
2011-09-20 17:46:40 +02:00
megamage
4ccb22e1a6
Fix the incorrect logic of threat online status check. Also add targets in other map or phase to offline container.
2011-09-20 10:26:34 -04:00
megamage
8aead2a1ee
Do not add spell-caused threat to creatures in other map or phase. Fix crashes #2396 and #2992 .
...
Note: Threat system is still thread-unsafe. This patch only reduces the chance of crash.
2011-09-20 10:24:44 -04:00
Shauren
3d4f9a0d1c
Core/World: Shutdown messages are now sent in blizzlike intervals (every 15 seconds under 5 minutes and every minute under 15 minutes)
2011-09-20 11:40:08 +02:00
Shauren
80800def40
Core/Scripts: Reverted part of 7afb179185, fixes selecting random target starting at given position
...
Closes #3127
2011-09-20 09:03:12 +02:00
megamage
e81b3c6fde
Move thread-unsafe events from Player to BattlegroundQueue. Fix crash #2960 .
2011-09-19 17:22:27 -04:00