Ovahlord
7a2e26d42e
Core/Random: use std::bernoulli_distribution for roll_chance_ calls to get more reliable roll results for yes-no scenarios
2022-03-10 23:10:49 +01:00
Ovahlord
a6809465b5
DB/Spells: added and updated proc data for Lightweave Embroidery
2022-03-10 20:45:44 +01:00
Ovahlord
5f2b1e45e4
Core/Spells: improve integer to float conversions and checks for spell proc entries
2022-03-10 20:43:12 +01:00
Ovahlord
fd22ea32e6
Core/Spells: merged master version of checking for cast immunities
2022-03-10 20:41:47 +01:00
Ovahlord
ae606af1ab
DB/Spells: updated Arcane Missiles proc entries to only proc from other damaging spell casts
2022-03-10 13:16:03 +01:00
robinsch
ae97821c78
Tool/MMAP: Fixed invalid check causing certain tiles not to build ( #27833 )
...
example: mmaps_generator 230 will cause tile 33, 29 to not build because of the check. causing NPCs to not have mmap information in some parts of the map.
.go xyz 1380 -831 -88 230 has no mmap tile information because of above check.
https://i.imgur.com/Pypeu4f.png
# Conflicts:
# src/tools/mmaps_generator/MapBuilder.cpp
2022-03-04 14:43:21 +01:00
Ovahlord
2aee19fc86
Core/Movement: ported MotionMaster::MoveJumpWithGravity implementation from master branch and cut off post Cataclsym features
2022-02-24 19:37:05 +01:00
Ovahlord
ce9da3a209
Core/Spells: integrated Long Arm of the Law's mechanic into the Judgement spell script and removed the proc entry
...
* updated some proc entries while at it
2022-02-24 14:14:16 +01:00
Ovahlord
1534ede45a
Core/Spells: updated proc flags for Cataclysm
2022-02-23 21:17:52 +01:00
Ovahlord
f641bcb2d1
Core/Spells: resolved a cherrypick error
2022-02-22 21:51:21 +01:00
Shauren
c307969695
Core/Spells: Changed channel triggered spells to inherit positive/negative status from main spells
2022-02-22 21:24:49 +01:00
Ovahlord
78896a132f
Core/Spells: ported proc flag updates from master branch
2022-02-22 21:19:09 +01:00
Ovahlord
e83c5955b4
Core/Spells: moved Improved Devouring Plague to spell script and fixed the damage effect
2022-02-22 12:57:29 +01:00
Ovahlord
1c56faaa2c
Core/Guids: refactored more range based loops to reduce copying elements of containers
2022-02-21 20:36:49 +01:00
Ovahlord
639799c7ed
Scripts/LCT: make sure that High Prophet Barim stops moving when he is about to cast Repentance
2022-02-21 19:46:46 +01:00
Ovahlord
80881f898c
build fix
2022-02-21 14:55:09 +01:00
Ovahlord
7bf3379df5
warning fixes
2022-02-21 14:43:50 +01:00
Ovahlord
a204e9c61a
Core/Units: some minor refactors to reduce the amount of container element copies and improved some array initializations
2022-02-21 14:31:46 +01:00
Ovahlord
a652191a62
Core/Spells: 6506e71a23 followup
2022-02-21 13:49:17 +01:00
Ovahlord
6506e71a23
Core/Units: added a helper to check if a limited target aura exists without creating an empty element in the container
2022-02-21 13:44:24 +01:00
Ovahlord
003b096215
DB: drop long deprecated spell_proc_event table
2022-02-21 12:14:20 +01:00
Ovahlord
f97f57c0f6
Core/Spells: Nether Vortex will now only proc its Slow effect only when the mage has no other Slow auras applied
2022-02-21 11:59:42 +01:00
Ovahlord
6e412b16de
Core/Spells: correctly implement Elemental Oath
2022-02-21 11:17:41 +01:00
Ovahlord
d712a12f1c
Core/Spells: use correct macro for tree of life stance requirement
2022-02-21 10:53:32 +01:00
Ovahlord
97a79175fc
Core/Spells: added a bunch of default ctors for several spellMgr structs to silence uninitialized member warnings
2022-02-21 10:50:00 +01:00
Ovahlord
33bc96fcce
CMake: disable unscoped enum type warning C26812 for msvc compilers
2022-02-21 10:36:36 +01:00
Ovahlord
06f6987e2a
Core/Spells: allow Rupture's damage to scale with combo points as well
2022-02-21 10:21:43 +01:00
Ovahlord
f01012aac9
Core/Spells: corrected the finishing move spell attributes for Rupture and Expose Armor
2022-02-21 10:16:30 +01:00
Ovahlord
d53fb14cbb
Core/Creatures: no longer initialize CharmInfo for minions on creation. Unit::SetCharmed takes care of non-guardian initialization
...
closes #334
2022-02-21 09:42:41 +01:00
funjoker
429584e5b8
Tools/Patcher: no hardcoded jump
2022-02-20 23:34:01 +01:00
funjoker
10e7828dbc
Tools/Patcher: Fix incorrect Mac64 pattern and patches
2022-02-20 22:06:22 +01:00
Shauren
93259bc282
Build: Never automatically link any boost library with a #pragma comment(linker) encountered in boost headers
2022-02-20 20:27:55 +01:00
Shauren
5ad23e61e4
Dep: Raise required boost versions to 1.73 on windows and 1.71 on linux and remove compatibility code for unsupported versions
...
# Conflicts:
# dep/boost/CMakeLists.txt
2022-02-20 20:27:35 +01:00
Ovahlord
bbcd74d671
Scripts/FL: disable Heart of Ragnaros spell cast on encounter completion until it is handled to avoid spawning hearts at the location of every npc in the raid
2022-02-20 20:21:30 +01:00
ccrs
3499ffa187
Core/Petition: add missing increment on RemovePetitionsByOwnerAndType iteration
...
(cherry picked from commit aa86dfddca )
2022-02-16 05:00:59 +01:00
xinef1
e5f3de026f
Core/Misc: implemented petition manager ( #19010 )
...
- Implemented manager for petitions to perform all petition related tasks and synchronize data with database.
- This kills ugly synchronous querys on packet handlers
(cherry picked from commit a4aa95a5a3 )
2022-02-16 04:59:12 +01:00
ariel-
cb168a8e7e
Core/Unit: fix crash on magic school autoattacks
...
Closes #19436
(cherry picked from commit 0b50ea072e )
2022-02-16 04:49:24 +01:00
jackpoz
8746d9f56a
Core/Misc: Fix static analysis issues
...
(cherry picked from commit 486b032343 )
2022-02-16 04:49:24 +01:00
ariel-
4c658cf2da
Revert "Core/Spell: don't set scaleAura for some special spells"
...
This reverts commit 1ca8434b36 .
Closes #19472
(cherry picked from commit c296d255e2 )
2022-02-16 04:49:24 +01:00
ariel-
5ad31dcf55
Core/Unit: fix SPELL_AURA_MOD_DAMAGE_DONE damage calculation on non-melee schools
...
for Keader :P
(cherry picked from commit 66ac1509ae )
2022-02-16 04:49:24 +01:00
ariel-
d441e864c4
Core/Unit: cleanup and minor fixes of miss and resist calculations
...
- Removed Unit::GetUnitMeleeSkill as it was basically a copy of GetMaxSkillValueForLevel
- Removed static from GetEffectiveResistChance, as this was passed anyways, changed name to CalculateAverageResistReduction, which better reflects what it does
- Fix melee miss chances calculated from attacker maxskill instead of victim maxskill
- Do actual checks if spell can be resisted/missed in MagicSpellHitResult (ie chances > 0)
- Fixed SPELLMOD_RESIST_MISS_CHANCE calculation in MeleeSpellMissChance
- Minor codestyle and cleanup of diminishing returns calcs
(cherry picked from commit e565b34f6d )
2022-02-16 04:49:24 +01:00
ariel-
0e8422c30a
Core/Misc: fix static analysis issues
...
CID 1373466
CID 1373481
CID 1373482
(cherry picked from commit e478434146 )
2022-02-16 04:49:24 +01:00
ariel-
58745ed8cc
Core/AHBot: fixed assert check
...
(cherry picked from commit c36854677c )
2022-02-16 04:49:24 +01:00
ariel-
14a95ff976
Core/Spell: don't set scaleAura for some special spells
...
Closes #14541
(cherry picked from commit 1ca8434b36 )
2022-02-16 04:49:24 +01:00
ariel-
4a3c6b3ae5
Core/AHBot: fix a typo
...
(cherry picked from commit e594c2d096 )
2022-02-16 04:49:24 +01:00
ariel-
df00319c1b
Core/AHBot: Refactor of AuctionHouseBotSeller:
...
- Use AuctionHouseBot.Class.* for what they really are, priorities, factor them when calculating item amount per class, changed enums to CONFIG_AHBOT_CLASS_*_PRIORITY to reflect this change
- Don't factor in the priority calc empty item lists:
* Let's say you had AuctionHouseBot.Class.Glyph set to 10, sum of AuctionHouseBot.Class.* is 20, and AuctionHouseBot.Items.Amount.White is 5000
* If there were no glyphs on the item list, you automatically lost 50% of the total item amount, meaning only 2500 of original 5000 were alloted to fill
- Fixed AuctionHouseBot.AH.Price.Ratio to be an actual percentage factor
- Separated containers in SellerConfiguration, each one better reflects what kind of data is stored there, now we won't use magic index 0 from _ItemInfo :P
- General cleanup, removal of bad voodoo and magical numbers
- Use unordered_sets for loading item lists, as they were only used to check for item presence
(cherry picked from commit 7f8bfe68d0 )
2022-02-16 04:49:24 +01:00
Chaouki Dhib
17c4d8f6d9
Core/Spells: fix wrong distance calculations in AoE spells [Needs testing] ( #16290 )
...
Core/Spells: Fix wrong distance calculations in AoE spells.
Pull request #16290 by chaodhib.
God bless, finally.
(cherry picked from commit a1f2f30c14 )
2022-02-16 04:49:24 +01:00
ariel-
4ad1d377fe
Core/Entities: virtualize CheckAttackFitToAuraRequirement
...
- Should've been like this to begin with
(cherry picked from commit 21d95a1d76 )
2022-02-16 04:49:24 +01:00
ariel-
70ecdd1511
Core/Aura: fix SPELL_AURA_MOD_TOTAL_STAT_PERCENTAGE unapply case for dead players
...
Closes #19276
(cherry picked from commit e1083794cd )
2022-02-16 04:49:24 +01:00
ariel-
827fcb652a
Core/Entities: Fix null-dereference crash
...
Closes #19191
(cherry picked from commit d61e0f79c4 )
2022-02-16 04:49:24 +01:00