Commit Graph

21965 Commits

Author SHA1 Message Date
Ovah
7fcb77ecd1 Core/Taxis: teleport players to the destination taxi node location instead of their current ground position (#23835)
* Core/Taxis: teleport players to the destination taxi node location instead of straight to their current ground position

* fixed a typo
2019-10-08 11:11:24 +02:00
Giacomo Pozzoni
abcad7cda5 Core/LFG: Fix re-queueing while in a dungeon (#23862)
Fix an issue that wouldn't allow to re-queue after joining a dungeon, having 1 member leave/get kicked, queue, leave, queue.
In this case a message "One or more dungeons was not valid" would be displayed because LFG would try to queue the group as "continue dungeon" but the current group was not marked as "in dungeon" state anymore.
2019-10-06 22:24:13 +02:00
jackpoz
ada4e431ae Core/LFG: Remove Dungeon Cooldown when getting kicked 2019-10-05 20:40:17 +02:00
jackpoz
88317a4ec8 Core/Misc: Fix issues reported by static analysis
Fix issues reported by Coverity Scan
2019-10-04 19:16:45 +02:00
Keader
a108f2ba61 Scripts/ICC: Fixed some issues with Rotface Oozes (#23845) 2019-10-04 09:35:22 -03:00
Keader
8210b4a539 Scripts/ICC: Fixed Death Plague (Frost Giant) (#23847) 2019-10-04 09:33:14 -03:00
Keader
34ee2effc8 Scripts/Forge of Souls: Fixed spell Soul Sickness (#23843) 2019-10-03 08:49:05 -03:00
Keader
16fde1ffad Scripts/ICC: Fixed Tear Gas not getting removed of Abomination in phase change of PP (#23846) 2019-10-02 16:50:45 -03:00
Giacomo Pozzoni
b3b8ec811d Core/Pet: Fix guardians low damage (#23840)
Fix guardians low damage for unhandled cases in Guardian::InitStatsForLevel()
2019-10-02 13:59:52 +02:00
Giacomo Pozzoni
ef694cc251 Scripts: Fix crossfaction combat issue (#23818)
* Scripts/PitOfSaron: Fix Martin Victus combat in crossfaction groups

Fix Martin Victus attacking players in crossfaction groups because it was spawned as summon of the boss, triggering DoCombatInZone()

* Scripts/ForgeOfSouls: Fix guards combat in crossfaction groups

Fix Devourer of Souls guardians attacking players in crossfaction groups because they were spawned as summons of the boss, triggering DoCombatInZone()

* Scripts/Misc: Fix no PCH build
2019-09-28 15:45:25 +02:00
Ovah
c1e3d79a4f Core/Movement: fixed taxi pathings getting finalized earlier than intended (#23830)
* Core/Movement: fixed taxi pathings getting finalized earlier than intended

Since we handle the intial starting point of a spline properly now the update logic was still expecting the old handling which resulted in incrementing the current node index earlier than intended

* apply a missing change
2019-09-28 09:24:41 +02:00
Giacomo Pozzoni
ca8953a0ec Core/Misc: Fix static analysis issues
Fix static analysis issues reported by Coverity
2019-09-27 14:12:10 +02:00
Keader
746a1d89b3 Scripts/Tempest Keep: Fixed a typo in Nethermancer Sepethrea
Closes #23828 
Ty Rizztazz
2019-09-25 16:56:03 -03:00
Giacomo Pozzoni
ed08754663 Core/Misc: Fix static analysis issue
Fix static analysis issue
2019-09-25 11:44:08 +02:00
tarwyn
c8dc9fdc41 Fix inconsistent NPC aggro on spell miss (#23816) 2019-09-23 08:01:28 +02:00
Ovah
cf3277c641 Core/Movement: provide an extra spline path vertex for taxi pathings … (#23817)
* Core/Movement: provide an extra spline path vertex for taxi pathings so the first path point wont get lost.

* Update FlightPathMovementGenerator.cpp
2019-09-22 17:12:59 +02:00
Killyana
8e3862cfbd Instance/Script: Gorkun Ironskull & Martin Victus 2019-09-21 21:52:33 +02:00
jackpoz
f9d6c57006 Core/Quest: Fix quests not being shareable 2019-09-21 18:26:55 +02:00
jackpoz
42ab6010f8 Core/Map: Move a log from ERROR to WARN
Move "Could not load MMAP" log from ERROR to WARN as 99% of times is a false positive
2019-09-21 18:05:19 +02:00
Gildor
a392216d20 Scripts/Icecrown Citadel: Remove duplicated Spell enum (#23810) 2019-09-21 13:17:45 +02:00
Giacomo Pozzoni
fb059722fd Core/Calendar: Add some additional validation when creating events (#23797)
* Core/Calendar: Add some additional validation when creating events

Allow only 30 player events and 100 guild events to be created.
Don't allow to create guild events if player is not in guild.
Send some more error messages to the client (not blizzlike errors but better than nothing).

* Core/Calendar: Add some additional validation/checks

Add guild id check in GetPlayerEvents().
Change error message in HandleCalendarCopyEvent() to be the same as in HandleCalendarAddEvent() when creating an event in the past.

* Core/Calendar: Add some additional validation/checks

Reduce the number of CMSG_CALENDAR_ADD_EVENT packets a seconds allowed from 10 to 3.

* Core/Calendar: Add some additional validation/checks

Implement 5 seconds cooldown between the creation of calendar events

* Core/Calendar: Add some additional validation/checks

Don't allow to copy events of a different player/guild

* Core/Calendar: Implement automatic deletion of old events

Implement automatic deletion of events older than 1 month (30 days).
Fix debug assertion triggered when deleting a character with calendar events.
Avoid double std::set lookup when deleting events when deleting a character.

NB: The whole CalendarMgr/CalendarHandler code should be checked line by line for bugs/crashes/exploits.
2019-09-17 09:11:56 +02:00
Kelno
6fc7ab3448 Core/Commands: Fixed wrong permissions for .lookup map commands (#23800) 2019-09-16 17:41:55 +02:00
jackpoz
215a6cee24 Core/Movement: Fix LoS issue of NPCs chasing targets
Add Line of Sight checks to ChaseMovementGenerator::Update(), fixing to ChaseMovementGenerator not reaching a point with valid LoS to the target.

Fix re-implements 8927a04253 after 2a84562dc8 partially removed it.

Fix #23724
2019-09-13 21:06:28 +02:00
Gildor
b98f858cd2 Spells/DK: Fix wrong class name in Rime AuraScript (#23783)
(Introduced in this commit: 2ff855054f)
2019-09-10 16:29:38 +02:00
jackpoz
7c0b31b8b5 Core/MovementGenerator: 680e1cbd6c follow-up 2019-09-08 15:48:06 +02:00
jackpoz
680e1cbd6c Core/MovementGenerator: Fix crash in taxi paths
Fix a crash in taxi paths happening when joining a battleground/dungeon while on a taxi path after second last node but close to last node, then leaving/finishing the battleground.
2019-09-07 18:22:26 +02:00
Gildor
f8d7b26047 Core/Misc: Fix parry-haste mechanic. (#23773)
* Should check victim that do a parry instead of the unit that deal the damage (Wrong implementation of this commit: 4a46fee03e )

Closes #23754
2019-09-07 12:57:02 +02:00
Artamedes
8ecc45cd1a Scripts/Pet: Fix npc_pet_gen_soul_trader not following owner (#23772) 2019-09-06 22:14:09 -03:00
Artamedes
88e74ac385 Scripts/PitOfSaron: Make sure ick stops moving when casting Explosive Barrage (#23768) 2019-09-06 21:47:34 +02:00
Artamedes
a17c83bde8 Scripts/PitOfSaron: Fix Krick sometimes stuck in combat after finish kill Ick (#23767) 2019-09-06 21:47:10 +02:00
Artamedes
876a848730 Scripts/Ulduar: Fix Stormcaller Brundir walking into walls (#23755)
* Scripts/Ulduar: Fix Stormcaller Brundir walking into walls

* Cleanup and fix logic + review

* Review: remove autos
2019-09-06 20:09:47 +02:00
Artamedes
832c95fa4f Scripts/ScarletMonastery: Rewrite Mograine and Whitemane encounter (#23761)
* Scripts/ScarletMonastery: Rewrite Mograine and Whitemane encounter

* qq

* qq 2

* tryfix circleci build

* review suggestions
2019-09-06 20:08:47 +02:00
Artamedes
1b095811b8 Scripts/Outland: Change auto to TempSummon* (#23764) 2019-09-05 16:57:34 +02:00
Artamedes
0b3a9e2a2b Scripts/Outland: Fix npc_ancestral_wolf not starting waypoint (#23763)
* Scripts/Outlands: Fix npc_ancestral_wolf not starting waypoint, and also add a way to not follow owner automatically in CreatureAI::JustAppeared() for tempsummons

* fix nopch
2019-09-05 08:37:44 +02:00
Artamedes
6ebe1afeec Core/Handlers: Handle CMSG_REQUEST_PET_INFO - this fixes when you /reload and the pet bar disappears (#23762) 2019-09-04 08:41:18 +02:00
jackpoz
4074cb0f01 Core/Creature: Fix another pet assert
Fix an assert triggered when dismissing a Warlock pet while it's casting a spell
2019-09-01 19:05:29 +02:00
Shauren
dab66cb8d0 Core/SAI: Reserve action ids 2019-08-31 13:58:55 +02:00
Treeston
23fd193e4e Scripts/ICC: Professor Putricide no longer tries to add threat on units it cannot add threat on because of immunity flags. Instead, its AI manually controls the engagement state. Should close #23727. 2019-08-30 01:04:11 +02:00
AlιAѕѕaѕѕιN
92d83c3c2e [3.3.5] Fix spell_area not checking for zoneID for quests (#23719)
* Fix spell_area not checking for zoneID for quests

* Addendum to bdffe0a4a6

* Fix spell_area handle same spell with the same quests

Also fix not checking for quest_end at all.

* Addendum to 2d6b0545e3

* Better commenting for 7a50189de3

* Addendum to 2d6b0545e3
2019-08-28 08:03:41 +02:00
ForesterDev
07e2264964 Core/PacketIO: updated SMSG_PLAY_SOUND, SMSG_PLAY_MUSIC and SMSG_PLAY_OBJECT_SOUND (#23636)
* Core/PacketIO: SMSG_PLAY_SOUND

(cherry picked from commit 82a33c7fa8)

# Conflicts:
#	src/server/game/Battlefield/Battlefield.cpp
#	src/server/game/Battlegrounds/Battleground.cpp
#	src/server/game/Battlegrounds/BattlegroundMgr.cpp
#	src/server/game/Battlegrounds/BattlegroundMgr.h
#	src/server/game/Entities/Object/Object.cpp
#	src/server/game/Server/Packets/MiscPackets.cpp
#	src/server/game/Server/Protocol/Opcodes.cpp
#	src/server/game/Texts/CreatureTextMgr.cpp
#	src/server/game/Texts/CreatureTextMgr.h
#	src/server/scripts/Commands/cs_misc.cpp

* Update for 3.3.5

* Core/PacketIO: updated and enabled SMSG_PLAY_MUSIC

(cherry picked from commit c6718dc120)

# Conflicts:
#	src/server/game/Maps/Map.cpp
#	src/server/game/Server/Packets/MiscPackets.cpp
#	src/server/game/Server/Protocol/Opcodes.cpp
#	src/server/game/Server/Protocol/Opcodes.h
#	src/server/game/Spells/SpellEffects.cpp

* Core/Packets: added SMSG_PLAY_OBJECT_SOUND packet class

(cherry picked from commit 1272e9eea6)

# Conflicts:
#	src/server/game/Server/Packets/MiscPackets.cpp
#	src/server/game/Server/Packets/MiscPackets.h
#	src/server/game/Server/Protocol/Opcodes.cpp

* fic build

* change variable names

* fix build error field will be initialized after
2019-08-23 19:28:21 +02:00
ForesterDev
448facc5e7 Core/Spells: Fixed warlock's Banish cancel if target was already banished (#23697)
* Core/Spells: Add SpellMissInfo argument to BeforeHit hooks and call them also when the spell doesn't hit. (#17613)

(cherry picked from commit 8ff5b35be1)

# Conflicts:
#	src/server/game/Spells/Spell.cpp
#	src/server/scripts/Northrend/IcecrownCitadel/boss_the_lich_king.cpp
#	src/server/scripts/Spells/spell_warlock.cpp

* Core/Spells: Fixed warlock's Banish cancel if target was already banished (#17614)

(cherry picked from commit 4587b5d880)

# Conflicts:
#	src/server/scripts/Spells/spell_warlock.cpp
2019-08-23 19:24:56 +02:00
Keader
10f6e38185 nopch fix 2019-08-21 23:08:36 -03:00
Keader
cbc01f35b6 Core/Scripts: Proper fix Gal'Darah Puncture remove 2019-08-21 23:03:25 -03:00
Keader
1886507e7f Fix nopch build 2019-08-20 06:35:02 -03:00
Keader
130a3859ec Scripts/Gundrak: Fixed Puncture when Gal'darah die 2019-08-19 23:52:04 -03:00
Sorikoff
d56dd89635 Scripts/Spells: Code style adjustments for druid scripts (final?) (#23726) 2019-08-19 09:13:38 +02:00
Keader
61ad87d106 Scripts/Gundrak: Added a missing entry in Gal Darah Stampede Charge script
Noob Keader, Shame !
2019-08-18 13:07:18 -03:00
Sorikoff
63bbf4a4be Scripts/Spells: Code style adjustments for druid scripts (#23725) 2019-08-18 17:24:18 +02:00
Sorikoff
9a8a01925a Scripts/Spells: Port druid scripts to new script registration syntax (2 of 3) (#23696)
* Scripts/Spells: Port Druid Scripts to New Script Registration

* Revert

* Revert 2

* Revert 3

* Revert 4
2019-08-18 15:56:27 +02:00
Shauren
aa0d468e04 Tools/Misc: Document strange array access indexing
Closes #23723
2019-08-18 12:40:38 +02:00