* Core/AI: Fix assertion triggered with PetAI derived scripts
Fix an assertion triggered when spawning through ".npc add" or from SQL db table a Creature with AI set to a custom AI inheriting from PetAI.
(cherry picked from commit 95a76a83fc)
- No more automatic combat -> threat promotion. This matches anecdotal retail behavior - spells already in transit will not cause mob to chase you if its primary target vanishes before the spell hits.
- Prevent mobbing by stopping creatures from auto-acquiring a nearby target just because the primary target vanished.
(cherry picked from commit 1acfefb973)
This fixes an exploit where creating the reference as offline (by vanishing while a spell was mid-flight) you could damage a creature further without it ever engaging you.
(cherry picked from commit 2402406228)
Updating original script which was posted for this npc at 54cb925f8bea76ddbb364208df/sql/old/3.3.5a/TDB49_to_TDB50_updates/world/2012_09_26_00_world_misc.sql#L7
so that it also replaces http://www.wowhead.com/item=31763/druid-signal as well as the felsworn gas mask
(cherry picked from commit 6dd8e2beef)
(cherry picked from commit ffbaf80aeb)
Updating my previous script for this as my prior work was no longer working as intended, was no longer in sync with spawn of caged human and when this changed to squirrel, toad, rabbit, sheep only the name of the npc changed the the appearance never changed,
deleting the permament spawn of caged human Apothecary Keever after he casts the teleport spell
(cherry picked from commit 833b5b9e16)
- Who would have suspected GetAuraEffect (iconId override) did a check against null spellfamilyflags?
- Remove mirror timers hack (triggered spell already allows underwater breathing)
(cherry picked from commit 4402f71eb7)
- corrected the comment "1205-2002 - free" to "1205-1999 - free"
- increased the main indent by 2 spaces to get more lines aligned
- corrected the enum LANG_DO_NOT_USE_6X_DEBUG_AREATRIGGER_LEFT from 1999 to 1199
Ref. commit 5f54149107
(cherry picked from commit ba5f6a8616)
This hook modifies damage AFTER it has been reduced by target auras/armor/resistances etc, it's useful if you want to scale damage by a factor, but not to add flat bonuses.
We're fixing those by moving calculation to Launch phase, where target taken bonuses haven't been used yet.
- Bronjahm: Magic's Bane
- BPC: Shadow Prison
- Oculus: Shock Lance
- Ymiron: Dark Slash (extra fix, it was wrongly damaging half of total health, it's supposed to be half of CURRENT health!)
- DK: Raise Ally Thrash spell (also extra fix: corrected formula)
- Warrior: Bloodthirst (shouldn't matter much as it's damage class none and those don't get bonuses by default)
- Warrior: Concussion Blow
- Warlock: extra fix for Haunt, healing part shouldn't scale with spell power
Closes#9560
(cherry picked from commit 9f5d1e2b10)
