Commit Graph

35857 Commits

Author SHA1 Message Date
Killyana
aaed9e8fbd DB/Misc: Fix spawns on Skyguard Outpost and add missing spawns for Simon Game
(cherry picked from commit dc16cf89b7)
2021-11-21 14:40:45 +01:00
jackpoz
e9e3d2d69d Core/Utils: Handle UTF-8 conversion errors
Replace the output string when a UTF-8 conversion error happen with an error message instead of using an empty string, swallowing any message that the caller wanted to log.

(cherry picked from commit bdb7e6e5e8)
2021-11-21 14:38:29 +01:00
Killyana
d8b76a6e6d DB/Creature: Wrath Corruptor
Thanks to Keader for the spell_script
Original sql by Tobschinski c8f1753834

(cherry picked from commit fb28083b3b)
2021-11-21 14:38:17 +01:00
Shauren
c2eff8fabc Core/LFG: Ignore LFG cooldown when joining queue to replace missing party member when dungeon is already in progress
(cherry picked from commit 7fb52334b2)
2021-11-21 14:35:00 +01:00
Trond B. Krokli
e26b667742 Scripts/Quest: make Wounded Skirmisher reply talk show class & race (#22936)
Quest 12288: Overwhelmed!
- Upon casting the healing quest spell, Wounded Skirmisher (npc_wounded_skirmisher)
  shows $r and $c in their reply talk text because of the missing target argument,
  hence not targeting the player on the quest (or the specific caster, in this case).

Text used by the NPC Wounded Skirmisher:
    0  Ahh.... better.
    1  Whoa - I nearly died there. Thank you, $r!
    2  Thank you, $c.

Solution: add the missing target name, caster, to the Talk() script line.
(cherry picked from commit 95398fadf9)
2021-11-21 14:34:43 +01:00
Killyana
a65c27c07a DB/GameObject: Fel Crystalforge
Fix positions and add missing spawns

(cherry picked from commit 14cf9c3fba)
2021-11-21 14:34:25 +01:00
Killyana
122c89c907 DB/Event: Nocturnal fishing and Diurnal fishing
(cherry picked from commit a854b2a2ee)
2021-11-21 14:32:46 +01:00
Killyana
1d91bcad63 DB/Creature: Remove wrong spawn
(cherry picked from commit 9f5cba2929)
2021-11-21 14:31:51 +01:00
Killyana
69f2f2a28e DB/Fishing: Add seasonal fish, Raw Summer Bass/Winter Squid
(cherry picked from commit f5b26b6bfb)
2021-11-21 14:30:39 +01:00
ccrs
e52be384d3 Core/Movement: 9080e7863c followup
not the desired optimization I was aiming at, ty Shauren

(cherry picked from commit 9695c3d46d)
2021-11-21 14:17:56 +01:00
ccrs
1c5287032a Core/Movement: correct logic wrongly ported in 2a84562dc8
I'm referencing line 97 from ChaseMovementGenerator.
That commit introduced a modification in this use case:
- Chasing target is not my current victim, I should stop moving till it is my victim again
Changed To:
- Chasing target is not my current vicitm, I should stop chasing
My correction:
- I dont care about the relation of my current victim and my chasing target, I'm commanded to chase, something will tell me to stop chasing
--> Most likely: evade, new attackstart, etc.

the rest are just minor changes

(cherry picked from commit 9080e7863c)
2021-11-21 14:17:23 +01:00
Killyana
90cce65d46 DB/Gossip: Fix rogue trainers gossips related to Elegant Letter
(cherry picked from commit 6289da716e)
2021-11-21 14:17:01 +01:00
Giacomo Pozzoni
9668096056 Core/Networking: Fix memory leak (#22923)
Fix memory leak reported by ASan happening when ports fail to bind in Authserver

(cherry picked from commit 57d7b19452)
2021-11-21 13:54:27 +01:00
Killyana
f263e7c27a DB/Creature: Artist Renfray
(cherry picked from commit 3c0334fd7b)
2021-11-21 13:53:28 +01:00
Killyana
6b6eff6f96 DB/Creature: Rory
(cherry picked from commit bee08cc3e7)
2021-11-21 13:51:43 +01:00
Killyana
c375208e5b Rename spell correctly
(cherry picked from commit 4c53dd930e)
2021-11-21 13:30:00 +01:00
Killyana
0b1c3d3544 Creature/Script: Add missing abilities for Ghostly Citizen and Spectral Citizen
Closes #22662

(cherry picked from commit 21030d0cd0)
2021-11-21 13:29:37 +01:00
illfated
70f05f7078 DB/Quest: The Soul Devices RewardText fix
Closes #22930

(cherry picked from commit 33f61bd57e)
2021-11-21 00:13:04 +01:00
Jeremy
2a9940e17d Core/GameObject: Implement GameObject::Use case for GAMEOBJECT_TYPE_NEW_FLAG (#27267) 2021-11-20 20:36:56 +01:00
Shauren
e9e69ed978 Core/BattlePets: Set Allow = false; in SMSG_QUERY_BATTLE_PET_NAME_RESPONSE when name is empty 2021-11-20 20:22:53 +01:00
Antonio Martín Berti
7c53be0210 Core/Auras: Implemented SPELL_AURA_MODIFY_FALL_DAMAGE_PCT (#27296) 2021-11-20 20:04:21 +01:00
Meji
8614690e27 Core/BattlePets: Implemented battle pet name query packet (#27294)
Co-authored-by: Shauren <shauren.trinity@gmail.com>
2021-11-20 19:06:14 +01:00
Seyden
b1eb4c2b3e Scripts/Spells: Implement Demon Hunter Base Spell "Glide" 2021-11-20 15:51:02 +01:00
Seyden
adb439fdfe Scripts/Spells: Predefine spell ids used for DH scripts 2021-11-20 15:51:02 +01:00
Seyden
e4630c5354 Core/Movement: Temporarily disable "no state change" checks in Unit::SetFeatherFall and Unit::SetCanTurnWhileFalling
Co-authored-by: Shauren <shauren.trinity@gmail.com>
2021-11-20 15:51:02 +01:00
Shauren
0175371730 Nopch build fix 2021-11-20 01:56:55 +01:00
Shauren
8cc6520b89 Core/Spells: SpellHistory updates
* Add duration override argument to StartCooldown (for cooldowns sent to client)
* Research new SMSG_SPELL_COOLDOWN flags
* Send interrupt school lockouts with newly defined SPELL_COOLDOWN_FLAG_LOSS_OF_CONTROL_UI
* Fixed packet structure of SMSG_MODIFY_COOLDOWN
* std::chorno-ification
2021-11-20 00:28:48 +01:00
acidmanifesto
d4d47b52e3 Core/Misc: Corrected function name in log message (#27288) 2021-11-19 20:07:07 +01:00
Meji
895367e69f Core/BattlePets: Journal lock improvements (#27178)
Co-authored-by: Shauren <shauren.trinity@gmail.com>
2021-11-19 15:37:21 +01:00
Meji
12cc779ab0 Core/BattlePets: BattlePetError enum class (#27286) 2021-11-19 14:01:22 +01:00
Shauren
f97deb3316 Core/Quests: Fixed loading quest greeting locales
Closes #27292
2021-11-19 13:54:32 +01:00
funjoker
10086bdb3c DB/Hotfixes: Update hotfixes to 41079 2021-11-19 11:50:01 +01:00
Shauren
41859db7c6 Core: Updated allowed build to 9.1.5.41079 2021-11-19 00:41:58 +01:00
Rynem Storm
c7ad7d5e15 DB/Spell: fix mistake in Blood Draining's CheckProc and remove Attack Power scaling (#22862)
(cherry picked from commit a057d26f20)
2021-11-18 23:04:07 +01:00
Shauren
f24e16a460 Core/Spells: Fixed crash with some gameobject spell casters
(cherry picked from commit 755133d860)
2021-11-18 23:03:14 +01:00
Killyana
4c838dcb17 DB/Creature: Add missing npc_flag hasgossip to some creatures Part4
Ref #22912

(cherry picked from commit 9e069a2f69)
2021-11-18 23:00:35 +01:00
Killyana
7fe844a1e8 Quest/Script: Kodo Roundup
Fix faction issue and handle the gossip correctly via the script

(cherry picked from commit 5e73647c84)
2021-11-18 22:58:52 +01:00
Giacomo Pozzoni
fff0d174aa Scripts/Misc: Fix LoadMinionData() dynamic analysis issues
Fix issues reported by Address Sanitizer about LoadMinionData() calls on arrays that don't end with a {0, 0} pair.

(cherry picked from commit 08dcee0cf9)
2021-11-18 22:53:21 +01:00
Killyana
968c0f0aec DB/Creature: Mo'arg Extractor and Crystalfused Miner
(cherry picked from commit cd656b7bed)
2021-11-18 22:51:56 +01:00
Killyana
173307b9cd DB/Creature: Rotting Worm
Closes #12897

(cherry picked from commit cc7a22af9f)
2021-11-18 22:50:05 +01:00
Keader
33a2d627dd Core/Spell: Fixed some negative spells showing as positive
Closes #22840
Revert 9ecce33192 and 7611242530
Update #22757

(cherry picked from commit a0de602d38)
2021-11-18 22:48:34 +01:00
Keader
5cb05d1a40 DB/Creature: Fixed linked respawn error
(cherry picked from commit 5a46faf176)
2021-11-18 22:42:36 +01:00
Shauren
ba2586c92f Core/Spells: Fixed unapplying rockbiter weapon
Closes #22528

(cherry picked from commit f93a23adc5)
2021-11-18 22:41:57 +01:00
Keader
dd067390dc Scripts/Icecrown Citadel: Some fixes for Valithria Dreamwalker's encounter
Closes #22754 #21887 #17882
Ty sirikfoll for all help
Bonus fixes: Abomination letting worms when fight end, visual missing, archmages stop respawn if corpse despawn

(cherry picked from commit dd81978f43)
2021-11-18 22:41:57 +01:00
DanVS
3b1ed434ae Core/Scripts: Move some spells to scripts (#22332)
(cherry picked from commit 8051ff13df)
2021-11-18 22:41:57 +01:00
PolarCookie
19646a8363 That's Abominable for the 3 other quests, and knockbacks for all. (#22127)
(cherry picked from commit fb19f7be1f)
2021-11-18 22:41:57 +01:00
Killyana
1199906b32 DB/Creature: Shard-Hide Boar
(cherry picked from commit be561bef0f)
2021-11-18 22:41:57 +01:00
Keader
748e8463c7 Core/Spells: Malleable Goo need be negative
Closes #22757

(cherry picked from commit 9ecce33192)
2021-11-18 22:41:57 +01:00
Ghaster
f4d029b952 Core/Creature: Profession trainer fixes (PR #22904)
Closes #22903

(cherry picked from commit 19791a35df)
2021-11-18 22:41:57 +01:00
Keader
c4eed6561c Scripts/The Steamvault: Fixed Chambers Access Panel and Main Chambers Door
Closes #21067
Ty Kittnz, killerwife, Aokromes (sniffs)

(cherry picked from commit b283565d8a)
2021-11-18 22:41:55 +01:00