Commit Graph

776 Commits

Author SHA1 Message Date
Xanadu
ab146caaa8 Fixed persistent area aura visual radii (flamestrike, consecration etc.). Thanks to QAston and _manuel_ for research.
Closes issue 522. Closes issue 719.

--HG--
branch : trunk
2010-02-11 21:31:12 +01:00
Trazom62
b0ea16f10b Fix crash in Spell::EffectApplyAura.
Fixes issue #657.

--HG--
branch : trunk
2010-02-07 18:16:53 +01:00
Xanadu
f8d1920fa5 Yet more cleanup, mostly in the script system. This should conclude the script integration into core.
--HG--
branch : trunk
2010-02-05 13:01:32 +01:00
Xanadu
a5d1bc77ab A great purge of obsolete macros.
--HG--
branch : trunk
2010-02-05 00:31:28 +01:00
QAston
10695f9131 *Drop spell_stack_masks table
*Add spell_group_stack_rules table (for more info see wiki)
*The table is maintained by core team
*Move some spell specific out of core to the new table

--HG--
branch : trunk
2010-02-02 22:35:01 +01:00
QAston
a1256d88ee *drop spell_elixir table
*add spell_group table for storage of groups of spell (kinda obvious, isn't it?) and populate the table with converted spell_elixir table data
*the table is going to be maintained by core team
*fix percentage display at spell_ranks table loading
*add TARGET_UNIT_CASTER to allowed learn spell targets in npc_trainer table, thanks to Aokromes for noticing the issue.

--HG--
branch : trunk
2010-02-01 19:22:32 +01:00
_manuel_
0711119de5 Removed tabs. Closed issue 397 and 171.
--HG--
branch : trunk
2010-01-27 15:15:49 -03:00
_manuel_
6c63596be0 Re-add event support for type 10 (goober) GOs. By Biglad
--HG--
branch : trunk
2010-01-27 14:50:42 -03:00
Trazom62
275ffe4f28 Fix SpellEffect Quest Complete: shall work if player is the unitTarget
--HG--
branch : trunk
2010-01-25 20:45:02 +01:00
thenecromancer
73dd5925be Do not allow units that are not in world to create dynamic objects from spell effect handlers
--HG--
branch : trunk
2010-01-24 23:47:17 +01:00
thenecromancer
372bef8a55 SPELLMOD_DAMAGE is applied in SpellDamageBonus() - remove this hack for Eviscerate to prevent double apply
--HG--
branch : trunk
2010-01-24 15:23:30 +01:00
QAston
d1a40eb688 *Do not keep area aura targets in combat with aura owner
*Add some safety checks to area aura target map update.

--HG--
branch : trunk
2010-01-24 13:08:25 +01:00
thenecromancer
e893ad71cf Fix Empowered Rune Weapon
Cleanup cast flags

--HG--
branch : trunk
2010-01-23 16:06:06 +01:00
Trazom62
2a261b44e1 Fix EffectSendEvent to work if target is GO or Unit.
--HG--
branch : trunk
2010-01-21 23:57:14 +01:00
Rat
0cc053ea4d *Integrate Script system to Core
-added ScriptMgr for loading scripts
-removed bindings
-moved script system to src/game
-moved scripts to src/scripts
-VC project files updated
-cmakes updated (not 100% done yet)

NOTE to Devs:
-file locations changed
-precompiled renamed to ScriptedPch
-ecsort_ai renamed to ScriptedEscortAI
-follower_ai renamed to ScriptedFollowerAI
-guard_ai renamed to ScriptedGuardAI
-simple_ai renamed to ScriptedSimpleAI
-sc_creature renamed to ScriptedCreature
-sc_gossip renamed to ScriptedGossip
-sc_instance  renamed to ScriptedInstance

*use the new headers in scripts, thank you

NOTE to ALL:
cmake not fully tested, please report any errors with it
could make creashes, incompability
USE AT YOUR OWN RISK before further tests!!

--HG--
branch : trunk
2010-01-19 11:36:05 +01:00
QAston
f5dea61b66 *Remove some of no longer needed debug code.
--HG--
branch : trunk
2010-01-18 23:47:26 +01:00
QAston
a1bbbd1421 *Cleanups before delete after not successfull load pet from db. Thanks to Drahy for debug traces.
--HG--
branch : trunk
2010-01-18 23:12:35 +01:00
n0n4m3
99f66a6bc9 Updated copyright for new year.
--HG--
branch : trunk
2010-01-16 20:19:18 +03:00
n0n4m3
ed5152316f Rewrite parts of GameObject use for GO type 10, by NoFantasy.
--HG--
branch : trunk
2010-01-16 19:31:10 +03:00
n0n4m3
706718b28c Fixed some problems with pets, port from tc1, by krz, thx Frankir.
--HG--
branch : trunk
2010-01-16 19:11:32 +03:00
n0n4m3
e21e0ce95b Fixed wrong duration for Dancing Rune Weapon, removed in 3.2.x, thx QiSoft.
--HG--
branch : trunk
2010-01-16 19:02:26 +03:00
XTZGZoReX
53f9e0fba0 * Merge.
--HG--
branch : trunk
2010-01-13 18:25:46 +01:00
XTZGZoReX
f5998611c3 Backed out changeset: 52e769d95f14
--HG--
branch : trunk
2010-01-13 18:24:23 +01:00
XTZGZoReX
5a9ef604e2 * Fix CRLF.
--HG--
branch : trunk
2010-01-13 18:22:31 +01:00
n0n4m3
f7ad3aefc8 Removed all my commits for today, this is hack? really? okey
--HG--
branch : trunk
2010-01-13 19:11:46 +03:00
n0n4m3
7d988221f7 Allow apply spell mods for spell Eviscerate.
--HG--
branch : trunk
2010-01-13 14:33:28 +03:00
thenecromancer
efbc71746f Fix pickpocket - reveal rogue only if spell is resisted
--HG--
branch : trunk
2010-01-13 11:47:50 +01:00
thenecromancer
531cd027aa Fix blink always teleporting to ground
--HG--
branch : trunk
2010-01-13 11:23:14 +01:00
thenecromancer
c36a8d2d5f Change SPELL_EFFECT_SUMMON_PHANTAS to SPELL_EFFECT_FORCE_DESELECT and allow it to be casted with active pet
This fixes Mirror Image not changing names when Water Elemental is active. (Note that deselect effect is done in linked spells for Killing Spree/Shadowmeld)

--HG--
branch : trunk
2010-01-13 10:27:44 +01:00
thenecromancer
a4cb03d9cd Remove unexpected arg, sorry for that
--HG--
branch : trunk
2010-01-13 10:20:28 +01:00
thenecromancer
ecd9470dc8 Fix Kill Shot damage (increase damage by attack power, not weapon damage ( that is already included in effects))
--HG--
branch : trunk
2010-01-13 09:54:03 +01:00
QAston
ef24d90472 * Make sure that aura is applied on unit before trying to remove it.
--HG--
branch : trunk
2010-01-10 20:09:44 +01:00
Rat
5b6079ea67 *cleaned up SharedDefines
--HG--
branch : trunk
2010-01-10 16:27:47 +01:00
QAston
f9c4030f59 *Implement attribute SPELL_ATTR_NEGATIVE_1
*Remove unneeded hacks from SpellMgr::_isPositiveSpell
*Missing ! in prev commit.

--HG--
branch : trunk
2010-01-10 13:48:57 +01:00
QAston
e3ff6145ee * Use pair<uint32, uint64> lists instead of <Aura*> lists in Dispel/SpellSteal effects handlers (prevent reference to aura removed from unit)
* Correctly fill EffectStealBeneficialBuff list with Stackable/Chargeable auras

--HG--
branch : trunk
2010-01-10 12:08:58 +01:00
QAston
8e9d2cdf01 Update aura system:
* Change system logic - unify Auras, AreaAuras and PersistentAreaAuras:
  * Aura has now its owner - which is the WorldObject, which applies aura (creates AuraApplication object) dependant on aura radius, and effect type
  * Owner can be Dynobj (DynObjAura class) for PersistentAreaAuras, or Unit (UnitAura class) for Area and nonArea auras
  * Aura data is shared for all units which have AuraApplication of the Aura
   * Because of that AuraEffect handlers , and periodic tick functions can't modify AuraEffect object (they are const now)
  * Remove spell source and AreaAuraEffect classes
  * Add AuraEffect::UpdatePeriodic function, to allow periodic aura object modification (target independant)
  * Add AuraEffect::CalculateAmount and AuraEffect::CalculateSpellMod function, to allow non-default amount calculation
  * AreaAura updates are done in owner _UpdateSpells cycle
  * Since now you don't need to wait an aura update cycle to get area aura applied on it's correct target list
  * And you can access area aura target list
  * Add basic support for aura amount recalculation
  * Save recalculation state and base amount of auras to db
  * Add AuraEffect::CalculatePeriodic function to determine if aura is periodic, and to set correct tick number after aura is loaded from db
  * Add ChangeAmount function in addition to SetAmount function, to allow easy reapplication of AuraEffect handlers on all targets
  * Sort aura effect handlers in SpellAuras.cpp and .h by their use
  * Add check for already existing aura of that type to some AuraEffect handlers, to prevent incorrect effect removal
  * SPELL_AURA_CONVERT_RUNE and MOD_POWER_REGEN and MOD_REGEN hacky handlers are now implemented correctly
  * Send aura application client update only once per unit update - prevent unnecesary packet spam
 * Fix ByteBuffer::appendPackGUID function - it added additionall 0s at the end of the packet
 * Fix memory leak at player creation (not deleted auras)
 * Updated some naming conventions (too many to mention)
 * Added Unit::GetAuraOfRankedSpell() function
 * Remove procflags on aura remove, use Aura::HandleAuraSpecificMods instead
 * Added functions to maintain owned auras (GetOwnedAuras, GetOwnedAura, RemoveOwnedAura, etc)
 * Implement AURA_INTERRUPT_FLAG_LANDING
 * Implement EffectPlayerNotification (thanks to Spp)
 * Remove wrong aura 304 handler
 * Add better handler for death runes
 * Remove unnecesary variables from DynamicObject class, and cleanup related code, link dynobj duration with aura
 * Add GetAuraEffectTriggerTarget function in CreatureAi for special target selection for periodic trigger auras used in a script
 * Add many assert() procection from idiots using some functions in wrong way
 * I am to lazy to write here anything more
Thanks to Visagalis for testing this patch
PS: Do not make patches like this, please

--HG--
branch : trunk
2010-01-10 01:23:15 +01:00
Astellar
c239c380df Some Fixes for Earth Shield.
Now Dispel and Spellsteal effects will correctly dispel and steal Earth Shield's charges instead of entire aura.

--HG--
branch : trunk
2010-01-07 23:31:46 +03:00
Astellar
a886552c85 Glyph of Blocking proc moved to DB.
--HG--
branch : trunk
2010-01-05 15:52:44 +03:00
Astellar
53a7a7bd48 Cleanups for Devastate and Glyph of Devastate.
--HG--
branch : trunk
2010-01-05 14:36:06 +03:00
Win32
c2791f7d0e fix Pain and Suffering (reduces the damage you take from your own Shadow Word: Death)
and remove double dmg Shadow Word: Death

--HG--
branch : trunk
2010-01-04 15:53:19 +02:00
Win32
e8ebeff6bf fix Restorative Totems
--HG--
branch : trunk
2010-01-04 11:05:19 +02:00
p0wer
0aef7ea793 Fix Mind Blast applying Mind Trauma. Will now proc. Thanks to Morpheux for
pointing out that it wasn't proccing.

--HG--
branch : trunk
2009-12-27 18:38:09 -06:00
p0wer
be6b12af36 Fix whitespace for Flask of the North. Cleanliness and organization = win. =D
--HG--
branch : trunk
2009-12-27 18:09:41 -06:00
p0wer
3cf90a73a5 merge
--HG--
branch : trunk
2009-12-27 17:50:40 -06:00
p0wer
23c3086eb2 Backed out changeset: bcf447b68a92
--HG--
branch : trunk
2009-12-27 17:49:52 -06:00
maanuel
e2a6e6dd24 Support for spell 67751 used by Argent Confessor Paletress. Thanks to QAston and Gyullo.
--HG--
branch : trunk
2009-12-27 18:01:34 -03:00
p0wer
2ba1a48dd4 Replace some more id's with new variable names. Fix some whitespace formating.
--HG--
branch : trunk
2009-12-27 12:28:46 -06:00
n0n4m3
874751cd7b Fixed spell Master's Call, autor ?, thx sundark
--HG--
branch : trunk
2009-12-26 18:52:31 +01:00
maanuel
6272e29d90 Support for spell 67729.
--HG--
branch : trunk
2009-12-26 14:46:19 -03:00
n0n4m3
947b258479 Fixed Mana Gems, implement SPELL_EFFECT_CREATE_MANA_GEM and revert prev. commit...
--HG--
branch : trunk
2009-12-26 18:25:49 +01:00