Tested with:
- Windows 8 x64
- MySQL 5.5.30 win32
- OpenSSL 1.0.1c (32 bits)
- No PCH
- MinGW with GCC 4.7.0
TODO:
- Fix compile/link with PCH enabled
- Fix compile with WheatyExceptonionReport enabled (ignored for now)
- Fix compile of .rc files (ignored for now)
- Test with more platforms
(Missing change from previous commit)
To enable any of the removed config option you should now add the proper role to the proper groups
IE:
AllowTwoSide.Interaction.Mail = 1 --> Add role 19 to group 1 (Add it to players)
- Remove config options: CONFIG_ALLOW_TWO_SIDE_INTERACTION_CHAT, CONFIG_ALLOW_TWO_SIDE_INTERACTION_MAIL, CONFIG_GM_LOG_TRADE, CONFIG_ALLOW_TWO_SIDE_ACCOUNTS, CONFIG_ALLOW_TWO_SIDE_WHO_LIST, CONFIG_ALLOW_GM_FRIEND, CONFIG_ALLOW_TWO_SIDE_ADD_FRIEND, CONFIG_SILENTLY_GM_JOIN_TO_CHANNEL
- Fix RBAC_PERM_SKIP_CHECK_CHAT_SPAM (Was checking spam for those that had the permission)
- Only check RBAC_PERM_TWO_SIDE_INTERACTION_CHAT for sender of whispers (Restores GM being able to whisper players)
- Only check RBAC_PERM_TWO_SIDE_INTERACTION_MAIL for sender
- Fix .ticket assign <Player>, with last RBAC change it was changed by mistake from Player to Account
* There are 28 vehicles using for what is stated in the description - it handles keeping specific emote states (animations) for passengers entering vehicles, I'm not 100% sure if is connected with the aura states that apply them. There are videos for every single known creature that is using it. 31583 - is clearest example since has only this flag as unknown on seat 0. Putting it here only to give direction to where researching should be made if someone dig into it more or can implement support for it.
* There are heavy core problems that make it not fully functional for now.
1) Enter vehicle of 31578 is being overriding the vehicle aura of the accessory so it kicks it out. (both get applied to 1, but instead decoy should be to 0).
2) Even if mentioned above get fixed the accessory is supposed to implicitly hit another passenger with explosion
and no seat flags for it even unknown.
3) Armored Decoy doesn't keep emote from freeze mechanic when enter vehicle connected with a not supported flag.
4) Vehicle speed seems too fast (there is some general vehicle not correct speed problem with spline being involved).
Connected with: #5757
* I tought if a spell would hit all targets on map then the force cast would be cast for each, apparently I was wrong since it had unlimited implicit targets.
* Remove a condition with target mask players since there is a attribute that takes care of that.
Closes#9365
* Nexus Lords had a bit imba timers on Arcane Shork, sorry for it wrong information. Now have retail timers.
* Scion of Eternity Arcane Barrage had wrong timers also for intial random cast and for each after. They were a bit lower.
* Implemented source mechanic that will always differ target of cast X to target of next cast. All rest is % chance based on various cases can happen.
* Removed condition for Arcane Overlaod bubbles now aura will never ("disappear"), if two are at one place they will override each other, but damage will never be leaked test enough times so don't bother stating opposite. Damage in ALL cases is reduced.
* Made Malygos range outside of platform a bit shorter to match retail real distance that also fixed timings of bubble mechanic, now they will always be there, if you are fast enough.
* And finally fixed some slight stuff on Malygos spell. Now all will work and Arcane Storm has it's correct visual mechanic again.
Closes#9321
* Note that even after last changes happens I'm not sure exactly how the timers are controlled. The wipe chance should be a lot smaller now.. Any further change I can think of is beyond what I see. The main problem is currently. In theory there is chance, If timers get to be same with delay lesser than 2 seconds and if target randomisations select same target for shit out of luck reason. And if starting different timers were matching you can be hit atleast 2-3 times and on 25 mode maybe more. The timers are not with fixed difference for sure is all I know.
* Removed long deprecated code for mining nodes (multiple uses, artifact of TBC)
* Made fishing pools generate use count only on spawn (and respawn) instead of randomizing use count on every fishing attempt - prevents early despawning in some cases
* Starting timers were a bit slower
* Destroy platform proper timing for drake casting mount spell to player (trigger)
* Remove IMMUNITY_PC flag after Iris is triggered (thx to Expecto) and readd it on evade
* Remove NOT_SELECTABLE flag since shouldn't be present at starting event
* Fix misc of id of Static Field added to LOS attributes
* I have no idea how these breaks were removed, but it was breaking the whole mechanic.
* Also fix some slight chance for fail of transitioning p II -> p III
* Surge of Power (25 man) still needs to get fixed some weird facing and warnings aren't always sent for some reason
