Commit Graph

25636 Commits

Author SHA1 Message Date
jackpoz
376defd085 Scripts/Icecrown Citadel: Fix "intended" crash
Change an assert (that can happen easily using ".npc add") to a sanity check

(cherry picked from commit 953640d563)
2021-09-26 16:21:33 +02:00
jackpoz
330881518a Core/Quest: Fix crash caused by disabled quests
Fix crash happening when a disabled quest was added and rewarded (through a GM command). Disabled quests are not validated on startup and they can reference invalid spells.

(cherry picked from commit 5f6af8c6cb)
2021-09-26 16:21:11 +02:00
ccrs
ab740026b3 Core/Movement: crashfix workaround
untested
ref #18471

(cherry picked from commit 76667e45a9)
2021-09-26 16:16:16 +02:00
jackpoz
3f659ce5ff Core/Thread: Fix crash added in fd33b1cd02
Fix crash caused by dereferencing uninitialized field.

(cherry picked from commit 623bc6483a)
2021-09-26 16:15:52 +02:00
Treeston
9f06cb63d2 Core/Threat: My dictionary informs me that "fixtate" is not, in fact, a word. Corrected to "fixate".
fd33b1c follow-up

(cherry picked from commit 1d27f83bda)
2021-09-26 16:13:15 +02:00
Shauren
58043c8d90 Core/Movement: Removed unneccessary z position adjustment
Closes #21872

(cherry picked from commit d9a2177e9c)
2021-09-26 16:12:52 +02:00
Treeston
16eb5032ad Core/Threat: Re-add fixtate system. I am being told Netherspite needs it.
(cherry picked from commit fd33b1cd02)
2021-09-26 16:12:33 +02:00
Treeston
c926e2fc94 1b7ec4b follow-up
(cherry picked from commit 7fe59c95d8)
2021-09-26 16:11:59 +02:00
Treeston
4634cfaa9f Core/Threat: Fix taunt behavior in some edge cases
(cherry picked from commit 1b7ec4bc84)
2021-09-26 16:07:40 +02:00
Treeston
f1ac141f25 Core/Unit: UNIT_FLAG renames
[UNIT_FLAG_PLAYER_CONTROLLED -> UNIT_FLAG_POSSESSED]
[UNIT_FLAG_PVP_ATTACKABLE -> UNIT_FLAG_PLAYER_CONTROLLED]
Signed off by: Shauren, Warlockbugs.

(cherry picked from commit 081eab3cf5)
2021-09-26 16:07:09 +02:00
Jorge Turrado Ferrero
a9b97939a8 Scripts/Ulduar: Fixed Vehicles when flame leviathan die(#21897)
(cherry picked from commit f13de80834)
2021-09-26 15:49:18 +02:00
Keader
962833d86f Core/Handlers: Fixed Equipament Manager (for real this time)
(cherry picked from commit 26a444719b)
2021-09-26 15:47:34 +02:00
Gooyeth
80d4bde77a Core/Player: Skip the cinematic of the first login if the character is teleported before. (#21776)
(cherry picked from commit 8cec3ffe43)
2021-09-26 15:45:44 +02:00
Keader
d8e57b1ddc Core/Handlers: Fixed a Equipament Manager typo
(cherry picked from commit 5a22467912)
2021-09-26 15:43:00 +02:00
Keader
1fcabb4092 Core/Handlers: Fixed equipament manager with empty slots. Yes kids, dont use drugs !
Followup: 42be04898c
(cherry picked from commit dec75903cf)
2021-09-26 15:42:24 +02:00
Shauren
9709643f50 Core/Misc: Fix copyright headers 2021-09-26 14:22:52 +02:00
ccrs
0b6049fe0b Core/Movement: use helpers for validation
(cherry picked from commit 7118806231)
2021-09-26 14:21:14 +02:00
ccrs
d59a6af9c6 Core/Movement: move MoveSplineInit (#21857)
The number of edge cases in which weirdness is seen on "effect movements" will be kinda reduced, plus consistency, plus movementInform on custom movement spline initalizations.

(cherry picked from commit 2a45418032)
2021-09-26 14:19:36 +02:00
Shauren
334b02e1da Core/SAI: Fixed crashes when SAI targets pets that use sai if not tamed
Closes #21870

(cherry picked from commit beb333738d)
2021-09-26 12:43:18 +02:00
ccrs
d376058dcc Core/Movement: crashfix
New movement -> Mutate -> Finish current for that slot that happens to be the same type, Follow -> Finish method on the removed movement -> UpdateSpeed call -> search for top -> crash

Closes #21861

(cherry picked from commit bcab5bc4e7)
2021-09-26 01:43:24 +02:00
Shauren
068b340b69 Core/Transports: Force transport passengers into legacy spawn group
Ref #21641

(cherry picked from commit a5df77a9d6)
2021-09-26 01:42:54 +02:00
Shauren
5274f7af17 Core/PacketIO: Added missing move assignment operator to ByteBuffer
(cherry picked from commit fcb1e3e642)
2021-09-26 01:27:59 +02:00
ccrs
4793b073ee Core/Misc: movement header cleanup
(cherry picked from commit f9914caefc)
2021-09-26 01:22:17 +02:00
Nitair
4f0aa11c6e Scripts/Stratholme: Baroness Anastari rework (PR #21687)
(cherry picked from commit dc28889151)
2021-09-25 22:45:56 +02:00
Gooyeth
a9e7464e0d Core/Battleground: allow Random battleground and arena queues same time. (#21730)
- It also restricts queuing to arenas if it is in queue of dungeon finder

(cherry picked from commit 8aad6f828e)
2021-09-25 21:36:11 +02:00
Shauren
e598cfe28d Core/SAI: Fixed silence logic in 1e8227eda7
(cherry picked from commit 668df7fd01)
2021-09-25 20:46:13 +02:00
Killyana
c0cb8fc1fe Core/SAI: Allow movements for creature using castflag 64 when silenced
Closes #20222

(cherry picked from commit 1e8227eda7)
2021-09-25 20:45:27 +02:00
Killyana
e7f93ca96d Core/SmartAI: Remove PauseMovement on AttackStart
Closes #21144

(cherry picked from commit e27a745c58)
2021-09-25 20:43:39 +02:00
Shauren
52de393f10 Core/Players: Greatly simplifiy fdb2b90685
(cherry picked from commit 9617778336)
2021-09-25 15:36:50 +02:00
Shauren
47630708f0 Core/Players: Prevent creating characters with duplicate name by reserving name early in the process
Closes #21656
Closes #21809

(cherry picked from commit fdb2b90685)
2021-09-25 15:34:20 +02:00
Shauren
453b59de57 Core/Maps: Adjusted logic in GetFullTerrainStatusForPosition to closer match what the client does regarding being inside WMOs
Closes #21625
Closes #21624
Closes #21516

(cherry picked from commit b9c6bbb51d)
2021-09-25 01:04:21 +02:00
Treeston
3d9d6fbcb8 Core/Movement: Fix a potential crash on newly created pets. Closes #21791.
(cherry picked from commit 74defba5a7)
2021-09-24 23:43:30 +02:00
Shauren
d76db70cbf Core/Chat: Fixed chat link exploit
Closes #21790

(cherry picked from commit 454bae42c6)
2021-09-24 23:38:11 +02:00
Treeston
1493920495 Core/Movement: Replace old TargetedMovementGenerator into ChaseMovementGenerator and FollowMovementGenerator, full rewrite for both.
- Chase to angle is now functional. Pets use this to chase behind the target. Closes #19925.
- Chase to arbitrary range interval works. Not used anywhere, but you can technically make hunter-like mobs.
- Pets now follow the hunter cleanly and without stutter stepping. Also fix some other things. Closes #8924.

(cherry picked from commit 2a84562dc8)
2021-09-24 23:37:43 +02:00
ariel-
3d1da4957c Core/Player: partial revert of m_items handling as it's cause of a exploit
Closes #21760

(cherry picked from commit a413e7dee9)
2021-09-23 23:53:04 +02:00
Keader
69663cc94f Core/Spells: Fix UNIT_CREATED_BY_SPELL in SPELL_EFFECT_SUMMON (#21756)
(cherry picked from commit 309738dc3e)
2021-09-23 23:50:13 +02:00
ariel-
3ea88f814a Core/Spells: all bleed effects should ignore armor
Closes #21759

(cherry picked from commit 5dec0e491b)
2021-09-23 23:37:11 +02:00
Gooyeth
2bea816bbe Core/Auras: Don't save liquid auras
(cherry picked from commit 8001c5ead1)
2021-09-23 23:23:06 +02:00
ariel-
765987a9f5 Core/Misc: whitespace/tab cleanup
(cherry picked from commit bcc7427fbc)
2021-09-23 22:50:09 +02:00
Treeston
a5ae9522f3 travis fix, ebc96af follow-up
(cherry picked from commit e350cfc437)
2021-09-23 22:40:42 +02:00
Treeston
fc05aba0d4 crash fix follow-up
(cherry picked from commit 6939f4eb7b)
2021-09-23 22:28:48 +02:00
Treeston
f69d12504c Core/Object: Bump hover delta handling on nearpoints downstack into GetNearPoint2D (from movement generators); functionality should be unchanged
(cherry picked from commit ebc96af6bb)
2021-09-23 22:28:06 +02:00
Treeston
b0e064ff89 you saw nothing, and have no evidence against me
(cherry picked from commit 69143b949e)
2021-09-23 22:24:08 +02:00
Treeston
572c16b017 fb39980 follow-up
(cherry picked from commit 44502bbfff)
2021-09-23 22:21:55 +02:00
Treeston
bc89e1cdb0 Core/Position: Refactor GetAngle -> GetAbsoluteAngle because code clarity is good.
(cherry picked from commit 4692e10ca2)
2021-09-23 22:21:29 +02:00
Treeston
bf958da148 Core/Position: code style cleanup of position.h; no change in functionality.
(cherry picked from commit fb39980c52)
2021-09-23 21:31:15 +02:00
Gooyeth
086447370b Core/Database: Add columns on *_banned (#21748)
* Add columns on ban character query

* Add columns on ban account query

(cherry picked from commit 768968f0c0)
2021-09-23 21:18:49 +02:00
DanVS
bc34fd2f65 [3.3.5] Scripts/Spells: handle auras on unequipping scripted items (#21643)
Ref: #20415
(cherry picked from commit c2f1657988)
2021-09-23 20:55:30 +02:00
Keader
c1641642cb Scripts/Magtheridon: Fixed Magtheridon inaccessible
Closes #21693

(cherry picked from commit 99993a7f62)
2021-09-22 23:29:33 +02:00
Shauren
c34e0f80a0 Core/Items: Disable effects on items marked as legacy 2021-09-22 00:01:47 +02:00