Peter Keresztes Schmidt
e372f9badb
Core/Battlegrounds: Use std::chrono::duration overloads of EventMap ( #25015 )
...
Contributes to #25012
2020-07-14 18:11:07 +02:00
Shauren
8675fd756f
Core/Misc: Fixed wrong db field accessors usage found with TRINITY_STRICT_DATABASE_TYPE_CHECKS
...
* Fixes loading group instance reset times
* Fixes loading battlefield templates
2020-07-14 12:46:57 +02:00
Giacomo Pozzoni
ee34a1f19e
Scripts/Kologarn: Fix another "stuck in combat" issue ( #24998 )
2020-07-14 09:44:17 +02:00
Gildor
5e1571062a
Core/Spells: Check a few aura effects for determining if should be negative ( #25004 )
2020-07-14 09:43:41 +02:00
Giacomo Pozzoni
203573db83
Core/Spells: Implement SPELL_EFFECT_ACTIVATE_OBJECT. ( #23 ) ( #24997 )
...
* Core/Spells: Implement SPELL_EFFECT_ACTIVATE_OBJECT. (#23 )
Original research by @xvwyh.
# Conflicts:
# src/server/game/DataStores/DBCStores.cpp
# src/server/game/DataStores/DBCStructure.h
# src/server/game/DataStores/DBCfmt.h
# src/server/game/Entities/GameObject/GameObject.h
# src/server/game/Entities/GameObject/GameObjectData.h
# src/server/scripts/EasternKingdoms/ZulAman/zulaman.cpp
# src/server/scripts/Kalimdor/HallsOfOrigination/boss_temple_guardian_anhuur.cpp
* Add missing sql update
* Fix some build errors
* Remove unused enum values
* Change artkits from 0-4 to 0-3
* Remove unused code
* Code review feedback
* Fix sql
* Remove artkit4 special case handling
* Default initialize artKits
* Code review feedback
* Split sql into structure and data files
Co-authored-by: Warpten <vertozor@gmail.com >
2020-07-14 09:34:03 +02:00
Shauren
e2ec3df27e
Add missing breaks
2020-07-13 18:15:09 +02:00
Peter Keresztes Schmidt
10be49bdfe
Fix some compiler warnings reported by GCC ( #25007 )
...
* Core/AI: Remove unneeded null checks
GetMap() can never return NULL.
Fixes additionally -Wunused-variable warnings
reported by GCC.
* Core/GameObject: Fix a -Wunused-variable warning reported by GCC
* Core/Player: Fix a -Wunused-variable warning reported by GCC
* Scritps/CavernsOfTime: Fix -Wimplicit-fallthrough warnings reported by GCC
* Scritps/CavernsOfTime: Fix a -Wmaybe-uninitialized warning reported by GCC
Warning:
/home/peterke/DEV/TrinityCore/src/server/scripts/Kalimdor/CavernsOfTime/CullingOfStratholme/npc_arthas.cpp: In member function ‘virtual void npc_arthas_stratholme::npc_arthas_stratholmeAI::UpdateAI(uint32)’:
/home/peterke/DEV/TrinityCore/src/server/scripts/Kalimdor/CavernsOfTime/CullingOfStratholme/npc_arthas.cpp:1119:58: warning: ‘emote’ may be used uninitialized in this function [-Wmaybe-uninitialized]
1119 | (*it)->HandleEmoteCommand(emote);
| ~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~
* Scritps/PitOfSaron: Fix -Wunused-variable warnings reported by GCC
* Scritps/EyeOfEternity: Fix a -Wclass-memaccess warning reported by GCC
Warning:
/home/peterke/DEV/TrinityCore/src/server/scripts/Northrend/Nexus/EyeOfEternity/boss_malygos.cpp: In member function ‘virtual void boss_malygos::boss_malygosAI::UpdateAI(uint32)’:
/home/peterke/DEV/TrinityCore/src/server/scripts/Northrend/Nexus/EyeOfEternity/boss_malygos.cpp:950:81: warning: ‘void* memset(void*, int, size_t)’ clearing an object of non-trivial type ‘class ObjectGuid’; use assignment or value-initialization instead [-Wclass-memaccess]
950 | memset(_surgeTargetGUID, 0, sizeof(_surgeTargetGUID));
|
* Scritps/CoilfangReservoir: Fix a -Wclass-memaccess warning reported by GCC
Warning:
/home/peterke/DEV/TrinityCore/src/server/scripts/Outland/CoilfangReservoir/SerpentShrine/boss_leotheras_the_blind.cpp: In member function ‘void boss_leotheras_the_blind::boss_leotheras_the_blindAI::Initialize()’:
/home/peterke/DEV/TrinityCore/src/server/scripts/Outland/CoilfangReservoir/SerpentShrine/boss_leotheras_the_blind.cpp:220:55: warning: ‘void* memset(void*, int, size_t)’ clearing an object of non-trivial type ‘class ObjectGuid’; use assignment or value-initialization instead [-Wclass-memaccess]
220 | memset(InnderDemon, 0, sizeof(InnderDemon));
| ^
* Scritps/Naxx: Fix a -Wimplicit-fallthrough warning reported by GCC
For discussion see https://github.com/TrinityCore/TrinityCore/pull/25007
2020-07-13 16:35:31 +02:00
Ghaster
5af8ff2b84
Core/Spells: Use correct SpellEntry field for Amplitude ( #25008 )
2020-07-12 16:56:50 +02:00
Peter Keresztes Schmidt
c92950b3e1
Core/DataStores: Update DBC field names to generated ones ( #24999 )
2020-07-12 15:36:55 +02:00
Max Drosdo.www
3529442668
Core/Player: Introduce separate level caps for each expansion ( #24989 )
2020-07-11 11:10:04 +02:00
Shauren
dc71bd466f
Core/DBLayer: Fix build with TRINITY_STRICT_DATABASE_TYPE_CHECKS
2020-07-11 10:58:25 +02:00
Shauren
c317f248bf
Core/DBLayer: Optimize string based query results by eliminating unneeded buffer copies
...
(cherry picked from commit 59f1f60a83 )
# Conflicts:
# src/server/database/Database/Field.cpp
# src/server/database/Database/Field.h
# src/server/database/Database/QueryResult.cpp
2020-07-10 22:47:04 +02:00
Eridium
98c37b15e0
Creature/Script: npc_blackfathom_deeps_event ( #24969 )
...
* Creature/Script: npc_blackfathom_deeps_event
* Update blackfathom_deeps.cpp
* Update blackfathom_deeps.h
* codestyle
* Update blackfathom_deeps.cpp
Co-authored-by: Killyana <Killyana@users.noreply.github.com >
Co-authored-by: Ovah <dreadkiller@gmx.de >
2020-07-09 22:39:44 +02:00
jackpoz
f10b9d617a
Core/Database: Apply 54b0b8f5ea to 141ada19b0
2020-07-09 22:37:23 +02:00
jackpoz
b4adaa838c
Core/Creature: Add null check for charmed creatures
2020-07-09 22:12:18 +02:00
Ovah
94a4404e7e
Core/Spells: Expose corpseTarget to spell scripts with SpellScript::GetHitCorpse() ( #24981 )
...
Closes #24945
2020-07-09 20:03:40 +02:00
akrom23
f99a79cb43
Creature/AI: Remove SetVisible from SmartAI::InitializeAI
...
Closes #24184
2020-07-09 19:34:36 +02:00
Shauren
14db2215d3
Core/Spells: Don't select corpses for spell targets that expect to hit units
...
Closes #24980
2020-07-09 18:44:21 +02:00
Ovah
232628f0a6
Scripts/ICC: fixed a crash in the Lich King encounter caused by invalid corpse targets
2020-07-09 14:22:00 +02:00
offl
c6811d3e4e
DB/Quest: Convert & update support for 'Khu'nok Will Know' to SAI
...
Closes #24933
2020-07-08 17:37:05 +02:00
Ovahlord
8a82403400
Core/Events: refactored battleground holiday assignments.
...
Instead of going with shitty bitmasks we now accept plain battleground ids
instead
2020-07-07 17:07:09 +02:00
offl
46ad9fa0d9
DB/Quest: Convert & update support for 'Chasing A-Me 01' to SAI
...
Closes #24925
2020-07-07 00:28:25 +02:00
offl
18864aeddb
DB/Quest: Convert & update scripts from Thousand Needles to SAI
...
Closes #24924
2020-07-06 23:46:19 +02:00
offl
c29e3b46af
DB/Quest: Convert & update support for 'Protect Kaya' to SAI
...
Closes #24923
2020-07-06 23:34:41 +02:00
Giacomo Pozzoni
8c0a315734
Core/Pools: Attempt to workaround pools being broken since 2015 ( #24949 )
...
* Core/Pools: Attempt to workaround pools being broken since 2015
Attempt n°2
* Fix warning
2020-07-06 21:05:43 +02:00
Max Drosdo.www
e20e51a385
Core/Unit: Prevent gaining weapon and defense skillups in pvp ( #24895 )
2020-07-06 18:34:42 +02:00
jackpoz
bf62901053
Core/PetAI: Validate GetCharmInfo()
...
Fixes #24870
2020-07-05 20:22:45 +02:00
jackpoz
519192f210
Core/Spells: Add missing code from corpse target type cherry-picks
2020-07-05 16:21:58 +02:00
Gildor
2a5f537d6a
Core/Gameobjects: Improve IsValidAttackTarget faction check for traps that hasn't owner or have NPC owner ( #24931 )
2020-07-04 15:58:41 +02:00
Gildor
26ba4ecd51
Core/Spells: Check a few aura effects for determining if should be negative ( #24930 )
...
* Core/Spells: Check a few aura effects for determining if should be negative
* Rename 9999_99_99_99_world_auras.sql to 2020_07_04_00_world.sql
Co-authored-by: Giacomo Pozzoni <giacomopoz@gmail.com >
2020-07-04 15:56:48 +02:00
offl
2ebef0c51c
DB/Creature: Convert & update support for 'Messenger Torvus' to SAI
...
Closes #24852
2020-07-02 23:20:19 +02:00
Gildor
4a4aac61d5
Core/Gameobjects: Traps shouldn't ignore IsImmuneToNPC/IsImmuneToPC and IsInSanctuary rules if has owner ( #24911 )
2020-07-01 22:53:28 +02:00
Gildor
af1571ce50
Core/Spells: SPELL_AURA_MOD_HEALTH_REGEN_PERCENT should be negative if TargetType is enemy and Basepoints are negative ( #24902 )
2020-07-01 22:50:11 +02:00
Gildor
7a81ce2f21
Core/Spells: SPELL_AURA_MELEE_SLOW should be negative if TargetType is enemy or Basepoints are negative ( #24901 )
2020-07-01 22:46:21 +02:00
Gildor
0759d73777
Core/Spells: SPELL_AURA_MOD_MELEE_RANGED_HASTE should be negative if Basepoints are negative ( #24900 )
2020-07-01 22:45:21 +02:00
Keader
4418450804
Scripts/Warrior: Fixed a typo on intervene script
2020-07-01 07:31:51 -03:00
Rothend
193408f335
Core/Players: properly scale current value of hidden skills with player level ( #24886 )
...
Closes #20979
Closes #24801
2020-06-30 16:39:12 +02:00
Giacomo Pozzoni
cc71da35b5
Core/Spells: implement corpse target type support and properly fix resurrections ( #24921 )
...
* Core/Spells: implement corpse target type support and properly fix resurrections
(cherry picked from commit df193945d9 )
# Conflicts:
# src/server/game/Spells/Spell.cpp
# src/server/game/Spells/Spell.h
* Core/Spells: implement TARGET_CORPSE_SRC_AREA_RAID and updated remaining resurrection effect handlers for updated corpse targeting
(cherry picked from commit 98b075cb4b )
# Conflicts:
# src/server/game/Miscellaneous/SharedDefines.h
# src/server/game/Spells/Spell.cpp
# src/server/game/Spells/SpellEffects.cpp
# src/server/game/Spells/SpellInfo.cpp
* Fix no-pch
Co-authored-by: Ovahlord <dreadkiller@gmx.de >
2020-06-29 23:03:03 +02:00
genion18
32aebc14ab
DB/Quest: Rumors for Kravel outro event
...
Closes #24835
2020-06-29 01:32:49 +02:00
offl
eea3cf1401
DB/Quest: Convert & update support for 'Escorting Erland' to SAI
...
Closes #24834
2020-06-29 01:24:45 +02:00
offl
fb58ca0bf5
DB/Quest: Convert & update support for 'Pyrewood Ambush' to SAI
...
Closes #24833
2020-06-29 01:11:10 +02:00
Keader
6d16c39e76
Scripts/Warrior: Implemented threat effect of Intervene
2020-06-28 13:14:25 -03:00
Shauren
b304f4ad8d
Nopch fix
2020-06-27 20:34:19 +02:00
Shauren
0468c70dfe
Core/Maps: Implemented getting area id from gameobject spawns
...
Yes, you can now spawn LK platform anywhere and it will treat you as inside Icecrown Citadel
(cherry picked from commit 42f9deb21e )
2020-06-27 20:23:30 +02:00
jackpoz
54c701cf0d
Core/Common: Replace ASSERT(false, "...") with ABORT_MSG("...")
2020-06-26 23:37:52 +02:00
jackpoz
49da3533cd
Core/Common: Add macro ASSERT_WITH_SIDE_EFFECTS to be used when asserting conditions that have side effects
2020-06-26 23:21:49 +02:00
offl
d526d5d176
DB/Quest: Convert & update support for 'Scratches' to SAI
...
Closes #24824
2020-06-26 22:40:13 +02:00
offl
f621173748
DB/Quest: Convert Galen's Escape to SAI
...
Closes #23684
2020-06-26 16:05:08 +02:00
offl
f2c2210dbb
DB/Quest: Convert & update support for 'City of Light' to SAI
...
Closes #24814
2020-06-26 15:49:39 +02:00
jackpoz
3ac1992afb
Core/MMAPs: Fix small steps being considered as NAV_AREA_GROUND_STEEP
2020-06-24 22:53:41 +02:00