Commit Graph

22913 Commits

Author SHA1 Message Date
Shauren
d4d8366131 Proper typo fix, it was too early in the morning 2017-02-28 10:58:35 +01:00
Shauren
5b4820cc0f Typo/build fix 2017-02-28 08:46:11 +01:00
SnapperRy
9da35aa3bd Core/Achievement: do not consider overkill damage for ACHIEVEMENT_CRITERIA_TYPE_DAMAGE_DONE.
(cherry picked from commit 4eb799560c)

Fix wrong copy-paste from last commit.

Sorry.
(cherry picked from commit c41b4000f9)
2017-02-27 21:59:02 +01:00
Shauren
c7cd51e8f5 Core/Movement: New names for a few spline flags 2017-02-27 19:30:44 +01:00
SnapperRy
87b6b9c27f Core/Creature: enable pet bar for TempSummons with category SUMMON_CATEGORY_PET.
Thanks @ariel- for helping with the research (although I'm two months late).
(cherry picked from commit 025002b907)
2017-02-26 21:34:05 +01:00
SnapperRy
1b288ebbdd Core/SmartAI: do not target player's group for SMART_ACTION_CALL_AREAEXPLOREDOREVENTHAPPENS.
SMART_TARGET_INVOKER_PARTY or SMART_ACTION_CALL_GROUPEVENTHAPPENS should instead be used to achieve this functionality.

(cherry picked from commit 6586885bca)
2017-02-26 21:31:16 +01:00
vincent-michael
7c12096df0 Core/PacketIO: Re-enabled SMSG_INITIAL_SETUP opcode 2017-02-26 21:06:10 +01:00
treeston
0b6422ab9b Maps/Boundary: Some code style clean-up in AreaBoundary code, as well as adding an additional utility overload to IsWithinBoundary (Position const&).
(cherry picked from commit a7afb47633)
2017-02-26 20:02:25 +01:00
treeston
e829af4c2b Common/Utilities: More std::chrono overloads for EventMap. Specifying 2 std::chrono types now gives you a random (to milliseconds) time in that interval (inclusive) for (Re)ScheduleEvent.
(cherry picked from commit 2174c5d7dd)
2017-02-26 20:02:15 +01:00
SnapperRy
cab4ce3a53 Core/Fishing: implement retail-like fishing skill-up functionality (#17528)
Follow-up to  6f1e823.

Forgot to update base characters database. Sorry.
2017-02-26 19:59:07 +01:00
SnapperRy
29ce69b3ad DB/Quest: improvements for Test at Sea:
- Prevent player from entering combat when using the quest item.
- The targeted NPCs should only yell sporadically.
(cherry picked from commit 271c16fb60)

Rename 2016_09_12_03_world.sql to 2016_09_13_01_world.sql
(cherry picked from commit 43968512ce)
2017-02-26 19:26:43 +01:00
ariel-
fecf3b6143 Core/Spell: Updated SpellInfo::GetMaxTicks with all effects capable of periodics
(cherry picked from commit e0ba5f9ed6)
2017-02-26 19:22:21 +01:00
SnapperRy
83257dacf2 Core/Fishing: ignore required skill when fishing in pools.
(cherry picked from commit 4164e0cf88)
2017-02-26 19:21:19 +01:00
ariel-
bf3570dadb Core/Spell: do not cast interrupt effect if the spell did not hit
(cherry picked from commit 08e0390d95)
2017-02-26 19:20:36 +01:00
treeston
9039a1c138 Instance/UtgardePinnacle: Fix Svala Sorrowgrave timings (from sniff).
(cherry picked from commit 5d87e4af8c)
2017-02-26 19:20:13 +01:00
Aokromes
927a1b3e1e Core/Updater: Clarify more 2 errors
(cherry picked from commit fe9f79780e)

Update DBUpdater.cpp
(cherry picked from commit fb048a4cdb)

Update DBUpdater.cpp
(cherry picked from commit 9250680680)
2017-02-26 16:56:45 +01:00
treeston
e39c582532 Core/Movement: Fix an edge case crash in HomeMovementGenerator.
(cherry picked from commit f2067d3557)
2017-02-26 16:52:24 +01:00
joschiwald
7ee191578e Scripts/Spells: Updated two Anraphet SpellScripts 2017-02-26 16:38:22 +01:00
treeston
e9b931e297 Entities/Object: Add some Position const& overloads to distance/angle methods for usability.
(cherry picked from commit 0e8c2f9032)

Woops. Thanks, clang.

Crash fix.
(cherry picked from commit 1b7eebc7ba)
2017-02-26 15:49:01 +01:00
SnapperRy
1bb998f406 Script/Quest: replace wrong test spell used for quest "Red Snapper - Very Tasty!" with actual summoning.
The spell does not appear in sniffs, and the summoned NPC's spawn time was far too short to be appropriate (15 seconds).
(cherry picked from commit 0479f08c3c)

Script/Quest: fix and use proper serverside summon spell for quest "Red Snapper - Very Tasty!".
(cherry picked from commit 2f493430c9)
2017-02-26 15:39:00 +01:00
Rochet2
117b45d768 Core/Scripts: Enhance quest status hook by making it catch more status changes (#17865)
(cherry picked from commit c52566a888)
2017-02-26 15:36:01 +01:00
treeston
9710c808d7 Core/Maps: Add override to allow InstanceMap const* -> InstanceScript const*.
Also tighten const-ness on CanSpawn method of CreatureScript.

(cherry picked from commit 3c32086b81)
2017-02-26 15:33:46 +01:00
treeston
31a3f2297b Core/Conditions: New CONDITION_QUESTSTATE (47). It's the existing quest conditions collapsed into a bitmask value2 because I'm a lazy person that doesn't like having long SQL queries.
Then use this new condition to fix Sniffing out the Perpetrator for Horde. Tagging issue #17914.

(cherry picked from commit 62cffd11d0)
2017-02-26 15:31:42 +01:00
treeston
e941d7e04b Creature/Scripting: Move CreatureAI::CanRespawn to CreatureScript::CanSpawn. Now also applies to initial spawn. Dynamic spawning prep.
(cherry picked from commit b3d44d6c36)

Game/Scripting: Follow-up to b3d44d6. Fix script selection for creatures on difficulty > 0.
(cherry picked from commit 91c2b3162d)

Build fix.
(cherry picked from commit a9f1151f2c)

Fine, this time I actually built it. Promise.
(cherry picked from commit 0c2c88ed50)
2017-02-26 15:30:15 +01:00
treeston
9c36dd7e94 AI/SmartAI: Fix an issue where SmartAI creatures would not properly follow their owner on evade. Also fix a bug where creatures with INHABIT_ROOT would get stuck in evade under certain conditions.
This allows us to fix quest 12261 (No Place to Run). Closes #16291.

(cherry picked from commit e69a483aa9)

Derp. Build fix.
(cherry picked from commit 9180bcd404)
2017-02-26 15:30:15 +01:00
ariel-
c229816104 Core/Entities: moved duplicated triggered cast proc check to Unit::ProcDamageAndSpellFor, it was preventing some always triggered auras from proccing.
(cherry picked from commit 19e757af5c)
2017-02-26 15:30:14 +01:00
ariel-
945bbbfa77 Core/AI: updated SpellTargetSelector::operator() (#17824 follow-up)
(cherry picked from commit 805637cea1)
2017-02-26 15:30:14 +01:00
ariel-
4957a17cb1 Core/Battlefield: container optimization
(cherry picked from commit 932d31598d)
2017-02-26 15:30:13 +01:00
ariel-
4d061e0b49 Core/Battlefield: fix Wintergrasp defender portal logic
(cherry picked from commit 43c071d0c8)
2017-02-26 15:30:08 +01:00
ariel-
a82e9e5150 Core/Scripts: move Icehowl unroot after movement (MotionMaster does not update if unit is Rooted)
Closes #17864

(cherry picked from commit 47a43b21c8)
2017-02-26 15:30:08 +01:00
ariel-
0afe0e536d Core/Scripts: Implement Flag of Ownership. Closes #12265
Core/Spells: Implemented TARGET_CORPSE_SRC_AREA_ENEMY. Closes #12803

(cherry picked from commit bc4b4f656c)
2017-02-26 15:30:07 +01:00
ariel-
934f038753 Core/Scripts: Removed Glyph of Backstab.
(cherry picked from commit 31399d5f34)
2017-02-26 15:30:02 +01:00
Shauren
e9bdcd9d64 Scripts/Naxxramas: Fixed invalid use of std::initializer_list 2017-02-26 15:01:23 +01:00
Shauren
bc2380e105 Core/DataStores: Fixed Meta->Types/TypesString mixup causing crashes when trying to send hotfix for nonlocalized string
Closes #18882 (for real this time)
2017-02-26 15:00:46 +01:00
Shauren
047c6f072b Core/Movement: Handle move stop embedded in spell cast requests 2017-02-25 22:13:00 +01:00
vincent-michael
a4c226eecc Core/Spells: Fixed possible crash 2017-02-25 00:05:21 +01:00
Shauren
bfe4733195 Build fix 2017-02-21 21:05:37 +01:00
Shauren
3fce636c19 Revert "Fix non-PCH build." and fix it the proper way
This reverts commit 438d090c8d.
2017-02-20 17:39:31 +01:00
ariel-
b1b150a419 Core/Transport: do not relocate players on board of vehicles when near teleporting. Vehicle should take care of that
(cherry picked from commit 7470bf6b97)
2017-02-19 15:34:57 +01:00
ariel-
b239afb0ef Core/Misc: calculate rotation fields from orientation in some places it's impossible to get:
- SmartScripts: SMART_ACTION_SUMMON_GO
- Spell Effects:
  * SPELL_EFFECT_DUEL
  * SPELL_EFFECT_SUMMON_OBJECT_WILD
  * SPELL_EFFECT_SUMMON_OBJECT_SLOT1
  * SPELL_EFFECT_SUMMON_OBJECT_SLOT2
  * SPELL_EFFECT_SUMMON_OBJECT_SLOT3
  * SPELL_EFFECT_SUMMON_OBJECT_SLOT4
- Command Scripts: .gobject add

Closes #17891

(cherry picked from commit 14445d2202)
2017-02-19 15:34:57 +01:00
treeston
dd0df772df Scripts/Events: Globally fix all ExecuteEvent loops to check UNIT_STATE_CASTING after each iteration, instead of just checking it once initially.
Fixes and closes #17892.

(cherry picked from commit ac62d7156f)

Drycoding is bad, mmkay?
(cherry picked from commit ed83a35fbe)
2017-02-19 15:09:02 +01:00
treeston
5654fb9343 Merge branch '3.3.5-goshdangitsmartai' into 3.3.5 (PR #17738)
(cherry picked from commit e9eacae7b2)

Core/SmartScripts: Add missing break, 5f43e7b follow-up.
(cherry picked from commit a4623efaa6)
2017-02-19 15:07:42 +01:00
r00ty-tc
8a71e4255e [Core/Maps] Activate creatures and objects during opening cinematics and other flyby cameras (sunwell etc).
Requires re-running map extractor to extract camera m2 files from data
files. These are very small.
2017-02-19 14:47:20 +01:00
Gacko
438d090c8d Fix non-PCH build.
What else?
2017-02-19 14:36:21 +01:00
Shauren
5dbe9e7890 Core/Creatures: Implemented all creature equipment modifiers
* It is now possible to give creatures a mythic/heroic weapon

Closes #19160
2017-02-19 10:58:08 +01:00
Shauren
8db72348ee Build fix 2017-02-19 00:59:43 +01:00
Shauren
5e437f5d3d Core/Movement: Implement SpellEffectExtraData curve modifiers 2017-02-18 21:55:28 +01:00
ariel-
255dd29562 Core/Spell: no need to bloat existing parameter lists. (f81754a306 follow up)
(cherry picked from commit 4829cca9fb)

Note to self: drycoding is bad
(cherry picked from commit 7e8a08c351)

Another build fix.

(it was probably better to just revert the commit instead)
(cherry picked from commit be8d113699)
2017-02-18 18:07:07 +01:00
ariel-
163f5b02af Core/Spell: Workaround cobra strikes into a charged aura instead of stacked.
Fixes #754

(cherry picked from commit 65d0a9478d)
2017-02-18 17:59:17 +01:00
ariel-
7a971d7ed2 Core/Spells: register SPELLMOD_CRITICAL_CHANCE in casting spell modifiers.
(cherry picked from commit f81754a306)
2017-02-18 17:57:55 +01:00