Commit Graph

18696 Commits

Author SHA1 Message Date
Killyana
ef794af489 Spell: "Fierce Lightning Stike" must hit only one target
(cherry picked from commit 8942142286)
2021-12-20 22:15:44 +01:00
Shauren
5d02739b98 Scripts: Fix rbac permission for skipping default boss sequencing check
(cherry picked from commit e660c8bc19)
2021-12-20 21:40:47 +01:00
Kelno
45585b5305 Fixed PvP Combat timer never getting refreshed (#24058)
* Fixed PvP Combat timer never gets refreshed while meleeing

* Apply Treeston feedback

Co-authored-by: Giacomo Pozzoni <giacomopoz@gmail.com>
(cherry picked from commit 2b024e8fbf)
2021-12-20 21:25:46 +01:00
Regigicas
aa81d8979f Core/SAI: Fix SMART_ACTION_SET_MOVEMENT_SPEED behavior (#24059)
(cherry picked from commit 1369620436)
2021-12-20 21:25:33 +01:00
Giacomo Pozzoni
ce25c212e0 Scripts/Ulduar: Attempt to fix Yogg-Saron not evading on wipe (#24055)
(cherry picked from commit 039534d1db)
2021-12-20 21:24:51 +01:00
Alan Deutscher
cd72ecce78 Scripts/Spells: fix Turkey Timer duration (#24048)
* spell_gen_turkey_marker::OnPeriodic: Pop expired stack timestamps from tracking list.

* Be a bit more explicit about the data type of removedCount.

* Formatting nudge.

* Remove brackets.

(cherry picked from commit a0c07655eb)
2021-12-20 21:24:37 +01:00
xvwyh
9b79d1b410 Core/DynamicObjects: Restore the ability of DynamicObjects to be world objects which was accidentally removed in f0f4a620fb breaking Far Sight (#24046)
Fixes #17081

(cherry picked from commit d4ba47a76e)
2021-12-20 21:22:37 +01:00
ccrs
25a987496c Scripts/ICC: include missing call from UnitAI::JustExitedCombat override in npc_green_dragon_combat_trigger
(cherry picked from commit 330cbb55fb)
2021-12-20 21:10:33 +01:00
Shauren
e43a02668f Scripts/Icecrown Citadel: Removed unneccessary combat hacks from Valithria Dreamwalker
(cherry picked from commit c188d4db85)
2021-12-20 21:07:50 +01:00
Killyana
e9ba28afc9 Quest/Scripts: Remove some hacks from "Trolls Is Gone Crazy!"
(cherry picked from commit a149261e94)
2021-12-20 21:07:28 +01:00
Giacomo Pozzoni
dd929665e5 Core/PathGenerator: Fix path generator returning shortcuts when start and end are on the same polygon (#24036)
* Core/PathGenerator: Fix path generator returning shortcuts when start and end are on the same polygon

Fix path generator returning shortcuts when start and end are on the same polygon by handling this case as if start and end were on 2 different polygons. This will ensure BuildPointPath() gets called which calls FindSmoothPath(), making sure each step is not longer than SMOOTH_PATH_STEP_SIZE (4 yards)

* Change ingame cast error message to SPELL_FAILED_NOPATH from SPELL_FAILED_OUT_OF_RANGE if the generated path is too long

(cherry picked from commit 29bf280e34)
2021-12-20 20:35:37 +01:00
Keader
174f4bad3d Scripts/Blood Furnace: Fixed Broggok reset issues and some little improvements
Closes #23658

(cherry picked from commit 1bdc792559)
2021-12-20 20:18:55 +01:00
Giacomo Pozzoni
7c97fa4449 Scripts/Misc: Fix build warnings
(cherry picked from commit 37ffdc05b2)
2021-12-19 23:31:30 +01:00
Killyana
71e474e14f DB/Spawns: Remove "Hand of the Deceiver" spawns as summoned by a script
(cherry picked from commit 434cdb1fa0)
2021-12-19 23:27:12 +01:00
Killyana
3f3abe9ad0 Creature/Script: Add text target for npc_shadowfang_prisoner
(cherry picked from commit 10ba39e626)
2021-12-19 19:49:52 +01:00
Shauren
d44d218046 Core/Phasing: Delete old and unused enum 2021-12-19 18:12:28 +01:00
Shauren
68a25f5e9b Core/Scripts: Add missing implementation for samePhase argument of ScriptedAI::ForceCombatStopForCreatureEntry 2021-12-19 18:12:12 +01:00
ccrs
d7571e5d1f Scripts/ICC: little bit of cleanup in Valithria after the "recent" changes
(cherry picked from commit 7ffe018571)
2021-12-19 18:05:23 +01:00
Killyana
956a342845 Core/Movement: Remove a wrong set SetWalk from HomeMovementGenerator
(cherry picked from commit 9f057d7082)
2021-12-19 17:44:10 +01:00
Killyana
a7cf209428 Core/Creature: Clear creature focus after an evade
(cherry picked from commit a32aeceb0d)
2021-12-19 17:44:00 +01:00
Giacomo Pozzoni
d095d4afe9 Fix fleeing speed to 66% run speed (#24025)
* Core/Movement: Fix fleeing speed to 66% run speed

Fix fleeing speed to 66% run speed until the creature starts returning home

* Fix build

* Don't check speed type

* Don't apply speed reduction twice

* Fix no-pch (1st try)

* Make sure every spell focus is interrupted when seeking assistance

(cherry picked from commit 4ccf01de39)
2021-12-19 17:39:25 +01:00
Killyana
d946d74ff9 Core/AI: Fix creatures not updating their target properly once engaged
Closes  #21562

(cherry picked from commit 7fb7432620)
2021-12-19 15:54:20 +01:00
Giacomo Pozzoni
8d32849b34 Core/MMaps: Fix charge underwater/falling (#24010)
* Core/MMaps: Fix charge underwater

Fix charge sometimes returning "no path available" when swimming/underwater.
Fix charge selecting a destination point 4 yards above swimming/underwater targets

* Allow falling units to charge targets that are below (lower Z coordinate)

* Disable "raycast" pathfinding as it's not blizzlike.

This might show some strange paths when charging with a target in front.
It also fixes some falling undermap issues.

This Reverts 272009ebee

* Remove Z offset when charging a target as it never made sense

(cherry picked from commit 88a14251e2)
2021-12-19 15:54:09 +01:00
Keader
80dbecbd56 Scripts/ICC: Fixed Valithria Archmages casting while dead
After 9c603ea87f, dead creatures will tick UpdateAI
Closes: #24012

(cherry picked from commit 2f31119ea3)
2021-12-19 15:51:30 +01:00
Giacomo Pozzoni
292df30394 Core/Movement: Fix wrong orientation set when pausing movement (#23986)
* Core/Movement: Fix wrong orientation set when pausing movement

* Update MoveSpline.h

* Update Unit.cpp

(cherry picked from commit e698c17a26)
2021-12-19 15:48:43 +01:00
Eridium
2b27278516 Spell/Script: Egg Nog (#24007)
Closes  #23996

(cherry picked from commit b60786a916)
2021-12-19 15:48:29 +01:00
Killyana
a09d5d4854 Creature/AI: Reset CoolDowns on evade
Closes  #24008

(cherry picked from commit cb11ad97fb)
2021-12-19 15:46:40 +01:00
Michael
72e61625bc additional output for additem command (#24006)
* additional output for additem command

when removing items with additem:

if the user provides an amount too large of a negative amount, the command will now output the amount of items that could not be destroyed.

* renamed sql file to hopefully avoid conflicts

* added clarification to failure string

* changed unneeded else if condition to else

* code style; braces

* Update and rename 9999_99_99_99_world.sql to 2019_12_28_01_world.sql

(cherry picked from commit 6b19f4a0ab)
2021-12-19 15:46:20 +01:00
jackpoz
2327ff4d6d Core/Movement: Fix fleeing speed to 66% run speed
Fix AssistanceMovementGenerator using 100% MOVE_RUN speed instead of 66% . Please note that the fleeing mechanic still has some open issues that this single commit doesn't fix

(cherry picked from commit 862d47394b)
2021-12-19 15:34:20 +01:00
Giacomo Pozzoni
b40cadd5a1 Core/Movement: Fix stunned falling units freezing the client (#24000)
(cherry picked from commit 8f94c9ef6b)
2021-12-19 15:33:57 +01:00
Keader
b9def15aa7 Scritps/ICC: Fixed resistance calculation for Mutated Transformation (Professor Putricide) (#23858)
More Info in: #23837

(cherry picked from commit 9f7b464a6a)
2021-12-19 15:33:41 +01:00
Giacomo Pozzoni
96ec8477f0 Core/Creatures: Fix spell_school_immune_mask being applied against positive spells too (#23999)
(cherry picked from commit 18a4cbee5e)
2021-12-19 15:31:34 +01:00
Giacomo Pozzoni
fda1630f74 Core/Spells: Fix Spellsteal stealing Silence buff of Arcane Torrent (#23992)
(cherry picked from commit 7920347f43)
2021-12-19 15:30:59 +01:00
Giacomo Pozzoni
1635a34228 Core/Movement: Add more LOS checks (#23991)
Add more LOS checks to ensure Units don't cross trees/walls when fleeing/moving

(cherry picked from commit 13ad8b66d9)
2021-12-19 15:30:13 +01:00
Meji
c4fee8c5cf Core/Spells: Implemented spell effect 204 (SPELL_EFFECT_CHANGE_BATTLEPET_QUALITY) (#27425) 2021-12-19 13:27:27 +01:00
jackpoz
e6ac3316b7 Core/Map: Load the grid of TempSummons owned by Players
Ensure to load the grid of TempSummons owned by Players when the relocate to another cell

(cherry picked from commit afbc478919)
2021-12-19 13:14:33 +01:00
Shauren
e30683fda4 Scripts: Add missing killer nullptr checks in JustDied hooks
(cherry picked from commit 175eba74ae)
2021-12-19 13:12:42 +01:00
Shauren
e539de68e1 Core/Creatures: Fixed crash when guards get killed by periodic auras whose caster is offline or despawned
(cherry picked from commit 046e98bc5d)
2021-12-19 13:12:30 +01:00
jackpoz
7fb3b89d1d Scripts/Misc:Code cleanup
(cherry picked from commit 68fa3091a2)
2021-12-19 13:12:05 +01:00
Killyana
22e088351d Creature/Script: Fire Bomb
Closes #23977

(cherry picked from commit c5c46fed6a)
2021-12-19 13:11:06 +01:00
Killyana
8c6216eaab Creature/Script: Toravon Frozen Orb Stalker
(cherry picked from commit 9bed0aa8d8)
2021-12-19 13:10:28 +01:00
Killyana
ff30b0751e Spell: Move Crystal Spike aura to the cpp
(cherry picked from commit 26faca51cd)
2021-12-19 13:09:42 +01:00
Killyana
a8cbaa33ac Spell: Move Shadow Trap aura to the cpp
(cherry picked from commit 462b63957a)
2021-12-19 13:04:08 +01:00
Eridium
c96157cb95 Boss/Script: Fix Mechano-Lord Capacitus's Nether Charges (#23976)
* Boss/Script: Fix Mechano-Lord Capacitus's Nether Charges

Closes #23973

* Update boss_mechano_lord_capacitus.cpp

* Update boss_mechano_lord_capacitus.cpp

* Update boss_mechano_lord_capacitus.cpp

* Rename 2019_12_99_99_world.sql to 2019_12_19_00_world.sql

(cherry picked from commit efcbfa5c24)
2021-12-19 12:34:32 +01:00
Killyana
41b7b39e3c Spell: Move Column of Frost & Mana Void to the cpp
(cherry picked from commit 74f92d776b)
2021-12-19 12:33:59 +01:00
Killyana
eb36b2f2f7 Spell/Script: Move the spell "Flame Sphere Spawn Effect" from the DB to the cpp
(cherry picked from commit 4d89da56c1)
2021-12-19 12:25:17 +01:00
aquadeus
07015cc052 Scripts/Spells: Fix paladin talent Eye for an Eye (#27426) 2021-12-19 11:53:17 +01:00
aquadeus
5750466259 Scripts/Spells: Fixed priest talent Masochism (#27420) 2021-12-19 11:41:33 +01:00
Giacomo Pozzoni
64eb65cd45 Core/Creature: Remove empty spell ids from CreatureAddon.auras vector
Close #23969

(cherry picked from commit f20265feaf)
2021-12-19 01:46:07 +01:00
jackpoz
73e7719dbf Core/Creature: Log an error for Creatures spawned with temporary auras
The errors still need to be addressed.
Close #23225

(cherry picked from commit 54f9456764)
2021-12-19 01:44:53 +01:00