Commit Graph

22951 Commits

Author SHA1 Message Date
Jinnaix
26002c530f Scripts/Diremaul - Dire Maul crystal and forcefield fix (#25332)
* Scripts/Diremaul
Diremaul Crystal and Forcefield fix

* Apply suggestions from code review

Apply suggestions

Co-authored-by: MaxtorCoder <warsongkiller.s8@gmail.com>

* Fix stuff

* _private member

* use std array instead of c-arrays and standartized guid container namings

* Process feedback

* finalize

* blubb

* small changes

* whoops

* Process feedback

* Missing include

* Process feedback

* Apply suggestions from code review

Co-authored-by: Giacomo Pozzoni <giacomopoz@gmail.com>

* remove unused field

Co-authored-by: MaxtorCoder <warsongkiller.s8@gmail.com>
Co-authored-by: Ovah <dreadkiller@gmx.de>
Co-authored-by: Giacomo Pozzoni <giacomopoz@gmail.com>
2021-01-10 16:38:41 +01:00
Giacomo Pozzoni
fc1a0d9368 Core/Unit: Fix movement hiccups in water (#24020)
* Core/Unit: Allow to define Units which can enter water but cannot swim

Allow to define Units which can enter water but cannot swim, i.e. crabs walking at the bottom of a sea.

* Add UNIT_FLAG_SWIMMING to creatures when entering combat

* Fix charmed creatures not entering water

* Always allow Creatures controlled by players to enter water

* Add swimming flag when possessing a unit and remove it properly at the end, even if the creature engaged combat before and after.
When adding/removing UNIT_FLAG_SWIMMING manually calling Creature::RefreshSwimmingFlag(true) might be required.
2021-01-10 10:18:51 +01:00
offl
95a2b906b0 DB/Creature: Remove remaining UNIT_FLAG_PACIFIED part 1
Ref #25764
2021-01-10 01:21:05 +02:00
Kyle Phelps
817bd92a2a Split all addon chat logs into separate log streams (#25816)
* Split all addon chat logs into separate log streams

* Add missing channels

(cherry picked from commit ee6e71bbd3)

# Conflicts:
#	src/server/scripts/World/chat_log.cpp
2021-01-08 23:40:59 +01:00
wotlk-enthusiast
a225717b99 Scripts/Utgarde Pinnacle: Svala Sorrowgrave Intro and Ritual of the Sword (#24503)
* Scripts/Svala SorrowGrave - Fix broken intro event and Ritual of the Sword

* Added missing header for non-PCH build.

* Added error checking for Svala's targeting, and tightened up the timing on the intro event.

* Update WorldDB\Creature_Template_Movement for Svala

* Fix movement during intro and ritual event

* Rename SQL file for merge

Co-authored-by: Carbenium <carbenium@outlook.com>
2021-01-08 22:56:55 +01:00
offl
27722d42ef DB/Creature: Add UNIT_FLAG2_UNK1 (CREATURE_DIFFICULTYFLAGS_2_HIDE_BODY) 2021-01-08 00:49:18 +02:00
Mikhail Redko
a9db8a9b9a Scripts/Spells: Implement effect "Party Time" & Add Rejuvenation when eating Deviate Fish (#25802)
* Scripts/Spells: Implement effect "Party Time" & Add Rejuvenation when eating Deviate Fish

* Rename XXXX_XX_XX_XX_world.sql to 2021_01_06_08_world.sql

Co-authored-by: Giacomo Pozzoni <giacomopoz@gmail.com>
2021-01-06 20:47:58 +01:00
Mikhail Redko
65083dc936 Scripts/Spells: Implement hunter pet talent "Improved Cower" (#25804)
* Scripts/Spells: Implement hunter pet talent "Improved Cower"

Closes #25600

* Rename XXXX_XX_XX_XX_world.sql to 2021_01_06_07_world.sql

Co-authored-by: Giacomo Pozzoni <giacomopoz@gmail.com>
2021-01-06 20:43:20 +01:00
Treeston
de33d50c19 Core/Warden: Max packet size 500 -> 450 2021-01-04 23:52:50 +01:00
Mikhail Redko
eaa22b8a17 Core/Misc: Remove unneeded null-terminator after switch from wchar_t to std::wstring in 309851e. Fixes creation characters with declined russian names (#25797)
Closes #23775
2021-01-04 19:52:43 +01:00
Shauren
8d450f3f07 Core/Commands: Add .reload vehicle_template
(cherry picked from commit 4ca15ec065)

# Conflicts:
#	sql/base/auth_database.sql
#	src/server/game/Accounts/RBAC.h
2021-01-03 22:51:53 +01:00
Sevi
6392d9ac48 Core/Vehicles: add a way to delay the Vehicle despawn Time if its needed.
* New database table `vehicle_template` holds info for despawn delay with option to extend it in the future

(cherry picked from commit c7b10d3c5f)

# Conflicts:
#	src/server/game/Entities/Unit/Unit.cpp
#	src/server/game/Entities/Vehicle/Vehicle.cpp
#	src/server/game/Globals/ObjectMgr.cpp
#	src/server/game/Globals/ObjectMgr.h
2021-01-03 22:10:55 +01:00
Kargatum
a32b6b8ac4 Core: whitespace cleanup, reduce double blank line to single (#25795)
* Core/Misc: fix double empty line

* worldserver.conf
2021-01-03 11:47:07 +01:00
Aurelio Arcabascio
4ea64b515a Core/Player: auto-attacked player stands up from sit or sleep state (#25684)
* Fixed Auto Attack bug on sitting player

* Victim now stands during sleep and stand emotes
2021-01-02 19:10:26 +01:00
Treeston
94c03b2107 Core/Maps: Move some more Map internals to actually be... internals. 2021-01-01 04:03:52 +01:00
jackpoz
1cafd4ef74 Core/Misc: Fix Windows 32 bits build
Close #25789
2020-12-31 19:55:55 +01:00
Treeston
803dc789e4 Core/Maps: All RespawnInfo* handed to outside code are now RespawnInfo const*, to signify that outside code has zero business changing these. 2020-12-31 18:57:18 +01:00
Shauren
7d70fbc64c Core/RBAC: Reserve permission id 2020-12-31 12:52:31 +01:00
Giacomo Pozzoni
96b289cadb Core/SAI: Fix SMART_EVENT_FLAG_NOT_REPEATABLE flag being ignored when specifying a chance (and other SMART_ACTION_CAST fixes) (#25778)
* Core/SAI: Fix SMART_EVENT_FLAG_NOT_REPEATABLE flag being ignored when specifying a chance

Fix SMART_EVENT_FLAG_NOT_REPEATABLE flag being ignored when specifying a chance, always making the action trigger.

* Fix SMART_ACTION_CAST with SMART_EVENT_FLAG_NOT_REPEATABLE not casting the spell at all if rolled chance was successful but creature couldn't cast the spell

* Prevent linked actions if SMART_ACTION_CAST couldn't be completed and will be retried later
2020-12-30 21:18:00 +01:00
Treeston
f8afcec9f3 Core/Maps: move pooling hand-off outside of Map::CheckRespawn (PR#25785)
fixes #25777
2020-12-30 21:08:22 +01:00
jackpoz
0ad1854d1c Scripts/ICC: Fix teleporter not removing players from Gunship
A more generic solution might be better, maybe depending on spell flags

Ref #25652
2020-12-28 12:38:34 +01:00
Giacomo Pozzoni
aabd2b49e2 Core/Maps: Attempt to fix picking the wrong min height (#25771)
Close #25652
2020-12-28 12:36:52 +01:00
Sevi
a843d8b10c Core/Vehicles: Add missing caster guid check
Merges #25773

(cherry picked from commit e26122dc54)
2020-12-28 11:55:55 +01:00
Shauren
7817f18c24 Core/Vehicles: Treat entering other vehicles mounted on main vehicle as swapping seats
(cherry picked from commit 110564e757)
2020-12-28 11:55:55 +01:00
Shauren
fe89e835fb Core/SmartAI: Reserve a param for SMART_ACTION_SOUND master branch specific functionality, for compatibility reasons 2020-12-27 22:28:27 +01:00
jackpoz
ed1c0b6ec9 Core/Maps: Partially revert 0c69316714
Revert define to constexpr as this also broke some calculations
2020-12-27 20:22:35 +01:00
jackpoz
1e3d85e283 Core/Maps: Partially revert 0c69316714
The development will continue in a PR
2020-12-27 19:33:52 +01:00
jackpoz
01b1f20d3e COre/Misc: Remove whitespace 2020-12-27 19:28:31 +01:00
jackpoz
0c69316714 Core/Maps: Use the same logic to calculate grid coords to avoid mismatches
Use the same logic of (CENTER_GRID_ID - x / SIZE_OF_GRIDS) in GridMap::getMinHeight() as Map::GetGrid() to avoid coord grid mismatches caused by floating point precision, i.e. getting the wrong grid.
Replace defines with constexpr in grids to make debugging easier.

Closes #25652
2020-12-27 18:24:53 +01:00
jackpoz
9994459bd1 Scripts/Commands: Include map min height in ".gps" command 2020-12-27 17:14:22 +01:00
offl
f62306f52d Core/Scripts: Add missing spells to Black Morass 2020-12-27 03:13:40 +02:00
offl
8ca575ed52 DB/Spell: Add effects to more spells from Violet Hold
Turned out almost all spells from BM were copied to create Violet Hold. Not only serverside spells and not only their effects but also attributes and icons. The scripts were also copied, possibly unchanged
2020-12-27 03:06:31 +02:00
Ovah
527db2170b Core/Units: do not send power update packets when gaining power via energize spell effects to match retail behavior (#25599)
This fixes possible clientside visual issues where power is being added twice until the next update_object packet is being sent
2020-12-27 00:05:37 +01:00
Ovah
b7ba856b63 Core/SAI: implement new smart actions to change AI Animkits and to enable/disable hover movement (#25623)
* Core/SAI: implement new smart actions to change AI Animkits and to enable/disable hover movement for units

SMART_ACTION_SET_AI_ANIM_KIT (parameter 1: animKitId)
SMART_ACTION_SET_HOVER (parameter1: enable/disable)

* Update SmartScriptMgr.cpp

* Update SmartScript.cpp

* removed SMART_ACTION_SET_AI_ANIM_KIT since it's reserved for master
2020-12-26 23:31:25 +01:00
Gildor
8217519ea2 Core/Visibility: Split BG/Arena visibility settings (#25690) 2020-12-26 23:30:16 +01:00
Giacomo Pozzoni
3b2c878dd0 Core/Spells: Implemented personal summons (#19231) (#25765)
* Core/Spells: Implemented personal summons (#19231)

* By default determined by summon property flag SUMMON_PROP_FLAG_PERSONAL_SPAWN

Closes #18254

(cherry picked from commit b7bb5e6a98)

# Conflicts:
#	src/server/game/Combat/ThreatManager.cpp
#	src/server/game/DataStores/DBCEnums.h
#	src/server/game/Entities/Creature/TemporarySummon.cpp
#	src/server/game/Entities/Creature/TemporarySummon.h
#	src/server/game/Entities/GameObject/GameObject.cpp
#	src/server/game/Entities/Object/Object.cpp
#	src/server/game/Entities/Object/Object.h
#	src/server/game/Maps/Map.h
#	src/server/game/Spells/SpellEffects.cpp

* Build fix

* Implement feedback

* Fix parameters passed in wrong order
2020-12-26 22:32:01 +01:00
offl
bb94aec975 Core/Scripts: Add missing spells to Violet Hold 2020-12-26 02:12:39 +02:00
Treeston
c8c572d980 Game/ChatCommands: Make sure ChatHandler::extractPlayerTarget populates the strtok buffer for non-nullptr returns. Closes #25692, supersedes #25698. 2020-12-10 15:23:58 +01:00
jackpoz
1c08395e8a Core/Movement: Add a debug log when a player falls below the map 2020-12-09 19:52:12 +01:00
offl
cc98f68ac7 DB/Creature: Properly apply CREATURE_FLAG_EXTRA_NO_SKILLGAIN
Closes #25674
2020-12-08 13:09:20 +02:00
Giacomo Pozzoni
a4e93d779c Improve multithreading of mmaps_generator (#25625)
* Build/Misc: Add a few *San CMake flags

Add the following flags for the related tools:
- MSAN for Memory Sanitizer
- UBSAN for Undefined Behavior Sanitizer
- TSAN for Thread Sanitizer

* Remove unused parameter

* Fix UBSan reported issue

* Disable G3D buffer pools when using Thread Sanitizer as it has its custom locking mechanisms

* Code cleanup

* Move threads from maps to tiles

* Move tile building logic to TileBuilder class

* Fix memory leak in TileBuilder

* Fix build

* Store TileBuilder as raw pointer for now, it will be changed later on to use modern C++ constructs

* Fix crash on shutdown

* Revert pvs-studio change

* Fix generating 1 single tile not closing the program
2020-12-06 17:52:13 +01:00
offl
6af54eb508 DB/Instance/Arcatraz: More adjustments 2020-11-26 02:25:47 +02:00
jackpoz
5270ff58da Core/Player: Adjust fall damage log
Move fall damage log to "entities.player.falldamage" category and include the usual debug info
2020-11-21 16:33:00 +01:00
Treeston
cc8287927b [3.3.5] Scripts/Commands: .learn adjustments (PR #25454) 2020-11-18 20:09:34 +01:00
Ovah
4abbeb2a60 Core/Maps: add new FLAG_ALLIANCE_ONLY and FLAG_HORDE_ONLY for instance spawn groups (PR #25656) 2020-11-17 23:41:15 +01:00
Ovah
850b88546f Scripts/Misc: Use InstanceMap* in InstanceScript instead of Map* (#25655)
# Conflicts:
#	src/server/game/Instances/InstanceScript.cpp
#	src/server/game/Instances/InstanceScript.h
#	src/server/scripts/EasternKingdoms/BlackrockMountain/BlackrockCaverns/instance_blackrock_caverns.cpp
#	src/server/scripts/EasternKingdoms/MagistersTerrace/instance_magisters_terrace.cpp
#	src/server/scripts/EasternKingdoms/TheStockade/instance_the_stockade.cpp
#	src/server/scripts/EasternKingdoms/ZulGurub/instance_zulgurub.cpp
#	src/server/scripts/Kalimdor/CavernsOfTime/CullingOfStratholme/instance_culling_of_stratholme.cpp
#	src/server/scripts/Maelstrom/Stonecore/instance_stonecore.cpp
#	src/server/scripts/Outland/BlackTemple/instance_black_temple.cpp

Co-authored-by: Shauren <shauren.trinity@gmail.com>
2020-11-17 19:45:13 +01:00
offl
be6941cd0c DB/Spells: Move conditions for spell 'Gor'drek's Ointment' from item script to DB 2020-11-11 04:27:44 +02:00
offl
ed8bf7f0e2 DB/Creature: Convert & update support for Tonk Mine to SAI 2020-11-11 04:25:54 +02:00
offl
05fa1a46b3 DB/Quest: Update support for 'Merciful Freedom' (11676) 2020-11-10 00:37:35 +02:00
offl
dc4cb8f1d3 DB/Quest: Convert & update support for 'Prison Break' (11587) to SAI 2020-11-10 00:36:00 +02:00