Change log:
- Timers are more accurate
- Corrected Charge ability ID based on 6.x researches
- Added Midnight's missing emotes
- Fixed issue with instance being stuck in combat in case of wipes
- Solved the rare scenario where Attumen would be summoned multiple times
- Visual spell on 3rd phase transition added
- Attumen and Midnight can now be damaged during 3rd phase transition
- Midnight calls for the aid of every horse still alive in the stables
- Use proper spells to summon Attumen and handle transitions
- Now despawns on evade
Video of encounter after changes: https://www.youtube.com/watch?v=KX0rqaBeSzw
Add all 6 spells available from item 20557,
Hallow's End Pumpkin Treat:
- Hallow's End Candy, Orange Giant (24924)
- Hallow's End Candy, Skeleton (24925)
- Hallow's End Candy, Pirate (24926)
- Hallow's End Candy, Ghost (24927)
- Hallow's End Candy, Female Defias Pirate (44742)
- Hallow's End Candy, Male Defias Pirate (44743)
Thanks @Keader for creating the new spell scripts & SQL,
saved me a lot of time! :-)
Event/Midsummer: improve pole ribbon functionality:
- Bunny creature should hover, which puts it in the intended position.
- Use correct visual and internal spells to handle cosmetics and timers.
Remove use of flags UNIT_FLAG_NON_ATTACKABLE and UNIT_FLAG_REMOVE_CLIENT_CONTROL
Replace with correct one, UNIT_FLAG_UNK_31, imunity part now is fully handled by auras
Fix a problem with bugged orientation while casting SPELL_SYNCH_HEALTH
Use std::crono notations
Remove unneeded code
Move one spell_linked_spell to SpellScript
Fix Loot issue
Fix Possible Crash
File: zone_borean_tundra.cpp
Script: npc_hidden_cultist
Quest: The Hunt is On, 11794
NPC: Tom Hegger, 25827
Before this change, Tom Hegger does not target player when saying his
aggro text "You don't know who you're messing with, $c! Death beckons!"
and hence the text $c will be shown instead of the player class.
1 more text line removed in the ongoing series: "Remove hardcoded text from core scripts".
Core script for "Plucky" Johnson :
- move the actual gossip handling to DB
- create new gossip_menu_option entry
- link the option to gossip_menu.text_id
- add correct default gossip to the NPC
- create SAI script with alternate emotes
- add condition check for quest taken
- remove the script from zone script
- extra enum cleanup in zone script
Move 2 core scripts to DB / SAI:
- npc_bunthen_plainswind (NPC 11798)
- npc_silva_filnaveth (NPC 11800)
Additional result: remove 4 hardcoded text lines.
Target: remove lines from the list http://pastebin.com/x7wZLpxH
Removing one more hardcoded text line from core scripts.
Also adding correct gossip to the npc_grandmother script.
Gossip changes in this script:
- remove hardcoded text from core script
- use existing npc_text IDs in gossip enum
- add missing text rows to gossip_menu_option
- use values from gossip_menu_option in enum
- replace spawn coordinates 0.0f with GetPosition()
2 more text lines removed in the ongoing series:
"Remove hardcoded text from core scripts".
Core script for boss Majordomo Executus:
- add missing gossip_menu_option entries
- link the options via the table gossip_menu
- remove hardcoded text from the script
- minor enum line order sorting cleanup
- replace OnGossipSelect() with sGossipSelect()
The scripted events are unchanged.
If the script is inaccurate, make a new PR.
