Commit Graph

21845 Commits

Author SHA1 Message Date
SnapperRy
ffe4d8f357 Fix non-PCH build. 2016-10-24 14:05:23 +02:00
SnapperRy
bc1bdb9e16 Add forgotten override. 2016-10-24 14:04:57 +02:00
SnapperRy
f134011668 Script/Spell: remove cosmetic effect for Water Bucket item at login if it expired after the player logged out. 2016-10-24 14:04:45 +02:00
Gustavo
a7ea5be3f0 Core/GameObject Also spawn trap for GAMEOBJECT_TYPE_BUTTON (#18083) 2016-10-24 14:03:34 +02:00
ariel-
7d04331322 Core/Spell: do positivity spell checks only against actually hitted effects instead of the whole spell
Closes #18097
2016-10-24 14:03:08 +02:00
ariel-
162eaad0ee Core/Spell: clear auras of channeled spells if channeling is cancelled due to invalid targets (dead or w/e)
Closes #14859
Closes #15186
2016-10-24 13:59:54 +02:00
ariel-
657aea3d5b Core/Spells: mark Arcane Missiles aura as negative. Was downranking the spell when targetting low level mobs due to effect 1 flagged as possitive.
Closes #12152
2016-10-24 13:59:38 +02:00
ariel-
d8f310e2a1 Core/AuctionHouseBot: ahbot characters subsystem shake-up
Bonus: fix moar static analysis issues
2016-10-24 13:57:56 +02:00
ariel-
6c25db28f2 indentation fixes in zone_wintergrasp.cpp 2016-10-24 13:57:26 +02:00
SnapperRy
f28c778788 Core/Spell: allow SPELL_EFFECT_QUEST_COMPLETE to set a quest to rewarded only if that quest is used as internal flag by the server (has flag 1024 - QUEST_FLAGS_TRACKING). 2016-10-24 13:55:33 +02:00
SnapperRy
4f313746e0 Core/Quest: show DIALOG_STATUS_AVAILABLE instead of DIALOG_STATUS_REWARD for non-repeatable autocomplete quests. 2016-10-24 13:55:18 +02:00
SnapperRy
51c6209922 Core/Quest: send correct packet when a quest cannot be rewarded for item-related errors. 2016-10-24 13:55:04 +02:00
treeston
5d0a5951a1 Entities/Creature: Fix an edge case issue where creatures would re-acquire target after respawn if they despawned while spell focusing.
Instance/AzjolNerub: Fix Anub'arak wall and add sequence break info. Fixes and closes #18013.
2016-10-24 13:54:20 +02:00
SnapperRy
28aba933d6 Core/Text: allow GENDER_NONE to use FemaleText in broadcast_text if not empty.
Otherwise it would only use MaleText, which breaks cases where female NPCs change model to one that has no gender.
2016-10-24 13:52:08 +02:00
SnapperRy
2bc051aabf Fix warning.
Also, the quest's name is Arelion's Secret, not Arelion's Mistress.
2016-10-24 13:48:42 +02:00
SnapperRy
8ba4528db8 Script/Quest: Arelion's Mistress. 2016-10-24 13:48:00 +02:00
SnapperRy
d77b366703 Core/Quest: do not set a quest to failed if it's rewarded or has no status at all (not taken). 2016-10-24 13:47:32 +02:00
treeston
a9557382e8 Scripts/AzjolNerub: Make pulling Anub'arak a bit cleaner. 2016-10-24 13:45:33 +02:00
treeston
e5f2fe7b7b Fix _DespawnAtEvade for other creatures to actually respawn said other creatures.
Also fix add aggro for Hadronox.
Fixes and closes #18012.
2016-10-24 13:45:01 +02:00
treeston
0ba8f4c955 Core/Creature: Fix respawn logic to call reset react state BEFORE calling Reset(). Fixes Krik'thir behavior after a wipe (and maybe some others).
Fixes and closes #18011.
2016-10-24 13:44:08 +02:00
tkrokli
64d39af11a Core/Scripts: move npc_saat to DB (#17813)
The core script only contains gossip handling + conditions.
- remove script from file the_black_morass.cpp
- thereby removing 1 line of hardcoded text
- remove redundant SD2 comments in header
- add SAI, gossip and conditions to DB
2016-10-24 13:37:21 +02:00
SnapperRy
a0313cb09d Core/Scripts: Gnomish Mind Control Cap and Gnomish Universal Re…
…mote
2016-10-24 13:36:53 +02:00
ariel-
b4ceb798e0 Core/AI: initial support for monster sparring (#17673) 2016-10-24 13:30:22 +02:00
Keader
73ee018122 Core/Scripts: Implemented right Snobold Vassal behavior on Gormok fight. (#17934) 2016-10-24 13:28:26 +02:00
iridinite
d364576cce [3.3.5] AHBot Characters (#17885) 2016-10-24 13:27:54 +02:00
Keader
1e60c73ad9 Core/Unit: Remove incorrect check that dont allow units attack your vehicle/passenger (#17932) 2016-10-24 13:27:40 +02:00
SnapperRy
4fc4c81e89 Core/SAI: always use DespawnOrUnsummon() for SMART_ACTION_FORCE_DESPAWN.
SmartAI uses that same method internally, so there's no need to handle it in two different ways.

Does not affect functionality, but prevents useless SAI error log in case the target creature is not using SAI.
2016-10-24 13:27:26 +02:00
Gustavo
d82abaa2ac Core/Scripts Boss Lady DeathWhisper improvements 2016-10-24 13:26:40 +02:00
Kittnz
72d02185ba Core/Event: Change Midsummer Music container to vector 2016-10-24 13:19:28 +02:00
Kittnz
de78de624e Core/Event: Change Midsummer Music to search grid only 2016-10-24 13:19:15 +02:00
SnapperRy
496268c478 Script/Creature: Scarshield Infiltrator/Vaelan. 2016-10-24 13:19:02 +02:00
ariel-
9b74762644 Core/SmartScripts: fixup SMART_EVENT_FLAG_WHILE_CHARMED behaviour to only mean charmed creatures (#17738 follow-up)
Unit::IsControlledByPlayer is a expected value for TempSummons (like some triggers used in quests, summoned by spells).
Previous logic broke a lot of quests which use triggers to do stuff.

Allow JustSummoned and events linked from other events with flag set also in charmed (prevents breaking event chains)
Allow vehicles (needed for vehicles with SmartAI, eg Iron Rune Constructs and You: Rocket Jumping)
2016-10-24 13:18:45 +02:00
ariel-
a2c88b2468 Core/AI: added container independent wrappers for WorldObject::GetxxxInGrid 2016-10-24 13:16:12 +02:00
SnapperRy
adb3889885 Core/Item: fix wrong error message triggered when trying to equip two items with the same ItemLimitCategory. 2016-10-24 13:12:58 +02:00
Aokromes
3a4b951299 Core/Entities: extend available containers for WorldObject::GetxxxInGrid 2016-10-24 13:10:01 +02:00
ariel-
a16983b5bd Core/Scripts: Fix runtime error 2016-10-24 13:03:47 +02:00
SnapperRy
5497eebe29 Script/Quest: Stop the Ascension! 2016-10-24 13:02:50 +02:00
ariel-
171738b70e Core/Auras: don't ignore SPELL_ATTR3_ONLY_TARGET_PLAYERS in area auras.
Also, start abusing the arbitrary containers for searchers introduced in 8775f8b28a
2016-10-24 13:01:59 +02:00
Aokromes
2057e6de4a Core/Items: Defined all item flags
(cherry picked from commit ef29f32)
2016-10-24 13:01:00 +02:00
SnapperRy
4a4142747b Core/Loot: revert unique item check introduced in ea69115.
Proven to be wrong in its current form. Will reintroduce later either in the same method or via db conditions.
2016-10-24 11:17:17 +02:00
SnapperRy
8707ff2425 Core/Loot: limit unique items check introduced in ea69115 to affect only items that start a quest.
Turns out epic and legendary items are excluded from this limitation (or it could be just instanced content that is immune to this). Other qualities are affected as normal. Sorry for the mishap.
2016-10-24 11:16:47 +02:00
Aokromes
d68a119d5d Script/Quest: Apply Heat and Stir.
Enjoy one of the most frustrating quests in Northrend!
2016-10-24 11:15:17 +02:00
ariel-
3944dc25b9 Core/Creature: Call SetSpawnHealth after JustReachedHome in HomeMovementGenerator
Fixes issues with quests that rely on this behaviour (eg Free your Mind)

Also updated SetSpawnHealth so it doesn't do anything in case spawn is manual (SetHealth(GetHealth()) does modify things depending on deathstate)
2016-10-24 11:10:41 +02:00
ariel-
947086fb54 Core/SmartAI: There's a function for that 2016-10-24 11:10:26 +02:00
SnapperRy
76d8a6e636 Core/SAI: don't reset event phase when npc evades/resets.
The scripts themselves should take care of that.
2016-10-24 11:06:13 +02:00
Krudor
2a607f6ce1 Core/Spells: Effect leap back fix (#18057)
* Fixed unintentional typo?

Seemed to fix the issues related to the effect for the spells I tried.
Sometimes the caster triggers leapback onto targets, and with the old
code, it instead made the caster leap back instead of its targets

(cherry picked from commit 08aab73c7f)
2016-10-24 11:03:23 +02:00
SnapperRy
e0f43cca2d Core/Wintergrasp: fix ownership of workshops at the beginning of a new battle.
Those two, together with the two workshop in the Keep, always belong to the defender team. The SouthEast and SouthWest ones always belong to the attacker team.
2016-10-24 10:59:42 +02:00
ariel-
0edf0c5ff6 Core/Scripts: updated Lock and Load script with new hooks, DamageInfo might be null, so check for that too 2016-10-22 10:53:58 +02:00
SnapperRy
a6eb8d9b11 Core/Wintergrasp: cleanup and codestyle. 2016-10-22 10:53:40 +02:00
jackpoz
2dfa3298c8 Scripts/Azjol-Nerub: fix static analysis issues 2016-10-22 10:50:37 +02:00