aboutsummaryrefslogtreecommitdiff
path: root/src
AgeCommit message (Collapse)Author
2021-06-20Core/Movement: fe1ba18905 followupccrs
ref https://github.com/TrinityCore/TrinityCore/commit/fe1ba1890540283b8d330fe98b96770fe372ba8d#r27507316 plus I noticed a logic error on speedchange call (cherry picked from commit 28c6db0807a604b0178abe24daa0e4eb21f560fb)
2021-06-20Core/Scripts: fix Tenacity Aurascript (target is null on UpdatePeriodic)ariel-
- also aura amount increases with stack so we lose spellid info, calculate it from basepoints directly - aura should be SPELL_AURA_MOD_HEALING_PCT instead of SPELL_AURA_MOD_HEALING_DONE_PERCENT (ie taken instead of done, confusing names) (cherry picked from commit bc2a4c816d6dc893b9b0c8d5bf0a15fe085506c5)
2021-06-20Core/Unit: kill unused parameter from SpellxxxBonusTakenariel-
(cherry picked from commit c7095375c37c3812d14fbc865b95c8442b8712cf)
2021-06-20Core/Scripts: remove Tenacity hack, implemented with proper auraariel-
(cherry picked from commit 404240fb6820ab997b65740b234305c4c654c543)
2021-06-20Archaedas should properly start now when clicking on the altar. (#21401)Wilcalaf
(cherry picked from commit 0c1aaac219545b3dacf930ce0dd956bd5d7c4b40)
2021-06-20Core/Unit: corrected calculation for ↵ariel-
SPELL_AURA_MOD_DAMAGE_TAKEN/SPELL_AURA_MOD_HEALING auras - Spell bonus calculation and penalty was done twice, but it's simply flat +SP, which should be taken into account before other bonuses - Fixed missing code from SpellDamageBonusDone/SpellHealingBonusDone and killed multiplication by stack amount twice for default coefficient spells (already multiplied on level penalty) (cherry picked from commit 4d14f613f3d0dc579e2ca4b8dead65ac6e43965d)
2021-06-19Core/Spells: Do not apply SpellModOp::CritChance to spells that can't critariel-
2021-06-19Core/Spells: add log on load about improper use of attribute ↵ariel-
PROC_ATTR_REQ_SPELLMOD (cherry picked from commit dfa861593ea3adf06a52cbddbe9e60131dcfe626)
2021-06-19Core/Spells: implement SPELLVALUE_CRIT_CHANCEariel-
(cherry picked from commit 546a605bd0cd0e828def81e26697f1c116a3f1b7)
2021-06-19Core/Spells: calculate crit chance only for spells that do damage/healingariel-
Refs #18813 (cherry picked from commit 52873a7072ceb1f88d9caeefdda6084e6bb1d4af)
2021-06-19Core/AI: EscortAI init logic moved from JustAppeared to InitializeAI. There ↵Treeston
are no escort NPCs using compatibility mode anymore, so this is equivalent. As a result, inheriting scripts calling Start in on-create hooks (like JustSummoned) will now work properly again. Tagging #20310. (cherry picked from commit e4e6e2209c8ad6cc534460a4ec9f6da469761d15)
2021-06-19Scripts/AzjolNerub: Hadronox is a big spider mommy, and needs more room to ↵Treeston
pet her spider pets properly. Hopefully this'll reduce the number of evades happening during the encounter. Tag #20310. (cherry picked from commit b243a7929bac02509594f5f25da476cfcea3d64a)
2021-06-19Core/Movement: WaypointMovementGenerator cleanupTreeston
(cherry picked from commit fe1ba1890540283b8d330fe98b96770fe372ba8d)
2021-06-19Core/Movement: Creatures' idle movement generator can no longer override ↵Treeston
player mover control. Tagging #20310, partial fix. (cherry picked from commit d02f481d9ac8e1d1a7716368f609d53a5add0960)
2021-06-19Core/Scripts: implemented Combined Toxins proc only from poisonsariel-
(cherry picked from commit 477878630e1bb2811d9be97189f0c819377b7840)
2021-06-19Core/Auras: fix periodic ticks proc after previous commitariel-
(cherry picked from commit 9d0e90829cb6e6da8bab2a0bf2834834998c5708)
2021-06-19Core/Spells: require phasemask set for periodic damage procflagariel-
Closes #21379 (cherry picked from commit b42ade918a7c68c6916450cf2eac1fc0ad4d78de)
2021-06-19Core/Player: Add some assertsjackpoz
Assert PlayerInfo for race/class pair in a few Player functions (cherry picked from commit 3576a38f6c107d6b17795d84fcb4f87809917299)
2021-06-19Scripting/Obsidian Sanctum: Fix crashjackpoz
Fix crash caused by calling Reset() in constructor (which is not allowed) (cherry picked from commit 5aba5c7afff4289b6b90311f66e6939791b89ee4)
2021-06-19Shared/Database: Improve dead-lock error handlingjackpoz
Improve dead-lock error handling in async transactions by retrying the transaction for up to 60 seconds instead of just 5 times (cherry picked from commit 54b0b8f5ead41f936b12e97d1b4fbacd9b89ab53)
2021-06-19Scripts/Instance: Transition Gnomeregan to boss states (instance spawn group ↵Treeston
prep) (cherry picked from commit a4fc32dd867aa4e3eba762a890cc845604e82043)
2021-06-19Scripts/Icecrown Citadel: Fixed Sindragosa spawn after grid unloadKeader
ty sirikfoll :) (cherry picked from commit 2994abeae6f8abac7d535d5f966135235db8d64d)
2021-06-19Game/AI: InvalidAIException internal cleanupTreeston
(cherry picked from commit b456915f9a565d570a0f5732d32935b7082312f5)
2021-06-19Core/Spells: remove 'Vanish Purge' hack, the spell is present on DB and is ↵ariel-
copy of one in vanilla DBC Thanks to killerwife for the heads-up (cherry picked from commit 303efcf0e4ee9ce3cfe308a3d6aa2aece1aa39da)
2021-06-19Core/Scripts: Fixed tabs issues introduced in ↵Keader
5bef3e426aea37b0e7555f146037c58e7be6352d (cherry picked from commit 31ad6358fb9088583142d108d2649d0c94b43358)
2021-06-19Core/Scripts: Fixed possible crashs related with JustDiedKeader
(cherry picked from commit 5bef3e426aea37b0e7555f146037c58e7be6352d)
2021-06-19Core/Scripts: fix non-functional Celestial Planetarium Access GOariel-
- Client only sends CMSG_GAMEOBJ_REPORT_USE for this one Closes #19982 (cherry picked from commit b490d3f5ad6ccdfd103c8f756d2912f05b1741a0)
2021-06-19Scripts/Magisters Terrace: Removed not allowed ENSURE_AI call from constructorsirikfoll
Closes #20727 (cherry picked from commit cfaa4e6caf8f26eb850a714994b533a77e92a92f)
2021-06-19Scripts/Sunwell Plateau: Fixed and improved spell "Curse of Boundless Agony" ↵sirikfoll
target selection (Boss Kalecgos) (cherry picked from commit 14b6e3bbb36e4b5ec5212ed2a3bf5eb0012e095f)
2021-06-19Core/Spells: fix logic error causing near teleports to drop combat for playersariel-
Closes #21362 (cherry picked from commit 65709e1c3081c97442792695cbc0f0826015d625)
2021-06-19Core/Spells: fix logic error causing near teleports to drop combat for playersariel-
Closes #21362 (cherry picked from commit 65709e1c3081c97442792695cbc0f0826015d625)
2021-06-19Core/Spells: remove duplicated LowerPlayerDamageReq call on reflected spellsariel-
- It is already called at Unit::DealDamage (cherry picked from commit e979a58d17081edb2a8bbba81b8ff1f80472b42c)
2021-06-19Core/Threat: Custom ThreatListIterator that transparently iterates over the ↵Treeston
backing map (instead of using heap iterators) when working with the unsorted threat list. This greatly reduces the range of actions that can cause iterator invalidation. Also some minor adjustments to .debug threat, which no longer hides certain invalid states from view. (cherry picked from commit 4cb13af4faff0c1f9dbda2ab6a86882b4e4201a6)
2021-06-19Core/Spells: fix SPELLMOD_DAMAGE application order for melee spellsariel-
Closes #20597 (cherry picked from commit 2d2c43f4b91fef6fcd4d8c069a9bb41d66c97efe)
2021-06-19Core/Spells: kill unused parameter from Spell constructorariel-
Added in 1f2292af796d4b424bf45711ae8c50e764cf0d61 (cherry picked from commit 9fc732eb97271885568598fc38353cd809043d34)
2021-06-19Core/AI: Fix assertion triggered with PetAI derived scripts (#21254)jackpoz
* Core/AI: Fix assertion triggered with PetAI derived scripts Fix an assertion triggered when spawning through ".npc add" or from SQL db table a Creature with AI set to a custom AI inheriting from PetAI. (cherry picked from commit 95a76a83fcbad0e52c6013697544e3c5691e7e24)
2021-06-19Scripts/Ulduar: Flame Leviathan used a very weird mixture of victim logic ↵Treeston
and REACT_PASSIVE, which broke during transition to the new system. Replaced with a working version. Closes #21265. (cherry picked from commit b3e0c892385c7f75a061feef08c3ac05b53b4e2e)
2021-06-19AI/SmartAI: Remove a silly incorrect piece of code that was breaking react ↵Treeston
state swaps on SAI creatures. Fixes #21353. (cherry picked from commit 6e0df9fce1e1f4de3ffa97bf9ef711f13f2b9a55)
2021-06-19Scripts/ICC: Valithria Dreamwalker's script no longer despawns unrelated ↵Treeston
mobs in Frostwing Halls, and thus won't get them stuck in a despawned state due to linked_respawn. Closes #21286. (cherry picked from commit aefc25482f79e07e1237cc0a6c01e7064fd745be)
2021-06-19Scripts/Icecrown Citadel: Corrected Val'kyr Shadowguard positioning on ↵sirikfoll
heroic mode (Lich King) Movement was being prevented by spell cast (cherry picked from commit a217c0be922f7a14bf78acb87aaaef5bc99afe95)
2021-06-19Spell/Script: Torch 52953 and 58121 must hit only one targetKillyana
(cherry picked from commit 8f71307e5619c8ef1801488812e20d07714fd733)
2021-06-19Core/Creature: Adjust SelectVictim behavior: (PR #21324)Treeston
- No more automatic combat -> threat promotion. This matches anecdotal retail behavior - spells already in transit will not cause mob to chase you if its primary target vanishes before the spell hits. - Prevent mobbing by stopping creatures from auto-acquiring a nearby target just because the primary target vanished. (cherry picked from commit 1acfefb973895b0e3df3c8d9b43b920d2a1b5392)
2021-06-19Scripts/Pets: Mirror Image re-write, because it's a colossal mess right now. ↵Treeston
(PR #19818) (cherry picked from commit 03ef79f3d9e323030c771e97863398c43f6cb3a4)
2021-06-19Combat/Threat: Now set engaged state for all units on offline reference ↵Treeston
registration (vanished/invis'd units). For non-PASSIVE units, this will immediately cause an evade. This fixes an exploit where creating the reference as offline (by vanishing while a spell was mid-flight) you could damage a creature further without it ever engaging you. (cherry picked from commit 24024062280e6963f713348baba2b8c69437891a)
2021-06-19Game/AI: Remove some unused old logic.Treeston
(cherry picked from commit c69584a9673ac2edb95b930c024fbd15374cb185)
2021-06-19Scripts/Icecrown Citadel: Added missing cosmetic colors and emotes to Big ↵Shauren
Ooze (Rotface) (cherry picked from commit aaab7ba9f4e08ba5b7d7ac2f4e37e07d80c8f339)
2021-06-19Quest/script: Freedom to RuulKillyana
Follows https://github.com/TrinityCore/TrinityCore/commit/4dc91429dd2158c75679d07c34a18a2e12b4ef7a (cherry picked from commit 52fc5a572b037a9aee084be7f5bcc9bb7d84c0e9)
2021-06-19DB/Quest: Freedom to RuulKillyana
Closes #7262 (cherry picked from commit 4dc91429dd2158c75679d07c34a18a2e12b4ef7a)
2021-06-18Core/Creature: add an assertion to guard against infinite loopsTreeston
(cherry picked from commit 320306554c2240c74d991f459e7bad5eef39ec5a)
2021-06-18Core/Misc: Sort stringAokromes
(cherry picked from commit 4130647bf6bb278c655c5d90569dfa322d0322f9)