Commit Graph

1667 Commits

Author SHA1 Message Date
leak
137b079eea Core: Generic cleanup (tab2spaces/trailing whitespace removal) 2011-01-26 01:03:35 +01:00
leak
180b739483 Core/Entities: Avoid unique key violations during character inventory saving
(It only works "<Machiavelli> because I saideth so")
2011-01-25 18:42:17 +01:00
Machiavelli
3d58165dbd Core/Items: Proper money refund fix for 0ad2c90d22. Thanks to Destalker 2011-01-25 13:36:40 +01:00
Machiavelli
17971acddb Core/Players: Implement generic SendClearFocus instead of magic SMSG_BREAK_PACKET randomly in the middle of code. Also preallocate correct size for packed guid. 2011-01-25 08:04:47 +01:00
Machiavelli
0ad2c90d22 Core/Items: Fix money refund amount. Also fix a possible exploit possibility of redeeming both vendor sellprice and money refund price in one go. 2011-01-24 23:10:08 +01:00
Manuel
70a45be159 Core/Scripts/Oculus: Improved Energize Core ability of Boss Varos. Thanks to Xanadu, Gyullo and Josh.
Signed-off-by: Manuel <manue.l@live.com.ar>
2011-01-24 18:57:11 -03:00
Manuel
fb950c00ee Core/ZoneScript: Implemented OnCreatureDeath function.
Signed-off-by: Manuel <manue.l@live.com.ar>
2011-01-24 18:56:06 -03:00
Shauren
867bc197ef Core/Instances: Made the max amount of instances player can enter within hour configurable and fixed typo in instance packing/cleaning query 2011-01-24 16:12:02 +01:00
Shauren
820f87f365 Core/Instances: Implemented confirmation dialog for players upon entering instance which would permanently bind the player to it, players can now choose to get saved or leave the instance
Also fixes broken build
2011-01-24 11:38:59 +01:00
Shauren
464837077a Core/Instances: Implemented hourly instance limit: players are limited to entering 5 instances per hour (account wide limit) 2011-01-24 11:20:30 +01:00
Shauren
e5b4f8e84d Scripts/Icecrown Citadel: Implemented boss raid frames for Blood Prince Council 2011-01-23 21:42:32 +01:00
Shauren
ac689f456d Core/Scripts: Implemented method for sending encounter boss frames from scripts 2011-01-23 16:59:33 +01:00
Shauren
9dfa00bb60 Core/Auras: Removed unneeded typecasting from aura 54798 handler 2011-01-23 11:09:26 +01:00
Machiavelli
0796889c21 Core/Vehicles: Hotfix for client freeze on vehicle enter by reverting certain changes to SMSG_MONSTER_MOVE_TRANSPORT. Still have to figure out the correct structure in the future. 2011-01-22 19:55:50 +01:00
Shauren
5adf9c5d30 Scripts/Spells: Moved all special target filtering cases to scripts 2011-01-22 17:21:24 +01:00
Shauren
c2690f748b Scripts/Spells: Implemented UnitTargetHandler spell script hook, it can be used to filter area targeting spells 2011-01-21 23:42:51 +01:00
Manuel
76e4b6dda4 Core/Scripts/Oculus: Implemented AI for boss Varos Cloudstrider <Azure-Lord of the Blue Dragonflight>.
Signed-off-by: Manuel <manue.l@live.com.ar>
2011-01-20 12:37:41 -03:00
Manuel
9c7e0702a6 Core/Spell: Modified ImplicitTargets of spells 54069 and 56251 for correct functionality. Thanks to Xanandu and click.
Signed-off-by: Manuel <manue.l@live.com.ar>
2011-01-20 12:31:17 -03:00
Manuel
19634e7fce Core/ZoneScript: Implemented ProcessEvent function for units.
Signed-off-by: Manuel <manue.l@live.com.ar>
2011-01-20 12:27:08 -03:00
leak
dd751242fc Core/Spells: Better solution for exploit check (Thanks to manuel)
Readd lost changes from char db type cleanup
2011-01-20 03:06:51 +01:00
leak
f7af49291b SQL: Characters db storage type cleanup No. 7 (final) - Note:
- It is _strongly_ recommended to extensively test the recent changes before applying them to live data

- To fully resync the character db layout with TC releases it is recommended to dump the characters table with
mysqldump --no-data characters > characters_database_livedata.sql
and use a diff tool to compare it against sql/base/characters_database.sql
2011-01-20 02:11:49 +01:00
leak
c59ea4726e SQL: Characters db storage type cleanup No. 6 2011-01-20 01:02:24 +01:00
leak
a486eb0c2f SQL: Characters db storage type cleanup No. 5 2011-01-20 00:08:45 +01:00
leak
a7df9ddff1 SQL: Characters db storage type cleanup No. 4 2011-01-19 22:46:21 +01:00
leak
471b6f138d SQL: Characters db storage type cleanup No. 3 - Note:
There is a chance that you will be getting importing errors / data truncation warnings because of ancient invalid pet names.
SELECT * FROM character_pet WHERE CHAR_LENGTH(`name`) > 21;
2011-01-19 18:51:00 +01:00
leak
c306acf298 SQL: Characters db storage type cleanup No. 2 2011-01-19 14:04:33 +01:00
leak
b8210f4396 SQL: Characters db storage type cleanup #1 - Note:
- MySQL numeric types can NOT be altered in value range or or storage size at all, so things like INT(32) are entirely pointless. As TC currently doesn't use the display width of numeric types, use the default width to avoid confusion. (see MySQL numeric types docs)

- Timestamps can be stored as INT(10) UNSIGNED. As the max value of this type is 4294967295 which translates into year 2106 using it as timestamp we are NOT affected by the year 2038 bug. If the timestamp needs to be negative in some cases, i.e. for displaying infinity using -1, use BIGINT(20) instead.

- Do NOT set ROW_FORMAT for InnoDB tables unless you specifically want COMPRESSED tables (which we don't for performance reasons). MySQL will chose the appropriate ROW_FORMAT by itself depending on the innodb_file_format setting of the server. (FIXED is only available for MyISAM)

- Even though VARCHAR does require less storage space than CHAR for values with variable length, the length still needs to be chosen wisely as this doesn't apply to memory consumption.
2011-01-19 02:53:44 +01:00
leak
40af92dd66 Core/Spells: Stop exploit that allowed looting despawned gameobjects by packet manipulation. 2011-01-18 20:02:28 +01:00
Spp
e05ab4b25a Core/Dungeon Finder: Fix exploit that allowed players to get random reward after finish a dungeon they did not queue for. Note: lfg_dungeon_encounters MUST contain the correct dungeonId, no the random ones. 2011-01-17 12:27:44 -03:00
Shauren
b28881f648 Core/Spells: Fixed Ignite talent getting removed by Ice Block
Closes #138
2011-01-16 19:26:01 +01:00
Machiavelli
deed0d0781 Core/General: Fix some comment style. //* to // *. Fixes certain code display errors on nano. Thanks to Aokromes for pointing out. 2011-01-16 12:23:17 +01:00
Machiavelli
09f2a48227 Core/Spells: Add unittarget check for spell 54798 2011-01-16 00:50:57 +01:00
Machiavelli
52cd2cbd7e Core/Maps: Unload transports in MapManager::UnloadAll instead of singleton destructor.
Core/Transports: Properly delink units from transports on transport desutruction. - Thanks to Shauren for help.
Core/ObjectAccessor: Unload corpse 'storage' in added UnloadAll method called in WorldRunnable postservice hook.
Core/Master: Change some postservice queries to syncrhonous (direct) execution to ensure execution on shutdown
Core/Master: Remove redundant calls to ACE::init and ACE::fini

These changes were made to fix crash/freeze issues on shutdown.
2011-01-16 00:08:52 +01:00
Machiavelli
38816cb1df Core/Spells: Implement SPELL_ATTR6_IGNORE_CROWD_CONTROL_TARGETS (0x00000100). Spells with this attribute flag (Avenger's Shield, Hammer of Righteousness, Shield of Righteousness, Felguard Cleave, Fel Iron Bomb) will ignore secondary targets that are under the effect of crowd control aura's.
Thanks to Shauren for advices.
2011-01-15 19:40:06 +01:00
Shauren
9584f58130 Core/Battleground: Combine bg score type enum values with the same name
Signed-off-by: Shauren <shauren.trinity@gmail.com>
2011-01-14 23:02:15 +01:00
Lightguard
4aae3cd45e Add missing opcodes to OpcodeHandlerTable.
Signed-off-by: Anubisss <anubisss210@gmail.com>
2011-01-14 22:40:41 +01:00
VladimirMangos
8c48704b23 Core/Loot: Fixed looting of individual, owner only items (item loot/skinning)
Signed-off-by: Shauren <shauren.trinity@gmail.com>
2011-01-14 21:24:11 +01:00
JohnHoliver
db72c4f561 Core - Modifies a few security checks to take realm id into consideration. It will enable add friends which have moderators (or more) status in other realms and cease undue AH activity logging from those same accounts.
Signed-off-by: click <per.wilhelmsen@gmail.com>
2011-01-14 21:05:02 +01:00
Shauren
458c7c642f Core/Spells: Fixed Glyph of Pain Suppression
Signed-off-by: Shauren <shauren.trinity@gmail.com>
2011-01-14 20:24:39 +01:00
Manuel
3ab85db411 Core/Player: Pets are unsummoned after spec switch. Fixes #180 2011-01-14 13:38:56 -03:00
Machiavelli
d399daab59 Core/Quests: Resolve ambiguity between QUEST_STATUS_COMPLETED and rewarded state by implementing QUEST_STATUS_REWARDED. The latter is not used in the database explicitly, only in the core. This is to prevent overhead by iterating over the rewarded quests storage multiple times.
All relevant upper level code has been updated accordingly to the best of my ability.
2011-01-13 23:06:59 +01:00
Machiavelli
57ee357c02 Core/Maps: Fix a possible crash in ObjectGridStoper:Visit
Dump found here: http://pastebin.com/2GZ3t5v4
2011-01-13 21:33:56 +01:00
Shauren
8d59953f93 Scripts/Icecrown Citadel
* Call EnterEvadeMode before teleporting players to entrance - prevents players being stuck in combat
* Fixed Gaseous Blight stacking damage
* Properly initialize phase for Professor Putricide when entering combat
* Fixed Blood Nova and Boiling Blood abilities of Deathbringer Saurfang
2011-01-12 22:50:51 +01:00
Machiavelli
52499b03ea Core/Guilds: Don't allow more than 25 and 100 log events to be sent to the client for bank eventlog and regular eventlog respectively. Higher values will result in client crashes. 2011-01-12 19:38:47 +01:00
Anubisss
806794d4ce Fix a crash in Spell::CheckCast().
This crash happens when effect is SPELL_EFFECT_TALENT_SPEC_SELECT and the caster is not a player.
You should always check object's type (or sure that object is 101% a player) before you use ToPlayer() casting function.

Signed-off-by: Anubisss <anubisss210@gmail.com>
2011-01-12 02:06:06 +01:00
Spp
bd2728eb74 Core: Fix some warnings 2011-01-11 11:18:00 +01:00
Shocker
f03040b5b3 Core/Spells: Glyph of Polymorph should remove leech auras too, fixes #171 2011-01-11 00:57:20 +02:00
Taser
1a5554ccb5 Core/Battlegrounds: Fix Fel Reaver Ruins capturepoint in Eye of the Storm
Signed-off-by: Machiavelli <machiavelli.trinity@gmail.com>
2011-01-10 22:31:57 +01:00
Shauren
870add0a3d Core/Spells: Fixed Spirit Walk ability of shaman's Feral Spirit summons
Closes #115

Signed-off-by: Shauren <shauren.dev@gmail.com>
2011-01-10 22:01:19 +01:00
Machiavelli
fa8e5047a6 Core/Guilds: Fix a possible client crash in MSG_GUILD_BANK_LOG_QUERY 2011-01-10 20:57:58 +01:00