Commit Graph

25471 Commits

Author SHA1 Message Date
Shauren
262ee285db Core/Misc: Updated SpellCastResult, GameError and HotfixStatus enums 2021-08-08 00:18:10 +02:00
Shauren
ce1046a8fd Core/DataStores: 9.1.0 db2 structures 2021-08-08 00:18:10 +02:00
Shauren
cd5357dc18 Core/PacketIO: 9.1.0 opcodes and packet structures 2021-08-08 00:18:05 +02:00
Shauren
07f51437fc Core/Auras: Fix incorrect use of GetUnitOwner() in DynObjAura::FillTargetMap
Closes #26735
2021-07-22 10:38:23 +02:00
Shauren
515d3da181 Core/Auras: Skip estimated points calculation for SPELL_EFFECT_PERSISTENT_AREA_AURA
Closes #26731
2021-07-21 16:19:14 +02:00
Shauren
0bbf3f7300 Core/AuctionHouse: Fixed paying for commodities
Closes #26621
2021-06-24 16:04:51 +02:00
Shauren
61a7026f17 Core/AuctionHouse: Fixed buying commodities
Closes #26110
Closes #26619
2021-06-23 22:44:39 +02:00
Killyana
f6f098171f Core/SAI: Move enum to the correct file
(cherry picked from commit 8aa10f6c65)
2021-06-22 13:19:36 +02:00
ariel-
5714e89ccf Core/Events: update holiday code and remove misleading log (event date is the one from game_event)
- add siign to DBC struct member CalendarFilterType as it was being used as such
- kill localtime usage as it's deprecated

Closes #18542

(cherry picked from commit 5b4287e683)
2021-06-22 13:19:03 +02:00
ariel-
d36f8bb754 Core/Scripts: implemented Fungal Decay & Tail Sting
Refs #18542

(cherry picked from commit 7dc78d8e3f)
2021-06-22 13:15:11 +02:00
ariel-
1fe817a995 Core/Auras: remove obsolete check that was preventing some auras to proc even if they met conditions otherwise
(cherry picked from commit 5f38b92340)
2021-06-22 13:07:03 +02:00
Keader
ab8f8e1ffb Scripts/Ulduar: Fixed amount of Mole Machines in Razorscale 10 man
(cherry picked from commit f609589e22)
2021-06-22 13:06:33 +02:00
Killyana
4b6e76a5ef Core/SAI: Add an action_param3 to "summon gob" to control when the object will despawn
0 - For despawn when creature dies or time runs out
1 - For despawn after time
Closes #11601

(cherry picked from commit ca4f1e334a)
2021-06-22 12:51:28 +02:00
Treeston
f0823eb048 Scripts/TotC: Reduce Twin Val'kyr berserk timer from 10 minutes to 8 minutes on normal mode (match DBM). This closes #15367, no matter what ccrs' bong says.
(cherry picked from commit 789f3c5d37)
2021-06-22 12:47:40 +02:00
ariel-
d91e099b10 Core/Spells: prevent creatures to focus channeled spells without SPELL_ATTR1_CHANNEL_TRACK_TARGET
- Creatures stuck here wouldn't try attacking because of this
- Remove one workaround in halion script, now it's unneeded

Ref #11311

(cherry picked from commit 29f7258dc8)
2021-06-21 12:47:03 +02:00
Gooyeth
493be0c888 Scripts/Commands: add AI/ScriptName to .gobject info (PR #21419)
(cherry picked from commit 42a11e97d5)
2021-06-21 00:10:39 +02:00
Treeston
f982f3019a Core/Combat: Unify combat permitted checks between CvC and PvC - only require "not friendly" in all cases. Fixes Yogg-Saron encounter. Closes #21380.
Also some bonus cleanup to Yogg's script to make transition cleaner.

(cherry picked from commit 4da9321d2b)
2021-06-21 00:07:24 +02:00
Treeston
37298ca99c Scripts/SmartAI: SetData now has an invoker (if the setting is done by something using SmartAI).
Also, some refactors. SMARTAI IS SUCH A FUCKING CLUSTERFUCK I SWEAR.

(cherry picked from commit cfc77fd843)
2021-06-21 00:06:41 +02:00
Gooyeth
17004c4121 Core/Scripts: Add bossId in state error log. (#21421)
(cherry picked from commit b9aec3b4d3)
2021-06-21 00:06:41 +02:00
ariel-
1f3e365ff6 Core/Auras: make area and dynauras condition compliant by using the spellarea searcher instead of script searchers
Closes #17317

(cherry picked from commit f1f6976f91)
2021-06-21 00:06:41 +02:00
ariel-
16b1f5c7f6 Core/Handlers: fix bogus check that skipped CMSG_CAST_SPELL packet under certain conditions, missing a target change
Closes #21390

(cherry picked from commit a145a14166)
2021-06-21 00:06:41 +02:00
ariel-
5323a7d386 Core/Spells: fixed server being too overzealous with autoshot
- Interrupting it when casting another spell and switching targets

Ref #21390

(cherry picked from commit 93cbe815cb)
2021-06-21 00:06:41 +02:00
Keader
cb8ea03175 Core/Scripts: Fixed some delayed enrage
Closes #15367

(cherry picked from commit 63c436f5fb)
2021-06-21 00:06:41 +02:00
ariel-
e9ddf644b0 Core/Scripts: implemented Seed of Corruption scaling damage tolerance
(cherry picked from commit df5afca278)
2021-06-21 00:06:39 +02:00
ariel-
5b42c0b270 Core/Spells: Port refactors from 1826437c09
(cherry picked from commit 1826437c09)
2021-06-20 22:25:18 +02:00
Treeston
168be492f5 Entities/GO: Add forceRespawnTimer support to DespawnOrUnsummon. Use it in SAI.
(cherry picked from commit 264d4e1d30)
2021-06-20 22:10:08 +02:00
Treeston
bccd81e12a Entities/GO: GameObjects now support (delayed) despawning in a reasonable manner. Closes #21406.
(cherry picked from commit f071fa9e93)
2021-06-20 21:49:11 +02:00
Treeston
bd158f6c29 oops, now it builds (and a bonus refactor that annoyed me)
(cherry picked from commit 2cd5992f37)
2021-06-20 21:42:35 +02:00
Treeston
1f26122528 Scripts/SmartAI: Forward invoker to invoked action list actions. Also JustAppeared -> InitializeAI.
(cherry picked from commit 6fb0bc1038)
2021-06-20 21:42:35 +02:00
Treeston
83c4aa88ec Scripts/TheBarrens: Fix "The Escape" (863) - I don't think this one ever worked, honestly.
(cherry picked from commit 0e401c7d96)
2021-06-20 21:42:35 +02:00
Treeston
06b5b8d8b7 Scripts/SmartAI: SMART_TARGET_INVOKER cleanup step 1. The core will now log errors on start-up if SMART_TARGET_INVOKER abuse is found, but will continue to load the scripts as deprecated for now.
Note that a lot of these scripts may either not currently work, not work reliably, or may be prone to breaking unexpectedly when core internals change. SMART_TARGET_INVOKER is undefined behavior on any event that doesn't directly specify its invoker.

(We are considering options for allowing INVOKER to make sense in timed action lists in a reliable fashion, so they are exempted at this time.)

(cherry picked from commit 482328bddf)
2021-06-20 21:42:33 +02:00
Treeston
ffce2c1f9a Core/Spell: Properly remove REACT_PASSIVE on permanent feign death unapply. Fixes and closes #21156.
(cherry picked from commit ac8b9be5d6)
2021-06-20 20:22:18 +02:00
Treeston
3b635a8a12 Scripts/AzjolNerub: Clean up Hadronox to hopefully avoid any further evade issues. Tag #20310.
(cherry picked from commit fe3b4de1cd)
2021-06-20 20:17:59 +02:00
ccrs
cecb91ad3d Core/Movement: fe1ba18905 followup
ref fe1ba18905 (r27507316)

plus I noticed a logic error on speedchange call

(cherry picked from commit 28c6db0807)
2021-06-20 01:34:48 +02:00
ariel-
a342b86403 Core/Scripts: fix Tenacity Aurascript (target is null on UpdatePeriodic)
- also aura amount increases with stack so we lose spellid info, calculate it from basepoints directly
- aura should be SPELL_AURA_MOD_HEALING_PCT instead of SPELL_AURA_MOD_HEALING_DONE_PERCENT (ie taken instead of done, confusing names)

(cherry picked from commit bc2a4c816d)
2021-06-20 01:15:00 +02:00
ariel-
15810eb579 Core/Unit: kill unused parameter from SpellxxxBonusTaken
(cherry picked from commit c7095375c3)
2021-06-20 01:09:20 +02:00
ariel-
23a88fae6f Core/Scripts: remove Tenacity hack, implemented with proper aura
(cherry picked from commit 404240fb68)
2021-06-20 00:55:53 +02:00
Wilcalaf
e9833447ed Archaedas should properly start now when clicking on the altar. (#21401)
(cherry picked from commit 0c1aaac219)
2021-06-20 00:30:33 +02:00
ariel-
bc6b0c5197 Core/Unit: corrected calculation for SPELL_AURA_MOD_DAMAGE_TAKEN/SPELL_AURA_MOD_HEALING auras
- Spell bonus calculation and penalty was done twice, but it's simply flat +SP, which should be taken into account before other bonuses
- Fixed missing code from SpellDamageBonusDone/SpellHealingBonusDone and killed multiplication by stack amount twice for default coefficient spells (already multiplied on level penalty)

(cherry picked from commit 4d14f613f3)
2021-06-20 00:28:50 +02:00
ariel-
18780206bc Core/Spells: Do not apply SpellModOp::CritChance to spells that can't crit 2021-06-19 23:55:03 +02:00
ariel-
3582bacc4a Core/Spells: add log on load about improper use of attribute PROC_ATTR_REQ_SPELLMOD
(cherry picked from commit dfa861593e)
2021-06-19 23:34:15 +02:00
ariel-
13be704cb4 Core/Spells: implement SPELLVALUE_CRIT_CHANCE
(cherry picked from commit 546a605bd0)
2021-06-19 23:33:44 +02:00
ariel-
85e5509e91 Core/Spells: calculate crit chance only for spells that do damage/healing
Refs #18813

(cherry picked from commit 52873a7072)
2021-06-19 23:33:38 +02:00
Treeston
f4cc76063f Core/AI: EscortAI init logic moved from JustAppeared to InitializeAI. There are no escort NPCs using compatibility mode anymore, so this is equivalent.
As a result, inheriting scripts calling Start in on-create hooks (like JustSummoned) will now work properly again.

Tagging #20310.

(cherry picked from commit e4e6e2209c)
2021-06-19 23:33:38 +02:00
Treeston
3c172ba17c Scripts/AzjolNerub: Hadronox is a big spider mommy, and needs more room to pet her spider pets properly. Hopefully this'll reduce the number of evades happening during the encounter. Tag #20310.
(cherry picked from commit b243a7929b)
2021-06-19 23:33:38 +02:00
Treeston
6d79b329ac Core/Movement: WaypointMovementGenerator cleanup
(cherry picked from commit fe1ba18905)
2021-06-19 23:33:38 +02:00
Treeston
88c1739e3e Core/Movement: Creatures' idle movement generator can no longer override player mover control.
Tagging #20310, partial fix.

(cherry picked from commit d02f481d9a)
2021-06-19 23:33:38 +02:00
ariel-
a24af55d13 Core/Scripts: implemented Combined Toxins proc only from poisons
(cherry picked from commit 477878630e)
2021-06-19 23:33:38 +02:00
ariel-
c21dc3c1b7 Core/Auras: fix periodic ticks proc after previous commit
(cherry picked from commit 9d0e90829c)
2021-06-19 23:33:38 +02:00
ariel-
91fa279bdf Core/Spells: require phasemask set for periodic damage procflag
Closes #21379

(cherry picked from commit b42ade918a)
2021-06-19 23:33:38 +02:00