Commit Graph

39720 Commits

Author SHA1 Message Date
schell244
460549799e Scripts/World: Hourly Bell sound, further improvements (#24147)
* Improvements for hourly bell sound

* TC codestyle

* added missing breaks and improve codestyle

(cherry picked from commit baa87c43ba)
2021-12-21 18:32:22 +01:00
Shauren
2c78f4dd1f Core/Misc: Resolve c++17 TODOs left in code as comments 2021-12-21 18:29:52 +01:00
Ujp8LfXBJ6wCPR
6229a6ddc1 Remove dependency on undefined behaviour (#24159)
See https://stackoverflow.com/a/4328396
Previous method works but is technically illegal.

(cherry picked from commit b089ed3b75)
2021-12-21 16:36:07 +01:00
Killyana
d4db721b7f DB/Misc: The Shattered Halls
(cherry picked from commit a3ea48af57)
2021-12-21 16:35:48 +01:00
Rushor
2326eac4f9 Scripts/Gameobject: Journal of Jandice Barov- Convert script to SAI. (#24157)
* Scripts/Gameobject: Journal of Jandice Barov- Convert script to SAI. (Thanks to Sunwell)

* Scripts/Gameobject: Journal of Jandice Barov - Update script and move go spawn to bossscript

* Update boss_jandice_barov.cpp

Co-authored-by: Eridium <6587064+Killyana@users.noreply.github.com>
(cherry picked from commit f0bf447cd1)
2021-12-21 16:33:47 +01:00
Rushor
41b10f4bb8 Scripts/Gameobject: Remove deprecated script for Cat Figurine (#24150)
Scripts/Gameobject: Remove deprecated script for Cat Figurine

(cherry picked from commit 596b2d1ed7)
2021-12-21 16:27:45 +01:00
Killyana
20ecd32d0d DB/Quest: Boiling Point
Closes #24152

(cherry picked from commit 2a349dd390)
2021-12-21 16:27:05 +01:00
Killyana
5fa750037e DB/Gossip: Fix some gossips
(cherry picked from commit a28a9f53df)
2021-12-21 16:26:01 +01:00
Ujp8LfXBJ6wCPR
42ce97a74c Core/Misc: Remove redundant null pointer checks before delete (#24140)
* Identified by clang-tidy readability-delete-null-pointer

(cherry picked from commit 9264e5b6f0)
2021-12-21 16:19:13 +01:00
Killyana
881f1907b3 DB/Conditions: Fix loot conditions for Brann's Communicator
(cherry picked from commit e06153dd43)
2021-12-21 16:15:21 +01:00
Killyana
d29528a102 DB/Quest: Fix gossips related to "The Mechagnomes" quest
(cherry picked from commit c287f3998a)
2021-12-21 16:14:53 +01:00
Killyana
c147575726 DB/Text: Update some gossips with broadcast
(cherry picked from commit 95b9009aa0)
2021-12-21 16:13:45 +01:00
Killyana
e2cf1a3290 DB/SAI: Fix some SAI
(cherry picked from commit 4a0f732ecb)
2021-12-21 16:05:02 +01:00
Killyana
5bdab7ab60 DB/Quest: World Event Dungeon - Hummel
(cherry picked from commit f579a73550)
2021-12-21 16:03:47 +01:00
Killyana
d0847878bf DB/Misc: Elite Tauren Chieftains World's End Tavern Concerts
Closes #24148

(cherry picked from commit 403d29b9c2)
2021-12-21 15:58:43 +01:00
Killyana
1d997bd6fd DB/Creature: Love Boats
Closes #14027

(cherry picked from commit d7cc6a0f98)
2021-12-21 15:57:14 +01:00
Rushor
1516759859 Scripts/Kalimdor: Move script of Hand of Iruxos Crystal to database. (#24141)
* Scripts/Kalimdor: Move script of Hand of Iruxos Crystal to database.

* Scripts/Kalimdor: Hand of Iruxos Crystal - Add despawn for gameobject.

* Scripts/Kalimdor: Hand of Iruxos Crystal - Add despawn for gameobject.

* Remove unneeded commentline

* Rename 9999_99_99_99_world.sql to 2020_02_11_00_world.sql

Co-authored-by: Aokromes <Aokromes@users.noreply.github.com>
(cherry picked from commit a67dd6ab60)
2021-12-21 15:56:23 +01:00
Killyana
d403e36538 DB/Text: Fix and remove some npc_text
(cherry picked from commit 7450be4cfd)
2021-12-21 15:54:36 +01:00
Ovah
a91be4995b Core/Vehicles: implement vehicle seat addon table to specify seat ori… (#24112)
* Core/Vehicles: implement vehicle seat addon table to specify seat orientation offsets and exit positions in form of offsets or absolute positions
* converted Traveler's Tundra Mammoth to seat addon table data

* first follow batch

* whoopsie

* Core/Vehicles: go from local copies to pointers

* Update and rename 2020_99_99_99_world.sql to 2020_02_08_01_world.sql

Co-authored-by: Giacomo Pozzoni <giacomopoz@gmail.com>
(cherry picked from commit 98d6c501d7)
2021-12-21 15:32:49 +01:00
schell244
eae7379417 Core/Scripting: fixed hourly bell sounds (#24127)
* fixed hourly bell sounds

* use switch and moved variable

* fix typo

(cherry picked from commit f87a4543ad)
2021-12-21 15:21:57 +01:00
Ujp8LfXBJ6wCPR
91a0fbbd71 Use boost::optional and boost::none instead of smelly pointer (#24134)
* Remove bad pointer usage from CharacterCache

Use TrinityCore Option type instead which is intended for this purpose. (Wrapper around boost::option until C++17 bump is finalised)

* Unify codestyle regarding TC optional type

Based upon advice from @Shauren

(cherry picked from commit 76831f1f46)
2021-12-21 15:21:39 +01:00
Treeston
94a79bac7a Core/Misc: Some refactoring, #23603 prep: (#23676)
- Split SpawnMetadata off from SpawnData
- No longer allocate Creature/Gameobject objects in ObjectGridLoader just to check their typeid and delete them afterwards

Co-authored-by: Giacomo Pozzoni <giacomopoz@gmail.com>
(cherry picked from commit 9304e496cb)
2021-12-21 15:16:26 +01:00
Giacomo Pozzoni
fe489e2be1 Build: Enable and require c++17 (#23868)
* Build: Enable and require c++17

* Build: Raise Visual Studio version from 2017 15.2 to 2017 15.9

* Build: Raise GCC version from 6.3.0 to 7.1.0

* Reduce branch differences

* Fix build after latest merge

* Cleanup after latest merge

(cherry picked from commit 726d5e91b5)
2021-12-21 01:20:51 +01:00
Shauren
172e5c3577 Dep/gSOAP: Upgrade to 2.8.117 2021-12-21 01:15:58 +01:00
Keader
e453c632e6 Game/Battlegrounds: Fixed Position and Rotation of Alterac Valley Gates
(cherry picked from commit ddd1a3c1ef)
2021-12-21 01:19:38 +01:00
Sorikoff
6433ed6014 Scripts/Spells: Gift of the Harvester (#24111)
* Scripts/Spells: Gift of the Harvester

* Scripts/Spells: nopch

* Scripts/Spells: nopch

* Scripts/Spells: validate

* Rename 9999_99_99_99_world.sql to 2020_02_01_03_world.sql

Co-authored-by: Giacomo Pozzoni <giacomopoz@gmail.com>
(cherry picked from commit e10239311c)
2021-12-21 00:48:30 +01:00
Giacomo Pozzoni
f1f1bc01ba Core/Movement: Fix WaypointMovementGenerator ignoring EscortAI::SetEscortPaused() on Gossip Hello (#24005)
Fix WaypointMovementGenerator ignoring EscortAI::SetEscortPaused() when talking to a NPC, scheduling a 3 minutes pause on the WaypointMovementGenerator even if it was already disabled with no timer, waiting for the player to select a gossip entry to resume the movement.

(cherry picked from commit a9e534762f)
2021-12-21 00:46:32 +01:00
ForesterDev
9124fd1f1f Core/Items: implement some helper methods for easier readability (#24113)
(cherry picked from commit 573ddf4d22)
2021-12-21 00:46:13 +01:00
Sorikoff
e882635774 Scripts/Borean Tundra: Iruk (#24117)
* Scripts/Borean Tundra: Iruk

* Apply suggestions from code review

Co-Authored-By: Trond B. Krokli <38162891+illfated@users.noreply.github.com>

* Update 9999_99_99_99_world.sql

* Rename 9999_99_99_99_world.sql to 2020_02_01_01_world.sql

Co-authored-by: Trond B. Krokli <38162891+illfated@users.noreply.github.com>
Co-authored-by: Giacomo Pozzoni <giacomopoz@gmail.com>
(cherry picked from commit 8c443ae39f)
2021-12-21 00:12:13 +01:00
Sorikoff
3daeb28420 Scripts/The Barrens: Beaten Corpse (#24124)
* Scripts/The Barrens: Beaten Corpse

* Rename 9999_99_99_99_world.sql to 2020_02_01_00_world.sql

Co-authored-by: Giacomo Pozzoni <giacomopoz@gmail.com>
(cherry picked from commit 74d19691a5)
2021-12-21 00:11:39 +01:00
Killyana
e57967aa3f DB/Creature: Plagued Dragonflayer Tribesman & Plagued Dragonflayer Rune-Caster & Plagued Dragonflayer Handler
Closes #24122

(cherry picked from commit c86d4404c8)
2021-12-21 00:08:43 +01:00
Killyana
40b744a229 DB/Creature: Add missing spawns to The Shattered Halls
(cherry picked from commit d4680bb2b2)
2021-12-21 00:04:29 +01:00
Killyana
f606e8a62c DB/Creature: Visiting Warlock
(cherry picked from commit 63e7edfb15)
2021-12-21 00:03:06 +01:00
Killyana
575e9502ec DB/Creature: Death Ray
(cherry picked from commit c6b294f1d5)
2021-12-21 00:01:59 +01:00
Killyana
637684cbff DB/Creature: Lunar Cluster Credit Marker & Lunar Firework Credit Marker
(cherry picked from commit c7a02a9812)
2021-12-20 23:59:36 +01:00
Ovah
5c258c1bbd Core/Scripting: fixed build. Re-enable ModifyVehiclePassengerExitPos for CreatureScript to allow scripted creatures that already have an AI to benefit from its functionality as well
(cherry picked from commit f0485cea39)
2021-12-20 23:56:45 +01:00
Ovah
64fc549be8 Core/AI: call ModifyVehiclePassengerExitPos for CreatureScripts since the hook is available for that class as well
(cherry picked from commit ebf116e6a3)
2021-12-20 23:56:31 +01:00
Killyana
e4e7f8b8dc DB/Creature: Wildervar Miner
(cherry picked from commit de7d9f2590)
2021-12-20 23:56:17 +01:00
Killyana
ac4df1d856 Spell/Script: Fix Prison chain for Unworty Initiate
Closes #24089
The spell 54613 is not used in the game

(cherry picked from commit 0ec2a5fd74)
2021-12-20 23:52:52 +01:00
Sorikoff
a463e7f1bd Scripts/Ebon Hold: How To Win Friends And Influence Enemies (#24090)
* Scripts/Ebon Hold: How To Win Friends And Influence Enemies

* Scripts/Ebon Hold: Improve SQL!

* Scripts/Ebon Hold: Final touch

* Scripts/Ebon Hold: Actually final touch

* Rename 9999_99_99_99_world.sql to 2020_01_26_04_world.sql

Co-authored-by: Giacomo Pozzoni <giacomopoz@gmail.com>
(cherry picked from commit 13c81f55e3)
2021-12-20 23:47:37 +01:00
Sorikoff
d37547e769 Scripts/Borean Tundra: Plug the Sinkholes (#24085)
* Scripts/Borean Tundra: Plug the Sinkholes

* Scripts/Borean Tundra: Improve SQL

* Scripts/Borean Tundra: Remove item script

* Rename 9999_99_99_99_world.sql to 2020_01_26_03_world.sql

Co-authored-by: Giacomo Pozzoni <giacomopoz@gmail.com>
(cherry picked from commit 552a638e31)
2021-12-20 23:47:37 +01:00
Killyana
9b48370ba1 DB/SAI: Warder Corpse & Defender Corpse
Closes #21102

(cherry picked from commit 1201b49f08)
2021-12-20 23:47:37 +01:00
Rushor
d19229b0aa DB/SAI: Steelforged Defender
Ref #13639

(cherry picked from commit 3d9c4a7b02)
2021-12-20 23:47:37 +01:00
Sorikoff
df5734d4c0 DB/Quests: Update Death Knight quests localization
Closes #24105

(cherry picked from commit de25e36477)
2021-12-20 23:47:37 +01:00
Killyana
885b6fa697 DB/Creature: Lost Soul pooling
(cherry picked from commit 1451732666)
2021-12-20 23:47:37 +01:00
Killyana
2452b9c7f7 DB/Creature: Spire Spiderling
Summoned by a spell

(cherry picked from commit 72b5039ec1)
2021-12-20 23:47:37 +01:00
Ovah
cdeb752941 Core/Movement: improved RandomMovementGenerator wait handling to get closer to retail behaivior (#24093)
* according to observations Blizzard is letting creatures do 2 up to 10 spline movements right after each other before waiting for a couple seconds

(cherry picked from commit 78c1216bcf)
2021-12-20 23:47:37 +01:00
Kelno
ce8c83ef6f Core/Maps: cosmetic correction on comment (#24096)
(cherry picked from commit d0efd76c92)
2021-12-20 23:47:37 +01:00
Ovahlord
606597f4f8 Core/Movement: reset position update interrupt info after the interrupt checks have been executed
* for discussion see: 02daf1bf3a (r36916229)

(cherry picked from commit 01584cb0b9)
2021-12-20 23:47:37 +01:00
Ovah
43a7091e8a Core/Movement: properly fix aura interrupts during movement (#24068)
We want our movement to be fully updated before even thinking about interrupting anything. The old logic was updating positions, interrupting stuff and afterwards updating movement generators. This way we were ending up with false interrupts.

properly fixes #22908

(cherry picked from commit 02daf1bf3a)
2021-12-20 23:47:23 +01:00