Commit Graph

6152 Commits

Author SHA1 Message Date
Shauren
5d02739b98 Scripts: Fix rbac permission for skipping default boss sequencing check
(cherry picked from commit e660c8bc19)
2021-12-20 21:40:47 +01:00
Giacomo Pozzoni
ce25c212e0 Scripts/Ulduar: Attempt to fix Yogg-Saron not evading on wipe (#24055)
(cherry picked from commit 039534d1db)
2021-12-20 21:24:51 +01:00
Alan Deutscher
cd72ecce78 Scripts/Spells: fix Turkey Timer duration (#24048)
* spell_gen_turkey_marker::OnPeriodic: Pop expired stack timestamps from tracking list.

* Be a bit more explicit about the data type of removedCount.

* Formatting nudge.

* Remove brackets.

(cherry picked from commit a0c07655eb)
2021-12-20 21:24:37 +01:00
ccrs
25a987496c Scripts/ICC: include missing call from UnitAI::JustExitedCombat override in npc_green_dragon_combat_trigger
(cherry picked from commit 330cbb55fb)
2021-12-20 21:10:33 +01:00
Shauren
e43a02668f Scripts/Icecrown Citadel: Removed unneccessary combat hacks from Valithria Dreamwalker
(cherry picked from commit c188d4db85)
2021-12-20 21:07:50 +01:00
Killyana
e9ba28afc9 Quest/Scripts: Remove some hacks from "Trolls Is Gone Crazy!"
(cherry picked from commit a149261e94)
2021-12-20 21:07:28 +01:00
Keader
174f4bad3d Scripts/Blood Furnace: Fixed Broggok reset issues and some little improvements
Closes #23658

(cherry picked from commit 1bdc792559)
2021-12-20 20:18:55 +01:00
Giacomo Pozzoni
7c97fa4449 Scripts/Misc: Fix build warnings
(cherry picked from commit 37ffdc05b2)
2021-12-19 23:31:30 +01:00
Killyana
71e474e14f DB/Spawns: Remove "Hand of the Deceiver" spawns as summoned by a script
(cherry picked from commit 434cdb1fa0)
2021-12-19 23:27:12 +01:00
Killyana
3f3abe9ad0 Creature/Script: Add text target for npc_shadowfang_prisoner
(cherry picked from commit 10ba39e626)
2021-12-19 19:49:52 +01:00
ccrs
d7571e5d1f Scripts/ICC: little bit of cleanup in Valithria after the "recent" changes
(cherry picked from commit 7ffe018571)
2021-12-19 18:05:23 +01:00
Keader
80dbecbd56 Scripts/ICC: Fixed Valithria Archmages casting while dead
After 9c603ea87f, dead creatures will tick UpdateAI
Closes: #24012

(cherry picked from commit 2f31119ea3)
2021-12-19 15:51:30 +01:00
Eridium
2b27278516 Spell/Script: Egg Nog (#24007)
Closes  #23996

(cherry picked from commit b60786a916)
2021-12-19 15:48:29 +01:00
Michael
72e61625bc additional output for additem command (#24006)
* additional output for additem command

when removing items with additem:

if the user provides an amount too large of a negative amount, the command will now output the amount of items that could not be destroyed.

* renamed sql file to hopefully avoid conflicts

* added clarification to failure string

* changed unneeded else if condition to else

* code style; braces

* Update and rename 9999_99_99_99_world.sql to 2019_12_28_01_world.sql

(cherry picked from commit 6b19f4a0ab)
2021-12-19 15:46:20 +01:00
Keader
b9def15aa7 Scritps/ICC: Fixed resistance calculation for Mutated Transformation (Professor Putricide) (#23858)
More Info in: #23837

(cherry picked from commit 9f7b464a6a)
2021-12-19 15:33:41 +01:00
Shauren
e30683fda4 Scripts: Add missing killer nullptr checks in JustDied hooks
(cherry picked from commit 175eba74ae)
2021-12-19 13:12:42 +01:00
jackpoz
7fb3b89d1d Scripts/Misc:Code cleanup
(cherry picked from commit 68fa3091a2)
2021-12-19 13:12:05 +01:00
Killyana
22e088351d Creature/Script: Fire Bomb
Closes #23977

(cherry picked from commit c5c46fed6a)
2021-12-19 13:11:06 +01:00
Killyana
8c6216eaab Creature/Script: Toravon Frozen Orb Stalker
(cherry picked from commit 9bed0aa8d8)
2021-12-19 13:10:28 +01:00
Killyana
ff30b0751e Spell: Move Crystal Spike aura to the cpp
(cherry picked from commit 26faca51cd)
2021-12-19 13:09:42 +01:00
Killyana
a8cbaa33ac Spell: Move Shadow Trap aura to the cpp
(cherry picked from commit 462b63957a)
2021-12-19 13:04:08 +01:00
Eridium
c96157cb95 Boss/Script: Fix Mechano-Lord Capacitus's Nether Charges (#23976)
* Boss/Script: Fix Mechano-Lord Capacitus's Nether Charges

Closes #23973

* Update boss_mechano_lord_capacitus.cpp

* Update boss_mechano_lord_capacitus.cpp

* Update boss_mechano_lord_capacitus.cpp

* Rename 2019_12_99_99_world.sql to 2019_12_19_00_world.sql

(cherry picked from commit efcbfa5c24)
2021-12-19 12:34:32 +01:00
Killyana
41b7b39e3c Spell: Move Column of Frost & Mana Void to the cpp
(cherry picked from commit 74f92d776b)
2021-12-19 12:33:59 +01:00
Killyana
eb36b2f2f7 Spell/Script: Move the spell "Flame Sphere Spawn Effect" from the DB to the cpp
(cherry picked from commit 4d89da56c1)
2021-12-19 12:25:17 +01:00
aquadeus
07015cc052 Scripts/Spells: Fix paladin talent Eye for an Eye (#27426) 2021-12-19 11:53:17 +01:00
aquadeus
5750466259 Scripts/Spells: Fixed priest talent Masochism (#27420) 2021-12-19 11:41:33 +01:00
Keader
f358ac39cc Build fix
(cherry picked from commit ecd4ffc1ce)
2021-12-19 01:42:27 +01:00
Keader
8ed57e95d5 Scripts/Azjol-Nerub: Fixed Gatewatcher pets evading when kill a player
Making Aokromes happy

(cherry picked from commit 58b5ea9f95)
2021-12-19 01:42:18 +01:00
Killyana
16ddcdfd0a DB/Quest: Take Down Tethyr!
Closes #22407

(cherry picked from commit c22b1e6cb4)
2021-12-19 01:42:16 +01:00
Killyana
884eeaed8d DB/Spawns: Rampart of skulls
Closes #23966

(cherry picked from commit 366ec08160)
2021-12-19 01:34:59 +01:00
Gildor
5004a8a4ec Scripts/VioletHold: Minor improvements (#23961)
* Scripts/VioletHold: Minor improvements
* Now we can teleport inside with gossip if event is in progress
* Improve HavePlayers() check logic

* Remove a pointless comment
suggested by shauren

* Move CheckWipe function to execute every 3 seconds instead every map update
suggested by Riztazz

* I supose Riztazz forgot add this to repeat every 3 seconds

(cherry picked from commit f661bc6c39)
2021-12-19 01:27:48 +01:00
Killyana
cf95274ace Quest: Weakness to Lightning
Closes #23916

(cherry picked from commit 6db4bf6671)
2021-12-19 01:09:15 +01:00
Ovah
04ed6e292c Scripts/ScarletEnclave: reworked Eye of Acherus script (#23953)
* updated script model to new standard
* corrected spell usage and timers based on sniff data
* removed hacks

(cherry picked from commit 60763fc5e2)
2021-12-19 01:05:59 +01:00
Giacomo Pozzoni
9bede687ce Core/GameObjects: Skip LoS checks for traps (#23936)
* Core/GameObjects: Skip LoS checks for traps

* Core/GameObjects: Fix spells cast by traps missing always

* Scripts/Spells: Fix WSG heal buff not healing

The WSG green heal buff is now cast by a GameObject so the spell target should be used to calculate the healing, not the GameObject.

(cherry picked from commit 909941e1b4)
2021-12-19 01:05:54 +01:00
ccrs
5d1281edda Scripts/PoS: a7a96d4 followup
cause edge cases may exist
ty Aokromes

(cherry picked from commit a58ed271c9)
2021-12-18 23:36:44 +01:00
ccrs
6443116d5b Scripts/ScarletMonastery: instance script cleanup (#23889)
Adapt InstanceScript into newer structure and style
Adapt existing boss scripts into newer structure and style
Improve existing boss related definitions

Should make each boss more functionally reliable, but nothing new has been added

(cherry picked from commit 06c6b30ed4)
2021-12-18 23:36:17 +01:00
ccrs
bb1a4e884a Scripts/PoS: a7a96d4 followup
we cant despawn all summons since vehicle spawn their passengers as regular summons
ty Aokromes

(cherry picked from commit fcbcb43b2b)
2021-12-18 23:23:08 +01:00
ccrs
b7346bac48 Scripts/PoS: a7a96d4 followup
(cherry picked from commit 40116f1025)
2021-12-18 23:22:54 +01:00
ccrs
7594ae72d7 Scripts/PoS: little implementation cleanup in boss_krickandick with, you guessed it, movement related corrections
also, never forgetti  -->
                                     ¨¨Ç*^¿?_:;_^!"·Ç!Ñ·$%/(/)/()(=)(=]]{
Unit::StopMoving() is evil, and so is MotionMaster::Clear()

the first can really mess up existing movement generators
the second can interrupt "controlled" movements... can do it literally mid-air

(cherry picked from commit a7a96d4271)
2021-12-18 23:22:38 +01:00
ccrs
a73e6a7438 Scripts/PoS: move boss_krickandick into new script definition
(cherry picked from commit d27fd717c1)
2021-12-18 23:22:08 +01:00
ccrs
d3ddb3726a Core/AI: 06443e3 followup
cause its not "that" horrible

(cherry picked from commit a71c5f4c7f)
2021-12-18 23:03:00 +01:00
jackpoz
d5d04a6c55 Core/Misc: Fix C++17 build errors
(cherry picked from commit 30823f9b79)
2021-12-18 22:51:50 +01:00
ForesterDev
4a47e1c6be Core/Defines: define UNIT_FLAG_SWIMMING (#23630)
(cherry picked from commit c03c88d0c0)
2021-12-18 22:50:52 +01:00
Giacomo Pozzoni
3da3683a90 Scripts/Kologarn: Fix "stuck in combat" issues (#23866)
Fix players stuck in combat with NPC_ARM_SWEEP_STALKER and/or both arms after killing the boss.

(cherry picked from commit fed030da19)
2021-12-18 22:47:49 +01:00
Keader
db03975a57 Scripts/ICC: Fixed some issues with Rotface Oozes (#23845)
(cherry picked from commit a108f2ba61)
2021-12-18 22:40:29 +01:00
Keader
e5accfa71a Scripts/ICC: Fixed Death Plague (Frost Giant) (#23847)
(cherry picked from commit 8210b4a539)
2021-12-18 22:40:16 +01:00
Keader
03a1b03633 Scripts/Forge of Souls: Fixed spell Soul Sickness (#23843)
(cherry picked from commit 34ee2effc8)
2021-12-18 22:37:30 +01:00
Keader
9abdc4ee3d Scripts/ICC: Fixed Tear Gas not getting removed of Abomination in phase change of PP (#23846)
(cherry picked from commit 16fde1ffad)
2021-12-18 22:33:47 +01:00
Giacomo Pozzoni
02c2ee9a43 Scripts: Fix crossfaction combat issue (#23818)
* Scripts/PitOfSaron: Fix Martin Victus combat in crossfaction groups

Fix Martin Victus attacking players in crossfaction groups because it was spawned as summon of the boss, triggering DoCombatInZone()

* Scripts/ForgeOfSouls: Fix guards combat in crossfaction groups

Fix Devourer of Souls guardians attacking players in crossfaction groups because they were spawned as summons of the boss, triggering DoCombatInZone()

* Scripts/Misc: Fix no PCH build

(cherry picked from commit ef694cc251)
2021-12-18 22:27:40 +01:00
Keader
5d2b37634b Scripts/Tempest Keep: Fixed a typo in Nethermancer Sepethrea
Closes #23828
Ty Rizztazz

(cherry picked from commit 746a1d89b3)
2021-12-18 22:24:21 +01:00