Commit Graph

2175 Commits

Author SHA1 Message Date
ariel-
5bcf14cdb8 Core/Unit: damage immune improvements (9f5df023b7 follow up)
- Handling checked in sniffs: Spell 63710 Void Barrier vs 49143 Frost Strike
  * Send spell miss immune only if spell consists of damage effects
- Checked with 348 Immolate:
  * No packets sent if damage immune, aura is applied normally

Also... who the fuck uses 0 to compare against pointers

(cherry picked from commit ca1c4525c7)

Core/Unit: fix build

Ctrl-S failure
(cherry picked from commit f3bdd705c0)
2017-12-30 22:56:48 +01:00
Treeston
60c756d3f8 Scripts/Various: Bringing nullptr civilization to the savages of master branch. Merry Christmas.
(2a08556 follow-up)
2017-12-26 01:33:50 +01:00
Treeston
2a08556273 Core/Unit: For convenience, explicitly redirect CastSpell with nullptr as first argument to the Unit* overloads. No more ->CastSpell((Unit*)nullptr, ...) all over the place!
(cherry picked from commits c7896f3102 and 40c78cac4c)
2017-12-26 01:10:26 +01:00
Aokromes
90badf9d7e Misc: More cleanup 2017-11-25 02:50:29 +01:00
Aokromes
8d514fb031 Misc: Kill trailing white spaces 2017-11-25 01:39:02 +01:00
Duarte Duarte
ae917e950b Scripts: Fix static analysis issues CID 1381648, 1379869, 1377302 and… (#20748)
* Scripts: Fix static analysis issues CID 1381648, 1379869, 1377302 and 1377300
2017-11-14 11:23:25 +00:00
SnapperRy
ece0c955fc Codestyle.
(cherry picked from commit ec023c3032)
2017-11-11 20:05:40 +01:00
SnapperRy
0afa672077 Core/Script: Messenger Torvus.
(cherry picked from commit 924cdb9a11)
2017-11-05 12:46:29 +01:00
Keader
bc9b3b4928 Scripts/Trial of the Crusader: Fixed crash in Snobold Vassal script (#18124)
Closes #18122

(cherry picked from commit cdc5a36dbb)
2017-10-15 16:18:21 +02:00
joschiwald
0b36d80115 Fixed build 2017-10-03 17:57:59 +02:00
treeston
03a2f0d56a Entities/Creature: Fix an edge case issue where creatures would re-acquire target after respawn if they despawned while spell focusing.
Instance/AzjolNerub: Fix Anub'arak wall and add sequence break info. Fixes and closes #18013.

(cherry picked from commit 0d725e1336)
2017-10-03 17:35:19 +02:00
treeston
f1929df956 Scripts/AzjolNerub: Make pulling Anub'arak a bit cleaner.
(cherry picked from commit 59cbea00bc)
2017-10-03 17:21:41 +02:00
treeston
10e8b61f90 Fix _DespawnAtEvade for other creatures to actually respawn said other creatures.
Also fix add aggro for Hadronox.
Fixes and closes #18012.

(cherry picked from commit 1ecdea5374)
2017-10-03 17:21:23 +02:00
treeston
a8e3654860 Core/Creature: Fix respawn logic to call reset react state BEFORE calling Reset(). Fixes Krik'thir behavior after a wipe (and maybe some others).
Fixes and closes #18011.

(cherry picked from commit aab7abfd04)
2017-10-03 17:17:11 +02:00
Keader
c514227479 Core/Scripts: Implemented right Snobold Vassal behavior on Gormok fight. (#17934)
(cherry picked from commit 8fb2dce017)
2017-10-03 16:28:15 +02:00
Gustavo
d4fa2cf43f Core/Scripts Boss Lady DeathWhisper improvements (#17389)
(cherry picked from commit 8e82d8a9e7)

Rename 2016_99_99_99_world.sql to 2016_10_14_05_world.sql
(cherry picked from commit b4b8a7477b)
2017-10-03 15:28:39 +02:00
Shauren
8023905611 Core/Spells: Fixed typos in spell script validators 2017-09-06 23:16:36 +02:00
ariel-
b86150352d Core/Scripts: added missing null checks for DamageInfo struct
(cherry picked from commit 666422d827)

# Conflicts:
#	src/server/scripts/Spells/spell_dk.cpp
#	src/server/scripts/Spells/spell_mage.cpp
#	src/server/scripts/Spells/spell_paladin.cpp
#	src/server/scripts/Spells/spell_priest.cpp
#	src/server/scripts/Spells/spell_rogue.cpp
#	src/server/scripts/Spells/spell_shaman.cpp
#	src/server/scripts/Spells/spell_warlock.cpp
#	src/server/scripts/Spells/spell_warrior.cpp
2017-09-05 11:57:29 +02:00
SnapperRy
fa06aad708 Core/Wintergrasp: cleanup and codestyle.
(cherry picked from commit eb1a7297cf)
2017-09-05 11:43:29 +02:00
jackpoz
1fed5d571a Scripts/Azjol-Nerub: fix static analysis issues
(cherry picked from commit 2edfedc2b6)
2017-09-05 11:21:19 +02:00
SnapperRy
37d6c2bfff Battlefield/Wintergrasp: improvements:
- Move Wintergrasp Keep guard spawns from core to db, removing all duplicates in the meanwhile.
- Add Alliance Brigadier General inside the relic room.

Closes #7593.
(cherry picked from commit a0c9d33ed6)

Remove unused variable.
(cherry picked from commit 7ce3811913)
2017-09-05 10:39:08 +02:00
joschiwald
1fef1c595b Scripts: Added missing delimiter to MinionData arrays 2017-08-25 22:22:17 +02:00
Shauren
1de03622c5 Scripts: Delete broken multi profession trainer script (can now be done in db)
* Build fix
2017-08-20 15:06:59 +02:00
Shauren
b85d46138b Core/Creatures: Deleted obsolete pet trainer script and fixed build 2017-07-27 00:04:37 +02:00
joschiwald
9cb4a265a3 Misc: Fixed misleading indentation 2017-07-25 00:02:13 +02:00
Seyden
a9174d5eb7 Core/Scripts: Implement generic script loaders (and script registry macros) to greatly reduce code duplication (#19526) 2017-07-20 00:15:02 +02:00
vincent-michael
b81c2e7971 Scripts/Misc: Fixed static analysis issues 2017-07-16 12:18:14 +02:00
Shauren
b453e12423 Core/Game: Include cleanup part 5
* ObjectMgr.h
* Player.h
* Unit.h
* G3D should no longer propagate everywhere from Spline/MotionMaster
2017-06-04 01:00:45 +02:00
Shauren
a0a158b5b8 Core/Scripts: Include cleanup 2017-05-28 16:34:44 +02:00
Gacko
0596a223a2 Moar non-PCH fixes. 2017-05-25 12:40:58 +02:00
joschiwald
08482bfc0d Scripts/XT002: Fixed Scrapbot repair 2017-05-25 10:43:33 +02:00
Shauren
38c6694b8e More nopch fixes 2017-05-25 00:24:37 +02:00
Shauren
2200b4b0e1 Nopch fix 2017-05-24 21:30:43 +02:00
Shauren
5992572175 Nopch build fix 2017-05-19 00:41:18 +02:00
Shauren
c5d3dd90be Core/Game: Include cleanup
* Mostly aimed at removing Log/DatabaseEnv includes from other headers
* Fix most packet headers including other packet headers - moved common structures such as ItemInstance to their own files
* Moved SAI function definitions to source files (massive or requiring many different dependencies)
2017-05-18 23:53:25 +02:00
Shauren
b421a5c0cb Core/Game: Include cleanup - remove Map dependency from Object.h 2017-05-15 22:55:16 +02:00
Shauren
9299e9bde0 Core/Grids: Ported cmangos/mangos-wotlk@ea99457e50 2017-05-13 19:37:33 +02:00
joschiwald
036f67c0c1 Core/Collision: Replaced phasemask with proper phases in GameObject collision calculation 2017-05-05 21:22:58 +02:00
ariel-
b7bf703737 Core/Scripts: Convert spells to new proc system
- Converted Unit::HandleDummyAuraProc function to AuraScripts
  * Extra: DMC: Madness now uses DB texts. yay!
  * Extra: improvements on Imp. Spell Reflection (range and max targets, filter caster with conditions)

- Fixed Glyph of Succubus. (Closes #6599)

- Changed old (not-blizz) behavior of Vampiric Embrace:
  * Before: party heal affected the priest too and self heal was reduced by that amount to not over-heal
  * Now: self heal amount not affected, rather filter the priest out of the party heal using conditions :)

- Solve bug in AQ 3p set bonus, it should only trigger when healing others, not self heals.
- Priest T10 2p bonus (heal) now rolls its effect properly

- Use brand new GetEffectiveHeal to fix #17142
- While we're at it, also close #17034 for good
- Converted Unit::HandleAuraProc function to AuraScripts (#17941)
- Converted Unit::HandleAuraProc function to AuraScripts (cont'd) (#17955)
- Corrected Flametongue weapon damage formula
- Actually check offhand weapon for flametongue in Lava Lash script
- Implemented halved proc chance for Missile Barrage on Arcane Barrage, Fireball, Frostbolt and Frostfire Bolt cast
- Converted Unit::HandleProcTriggerSpell function to AuraScripts (#17956)
- De-hack Earth shield. Fixes #13808
- Updated Honor among Thieves
- Implemented mana proc for Mark of Conquest in case of ranged attack
- Fixed Scent of Blood giving more stacks than the talent rank currently learnt.
- Ported old proc table. Proc system is dead. Long live the proc system!
- Recklessness should get charges removed per cast. Closes #15529
- Use proc system to remove Molten Core charges on Incinerate/Soul Fire cast. Closes #15942

Closes #3463
Closes #5401
Closes #15595
Closes #15974
Closes #16679
Closes #17925

(cherry picked from commit 2ff855054f)

# Conflicts:
#	src/server/scripts/Northrend/UtgardeKeep/UtgardeKeep/utgarde_keep.cpp
#	src/server/scripts/Spells/spell_dk.cpp
#	src/server/scripts/Spells/spell_druid.cpp
#	src/server/scripts/Spells/spell_hunter.cpp
#	src/server/scripts/Spells/spell_item.cpp
#	src/server/scripts/Spells/spell_mage.cpp
#	src/server/scripts/Spells/spell_paladin.cpp
#	src/server/scripts/Spells/spell_priest.cpp
#	src/server/scripts/Spells/spell_rogue.cpp
#	src/server/scripts/Spells/spell_shaman.cpp
#	src/server/scripts/Spells/spell_warlock.cpp
#	src/server/scripts/Spells/spell_warrior.cpp
2017-04-23 19:01:39 +02:00
Shauren
c0eb6c3130 Core/Entities: Update updatefields to 7.2.0 2017-04-16 01:13:09 +02:00
Shauren
0b0d4c4011 Warning fixes 2017-04-03 10:38:15 +02:00
Shauren
8f49a32d13 Core/Spells: Removed even more uses of SpellIcon to identify spells 2017-04-03 00:27:16 +02:00
Shauren
f097e341f5 Core/Utilities: Rename RandomResizeList->RandomResize as it is no longer restricted to a list
* Also fix gcc build
2017-03-23 00:11:58 +01:00
Traesh
c290fc387b Build fix (#19343) 2017-03-21 22:57:19 +01:00
vincent-michael
5b638b76c1 Fixed typo in 182dba61db 2017-03-18 18:40:45 +01:00
vincent-michael
182dba61db Scripts/HowlingFjord: Fixed warning 2017-03-18 18:38:04 +01:00
Aokromes
c170813b96 Scripts/Wintergrasp: Fix vehicle teleporter (#17550)
By WoWErrorDev, closes #5831.
(cherry picked from commit 308a2413a1)
2017-03-05 01:39:26 +01:00
SnapperRy
b84d0e9fd4 Core/Conditions: implement CONDITION_WINTERGRASP_HORDE to check if Wintergrasp is held by Horde.
Use negative condition to check if it is held by Alliance instead.

Use this condition to fix availability of the Wintergrasp item-gathering weekly quests.
(cherry picked from commit 723c253f8f)

Make travis happy and fix codestyle for previous commit.
(cherry picked from commit 7267a41418)

Core/Conditions: partially revert 723c253, replacing CONDITION_WINTERGRASP_HORDE with a ConditionScript.
(cherry picked from commit fd620ca7d6)

Update 2016_10_04_03_world.sql
(cherry picked from commit 4891db4a4f)
2017-03-05 01:28:45 +01:00
treeston
ee6e27a1d6 Various: Fix coverity reported issues.
(cherry picked from commit 84cf239fda)

Core/Scripts: kill whitespace
(cherry picked from commit 83771597c1)
2017-03-05 01:19:55 +01:00
Keader
da0190f3d0 Core/Scripts: Fixed Gunship Mage cast interrupt
Closes: #14912

(cherry picked from commit 05c2fa2e02)
2017-03-04 00:05:55 +01:00