Commit Graph

7107 Commits

Author SHA1 Message Date
Vincent-Michael
88ea67add0 Core/SAI: Addet new error log for SMART_ACTION_CAST kill credit invalid target 2014-09-30 18:56:12 +02:00
jackpoz
4ed3254aa8 Core/Scripts: Fix invalid memory write
Fix invalid memory write caused by calling "delete this;" in a base class constructor.
2014-09-29 20:12:03 +02:00
joschiwald
c34af1d60b Core/Scripts: fixed memory leak caused by unassigned scripts in db 2014-09-29 19:03:04 +02:00
jackpoz
c23c66f719 Core/AH: Fix Auction House items not deleted from database
Fix some cases where Auction House items were not deleted from item_instance table of character database, for example if the owner didn't exist anymore or if the owner was the AHBot.

Updates #12699
Updates #13232
2014-09-28 21:13:19 +02:00
Shauren
0781d29657 Core/GameObjects: Fixed uninitialized elevator period value 2014-09-28 21:04:18 +02:00
Malcrom
ad336996ee Core/LootMgr: Forgot to change this. Found by Vincent Micheal 2014-09-27 23:17:29 -02:30
Malcrom
55b43c6751 Core/LootMgr: Update lootMgr to normalize loot_template tables 2014-09-27 22:40:58 -02:30
Duarte Duarte
1854eafcb6 Merge pull request #13140 from Unholychick/preventfleeing
Core/Mechanics: Fix prevent fleeing + fear
2014-09-27 21:40:41 +01:00
Shauren
605d51533c Core/Spells: Always add threat for spells from spell_threat table, not only if target was hit. Unsuccessful cast results in 0 threat added instead of the full amount and creating threat list entry for caster. This fixes various exploits with taunt spells bugging out scripts due to taunt immunity/passive state (creatures would immediately evade resetting script state if no entries were present on threat list - entry with no threat is not the same as no entry)
Closes #11883
2014-09-26 22:26:51 +02:00
jackpoz
79b9ca4a58 Scripts/Misc: Make InstanceScript::Initialize() obsolete
Move all InstanceScript initialization code from Initialize() to the constructor.
InstanceScript::Initialize() is now obsolete, please don't use it anymore. The only reason it's still in the sources is for backward compatibility.
2014-09-25 22:28:20 +02:00
mik1893
c9abaf4139 Core/Achievements: Fixed wrong packet generation in AchievementMgr::SendCriteriaUpdate 2014-09-25 14:06:35 +02:00
jackpoz
e77f503336 Scripts/Examples: Remove some more code related to example scripts 2014-09-22 20:25:11 +02:00
Morgoporc
ec59c3ab03 Core/Players/DK: Implement Rune Grace Period mechanic
Closes #11736
Fixes #6122
2014-09-22 01:05:13 +01:00
jackpoz
84efd8b92b Scripts/Examples: Remove outdated example scripts
Remove outdated misleading example scripts not following anymore current TC codestyle and standards. Please refer to the wiki or forum for up to date examples and documentation.
2014-09-21 22:42:50 +02:00
jackpoz
6e27841382 Core/Misc: Refactor scripts to fix static analysis warnings
Seventh batch of fixes targeting 100 issues reported by Coverity
2014-09-21 22:15:04 +02:00
Vincent-Michael
1d8feb271c Core:/SmartScript: Added log for item has credit spell blabla 2014-09-21 17:45:57 +02:00
Warpten
e70ce42416 Merge pull request #13180 from ShinDarth/335_fix
Core/ObjectMgr: corrected error labels
2014-09-21 15:24:51 +02:00
ShinDarth
4892408ed0 Core/ObjectMgr: corrected error labels 2014-09-21 15:21:30 +02:00
Vincent-Michael
c243bf96d4 DB/Spells:
- Added EffectItemType columns to spell_dbc table
- Fix "Create Bundle of Bloodthistle"
2014-09-21 04:18:31 +02:00
jackpoz
a209fc30ff Core/Misc: Avoid Helgrind reporting libstdc++ false positive race conditions 2014-09-20 22:35:13 +02:00
Shauren
d87c23cdaf Core/Achievements: Fixed realm first kill achievement restrictions - now only the first group will be able to complete it
Closes #2957
2014-09-20 19:07:39 +02:00
Shauren
16ecf9ec5d Core/Guilds: Fixed guild rank delete framexml event params 2014-09-20 10:47:14 +02:00
joschiwald
ac3623b316 Kill new compile warnings 2014-09-20 00:43:45 +02:00
joschiwald
bf37dbfb2a Core/Battlefield/WG: fixed warnings
Ref #13169
Closes #12714
2014-09-20 00:26:58 +02:00
ShinDarth
83f82b4a04 Core/ObjectMgr: check creature.orientation and gameobject.orientation range in loading
Closes #13156
2014-09-19 22:36:50 +01:00
Unholychick
a51c3ac5fe Core/Mechanics: Fix prevent fleeing + fear
Closes #9754

Players should never have been affected by SPELL_AURA_PREVENTS_FLEEING in the first place.
Curse of Recklessness will no longer prevent Fear effects, only prevent NPCs from fleeing (e.g. at low health).
Judgement of Justice will no longer prevent Fear effects, but will only prevent NPCs from fleeing (e.g. at low health).
Source: http://www.wowwiki.com/Patch_3.0.2
2014-09-19 22:16:49 +02:00
Shocker
80f77977f1 Core/Grids: Replace some magic numbers with constants
(P.S.: That's why! @cs_misc.cpp)
2014-09-19 18:03:49 +03:00
DDuarte
c678eaa71e Core/MapScripts: Use proper enum value for boss whisper in SCRIPT_COMMAND_TALK 2014-09-19 15:19:53 +01:00
DDuarte
878b7d3811 Core/MapScripts: Use proper source unit in SCRIPT_COMMAND_TALK
Closes #13161
2014-09-19 15:04:24 +01:00
DDuarte
256ad379dd Oops. 2014-09-19 03:39:57 +01:00
DDuarte
cefcde9ba9 Core/Misc: Multiple static analysis issues fixed (small optimizations and clear code) 2014-09-19 03:30:02 +01:00
joschiwald
e6b7de8c97 Fixed build 2014-09-19 04:20:01 +02:00
joschiwald
0f1f7ef401 Core/Misc: multiple changes
* fixed build
* apply tc codestyle to ObjectGuid class
* fixed warning
2014-09-19 03:16:59 +02:00
joschiwald
9d9919f6e0 Core/AreaTriggers: enable areatrigger teleports in battleground
Closes #11999
2014-09-19 01:48:35 +02:00
joschiwald
e567ab9597 Core/Texts: added TextRange parameter to creature_text
Ranges:
0 - Normal (Default)
1 - Area
2 - Zone
3 - Map
4 - World

Ref #13116
2014-09-18 23:33:59 +02:00
Shauren
31656c0213 Core/Trade: Fixed enchanting soulbound items in trade
Closes #12850
2014-09-18 21:15:39 +02:00
Vincent-Michael
ad49bd5194 SQL: Fix sql import 2014-09-18 06:05:38 +02:00
joschiwald
72ed5bfc93 Core/Misc: changed trinity string id to unsigned and removed obsolete code 2014-09-18 02:36:28 +02:00
joschiwald
b08dcb1d99 Core/Scripts: implemented a guid map in InstanceScript, this way you can easier store guids and access its objects 2014-09-18 00:25:05 +02:00
joschiwald
053beae172 Core/Spells: consider spell speed in SPELL_EFFECT_CHARGE
Misc: removed some duplicate guid words in logs
2014-09-17 23:24:31 +02:00
Shauren
e57a63939e Core/NetworkIO: Fixed queued packets not being properly sent causing players to be stuck during loading
Closes #13120
2014-09-17 23:06:34 +02:00
MitchesD
763a21d376 Merge pull request #13159 from ShinDarth/335_fix2
Corrected grammar of some strings
2014-09-17 19:29:21 +02:00
ShinDarth
1a068659b6 Core/Grammar: corrected grammar of some strings 2014-09-17 19:03:15 +02:00
Duarte Duarte
048e043d0d Merge pull request #13154 from Unholychick/casts
Core/Spells: Fix some -Wconversion warnings
2014-09-17 16:09:18 +01:00
Vincent-Michael
7db99ca007 Core: Fix warnings 2014-09-17 16:58:08 +02:00
DDuarte
af7daba02d Core/SAI: Remove SMART_ACTION_STORE_VARIABLE_DECIMAL
It's not used.
2014-09-17 01:07:29 +01:00
Unholychick
6477e96cca Core/Spells: Fix some -Wconversion warnings
Attempt to fix #13152 by properly casting between data types during damage calculations.
2014-09-16 23:56:05 +02:00
Shauren
7d1d55124c Merge branch 'ObjectGuid' of https://github.com/TrinityCore/TrinityCore
Conflicts:
	src/server/game/Entities/Player/Player.cpp
	src/server/game/Entities/Player/Player.h
	src/server/game/Scripting/MapScripts.cpp
	src/server/scripts/Northrend/Naxxramas/instance_naxxramas.cpp
	src/server/scripts/Northrend/Nexus/EyeOfEternity/instance_eye_of_eternity.cpp
	src/server/scripts/Northrend/Nexus/Nexus/boss_anomalus.cpp
	src/server/scripts/Northrend/Nexus/Nexus/boss_magus_telestra.cpp
	src/server/scripts/Northrend/Nexus/Oculus/boss_varos.cpp
	src/server/scripts/Northrend/Ulduar/HallsOfStone/halls_of_stone.cpp
	src/server/scripts/Northrend/Ulduar/Ulduar/boss_auriaya.cpp
	src/server/scripts/Northrend/Ulduar/Ulduar/boss_freya.cpp
	src/server/scripts/Northrend/Ulduar/Ulduar/boss_hodir.cpp
	src/server/scripts/Northrend/Ulduar/Ulduar/boss_ignis.cpp
	src/server/scripts/Northrend/Ulduar/Ulduar/boss_razorscale.cpp
	src/server/scripts/Northrend/UtgardeKeep/UtgardePinnacle/boss_skadi.cpp
	src/server/scripts/Northrend/UtgardeKeep/UtgardePinnacle/boss_svala.cpp
	src/server/scripts/Northrend/UtgardeKeep/UtgardePinnacle/boss_ymiron.cpp
2014-09-16 21:50:01 +02:00
Shauren
9b933b4a29 Core/Misc: Removed explicit qualifier from ObjectGuid uint64 conversion operator 2014-09-16 20:57:11 +02:00
Shauren
878073d516 Core/Logging: Fixed incorrect usage of guid in logs 2014-09-16 20:47:08 +02:00