Commit Graph

26435 Commits

Author SHA1 Message Date
aquadeus
01ac538cd2 Scripts/Spells: Fix priest Mind Bomb (#27415) 2021-12-17 12:27:12 +01:00
Shauren
05037bd936 Core/Auras: Implemented ChangeSpec, ChangeTalent and ChangeGlyph interrupt flags 2021-12-17 12:18:43 +01:00
Kelno
f3b0325758 Core/OPvP: Remove dangling line after 84b7b2e (PR #23625)
(cherry picked from commit ef3ee63d88)
2021-12-17 00:33:35 +01:00
Wyrserth
f6df334bb6 Script/ScarletEnclave: remove Eye of Acherus control and speed auras from player when the Eye of Acherus is dismissed.
(cherry picked from commit bf8741c53d)
2021-12-17 00:29:59 +01:00
Treeston
4c754de7a8 != and == are not the same thing.
(cherry picked from commit 51cf1c7136)
2021-12-17 00:29:31 +01:00
Treeston
c6834a1de6 oops, that wasn't supposed to remain there (0e7c66c follow-up)
(cherry picked from commit 81fcd2e2d5)
2021-12-17 00:29:21 +01:00
jackpoz
e998a1169d Core/Spline: Fix crash
Fix crash when calling MoveSpline::ToString() on an empty spline

(cherry picked from commit 2bac44c7d0)
2021-12-17 00:27:09 +01:00
Treeston
a4c2c0fb1d Core/AI: No longer override chase movement with follow movement if the creature engages before JustAppeared has had a chance to fire.
(cherry picked from commit 49b04c0fdd)
2021-12-17 00:25:59 +01:00
Wyrserth
a2b1b3e2aa Core/Instance: remove wrong raid-only restriction in the logic that kicks offline players out of instances when the instance is reset.
(cherry picked from commit e5615402cc)
2021-12-17 00:24:22 +01:00
Treeston
c13d83796f Core/AI: Finally move the "is creature engaged" flag to be a property of the creature AI, where it honestly always belonged. Fixes #17981 and #23602 for real this time.
(cherry picked from commit 0e7c66cb4c)
2021-12-17 00:23:33 +01:00
Wyrserth
3efc2caf96 Script/SethekkHalls: fix gossip text and quest event for NPC Lakka in Sethekk Halls.
(cherry picked from commit b8d86bba99)
2021-12-16 22:58:41 +01:00
Giacomo Pozzoni
493fe066f6 Core/Misc: Handle timezones for hour-specific events specifieds in worldserver.conf (#23540)
* Core/Misc: Handle timezones for hour-specific events specifieds in worldserver.conf

* Handle Respawn.RestartQuietTime too

* Handle XP.Boost.Daymask too

* Core/Misc: Code cleanup

* Core/Misc: Code cleanup

* Update Util.cpp

* Update boosted_xp.cpp

(cherry picked from commit aeddd417c4)
2021-12-16 22:35:44 +01:00
Treeston
611ddfee3c build fix after d1dc0e2
(cherry picked from commit c0f8e8535a)
2021-12-16 22:16:07 +01:00
ccrs
e94dca132b Core/SmartAI: add missing movement generator type check on SmartAI::SetCombatMove
ref #21562

(cherry picked from commit 0e3e4353a1)
2021-12-16 22:10:54 +01:00
ccrs
f1ef2f73a4 Core/SmartAI: allow more Unit::ResumeMovement calls on JustReachedHome()
Since ResumeMovement also works on other MOTION_SLOT_DEFAULT generators (like RandomMG)

(cherry picked from commit c8cb866db0)
2021-12-16 22:08:01 +01:00
Ovah
879e7094b7 Core/Misc: Add new centralized location for generic predicates (PR #23607)
(cherry picked from commit 6e2ca481e5)
2021-12-16 22:05:20 +01:00
jackpoz
17bf908847 Core/Misc: Fix warnings
(cherry picked from commit a9f1dc1da7)
2021-12-16 22:04:25 +01:00
jackpoz
2c3cdf67c2 Core/MovementGenerator: Add more asserts
(cherry picked from commit 9ed35e2108)
2021-12-16 22:04:12 +01:00
jackpoz
f65edd1130 Core/MovementGenerator: Add more details to asserts
Include movespline in Unit::GetDebugInfo() and the Player owner in FlightPathMovementGenerator::DoEventIfAny() assert

(cherry picked from commit 560b7e3397)
2021-12-16 22:03:52 +01:00
Ovah
a24a5e7778 Core/Movement: add a velocity argument for the spline chain meta table (PR #23575)
(cherry picked from commit 3f7b2252a1)
2021-12-16 22:03:35 +01:00
OcelotGear
65abf9b482 Script/Hunter: fix Snake Trap's snakes' initialization.
Closes #23570.

(cherry picked from commit 085f40a278)
2021-12-16 22:01:40 +01:00
Wyrserth
434ef51c10 Core/Creature: honor existing DB data for health and mana in case of summoned pets that don't have pet-specific stat data.
Closes #23570.

(cherry picked from commit 55570be661)
2021-12-16 22:01:10 +01:00
Wyrserth
537b425377 Core/Creature: don't set guardian stats in Creature::UpdateEntry(), because stat calculation from guardians is already done in Guardian::InitStatsForLevel.
Closes #281.

Signed-off-by: Wyrserth <wyrserth@protonmail.com>
(cherry picked from commit 5f5d2028df)
2021-12-16 21:57:19 +01:00
Treeston
e270351a16 Scripts/Commands: Adjust .list respawns to use enum iteration. Add enum iteration capability to SpawnObjectTypes.
(cherry picked from commit b64834c3f5)
2021-12-16 21:41:24 +01:00
Wyrserth
8b71e65f20 Core/Achievement: don't increase ACHIEVEMENT_CRITERIA_TYPE_RECEIVE_EPIC_ITEM counters for items bought back from vendors.
(cherry picked from commit a58955d88c)
2021-12-16 21:20:39 +01:00
Wyrserth
96bca1fe2b Script/BoreanTundra: move Pile of Fake Furs' script (related to quest Unfit for Death) from ItemScript to SpellScript.
Closes #21890.

(cherry picked from commit e7cf24d263)
2021-12-16 21:20:39 +01:00
Wyrserth
1f8a6bac87 Core/GameObject: do not allow players to interact with gameobjects that use the "Point" icon.
Updates #21890.

(cherry picked from commit c52c0f0b7d)
2021-12-16 21:20:38 +01:00
Wyrserth
cc0a9d1fe9 Core/Player: don't send errors to client from Satisfy* methods when Player::CanRewardQuest() is called with msg = false.
Fixes cases where people would get strange errors like "You are not high enough level for that quest" when entering WotLK instances.

(cherry picked from commit a4ddb30489)
2021-12-16 21:20:38 +01:00
Treeston
093223d7b4 Core/DB: Add RBAC for .debug poolstatus, because I need it for the pooling branch.
(cherry picked from commit a82bbeb101)
2021-12-16 21:20:38 +01:00
jackpoz
488d59aef3 Core/Misc: Fix no-pch build
(cherry picked from commit 504e452450)
2021-12-16 21:20:38 +01:00
Treeston
8b78f50556 Core/DB: Merge pool_creature, pool_gameobject and pool_pool into a single pool_members table.
(More pooling prep, I really don't want to have any sql update files in that PR if I can help it.)

(cherry picked from commit 45bc91c238)
2021-12-16 21:20:38 +01:00
Treeston
6f6cf975e4 Scripts/Commands: Add .debug questreset to force daily/weekly/monthly quest reset.
(cherry picked from commit 293ba08d21)
2021-12-16 21:20:38 +01:00
Treeston
bd7aae928e Core/Chat: Properly reload saved channel settings from DB after 8c16f31.
(cherry picked from commit 2c1b87ca29)
2021-12-16 21:20:38 +01:00
Treeston
9fa5c71409 Core/DB: Add a world state for daily quest reset time to characters. Not used right now, but written to allow easier transition later.
(cherry picked from commit 1277c54263)
2021-12-16 21:20:38 +01:00
Treeston
eee950cdd7 Core/Misc: Various dynspawn cleanup and refactors split off from pooling rewrite:
- Map::RemoveRespawnTime(SpawnObjectType, LowType, doRespawn) split into Map::Respawn and Map::RemoveRespawnTime, without the extra boolean
- Map::RemoveRespawnTime(RespawnInfo*) merged into Map::DeleteRespawnInfo(RespawnInfo*) and is now private
- Map::DeleteRespawnInfo(void) renamed to Map::UnloadAllRespawnInfos to properly describe what it does
- Map::ProcessRespawns now actually saves the delayed respawn time to DB if the respawn was delayed
- Map::AddRespawnInfo now takes const reference, and returns success as a boolean
- Map::AddRespawnInfo no longer offers an unused "replace" parameter
- Map::DeleteRespawnInfo no longer offers a variety of unused private overloads
- Map::SaveRespawnTime no longer offers a tantalizing writeDB parameter. Parameter is now called "startup" to properly describe what it does.
- Map::SaveRespawnInfoDB now takes RespawnInfo reference instead of all the various fields. Still public because compatibility mode. QQ.
- Map::GetWorldObjectBySpawnId sanitized
- Map::GetXRespawnTime methods sanitized to all go through Map::GetRespawnTime

(cherry picked from commit d60082ae86)
2021-12-16 01:33:09 +01:00
Treeston
d5e58cef69 Core/Spawns: Exterminate CONFIG_SAVE_RESPAWN_TIME_IMMEDIATELY with extreme prejudice. (It didn't work anyway.)
(cherry picked from commit 26440857c1)
2021-12-16 01:18:15 +01:00
Treeston
be05590a12 Core/DB: Unify creature_respawn and gameobject_respawn into a single respawn table
(cherry picked from commit 374597c8e9)
2021-12-16 01:10:06 +01:00
Shauren
58fb2ef631 Core/DB: Improved terrible assertion message
(cherry picked from commit eed9267685)
2021-12-16 00:54:53 +01:00
jackpoz
e7b94603f2 Core/Commands: Add .debug guidlimits <optional map id> chat command
Add .debug guidlimits <optional map id> chat command to show the highest low guid counter for Creature and GameObject, useful when reaching Respawn.GuidWarnLevel

(cherry picked from commit 7421ccaf7e)
2021-12-16 00:53:58 +01:00
ccrs
1e84edde39 Core/Spells: Port refactors from d1dc0e2dc1
(cherry picked from commit d1dc0e2dc1)
2021-12-16 00:42:21 +01:00
Treeston
ea753efb93 Core/Chat: Rewrite some custom channel handling. Channel creation now properly saves passwords. Closes #23589.
(cherry picked from commit 8c16f318fe)
2021-12-16 00:37:01 +01:00
jackpoz
71b2f8c6ab Core/Calendar: Fix issue with invite status being set to the wrong invite
Consider the case of Player A inviting Player B to a Calendar Event. After Player B clicks on Accepts/Tentative/Reject, the calendar shows that status for Player A instead.

(cherry picked from commit 7f3d8c99bb)
2021-12-16 00:15:48 +01:00
Wyrserth
1b7a1c51ae Core/Player: prevent trade system from getting stuck in an invalid state when the LevelReq.Trade config is used.
(cherry picked from commit a54af39e29)
2021-12-16 00:14:52 +01:00
ccrs
49bc6533fd Scripts/ScarletEnclave: 4ee84bb followup
(cherry picked from commit 81475f709f)
2021-12-16 00:11:25 +01:00
ccrs
8c35206bb5 Scripts/ScarletEnclave: 4ee84bb followup
(cherry picked from commit fa9a4ee20d)
2021-12-16 00:10:25 +01:00
ccrs
ef6a5d3c3c Core/Unit: movement related corrections prior to getting Charmed
(cherry picked from commit 294a3a2789)
2021-12-15 23:42:06 +01:00
Wyrserth
3bb61af113 Script/ScarletEnclave: use spline movement for the lauch phase of the Eye of Acherus.
Closes #22802.

(cherry picked from commit 4ee84bbecb)
2021-12-15 23:39:51 +01:00
Treeston
a69a061d76 Battleground/Arena: Properly check RBAC arena join permission before allowing queue. Closes #23000.
(cherry picked from commit af082664ca)
2021-12-15 23:31:31 +01:00
Treeston
b4b581de1b Scripts/Commands: .account ban no longer fails if an account containing the specified account name is already banned (f.ex. attempting to ban 'test' if 'test2' is already banned) - closes #22990
(cherry picked from commit daf423a6c3)
2021-12-15 22:48:03 +01:00
Treeston
b8c7260bfd typo fix, duplicate assignment
(cherry picked from commit 7d6896b541)
2021-12-15 22:41:58 +01:00