Mirror/TrinityCore
1
0
Fork 0
mirror of https://github.com/TrinityCore/TrinityCore.git synced 2026-01-17 08:00:48 +01:00
Code Issues Packages Projects Releases Wiki Activity
34,610 Commits 4 Branches 146 Tags
06b5b8d8b7ac3da65013ccc0f03599ee9dee2163
Commit Graph

5726 Commits

Author SHA1 Message Date
Treeston
ffce2c1f9a Core/Spell: Properly remove REACT_PASSIVE on permanent feign death unapply. Fixes and closes #21156. 
(cherry picked from commit ac8b9be5d6)
 2021-06-20 20:22:18 +02:00
Treeston
3b635a8a12 Scripts/AzjolNerub: Clean up Hadronox to hopefully avoid any further evade issues. Tag #20310. 
(cherry picked from commit fe3b4de1cd)
 2021-06-20 20:17:59 +02:00
ariel-
a342b86403 Core/Scripts: fix Tenacity Aurascript (target is null on UpdatePeriodic) 
- also aura amount increases with stack so we lose spellid info, calculate it from basepoints directly
- aura should be SPELL_AURA_MOD_HEALING_PCT instead of SPELL_AURA_MOD_HEALING_DONE_PERCENT (ie taken instead of done, confusing names)

(cherry picked from commit bc2a4c816d)
 2021-06-20 01:15:00 +02:00
ariel-
23a88fae6f Core/Scripts: remove Tenacity hack, implemented with proper aura 
(cherry picked from commit 404240fb68)
 2021-06-20 00:55:53 +02:00
Wilcalaf
e9833447ed Archaedas should properly start now when clicking on the altar. (#21401) 
(cherry picked from commit 0c1aaac219)
 2021-06-20 00:30:33 +02:00
Treeston
3c172ba17c Scripts/AzjolNerub: Hadronox is a big spider mommy, and needs more room to pet her spider pets properly. Hopefully this'll reduce the number of evades happening during the encounter. Tag #20310. 
(cherry picked from commit b243a7929b)
 2021-06-19 23:33:38 +02:00
ariel-
a24af55d13 Core/Scripts: implemented Combined Toxins proc only from poisons 
(cherry picked from commit 477878630e)
 2021-06-19 23:33:38 +02:00
jackpoz
e63c5f7b0c Scripting/Obsidian Sanctum: Fix crash 
Fix crash caused by calling Reset() in constructor (which is not allowed)

(cherry picked from commit 5aba5c7aff)
 2021-06-19 23:33:38 +02:00
Treeston
e8754cbdaf Scripts/Instance: Transition Gnomeregan to boss states (instance spawn group prep) 
(cherry picked from commit a4fc32dd86)
 2021-06-19 23:33:37 +02:00
Keader
299f22e3fc Scripts/Icecrown Citadel: Fixed Sindragosa spawn after grid unload 
ty sirikfoll :)

(cherry picked from commit 2994abeae6)
 2021-06-19 23:33:37 +02:00
ariel-
3485cb38ed Core/Spells: remove 'Vanish Purge' hack, the spell is present on DB and is copy of one in vanilla DBC 
Thanks to killerwife for the heads-up

(cherry picked from commit 303efcf0e4)
 2021-06-19 23:33:25 +02:00
Keader
9b7f3bff9f Core/Scripts: Fixed tabs issues introduced in 5bef3e426a 
(cherry picked from commit 31ad6358fb)
 2021-06-19 23:33:24 +02:00
Keader
ad5b0fa9cd Core/Scripts: Fixed possible crashs related with JustDied 
(cherry picked from commit 5bef3e426a)
 2021-06-19 23:33:24 +02:00
ariel-
4ae29e38ee Core/Scripts: fix non-functional Celestial Planetarium Access GO 
- Client only sends CMSG_GAMEOBJ_REPORT_USE for this one

Closes #19982

(cherry picked from commit b490d3f5ad)
 2021-06-19 23:33:24 +02:00
sirikfoll
9573987775 Scripts/Magisters Terrace: Removed not allowed ENSURE_AI call from constructor 
Closes #20727

(cherry picked from commit cfaa4e6caf)
 2021-06-19 23:33:24 +02:00
sirikfoll
e2c72cc02e Scripts/Sunwell Plateau: Fixed and improved spell "Curse of Boundless Agony" target selection (Boss Kalecgos) 
(cherry picked from commit 14b6e3bbb3)
 2021-06-19 23:33:24 +02:00
Treeston
809c38994a Core/Threat: Custom ThreatListIterator that transparently iterates over the backing map (instead of using heap iterators) when working with the unsorted threat list. This greatly reduces the range of actions that can cause iterator invalidation. 
Also some minor adjustments to .debug threat, which no longer hides certain invalid states from view.

(cherry picked from commit 4cb13af4fa)
 2021-06-19 23:33:24 +02:00
Treeston
d7542dc3e8 Scripts/Ulduar: Flame Leviathan used a very weird mixture of victim logic and REACT_PASSIVE, which broke during transition to the new system. Replaced with a working version. 
Closes #21265.

(cherry picked from commit b3e0c89238)
 2021-06-19 01:57:55 +02:00
Treeston
a8307e60a3 Scripts/ICC: Valithria Dreamwalker's script no longer despawns unrelated mobs in Frostwing Halls, and thus won't get them stuck in a despawned state due to linked_respawn. 
Closes #21286.

(cherry picked from commit aefc25482f)
 2021-06-19 01:35:41 +02:00
sirikfoll
bd7fbce592 Scripts/Icecrown Citadel: Corrected Val'kyr Shadowguard positioning on heroic mode (Lich King) 
Movement was being prevented by spell cast

(cherry picked from commit a217c0be92)
 2021-06-19 01:35:41 +02:00
Treeston
39dff738e1 Scripts/Pets: Mirror Image re-write, because it's a colossal mess right now. (PR #19818) 
(cherry picked from commit 03ef79f3d9)
 2021-06-19 01:35:41 +02:00
Shauren
428bf60f7f Scripts/Icecrown Citadel: Added missing cosmetic colors and emotes to Big Ooze (Rotface) 
(cherry picked from commit aaab7ba9f4)
 2021-06-19 01:35:40 +02:00
Killyana
2d43b8aaa3 Quest/script: Freedom to Ruul 
Follows 4dc91429dd

(cherry picked from commit 52fc5a572b)
 2021-06-19 01:35:38 +02:00
Killyana
30feaa06e8 DB/Quest: Freedom to Ruul 
Closes #7262

(cherry picked from commit 4dc91429dd)
 2021-06-19 00:14:06 +02:00
Treeston
7db3f7ca96 DB/SpawnGroup: Instance spawn group data for Tempest Keep: The Eye and Hellfire Citadel: Ramparts. 
(also some minor adjustments to command output for convenience)

(cherry picked from commit 51e28ae76a)
 2021-06-16 23:01:48 +02:00
Treeston
7c0ac5b959 Misc: assert -> ASSERT 
(cherry picked from commit 6c3c200cc5)
 2021-06-16 22:51:16 +02:00
Treeston
386ec58233 Scripts/Commands: new command '.debug instancespawn' 
(cherry picked from commit 6ce078d8e8)
 2021-06-16 22:50:04 +02:00
ariel-
570b2b4ce0 Core/Scripts: reverted Auriaya spell script logic 
Thanks Shauren for spotting it

(cherry picked from commit 6dd465c441)
 2021-06-16 21:36:30 +02:00
ariel-
d0f4310c44 Core/Entities: don't allow client control if player is still affected by any lose of control state 
(cherry picked from commit e315e41d36)
 2021-06-16 21:26:57 +02:00
ariel-
c77925da4a Core/Entities: killed Creature::SetInCombatWithZone and replaced with AI version 
Closes #12108 (again)

(cherry picked from commit 7c9722a4ae)
 2021-06-16 21:03:06 +02:00
ariel-
861cf261c5 Core/Formations: update codestyle and fix crash 
Closes #21288

(cherry picked from commit 73cc613dc8)
 2021-06-16 19:26:32 +02:00
Kittnz
cd3425f6a6 Scripts/Outland: Fix logical error in Hellfire event in Honor Hold 
(cherry picked from commit 8f64612cb1)
 2021-06-16 14:32:07 +02:00
ariel-
85ffcd9826 Core/Scripts: fix wrong uses of SetHitDamage hook. 
This hook modifies damage AFTER it has been reduced by target auras/armor/resistances etc, it's useful if you want to scale damage by a factor, but not to add flat bonuses.
We're fixing those by moving calculation to Launch phase, where target taken bonuses haven't been used yet.

- Bronjahm: Magic's Bane
- BPC: Shadow Prison
- Oculus: Shock Lance
- Ymiron: Dark Slash (extra fix, it was wrongly damaging half of total health, it's supposed to be half of CURRENT health!)
- DK: Raise Ally Thrash spell (also extra fix: corrected formula)
- Warrior: Bloodthirst (shouldn't matter much as it's damage class none and those don't get bonuses by default)
- Warrior: Concussion Blow
- Warlock: extra fix for Haunt, healing part shouldn't scale with spell power

Closes #9560

(cherry picked from commit 9f5d1e2b10)
 2021-06-16 14:26:09 +02:00
Keader
18b0135bf7 Scripts/Utgarde Keep: Fixed Ingvar evade in phase 2 (again) 
Closes #21264

(cherry picked from commit 96983fc6bb)
 2021-06-16 12:45:57 +02:00
ariel-
62c571076e Core/Scripts: added nullptr checks to DamageTaken hooks 
Since cb9e72e521 attacker may not be in world when hook is called

(cherry picked from commit 0db5c2df3f)
 2021-06-16 12:02:14 +02:00
Treeston
ea79b55698 Scripts/AzjolNerub: Missing nullptr check in Hadronox. Closes #21258. 
(cherry picked from commit d9d26200f7)
 2021-06-16 11:49:03 +02:00
Treeston
6fb45e31c2 DB/SpawnGroup: instance_spawn_group data for map 576 (The Nexus) 
(cherry picked from commit 0319c713a4)
 2021-06-16 11:46:50 +02:00
Moein
6d7288356a Scripts/Spells: quest "That's Abominable" (#21253) 
- scripted spell "Burst At The Seams" (59576)
- added Pet Bar

Closes #10876

(cherry picked from commit e519e14df8)
 2021-06-16 11:32:25 +02:00
ariel-
bb7869b31f Core/Scripts: fix some spells double dipping from done/taken bonuses 
Closes #21007

(cherry picked from commit ab3307fc23)
 2021-06-16 11:22:10 +02:00
ariel-
3bc3b3eeeb Core/Globals: revert back to unordered_map for templates 
Partial revert of commit b64c504314
See discussion on b64c504314

(cherry picked from commit b75ff7d4bf)
 2021-06-16 01:29:25 +02:00
ariel-
21556667c1 Core/Globals: throw some RAII into ObjectMgr, and load templates into vectors 
Ref #14274

(cherry picked from commit b64c504314)
 2021-06-16 01:00:11 +02:00
sirikfoll
5b5bc4c5c7 Scripts/Scarlet Enclave: Quest The Endless Hunger will work correctly after Unworthy Initiate Respawn 
Due to dynamic spawns, we need to be able to update the Npc GUID after the respawn, otherwise the quest can only be completed by the first player

(cherry picked from commit 72ff2e30c3)
 2021-06-15 23:43:17 +02:00
Keader
ca07b1a25d Scripts/Pit of Saron: Tyrannus followup 
fix new issue caused by 947cb6a453

(cherry picked from commit 0b09e9ee4e)
 2021-06-15 23:41:11 +02:00
Keader
ed8d57e72d Scripts/Pit of Saron: Fixed Tyrannus not working after evade 
(cherry picked from commit 947cb6a453)
 2021-06-15 23:40:47 +02:00
Keader
6ba82b56dc Scripts/Trial Of The Crusader: Lord Jaraxxus rework (#21216) 
(cherry picked from commit a41cd41695)
 2021-06-15 23:32:57 +02:00
ariel-
5fbddef85f Core/Spell: SpellValueOverrides encapsulation 
- No sense to let scripts use SpellValueOverrides, we already have modifiers in CastSpellExtraArgs struct

(cherry picked from commit 3b01cccd7e)
 2021-06-14 00:19:50 +02:00
Kittnz
267aeddc05 Scripts/EasternKingdoms: implement Children of Goldshire event (#20745) 
* Script: Implement Childeren of Goldshire

Notes: Need to update waypoints and default location of the childeren
http://wowwiki.wikia.com/wiki/Children_of_Goldshire
(cherry picked from commit a9c853ee3f)
 2021-06-13 22:30:10 +02:00
ariel-
fccf1a8c62 Core/Auras: removed caster dependency from core 
- Decoupled Unit logic: split of spell critical chance into done (caster bonuses) and taken (target bonuses), this allows to precalculate caster bonuses on aura apply and then check victim's auras on damage/healing calc
- Made static a bunch of methods (they no longer have this pointer because they are now called from periodic handlers which may or may not have an active caster in world)
- Simplified all AuraEffect bonuses into AuraEffect::_amount, no more duplicated code
- Critical chance and whether or not caster is player owned unit (for resilience calcs) is now saved one level upper, on Aura itself (it's impossible as of 3.3.5 to have different effects with different critical chances)
- Minor cleanup of SPELL_DAMAGE_CLASS_NONE and Arcane Potency (#18813) crit handling

Closes #19876

(cherry picked from commit cb9e72e521)
 2021-06-13 00:59:13 +02:00
Shauren
f6b919fafe Core/Reputation: Named all reputation flags 2021-06-05 23:00:06 +02:00
Shauren
80a6347b7a Core/Reputation: Implemented "friendship reputation" 2021-06-04 19:27:26 +02:00