Commit Graph

1364 Commits

Author SHA1 Message Date
Seyden
79c6054369 Core/Objects: Use player as summoner for personal clones (#27716)
* This allows clones to properly inherit phases
2022-02-08 00:03:02 +01:00
Treeston
2aa9d9a67a Scripts/Commands: Correct some unexpected behavior in .level
(cherry picked from commit d2f51569d1)
2022-02-06 01:15:37 +01:00
Treeston
378691aaa2 [3.3.5] Core/ChatCommands: Show error messages from argument parsers (PR #25443)
(cherry picked from commit 75f9e7396e)
2022-02-05 23:42:15 +01:00
Treeston
7d0586812a Core/Misc: Fix some static analysis warnings exposed after 6b8f3d0.
(cherry picked from commit 59be657ca2)
2022-02-05 23:05:14 +01:00
jackpoz
0441f3ea5e Core/LFG: Restore ".lfg queue" command argument handling
(cherry picked from commit a46c835ed1)
2022-02-05 22:59:46 +01:00
Treeston
013c9b2cb7 Core/ChatCommands: make ExactSequence more readable
(cherry picked from commit feaaa595ca)
2022-02-05 21:29:53 +01:00
Peter Keresztes Schmidt
bdd4ccbd78 Core/ChatCommands: Drop PlayerIdentifier's cast operators which could return nullptr (PR #25431)
(cherry picked from commit 8985fc4046)
2022-02-05 21:25:23 +01:00
Peter Keresztes Schmidt
fd41de7ce3 Scripts/Commands: Convert argument parsing of lfg commands to new system (PR #25430)
(cherry picked from commit 0769d77269)
2022-02-05 20:59:38 +01:00
Peter Keresztes Schmidt
26f3c25dae Scripts/Commands: Convert remaining debug commands (PR #25429)
(cherry picked from commit 062c55f1ab)
2022-02-05 20:50:33 +01:00
Treeston
42be7836df Chat/Commands: Eradicate ChatHandler::extractOptFirstArg
(cherry picked from commit 4f636b80e4)
2022-02-05 16:21:54 +01:00
Treeston
1e9d60b4ac Scripts/Commands: .character command conversion
(cherry picked from commit 00dd337b5d)
2022-02-05 14:44:01 +01:00
Treeston
706163743d [3.3.5] Scripts/Commands: .arena command conversion (PR #25407)
(cherry picked from commit b63d655e20)
2022-02-05 13:57:50 +01:00
Treeston
4d62cc70d6 Scripts/Commands: Convert argument parsing of .npc commands
(And I snuck some chat command cleanup in there, more de-cluttering!)

(cherry picked from commit 88d446dadf)
2022-02-05 00:43:55 +01:00
Treeston
6fded37e86 Scripts/Commands: Convert argument parsing of gameobject commands
(cherry picked from commit 35b3ba90b0)
2022-02-05 00:24:39 +01:00
Treeston
a65e7e0213 Scripts/Commands: Fix a crash in .help - closes #25360
(cherry picked from commit 944f49d613)
2022-02-04 21:21:40 +01:00
Treeston
45e9e94311 Core/ChatCommands: C++17 cleanup (again) (PR #25323)
(cherry picked from commit 2f7d2ef3e9)
2022-02-04 21:21:17 +01:00
Giacomo Pozzoni
99ee958e0a Core/Misc: Fix issues reported by static analysis (#25351)
* Core/Misc: Fix issues reported by static analysis

* Core/Vmaps: Code cleanup after e777161888

(cherry picked from commit cfc8f7b442)
2022-02-04 12:18:15 +01:00
Treeston
9f97fdd31a Core/Common: Tokenizer -> Trinity::Tokenize (PR: #25327)
(cherry picked from commit 534a2388b7)
2022-02-04 00:27:14 +01:00
Treeston
be9dadc189 Common/Utilities: Centralize string -> T conversion in StringConvert.h (PR #25335)
(cherry picked from commit cd30e0b86c)
2022-02-04 00:27:13 +01:00
Treeston
0473beff2b Core/Misc: std::string -> std::string_view in a bunch of places, notably chat commands and Util.h
(cherry picked from commit a41bbd9ad9)
2022-02-04 00:27:12 +01:00
Peter Keresztes Schmidt
1a6564f42f Scripts/Commands: Convert argument parsing of some misc commands to new system (#25308)
* Core/Shared: Make WeatherType smart

* Scripts/Commands: Convert argument parsing of some misc commands to new system

(cherry picked from commit 5bab0e43c6)
2022-02-04 00:27:12 +01:00
Peter Keresztes Schmidt
53b28572bf Scripts/Commands: Convert argument parsing of cast commands to new system (#25309)
(cherry picked from commit cefac75a7d)
2022-02-04 00:27:12 +01:00
Peter Keresztes Schmidt
582b8458ea Scripts/Commands: Fix two unreachable code issues found by PVS-studio (#25311)
(cherry picked from commit 3262ef447a)
2022-02-04 00:27:12 +01:00
Peter Keresztes Schmidt
5675d62159 Scripts/Commands: Convert argument parsing of message commands to new system (#25305)
(cherry picked from commit f17b9b20f1)
2022-02-04 00:27:11 +01:00
Peter Keresztes Schmidt
e9209c3131 Scripts/Commands: Convert argument parsing of most list commands to new system (#25303)
(cherry picked from commit 522a4cb1a6)
2022-02-04 00:27:11 +01:00
Peter Keresztes Schmidt
86bfde389a Scripts/Commands: Convert argument parsing of event commands to new system (PR #25275)
(cherry picked from commit 7bfeb03c13)
2022-02-03 00:19:14 +01:00
Peter Keresztes Schmidt
3c82863c52 Core/ChatCommands: Check whether a passed numeric enum value is valid (#25285)
(cherry picked from commit 4286e7aa02)
2022-02-03 00:18:48 +01:00
Peter Keresztes Schmidt
3ba767c438 Scripts/Commands: Convert argument parsing of gm commands to new system (#25279)
(cherry picked from commit 9c9e8c7d58)
2022-02-03 00:10:31 +01:00
Peter Keresztes Schmidt
888d217c16 Scripts/Commands: Convert argument parsing of remaining go command to new system (#25284)
(cherry picked from commit 1aadf6c6d1)
2022-02-03 00:08:21 +01:00
Carbenium
a773039211 Scripts/Commands: Convert argument parsing of honor commands to new system
(cherry picked from commit 515a34f64f)
2022-02-02 23:02:41 +01:00
Treeston
eaa3c7e5a0 Core/Warden: Add .debug warden force, allowing you to force specific warden checks to be sent
(cherry picked from commit f04f4e91ff)
2022-02-02 22:47:55 +01:00
Peter Keresztes Schmidt
dc5f7ee5fc Scripts/Commands: Convert argument parsing of deserter commands to new system (PR #25276)
(cherry picked from commit c952cb7f71)
2022-02-02 22:32:46 +01:00
Peter Keresztes Schmidt
4aa1c74232 Scripts/Commands: Convert argument parsing of cheat commands to new system (PR #25277)
(cherry picked from commit 4707e05938)
2022-02-02 22:21:51 +01:00
Peter Keresztes Schmidt
ec26736e30 Scripts/Commands: Convert argument parsing of most debug commands to new system (PR #25260)
(cherry picked from commit 76f309b4e8)
2022-02-02 22:13:50 +01:00
Treeston
e0ddc676d6 Scripts/Commands: Move .debug asan command bodies inside #ifdef ASAN
(cherry picked from commit e18f7aaa4d)
(cherry picked from commit 0b13fc1926)
(cherry picked from commit 5ecbe93f7d)
2022-02-02 21:27:52 +01:00
Peter Keresztes Schmidt
37777ac6e8 Scripts/Commands: Convert argument parsing of ahbot commands (PR #25264)
(cherry picked from commit 426513ec8e)
2022-02-02 21:17:51 +01:00
Carbenium
c8b0d4e6d8 Scripts/Commands: Convert argument parsing of bf commands to new system
(cherry picked from commit fa6a8e8f64)
2022-02-02 20:50:49 +01:00
Treeston
673521bc87 Core/ChatCommands: Move Trinity::ChatCommands::Variant from boost::variant to std::variant (for real this time)
(cherry picked from commit ffc3e355fe)
2022-02-02 20:49:42 +01:00
Shauren
ca92686b44 Core/Pets: Pet management refactoring (#25191)
* Core/Pets: Pet management refactoring

* Preload basic pet data on character login with async query
* Load additional pet data (declined names/auras/spells/cooldowns) using async query after we are sure pet loading will succeed
* Remove all select queries related to pet stable/unstable
* Remove all silent pet deletions except explicit UI-triggered abandons
* Fixed displaying stable master content when current pet is not summoned
* Allow to stable/swap unsummoned current pet

Closes #3610
Closes #21266

(cherry picked from commit 5c1fc5e387)
2022-01-31 00:17:21 +01:00
Shauren
7044204130 Core/Objects: Cleanup SmoothPhasing code - move to separate files and better integrate it with visibility system 2022-01-29 20:35:25 +01:00
Peter Keresztes Schmidt
ec44c8296d Scripts/Commands: Use enum type arg for HandleDebugAnimCommand (PR #25256)
* Core/Shared: Make Emote enum smart
* Scripts/Commands: Use enum type arg for HandleDebugAnimCommand

(cherry picked from commit 86dc58974a)
2022-01-26 22:16:05 +01:00
Peter Keresztes Schmidt
3923650aeb Core/ChatCommands: Add support for enum type arguments (PR #25242)
(cherry picked from commit 5e40eb20e2)
2022-01-26 22:13:06 +01:00
Peter Keresztes Schmidt
2e3c612c80 Core/Unit: Make HandleEmoteCommand typesafe (#25249)
* Scripts/ScarletMonastery: Fix wrong emote during Headless Horseman encounter

* Scripts/HoR: Fix wrong emote during escape event

* Core/Unit: Make improve type safety of HandleEmoteCommand

Change argument type to the expected enum type Emote

* Scripts/CoS: Use SetUInt32Value to set UNIT_NPC_EMOTESTATE

UNIT_NPC_EMOTESTATE is no flag field

(cherry picked from commit 6c7837f947)
2022-01-26 21:46:51 +01:00
Treeston
319ddd9bcd Core/Warden: Warden refactors (PR #25235)
(cherry picked from commit 6116e5b385)
2022-01-26 19:42:11 +01:00
jackpoz
26894508ef Core/Misc: Code cleanup
(cherry picked from commit dd28cecda3)
2022-01-26 19:18:46 +01:00
jackpoz
b3f0d92b81 Scripts/Command: Fix .mmap loc always printing command usage
(cherry picked from commit 0eb49a3cc9)
2022-01-26 19:16:55 +01:00
Giacomo Pozzoni
ffd85f9139 Scripts/Comamnds: Improve ".debug objectcount" command (#25208)
* Scripts/Comamnds: Improve ".debug objectcount" command

Include the top 5 most common creatures in the map

* Use C++ features to copy data

* Fix build warnings

* Update src/server/scripts/Commands/cs_debug.cpp

Co-authored-by: Shauren <shauren.trinity@gmail.com>

* Update src/server/scripts/Commands/cs_debug.cpp

Co-authored-by: Shauren <shauren.trinity@gmail.com>

* Update src/server/scripts/Commands/cs_debug.cpp

Co-authored-by: Shauren <shauren.trinity@gmail.com>

* Move CreatureCountWorker out of function and use template for unhandled cases

* Code cleanup

Co-authored-by: Shauren <shauren.trinity@gmail.com>
(cherry picked from commit bd5e832a64)
2022-01-26 16:22:00 +01:00
Giacomo Pozzoni
864d775280 Core/Misc: Fix static analysis issues (#25194)
(cherry picked from commit 07fd84b679)
2022-01-26 14:06:40 +01:00
Giacomo Pozzoni
61bf51874d Core/Misc: Fix static analysis issues (#25178)
(cherry picked from commit 7cf122fc2a)
2022-01-24 20:21:25 +01:00
Carbenium
82fce41852 Core/WorldObject: Replace non-std::chrono SummonGameObject overloads
Also fix intended despawn time of GOs used by the "Engineering a Disaster" quest

(cherry picked from commit 8642aaaf92)
2022-01-24 12:55:43 +01:00