Commit Graph

15188 Commits

Author SHA1 Message Date
Matan Shukry
d2be584f99 Core/Commands: Implemented command to teleport character to npc
Closes #25870
2021-01-28 21:32:36 +01:00
offl
1ed79d7a2e Core/Scripts: Verify & migrate spell school immunities to DB
Some already are stored in DB. Looks like they all are still valid for master
2021-01-26 23:43:50 +02:00
Giacomo Pozzoni
7d6f7e4d19 Core/SAI: Add new action SMART_ACTION_SET_HEALTH_PCT (#25932)
* Core/SAI: Add new action SMART_ACTION_SET_HEALTH_PCT

Add new action SMART_ACTION_SET_HEALTH_PCT (142) with one single parameter "percent" to set the Unit health.
Close #25317

* Do not allow 0%
2021-01-25 21:27:57 +01:00
Meji
28353e920b Core/Spells: Fixed spell effect 43 (SPELL_EFFECT_TELEPORT_UNITS_FACE_CASTER) (#25945) 2021-01-25 18:40:34 +01:00
Giacomo Pozzoni
661f554b9e Core/Misc: Fix static analysis issues (#25924)
* Core/Misc: Fix static analysis issues

* Fix infinite loop in ".debug send opcode"
Fix using uninitialized memory in ".debug send opcode"
2021-01-24 16:04:47 +01:00
illfated
23cd884f3b DB/Item: Remove Plans: Goblin Rocket Boots (7192) from loot & exclude from being sold by AHbot
Closes #25930
2021-01-24 15:10:04 +02:00
jackpoz
d0231c5a8f Scripts/Commands: Improve ".debug objectcount"
Include the number of SetActive objects in ".debug objectcount" command
2021-01-23 15:54:25 +01:00
Giacomo Pozzoni
a22bc236eb Core/Creature: Add new db field InteractionPauseTimer (#25880)
* Core/Creature: Add new db field InteractionPauseTimer

Add new db field InteractionPauseTimer to allow to define different interaction pause timers for each creature (the previous system was a global setting in worldserver.conf Creature.MovingStopTimeForPlayer)

* Set all columns in creature_template_movement as optional (can be NULL, default NULL). Fill only the columns that should override the default C++ value

* Use the InteractionPauseTimer value throughout the code instead of Creature.MovingStopTimeForPlayer

* Handle InteractionPauseTimer set to 0 as "don't stop at all"

* Implement InteractionPauseTimer in creature_movement_override

creature_movement_override allows NULL values, in which case the values from creature_template_movement will be used for those columns that are NULL, falling back to default C++ values if creature_template_movement has NULL values too (or no rows for the creature)

* Read default InteractionPauseTimer from worldserver.conf

* Rename 2021_99_99_99_world.sql to 2021_01_22_00_world.sql
2021-01-22 19:48:50 +01:00
Jan Van Buggenhout
a832a1fe90 Core/Misc: Fix typo in SendAuthWaitQue method name (#25887) 2021-01-18 17:35:35 +01:00
Jan Van Buggenhout
ec689e7908 Core/Misc: Update WorldSocket::OnRead to WorldSocket::ReadDataHandler in comments and logging (#25885) 2021-01-18 17:27:36 +01:00
Jan Van Buggenhout
c7e03e4cef Core/PacketIO: Change size of SMSG_AUTH_CHALLENGE WorldPacket from 37 to 40 in WorldSocket::HandleSendAuthSession (#25886) 2021-01-18 17:23:41 +01:00
Matan Shukry
cdfa85957e Core/logs: added xp info on login & logout (#25867)
* Core/logs: added xp info on login & logout

* - Moved getters to header
- Changed %s to %u

(cherry picked from commit bb24c6a11b)

# Conflicts:
#	src/server/game/Entities/Player/Player.h
#	src/server/game/Handlers/CharacterHandler.cpp
#	src/server/game/Server/WorldSession.cpp
2021-01-17 17:45:00 +01:00
Shauren
ee330be5c8 Build fix
(cherry picked from commit 28d470c50e)

# Conflicts:
#	src/server/game/Entities/Unit/Unit.cpp
2021-01-17 17:29:59 +01:00
jackpoz
1939736060 Core/Spells: Defined new spell attributes
(cherry picked from commit b2ddf547ff)

# Conflicts:
#	src/server/game/Miscellaneous/SharedDefines.h
2021-01-17 17:29:54 +01:00
Keader
740a59d1cd Scripts/Priest: Fixed Lightwell getting removed in first damage
* Spell should drop charge, only when damage > 30% of total health.
2021-01-17 10:22:02 -03:00
offl
7b79adf5b1 DB/Creature: Remove UNIT_FLAG_STUNNED in more cases
Ref #25764
2021-01-15 01:53:43 +02:00
xvwyh
7c6d92012a Core/Spells: Correct swapped TARGET_UNIT_NEARBY_ALLY and TARGET_UNIT_NEARBY_PARTY (#25837)
* Update SharedDefines.h

* Update SpellInfo.cpp
2021-01-14 10:41:03 +01:00
Trond B. Krokli
cf5f360299 Update LootMgr.cpp (#25849)
Typo correction for console & log output `>> Loaded reference loot templates in %u ms`

`refence` --> `reference`
2021-01-14 10:16:12 +01:00
Jinnaix
26002c530f Scripts/Diremaul - Dire Maul crystal and forcefield fix (#25332)
* Scripts/Diremaul
Diremaul Crystal and Forcefield fix

* Apply suggestions from code review

Apply suggestions

Co-authored-by: MaxtorCoder <warsongkiller.s8@gmail.com>

* Fix stuff

* _private member

* use std array instead of c-arrays and standartized guid container namings

* Process feedback

* finalize

* blubb

* small changes

* whoops

* Process feedback

* Missing include

* Process feedback

* Apply suggestions from code review

Co-authored-by: Giacomo Pozzoni <giacomopoz@gmail.com>

* remove unused field

Co-authored-by: MaxtorCoder <warsongkiller.s8@gmail.com>
Co-authored-by: Ovah <dreadkiller@gmx.de>
Co-authored-by: Giacomo Pozzoni <giacomopoz@gmail.com>
2021-01-10 16:38:41 +01:00
Giacomo Pozzoni
fc1a0d9368 Core/Unit: Fix movement hiccups in water (#24020)
* Core/Unit: Allow to define Units which can enter water but cannot swim

Allow to define Units which can enter water but cannot swim, i.e. crabs walking at the bottom of a sea.

* Add UNIT_FLAG_SWIMMING to creatures when entering combat

* Fix charmed creatures not entering water

* Always allow Creatures controlled by players to enter water

* Add swimming flag when possessing a unit and remove it properly at the end, even if the creature engaged combat before and after.
When adding/removing UNIT_FLAG_SWIMMING manually calling Creature::RefreshSwimmingFlag(true) might be required.
2021-01-10 10:18:51 +01:00
offl
95a2b906b0 DB/Creature: Remove remaining UNIT_FLAG_PACIFIED part 1
Ref #25764
2021-01-10 01:21:05 +02:00
Kyle Phelps
817bd92a2a Split all addon chat logs into separate log streams (#25816)
* Split all addon chat logs into separate log streams

* Add missing channels

(cherry picked from commit ee6e71bbd3)

# Conflicts:
#	src/server/scripts/World/chat_log.cpp
2021-01-08 23:40:59 +01:00
wotlk-enthusiast
a225717b99 Scripts/Utgarde Pinnacle: Svala Sorrowgrave Intro and Ritual of the Sword (#24503)
* Scripts/Svala SorrowGrave - Fix broken intro event and Ritual of the Sword

* Added missing header for non-PCH build.

* Added error checking for Svala's targeting, and tightened up the timing on the intro event.

* Update WorldDB\Creature_Template_Movement for Svala

* Fix movement during intro and ritual event

* Rename SQL file for merge

Co-authored-by: Carbenium <carbenium@outlook.com>
2021-01-08 22:56:55 +01:00
offl
27722d42ef DB/Creature: Add UNIT_FLAG2_UNK1 (CREATURE_DIFFICULTYFLAGS_2_HIDE_BODY) 2021-01-08 00:49:18 +02:00
Mikhail Redko
a9db8a9b9a Scripts/Spells: Implement effect "Party Time" & Add Rejuvenation when eating Deviate Fish (#25802)
* Scripts/Spells: Implement effect "Party Time" & Add Rejuvenation when eating Deviate Fish

* Rename XXXX_XX_XX_XX_world.sql to 2021_01_06_08_world.sql

Co-authored-by: Giacomo Pozzoni <giacomopoz@gmail.com>
2021-01-06 20:47:58 +01:00
Mikhail Redko
65083dc936 Scripts/Spells: Implement hunter pet talent "Improved Cower" (#25804)
* Scripts/Spells: Implement hunter pet talent "Improved Cower"

Closes #25600

* Rename XXXX_XX_XX_XX_world.sql to 2021_01_06_07_world.sql

Co-authored-by: Giacomo Pozzoni <giacomopoz@gmail.com>
2021-01-06 20:43:20 +01:00
Treeston
de33d50c19 Core/Warden: Max packet size 500 -> 450 2021-01-04 23:52:50 +01:00
Shauren
8d450f3f07 Core/Commands: Add .reload vehicle_template
(cherry picked from commit 4ca15ec065)

# Conflicts:
#	sql/base/auth_database.sql
#	src/server/game/Accounts/RBAC.h
2021-01-03 22:51:53 +01:00
Sevi
6392d9ac48 Core/Vehicles: add a way to delay the Vehicle despawn Time if its needed.
* New database table `vehicle_template` holds info for despawn delay with option to extend it in the future

(cherry picked from commit c7b10d3c5f)

# Conflicts:
#	src/server/game/Entities/Unit/Unit.cpp
#	src/server/game/Entities/Vehicle/Vehicle.cpp
#	src/server/game/Globals/ObjectMgr.cpp
#	src/server/game/Globals/ObjectMgr.h
2021-01-03 22:10:55 +01:00
Kargatum
a32b6b8ac4 Core: whitespace cleanup, reduce double blank line to single (#25795)
* Core/Misc: fix double empty line

* worldserver.conf
2021-01-03 11:47:07 +01:00
Aurelio Arcabascio
4ea64b515a Core/Player: auto-attacked player stands up from sit or sleep state (#25684)
* Fixed Auto Attack bug on sitting player

* Victim now stands during sleep and stand emotes
2021-01-02 19:10:26 +01:00
Treeston
94c03b2107 Core/Maps: Move some more Map internals to actually be... internals. 2021-01-01 04:03:52 +01:00
Treeston
803dc789e4 Core/Maps: All RespawnInfo* handed to outside code are now RespawnInfo const*, to signify that outside code has zero business changing these. 2020-12-31 18:57:18 +01:00
Shauren
7d70fbc64c Core/RBAC: Reserve permission id 2020-12-31 12:52:31 +01:00
Giacomo Pozzoni
96b289cadb Core/SAI: Fix SMART_EVENT_FLAG_NOT_REPEATABLE flag being ignored when specifying a chance (and other SMART_ACTION_CAST fixes) (#25778)
* Core/SAI: Fix SMART_EVENT_FLAG_NOT_REPEATABLE flag being ignored when specifying a chance

Fix SMART_EVENT_FLAG_NOT_REPEATABLE flag being ignored when specifying a chance, always making the action trigger.

* Fix SMART_ACTION_CAST with SMART_EVENT_FLAG_NOT_REPEATABLE not casting the spell at all if rolled chance was successful but creature couldn't cast the spell

* Prevent linked actions if SMART_ACTION_CAST couldn't be completed and will be retried later
2020-12-30 21:18:00 +01:00
Treeston
f8afcec9f3 Core/Maps: move pooling hand-off outside of Map::CheckRespawn (PR#25785)
fixes #25777
2020-12-30 21:08:22 +01:00
jackpoz
0ad1854d1c Scripts/ICC: Fix teleporter not removing players from Gunship
A more generic solution might be better, maybe depending on spell flags

Ref #25652
2020-12-28 12:38:34 +01:00
Giacomo Pozzoni
aabd2b49e2 Core/Maps: Attempt to fix picking the wrong min height (#25771)
Close #25652
2020-12-28 12:36:52 +01:00
Sevi
a843d8b10c Core/Vehicles: Add missing caster guid check
Merges #25773

(cherry picked from commit e26122dc54)
2020-12-28 11:55:55 +01:00
Shauren
7817f18c24 Core/Vehicles: Treat entering other vehicles mounted on main vehicle as swapping seats
(cherry picked from commit 110564e757)
2020-12-28 11:55:55 +01:00
Shauren
fe89e835fb Core/SmartAI: Reserve a param for SMART_ACTION_SOUND master branch specific functionality, for compatibility reasons 2020-12-27 22:28:27 +01:00
jackpoz
ed1c0b6ec9 Core/Maps: Partially revert 0c69316714
Revert define to constexpr as this also broke some calculations
2020-12-27 20:22:35 +01:00
jackpoz
1e3d85e283 Core/Maps: Partially revert 0c69316714
The development will continue in a PR
2020-12-27 19:33:52 +01:00
jackpoz
01b1f20d3e COre/Misc: Remove whitespace 2020-12-27 19:28:31 +01:00
jackpoz
0c69316714 Core/Maps: Use the same logic to calculate grid coords to avoid mismatches
Use the same logic of (CENTER_GRID_ID - x / SIZE_OF_GRIDS) in GridMap::getMinHeight() as Map::GetGrid() to avoid coord grid mismatches caused by floating point precision, i.e. getting the wrong grid.
Replace defines with constexpr in grids to make debugging easier.

Closes #25652
2020-12-27 18:24:53 +01:00
jackpoz
9994459bd1 Scripts/Commands: Include map min height in ".gps" command 2020-12-27 17:14:22 +01:00
offl
f62306f52d Core/Scripts: Add missing spells to Black Morass 2020-12-27 03:13:40 +02:00
offl
8ca575ed52 DB/Spell: Add effects to more spells from Violet Hold
Turned out almost all spells from BM were copied to create Violet Hold. Not only serverside spells and not only their effects but also attributes and icons. The scripts were also copied, possibly unchanged
2020-12-27 03:06:31 +02:00
Ovah
527db2170b Core/Units: do not send power update packets when gaining power via energize spell effects to match retail behavior (#25599)
This fixes possible clientside visual issues where power is being added twice until the next update_object packet is being sent
2020-12-27 00:05:37 +01:00
Ovah
b7ba856b63 Core/SAI: implement new smart actions to change AI Animkits and to enable/disable hover movement (#25623)
* Core/SAI: implement new smart actions to change AI Animkits and to enable/disable hover movement for units

SMART_ACTION_SET_AI_ANIM_KIT (parameter 1: animKitId)
SMART_ACTION_SET_HOVER (parameter1: enable/disable)

* Update SmartScriptMgr.cpp

* Update SmartScript.cpp

* removed SMART_ACTION_SET_AI_ANIM_KIT since it's reserved for master
2020-12-26 23:31:25 +01:00