Treeston
f8afcec9f3
Core/Maps: move pooling hand-off outside of Map::CheckRespawn (PR#25785)
...
fixes #25777
2020-12-30 21:08:22 +01:00
jackpoz
0ad1854d1c
Scripts/ICC: Fix teleporter not removing players from Gunship
...
A more generic solution might be better, maybe depending on spell flags
Ref #25652
2020-12-28 12:38:34 +01:00
Giacomo Pozzoni
aabd2b49e2
Core/Maps: Attempt to fix picking the wrong min height ( #25771 )
...
Close #25652
2020-12-28 12:36:52 +01:00
Sevi
a843d8b10c
Core/Vehicles: Add missing caster guid check
...
Merges #25773
(cherry picked from commit e26122dc54
2020-12-28 11:55:55 +01:00
Shauren
7817f18c24
Core/Vehicles: Treat entering other vehicles mounted on main vehicle as swapping seats
...
(cherry picked from commit 110564e757
2020-12-28 11:55:55 +01:00
Shauren
fe89e835fb
Core/SmartAI: Reserve a param for SMART_ACTION_SOUND master branch specific functionality, for compatibility reasons
2020-12-27 22:28:27 +01:00
jackpoz
ed1c0b6ec9
Core/Maps: Partially revert 0c69316714
...
Revert define to constexpr as this also broke some calculations
2020-12-27 20:22:35 +01:00
jackpoz
1e3d85e283
Core/Maps: Partially revert 0c69316714
...
The development will continue in a PR
2020-12-27 19:33:52 +01:00
jackpoz
01b1f20d3e
COre/Misc: Remove whitespace
2020-12-27 19:28:31 +01:00
jackpoz
0c69316714
Core/Maps: Use the same logic to calculate grid coords to avoid mismatches
...
Use the same logic of (CENTER_GRID_ID - x / SIZE_OF_GRIDS) in GridMap::getMinHeight() as Map::GetGrid() to avoid coord grid mismatches caused by floating point precision, i.e. getting the wrong grid.
Replace defines with constexpr in grids to make debugging easier.
Closes #25652
2020-12-27 18:24:53 +01:00
jackpoz
9994459bd1
Scripts/Commands: Include map min height in ".gps" command
2020-12-27 17:14:22 +01:00
offl
f62306f52d
Core/Scripts: Add missing spells to Black Morass
2020-12-27 03:13:40 +02:00
offl
8ca575ed52
DB/Spell: Add effects to more spells from Violet Hold
...
Turned out almost all spells from BM were copied to create Violet Hold. Not only serverside spells and not only their effects but also attributes and icons. The scripts were also copied, possibly unchanged
2020-12-27 03:06:31 +02:00
Ovah
527db2170b
Core/Units: do not send power update packets when gaining power via energize spell effects to match retail behavior ( #25599 )
...
This fixes possible clientside visual issues where power is being added twice until the next update_object packet is being sent
2020-12-27 00:05:37 +01:00
Ovah
b7ba856b63
Core/SAI: implement new smart actions to change AI Animkits and to enable/disable hover movement ( #25623 )
...
* Core/SAI: implement new smart actions to change AI Animkits and to enable/disable hover movement for units
SMART_ACTION_SET_AI_ANIM_KIT (parameter 1: animKitId)
SMART_ACTION_SET_HOVER (parameter1: enable/disable)
* Update SmartScriptMgr.cpp
* Update SmartScript.cpp
* removed SMART_ACTION_SET_AI_ANIM_KIT since it's reserved for master
2020-12-26 23:31:25 +01:00
Gildor
8217519ea2
Core/Visibility: Split BG/Arena visibility settings ( #25690 )
2020-12-26 23:30:16 +01:00
Giacomo Pozzoni
3b2c878dd0
Core/Spells: Implemented personal summons ( #19231 ) ( #25765 )
...
* Core/Spells: Implemented personal summons (#19231 )
* By default determined by summon property flag SUMMON_PROP_FLAG_PERSONAL_SPAWN
Closes #18254
(cherry picked from commit b7bb5e6a98
2020-12-26 22:32:01 +01:00
offl
bb94aec975
Core/Scripts: Add missing spells to Violet Hold
2020-12-26 02:12:39 +02:00
Treeston
c8c572d980
Game/ChatCommands: Make sure ChatHandler::extractPlayerTarget populates the strtok buffer for non-nullptr returns. Closes #25692 , supersedes #25698 .
2020-12-10 15:23:58 +01:00
jackpoz
1c08395e8a
Core/Movement: Add a debug log when a player falls below the map
2020-12-09 19:52:12 +01:00
offl
cc98f68ac7
DB/Creature: Properly apply CREATURE_FLAG_EXTRA_NO_SKILLGAIN
...
Closes #25674
2020-12-08 13:09:20 +02:00
Giacomo Pozzoni
a4e93d779c
Improve multithreading of mmaps_generator ( #25625 )
...
* Build/Misc: Add a few *San CMake flags
Add the following flags for the related tools:
- MSAN for Memory Sanitizer
- UBSAN for Undefined Behavior Sanitizer
- TSAN for Thread Sanitizer
* Remove unused parameter
* Fix UBSan reported issue
* Disable G3D buffer pools when using Thread Sanitizer as it has its custom locking mechanisms
* Code cleanup
* Move threads from maps to tiles
* Move tile building logic to TileBuilder class
* Fix memory leak in TileBuilder
* Fix build
* Store TileBuilder as raw pointer for now, it will be changed later on to use modern C++ constructs
* Fix crash on shutdown
* Revert pvs-studio change
* Fix generating 1 single tile not closing the program
2020-12-06 17:52:13 +01:00
offl
6af54eb508
DB/Instance/Arcatraz: More adjustments
2020-11-26 02:25:47 +02:00
jackpoz
5270ff58da
Core/Player: Adjust fall damage log
...
Move fall damage log to "entities.player.falldamage" category and include the usual debug info
2020-11-21 16:33:00 +01:00
Treeston
cc8287927b
[3.3.5] Scripts/Commands: .learn adjustments (PR #25454 )
2020-11-18 20:09:34 +01:00
Ovah
4abbeb2a60
Core/Maps: add new FLAG_ALLIANCE_ONLY and FLAG_HORDE_ONLY for instance spawn groups (PR #25656 )
2020-11-17 23:41:15 +01:00
Ovah
850b88546f
Scripts/Misc: Use InstanceMap* in InstanceScript instead of Map* ( #25655 )
...
# Conflicts:
# src/server/game/Instances/InstanceScript.cpp
# src/server/game/Instances/InstanceScript.h
# src/server/scripts/EasternKingdoms/BlackrockMountain/BlackrockCaverns/instance_blackrock_caverns.cpp
# src/server/scripts/EasternKingdoms/MagistersTerrace/instance_magisters_terrace.cpp
# src/server/scripts/EasternKingdoms/TheStockade/instance_the_stockade.cpp
# src/server/scripts/EasternKingdoms/ZulGurub/instance_zulgurub.cpp
# src/server/scripts/Kalimdor/CavernsOfTime/CullingOfStratholme/instance_culling_of_stratholme.cpp
# src/server/scripts/Maelstrom/Stonecore/instance_stonecore.cpp
# src/server/scripts/Outland/BlackTemple/instance_black_temple.cpp
Co-authored-by: Shauren <shauren.trinity@gmail.com >
2020-11-17 19:45:13 +01:00
offl
be6941cd0c
DB/Spells: Move conditions for spell 'Gor'drek's Ointment' from item script to DB
2020-11-11 04:27:44 +02:00
offl
ed8bf7f0e2
DB/Creature: Convert & update support for Tonk Mine to SAI
2020-11-11 04:25:54 +02:00
offl
05fa1a46b3
DB/Quest: Update support for 'Merciful Freedom' (11676)
2020-11-10 00:37:35 +02:00
offl
dc4cb8f1d3
DB/Quest: Convert & update support for 'Prison Break' (11587) to SAI
2020-11-10 00:36:00 +02:00
offl
e5fd5cc031
DB/Quest: Convert & update support for 'The Spider God' & 'Hive in the Tower' to SAI
2020-11-09 04:19:11 +02:00
offl
a2da08deb1
DB/Instance/The Arcatraz: Update auras, scripts & stats
2020-11-08 00:25:13 +02:00
Keader
be8b251b58
build fix
2020-11-05 12:57:36 -03:00
Keader
83e0a70ddc
Scripts/Black Temple: Some little fixes
...
- Fixed Reliquary of Souls ignoring boundary
- Fixed Maiev texts timer
- Fixed Shadow Prison hitting every single npc on black temple
Many thanks to Ovahlord
2020-11-05 12:05:14 -03:00
Shauren
b57530ebb1
Core/Commands: Exclude ambigious cast operator overloads from command Variant
...
Closes #25618
2020-10-30 13:36:14 +01:00
Keader
3c201b7554
Scripts/ScarletMonastery: Decrease boss number
...
Headless Horseman do not use BossAI anymore (since it can be done multiple times)
2020-10-28 11:59:41 -03:00
Keader
a93abcf803
Scripts/ScarletMonastery: Headless Horseman Rewrite ( #25614 )
2020-10-26 14:04:36 -03:00
jackpoz
28a1132211
Core/AI: Fix CorpseRemoved() and SMART_EVENT_CORPSE_REMOVED not being called for creatures without m_respawnCompatibilityMode
...
Fixes #24958
2020-10-25 13:29:58 +01:00
Giacomo Pozzoni
d7459ccced
CI/GitHub: Switch to GCC 8 ( #25610 )
...
* CI/GitHub: Switch to GCC 8
Build on GitHub Actions using GCC 8 as it's the oldest supported GCC
* Core/Misc: Attempt to fix GCC 8 build
2020-10-25 10:31:29 +01:00
Trond B. Krokli
22a1797731
Scripts/Stormwind City: Tyrion talks to player ( #25613 )
...
Add player parameter to the `Talk()` command to resolve an issue where
the creature_text `SAY_TYRION_1` shows $n in-game during the course of
events of the quest "The Attack!" in Stormwind City.
Soon to be replaced by SAI scripting. This is a temp solution.
Ref. #25608 & #24735
Co-authored-by: Giacomo Pozzoni <giacomopoz@gmail.com >
2020-10-25 10:10:07 +01:00
offl
7fd12cc722
DB/Instance/AQ40: Update gossips
...
Closes #25577
2020-10-25 01:35:35 +03:00
Shauren
53482f7299
Core/DBLayer: Fixed memory leaks with existing SQLQueryHolder uses and eliminated the possibilty of adding more in future (replaced manual memory management with smart pointers)
2020-10-24 17:37:24 +02:00
Keader
5e9a856ad7
Game/Player: Fixed Backlash/Backdraft priority ( #25564 )
...
Update #18516
2020-10-19 11:27:02 -03:00
Keader
5fee99bdbc
Scripts/ICC: Some fixes in Valkyr Shadowguard ( #25572 )
...
- Added missing transformation spell
- Fixed Soul Siphon casted in random targets. It should always cast in top threat player.
- Fixed combat reach of transformation
2020-10-14 08:31:15 -03:00
Treeston
684910a230
AI/CreatureAI: Properly update Victim even while spell focusing
2020-10-13 23:44:37 +02:00
Keader
3c0766df54
Scripts/ICC: Fixed Chocking Gas killing Abomination ( #25565 )
2020-10-12 19:56:56 -03:00
Gildor
b70314b075
Script/Commands: .character changeaccount now disconnects player before transferring (PR #25560 )
2020-10-12 20:16:23 +02:00
Keader
182fcc919e
Scripts/UtgardPinnacle: Implemented Beast's Mark ( #25557 )
2020-10-11 13:35:33 -03:00
Keader
dadc0c98c0
Scripts/IcecrownCitadel: Implemented Vampiric Might spell ( #25556 )
...
Closes #21294
2020-10-11 13:33:02 -03:00
