aboutsummaryrefslogtreecommitdiff
path: root/src
AgeCommit message (Collapse)Author
2021-06-19Core/Spells: fix logic error causing near teleports to drop combat for playersariel-
Closes #21362 (cherry picked from commit 65709e1c3081c97442792695cbc0f0826015d625)
2021-06-19Core/Spells: fix logic error causing near teleports to drop combat for playersariel-
Closes #21362 (cherry picked from commit 65709e1c3081c97442792695cbc0f0826015d625)
2021-06-19Core/Spells: remove duplicated LowerPlayerDamageReq call on reflected spellsariel-
- It is already called at Unit::DealDamage (cherry picked from commit e979a58d17081edb2a8bbba81b8ff1f80472b42c)
2021-06-19Core/Threat: Custom ThreatListIterator that transparently iterates over the ↵Treeston
backing map (instead of using heap iterators) when working with the unsorted threat list. This greatly reduces the range of actions that can cause iterator invalidation. Also some minor adjustments to .debug threat, which no longer hides certain invalid states from view. (cherry picked from commit 4cb13af4faff0c1f9dbda2ab6a86882b4e4201a6)
2021-06-19Core/Spells: fix SPELLMOD_DAMAGE application order for melee spellsariel-
Closes #20597 (cherry picked from commit 2d2c43f4b91fef6fcd4d8c069a9bb41d66c97efe)
2021-06-19Core/Spells: kill unused parameter from Spell constructorariel-
Added in 1f2292af796d4b424bf45711ae8c50e764cf0d61 (cherry picked from commit 9fc732eb97271885568598fc38353cd809043d34)
2021-06-19Core/AI: Fix assertion triggered with PetAI derived scripts (#21254)jackpoz
* Core/AI: Fix assertion triggered with PetAI derived scripts Fix an assertion triggered when spawning through ".npc add" or from SQL db table a Creature with AI set to a custom AI inheriting from PetAI. (cherry picked from commit 95a76a83fcbad0e52c6013697544e3c5691e7e24)
2021-06-19Scripts/Ulduar: Flame Leviathan used a very weird mixture of victim logic ↵Treeston
and REACT_PASSIVE, which broke during transition to the new system. Replaced with a working version. Closes #21265. (cherry picked from commit b3e0c892385c7f75a061feef08c3ac05b53b4e2e)
2021-06-19AI/SmartAI: Remove a silly incorrect piece of code that was breaking react ↵Treeston
state swaps on SAI creatures. Fixes #21353. (cherry picked from commit 6e0df9fce1e1f4de3ffa97bf9ef711f13f2b9a55)
2021-06-19Scripts/ICC: Valithria Dreamwalker's script no longer despawns unrelated ↵Treeston
mobs in Frostwing Halls, and thus won't get them stuck in a despawned state due to linked_respawn. Closes #21286. (cherry picked from commit aefc25482f79e07e1237cc0a6c01e7064fd745be)
2021-06-19Scripts/Icecrown Citadel: Corrected Val'kyr Shadowguard positioning on ↵sirikfoll
heroic mode (Lich King) Movement was being prevented by spell cast (cherry picked from commit a217c0be922f7a14bf78acb87aaaef5bc99afe95)
2021-06-19Spell/Script: Torch 52953 and 58121 must hit only one targetKillyana
(cherry picked from commit 8f71307e5619c8ef1801488812e20d07714fd733)
2021-06-19Core/Creature: Adjust SelectVictim behavior: (PR #21324)Treeston
- No more automatic combat -> threat promotion. This matches anecdotal retail behavior - spells already in transit will not cause mob to chase you if its primary target vanishes before the spell hits. - Prevent mobbing by stopping creatures from auto-acquiring a nearby target just because the primary target vanished. (cherry picked from commit 1acfefb973895b0e3df3c8d9b43b920d2a1b5392)
2021-06-19Scripts/Pets: Mirror Image re-write, because it's a colossal mess right now. ↵Treeston
(PR #19818) (cherry picked from commit 03ef79f3d9e323030c771e97863398c43f6cb3a4)
2021-06-19Combat/Threat: Now set engaged state for all units on offline reference ↵Treeston
registration (vanished/invis'd units). For non-PASSIVE units, this will immediately cause an evade. This fixes an exploit where creating the reference as offline (by vanishing while a spell was mid-flight) you could damage a creature further without it ever engaging you. (cherry picked from commit 24024062280e6963f713348baba2b8c69437891a)
2021-06-19Game/AI: Remove some unused old logic.Treeston
(cherry picked from commit c69584a9673ac2edb95b930c024fbd15374cb185)
2021-06-19Scripts/Icecrown Citadel: Added missing cosmetic colors and emotes to Big ↵Shauren
Ooze (Rotface) (cherry picked from commit aaab7ba9f4e08ba5b7d7ac2f4e37e07d80c8f339)
2021-06-19Quest/script: Freedom to RuulKillyana
Follows https://github.com/TrinityCore/TrinityCore/commit/4dc91429dd2158c75679d07c34a18a2e12b4ef7a (cherry picked from commit 52fc5a572b037a9aee084be7f5bcc9bb7d84c0e9)
2021-06-19DB/Quest: Freedom to RuulKillyana
Closes #7262 (cherry picked from commit 4dc91429dd2158c75679d07c34a18a2e12b4ef7a)
2021-06-18Core/Creature: add an assertion to guard against infinite loopsTreeston
(cherry picked from commit 320306554c2240c74d991f459e7bad5eef39ec5a)
2021-06-18Core/Misc: Sort stringAokromes
(cherry picked from commit 4130647bf6bb278c655c5d90569dfa322d0322f9)
2021-06-16DB/SpawnGroup: Instance spawn group data for Tempest Keep: The Eye and ↵Treeston
Hellfire Citadel: Ramparts. (also some minor adjustments to command output for convenience) (cherry picked from commit 51e28ae76a40bb40bdd6f163773d2e3bd8f76ec4)
2021-06-16Misc: assert -> ASSERTTreeston
(cherry picked from commit 6c3c200cc52397b4b32ed76e676830e9f1d67d4c)
2021-06-16Scripts/Commands: new command '.debug instancespawn'Treeston
(cherry picked from commit 6ce078d8e885f61ebdff3eb905e4cf6a2911da90)
2021-06-16Core/Spell: killed deprecated code which randomly changed powercost for ↵ariel-
missed spells Added in 80d3cd43f65e4e7cecfdd17e53c6a4542ddc4e40 Closes #5954 (cherry picked from commit b1072faa50493e287b5353056753d65ddcc445f3)
2021-06-16Core/Scripts: reverted Auriaya spell script logicariel-
Thanks Shauren for spotting it (cherry picked from commit 6dd465c4414b95c3540f38ed67eae2f6bc71a3c3)
2021-06-16Core/Player: only call _ApplyWeaponDamage for actual weaponsariel-
Closes #21308 (cherry picked from commit 8e0af1b93bed87753e89aebefba3fbb085f40565)
2021-06-16Core/Entities: don't allow client control if player is still affected by any ↵ariel-
lose of control state (cherry picked from commit e315e41d36061fc88dfa09bfa0da1fbc0c00826f)
2021-06-16Core/Entities: killed Creature::SetInCombatWithZone and replaced with AI versionariel-
Closes #12108 (again) (cherry picked from commit 7c9722a4ae08b5f283f6a085a411e37604a7da9f)
2021-06-16Core/Entities: don't allow client control if player is still affected by any ↵ariel-
lose of control state (cherry picked from commit e315e41d36061fc88dfa09bfa0da1fbc0c00826f)
2021-06-16Core/PlayerAI: perform cast checks on auto ranged attackariel-
Closes #19928 (cherry picked from commit 590d2518820d45e54a4a31cc554af18c0695bcd0)
2021-06-16Core/Unit: fixed Global cooldown cancelation on spell interruptariel-
Thanks to Nyeriah for the heads up (cherry picked from commit 514c847881a9fff504e90f1186a1209c0b8a3674)
2021-06-16Core/Formations: update codestyle and fix crashariel-
Closes #21288 (cherry picked from commit 73cc613dc86d7d72d78f22affe2faba6786bccc5)
2021-06-16Core/Spells: fix Spirit of Redemptionariel-
- Who would have suspected GetAuraEffect (iconId override) did a check against null spellfamilyflags? - Remove mirror timers hack (triggered spell already allows underwater breathing) (cherry picked from commit 4402f71eb7d17e5cf6b768a452baa00555eff7e4)
2021-06-16Core/Misc: corrections and indentations in Language.htkrokli
- corrected the comment "1205-2002 - free" to "1205-1999 - free" - increased the main indent by 2 spaces to get more lines aligned - corrected the enum LANG_DO_NOT_USE_6X_DEBUG_AREATRIGGER_LEFT from 1999 to 1199 Ref. commit 5f541491074765a346c7d0a83edb5f1fbf9240b1 (cherry picked from commit ba5f6a861652f522dd10fbe31f5e25272a3cd237)
2021-06-16Core/Unit: Remove a superfluous threat state update in SetPhaseMask.Treeston
(cherry picked from commit 2c86c78f04f7cb95c201592b8d3002525eb6a46f)
2021-06-16Scripts/Outland: Fix logical error in Hellfire event in Honor HoldKittnz
(cherry picked from commit 8f64612cb12d2ceabf610a436e7b514acdc1b181)
2021-06-16Core/Threat: Assistance threat (healing, buffs, etc.) is now properly split ↵Treeston
(instead of copied) between all creatures threatened by the action. Thanks to Foereaper for help with testing, and my apologies to healers everywhere. (No apologies for charm AI though. You deserve that one.) (cherry picked from commit 013d4560c784b1deced9cd2ea11606eaf6b44f2d)
2021-06-16Core/Threat: Passive creatures now properly become engaged when adding an ↵Treeston
offline threat entry. Fixes RoS and Thaddius, maybe more. Closes #21269. (cherry picked from commit a3732756121be6d5621fb42bc7a71882a28f03a6)
2021-06-16Core/Scripts: fix wrong uses of SetHitDamage hook.ariel-
This hook modifies damage AFTER it has been reduced by target auras/armor/resistances etc, it's useful if you want to scale damage by a factor, but not to add flat bonuses. We're fixing those by moving calculation to Launch phase, where target taken bonuses haven't been used yet. - Bronjahm: Magic's Bane - BPC: Shadow Prison - Oculus: Shock Lance - Ymiron: Dark Slash (extra fix, it was wrongly damaging half of total health, it's supposed to be half of CURRENT health!) - DK: Raise Ally Thrash spell (also extra fix: corrected formula) - Warrior: Bloodthirst (shouldn't matter much as it's damage class none and those don't get bonuses by default) - Warrior: Concussion Blow - Warlock: extra fix for Haunt, healing part shouldn't scale with spell power Closes #9560 (cherry picked from commit 9f5d1e2b10013e5fecf35fdd5af70921c96d07d1)
2021-06-16Scripts/Utgarde Keep: Fixed Ingvar evade in phase 2 (again)Keader
Closes #21264 (cherry picked from commit 96983fc6bb0bf0793d9a8da970009f346d8cdb62)
2021-06-16Core/Auras: fixed EquippedItemClass checkariel-
follow-up to 29c3b7d8f60c18e52ec22fec6de9abc3dc468166 (cherry picked from commit f1896144c00e9dc8f37590207feb8d7714e7132f)
2021-06-16Core/Auras: Don't remove shield only dependant auras on disarmariel-
Closes #19782 (cherry picked from commit b8c281f497d5da2251b11ab09f182a23a5721a1c)
2021-06-16Core/Auras: define and implement attribute SPELL_ATTR3_NO_PROC_EQUIP_REQUIREMENTariel-
Closes #20148 (cherry picked from commit 29c3b7d8f60c18e52ec22fec6de9abc3dc468166)
2021-06-16Core/Scripts: added nullptr checks to DamageTaken hooksariel-
Since cb9e72e521d3cc415dd15bf6912c87f89e41b92a attacker may not be in world when hook is called (cherry picked from commit 0db5c2df3fe56f42293865e87ec781cd4d41598b)
2021-06-16Scripts/AzjolNerub: Missing nullptr check in Hadronox. Closes #21258.Treeston
(cherry picked from commit d9d26200f7ffc07507dfca4a2c17fdfcde0194c8)
2021-06-16DB/SpawnGroup: instance_spawn_group data for map 576 (The Nexus)Treeston
(cherry picked from commit 0319c713a40489f7e29762cfdfbaa2df7701d4ab)
2021-06-16Scripts/Spells: quest "That's Abominable" (#21253)Moein
- scripted spell "Burst At The Seams" (59576) - added Pet Bar Closes #10876 (cherry picked from commit e519e14df8d846285f1d29fb7e5aa0b151c6f74e)
2021-06-16Core/CombatAI: Npcs with TurretAI will be able to attack againsirikfoll
Needed after the new Threat system (cherry picked from commit e12e0ad5827d7e794baa630724069680d7e07cfb)
2021-06-16Core/Player: Pass correct Zone ID to HandlePlayerLeaveZonesirikfoll
This will fix some issues with Wintergrasp, like phasing auras getting stuck and missing group invites for the battle, among others (cherry picked from commit ed9e220991e2aa3fa2d50359608fd27057cafbbc)