7915 Commits

Author SHA1 Message Date
Treeston
f02ff3bd6b [3.3.5] Azjol-Nerub rewrite
* Scripts/AzjolNerub: Complete rewrite.
- Gatewatcher:
  - Trash now actually engages properly one by one
  - Fix trash spell casting
  - Add missing quotes
- Hadronox:
  - Everything. Literally.
- Anub'arak:
  - Fix add spawns
  - Fix impale
  - OK this might as well be "fix everything with every boss". Because that's pretty much what happened.
- General hack cleanup

* Update and rename 9999_99_99_99_AZJOLNERUB.sql to 2016_09_25_01_world.sql

* Update and rename 2016_09_25_01_world.sql to 2016_09_25_02_world.sql

* Rename 2016_09_25_02_world.sql to 2016_09_26_02_world.sql

(cherry picked from commit 4b990eb7d7)

# Conflicts:
#	src/server/game/Spells/SpellMgr.cpp
#	src/server/scripts/Northrend/AzjolNerub/AzjolNerub/azjol_nerub.h
#	src/server/scripts/Northrend/AzjolNerub/AzjolNerub/boss_anubarak.cpp

Update boss_hadronox.cpp
(cherry picked from commit 04ec868768)

Update boss_hadronox.cpp

I hate travis, learn from buildbot
(cherry picked from commit aeb20951bb)

I think I got all of them this time

No idea how this one got past travis.
(cherry picked from commit ae163197a7)

Fix nonPCH.
(cherry picked from commit e121d66fbb)

...for real this time (seriously - what happened to test builds before merging, Aok?)
(cherry picked from commit dbe0789eba)

.....hail PCH
(cherry picked from commit 2528194cc1)

and you get a header, and everyone gets a header...
(cherry picked from commit 5e5fe37a7e)
2017-03-04 00:05:55 +01:00
joschiwald
e465465c67 Fixed build 2017-03-03 23:28:12 +01:00
SnapperRy
6b8cb42b1e Script/Quest: Trail of Fire (#17939)
(cherry picked from commit 31e495f44c)

Rename 9999_99_99_99_world.sql to 2016_09_25_03_world.sql
(cherry picked from commit 28968c6162)

DB/SAI: fix db errors introduced in 31e495f.
(cherry picked from commit 2452fb977b)

Core/Scripts: Fix build
(cherry picked from commit 6174091d76)
2017-03-03 22:55:23 +01:00
tkrokli
e13fadf8e9 Core/Scripts: move #define to enum/boss emote to DB (#17967)
boss_lurker_below.cpp : remove deprecated #define entries
- remove hardcoded text, use creature_text/broadcast_text
- move #define value & text reference to enum section
- replace TextEmote() with Talk() pointing to DB entry
(cherry picked from commit cd6fcce84b)
2017-03-03 22:31:29 +01:00
jackpoz
9d09307e34 Scripts/ICC: Fix chest loot exploit
Fix an exploit at chest loot bosses Valithria and Deathbringer that allowed the first played to hit them to leave party at low hp % and loot the whole chest alone, without the party being able to loot anything.

(cherry picked from commit c4865fe63e)

# Conflicts:
#	src/server/game/Entities/GameObject/GameObject.cpp
2017-03-03 22:31:28 +01:00
tkrokli
958665ab2e Core/Scripts: move npc_lunaclaw_spirit to SAI
This PR moves the core script `npc_lunaclaw_spirit` to SAI, removing hardcoded text.
The quests 6001 + 6002 are druid class quests to get bear form, removed in patch 4.0.3a

Changes in this PR:
- remove core script, including hardcoded text (with typo)
- use gossip_menu_option for each faction (Alliance & Horde)
- add SAI script to complete quest 6001 or 6002 based on option
- add gossip option conditions for team A (469) or team H (67)
- add gossip option conditions for quest 6001/6002 not completed

(cherry picked from commit 3ad76dea7b)
2017-03-03 21:57:23 +01:00
SnapperRy
6ad12301b4 Script/Quest: The Exorcism of Colonel Jules:
- Summoned NPCs will no longer give experience on kill.
- Require quests Fel Spirits and Digging for Prayer Beads to be completed.
- Reduce number of Foul Purges spawned in a single wave (only two should spawn each time).
- Properly give quest credit when talking with Colonel Jules after the exorcism.

(cherry picked from commit 0d70a7349d)
2017-03-03 21:55:01 +01:00
treeston
6a7ef793ca Scripts/IcecrownCitadel: Fix an issue where Deathbringer Saurfang's exit door could get stuck in a closed state. Fixes and closes #15018.
(cherry picked from commit 429700e614)
2017-03-03 21:51:36 +01:00
Keader
f6c9aff606 Core/Scripts: XT002 improvements in Hard Mode. Closes #17141. (PR #17900)
(cherry picked from commit 1f83412e4d)
2017-03-03 21:51:16 +01:00
treeston
205ec4c3bf Core/Unit: Standardize SetFacingTo and SetFacingToObject behavior while moving. Both now fail while moving unless arg2 bool is true.
Movement/SplineChain: Bump value range for DB chainId up to uint16 (0 to 65535) from uint8 (0 to 255). Turns out sniffs generate far more chains than I expected.

(cherry picked from commit 2170541a51)

Code style follow-up, I blame Notepad++.
(cherry picked from commit 7860da0de6)
2017-03-02 20:47:29 +01:00
treeston
b94642fb49 Instance/Naxxramas: Loatheb no longer instantly murders you. Five spam casts of Doom tend to do that to raids.
(cherry picked from commit 59527521e6)

5952752 follow-up: Member declaration now matches order of usage.
(cherry picked from commit 3298a5f65d)
2017-03-02 20:44:41 +01:00
treeston
59d48ce7e4 Core/Movement: Add new SplineChainMovementGenerator that allows accurate replication of sniffed waypoints in static sequences, along with DB facilities that allow loading of waypoints from DB.
(cherry picked from commit 6d00d3f283)

Merge remote-tracking branch 'Treeston/3.3.5-splinechains' into 3.3.5 (PR #17946)
(cherry picked from commit 20f483967f)

Core/Movement: Add a convenience default ctor to SplineChainResumeInfo, and fix PCH build in some configurations (zzz why do we even keep Appveyor and Travis around).
(cherry picked from commit 4fa646c0b2)

PCH build fix. Again.

(( Alright, you made me waste 20 minutes of my life on a full nonPCH rebuild of the core now. ))
(( I hope you're happy. ))
(cherry picked from commit 4a1a460241)
2017-03-01 22:03:35 +01:00
tkrokli
e4e1f4152f Core/Scripts: simplified npc_pet_trainer gossip script
This is what the script changes should have been in PR #17746
(also updates issue #14719 with a correct solution).

- remove OnGossipHello() to use DB conditions
- replace OnGossipSelect() with sGossipSelect()
- focus script on the confirming gossip option
- let the other gossip menus be handled in DB

(cherry picked from commit a475033c76)
2017-02-28 20:40:49 +01:00
Treeston
9b4ad0022b Map/Instances: Greatly simplify PermBindAllPlayers logic. (#17940)
(cherry picked from commit cf628880d5)
2017-02-28 20:25:20 +01:00
treeston
9039a1c138 Instance/UtgardePinnacle: Fix Svala Sorrowgrave timings (from sniff).
(cherry picked from commit 5d87e4af8c)
2017-02-26 19:20:13 +01:00
joschiwald
7ee191578e Scripts/Spells: Updated two Anraphet SpellScripts 2017-02-26 16:38:22 +01:00
SnapperRy
1bb998f406 Script/Quest: replace wrong test spell used for quest "Red Snapper - Very Tasty!" with actual summoning.
The spell does not appear in sniffs, and the summoned NPC's spawn time was far too short to be appropriate (15 seconds).
(cherry picked from commit 0479f08c3c)

Script/Quest: fix and use proper serverside summon spell for quest "Red Snapper - Very Tasty!".
(cherry picked from commit 2f493430c9)
2017-02-26 15:39:00 +01:00
Rochet2
117b45d768 Core/Scripts: Enhance quest status hook by making it catch more status changes (#17865)
(cherry picked from commit c52566a888)
2017-02-26 15:36:01 +01:00
ariel-
a82e9e5150 Core/Scripts: move Icehowl unroot after movement (MotionMaster does not update if unit is Rooted)
Closes #17864

(cherry picked from commit 47a43b21c8)
2017-02-26 15:30:08 +01:00
ariel-
0afe0e536d Core/Scripts: Implement Flag of Ownership. Closes #12265
Core/Spells: Implemented TARGET_CORPSE_SRC_AREA_ENEMY. Closes #12803

(cherry picked from commit bc4b4f656c)
2017-02-26 15:30:07 +01:00
Shauren
e9bdcd9d64 Scripts/Naxxramas: Fixed invalid use of std::initializer_list 2017-02-26 15:01:23 +01:00
ariel-
b239afb0ef Core/Misc: calculate rotation fields from orientation in some places it's impossible to get:
- SmartScripts: SMART_ACTION_SUMMON_GO
- Spell Effects:
  * SPELL_EFFECT_DUEL
  * SPELL_EFFECT_SUMMON_OBJECT_WILD
  * SPELL_EFFECT_SUMMON_OBJECT_SLOT1
  * SPELL_EFFECT_SUMMON_OBJECT_SLOT2
  * SPELL_EFFECT_SUMMON_OBJECT_SLOT3
  * SPELL_EFFECT_SUMMON_OBJECT_SLOT4
- Command Scripts: .gobject add

Closes #17891

(cherry picked from commit 14445d2202)
2017-02-19 15:34:57 +01:00
treeston
dd0df772df Scripts/Events: Globally fix all ExecuteEvent loops to check UNIT_STATE_CASTING after each iteration, instead of just checking it once initially.
Fixes and closes #17892.

(cherry picked from commit ac62d7156f)

Drycoding is bad, mmkay?
(cherry picked from commit ed83a35fbe)
2017-02-19 15:09:02 +01:00
r00ty-tc
8a71e4255e [Core/Maps] Activate creatures and objects during opening cinematics and other flyby cameras (sunwell etc).
Requires re-running map extractor to extract camera m2 files from data
files. These are very small.
2017-02-19 14:47:20 +01:00
Trond B Krokli
02757118f2 Core/Scripts/DB: remove hardcoded text from npc_beaten_corpse (#16907)
- remove hardcoded text from script npc_beaten_corpse
- remove OnGossipHello() hook, gossip text moved to DB
- use sGossipSelect() hook instead of OnGossipSelect()
- add npc_text 3557 and 3558 as text_id to gossip_menu
- add gossip_menu_option 2871 to NPC 10668 Beaten Corpse
- add condition for gossip_menu_option 2871 in Quest ID 4921

Tested on 4 different characters/classes, male & female.
Thanks to joschiwald for the sGossipSelect() script change.
(cherry picked from commit d82534a7bb)
2017-02-18 17:53:48 +01:00
treeston
bbbf8df8e5 Entities/Gossip: The Big One™ that gets rid of all uses of The Bad™ and The Ugly™, e.g. gossip preprocessor macros, and replaces them with the new-and-shiny gossip functions.
(cherry picked from commit d55426f5b4)
2017-02-18 17:50:00 +01:00
tkrokli
a714fe98f6 Core/Scripts: remove forgotten #define in boss_kalecgos.cpp
This #define was originally supposed to be removed in my PR #17832,
but for some reason it remained undeleted. This commit corrects it.

Also aligned all the enum values to the same column for readability,
based on a common multiple of 4 spaces.

(cherry picked from commit 068656af06)
2017-02-18 17:29:54 +01:00
Gustavo
cc39c11d7f Whitespace clean-up
(cherry picked from commit 6ee35734e4)
2017-02-18 17:25:36 +01:00
Gustavo
c4f2012ef5 Core/Spells Make credit for quests "The Grand Melee" and "Among the Champions" a triggered cast (#17870)
Fix a problem where the credit wasn't casted due to CGD
(cherry picked from commit e1761a24ce)
2017-02-18 17:23:20 +01:00
ariel-
b3f993894a Core/Scripts: Professor Putricide oozes, reapply passive proc auras on reset, and register them as PP summons since they're summoned by a trigger. (f183ed3c50 follow-up)
(cherry picked from commit 27590fbb98)
2017-02-18 17:16:11 +01:00
ariel-
7f66c730ec Update boss_kelthuzad.cpp
(cherry picked from commit 7e4abce820)

Core/Scripts: fix math error that would not select points on the entire circle
(cherry picked from commit cd9226e755)
2017-02-18 16:54:56 +01:00
Gustavo
accbb587b8 Core/Scripts Boss Skadi the Ruthless rework
(cherry picked from commit 40114cacd3)

Rename 2016_99_99_00_world.sql to 2016_08_25_06_world.sql
(cherry picked from commit 738e3cf002)

travis is lazy
(cherry picked from commit 92876278fe)
2017-02-18 16:44:24 +01:00
tkrokli
ac88c6ec17 Core/Scripts: move npc_experience hardcoded text to DB
(cherry picked from commit 8df4706992)

Rename 2016_08_28_17750_world.sql to 2016_08_25_05_world.sql
(cherry picked from commit 9c41af16ca)
2017-02-18 16:23:19 +01:00
tkrokli
d01dbdc528 Core/Scripts: move #define to enum in boss_kalecgos.cpp
(cherry picked from commit 8bc00e8952)
2017-02-18 16:20:47 +01:00
tkrokli
89923791b8 Core/Scripts: move forge_of_souls gossip to DB
(cherry picked from commit 537074a809)

Rename 2016_08_24_20_world.sql to 2016_08_25_03_world.sql
(cherry picked from commit 8500d0f9e0)
2017-02-18 16:19:17 +01:00
Gustavo
a4fc7d9d2d Core/Scripts Implement Pit of Saron Cavern event
(cherry picked from commit b459c6607f)

Rename 2016_99_99_99_world.sql to 2016_08_25_01_world.sql
(cherry picked from commit 05df3cc988)
2017-02-18 16:16:00 +01:00
Gustavo
e8df5babe6 Scripts/Pet Implemented Argent Squire/Gruntling and Argent Pony Bridle
(cherry picked from commit 989aaaa8b5)

Rename 2016_08_15_17779_world.sql to 2016_08_25_00_world.sql
(cherry picked from commit 526dfca864)
2017-02-18 16:00:52 +01:00
treeston
df0d32be81 Merge remote-tracking branch 'Treeston/3.3.5-kelthuzad' into 3.3.5 (PR #16634)
(cherry picked from commit 47a9cb1e56)

...Huh. Wonder how this one didn't make travis complain on the PR.
(cherry picked from commit 93a68d5881)

Was Travis completely napping on this one?
(cherry picked from commit 2d7dec0d39)
2017-02-18 15:57:19 +01:00
treeston
ab6f8f9fb7 Scripts/HallsOfLightning: Fix Volkhan healing.
(cherry picked from commit 5da3ae0489)
2017-02-18 15:49:06 +01:00
tkrokli
16c6e0fb80 Core/Scripts: set correct unit_flags on Scarlet Mine Car (#17844)
Closes #17816
(cherry picked from commit f3dc97f263)

Rename 2016_08_24_08_world.sql to 2016_08_24_03_world.sql
(cherry picked from commit cabf6bd98a)
2017-02-18 15:49:05 +01:00
SnapperRy
a6209e6d6d Event/Brewfest: implement relay race (#17603)
(cherry picked from commit 894378f867)

Rename 9999_99_99_99_world.sql to 2016_08_23_05_world.sql
(cherry picked from commit 6036b07f25)
2017-02-18 14:47:00 +01:00
tkrokli
d8befaf68b Core/Scripts: npc_wormhole #define text moved to DB (#17805)
Another core script hardcoded text removal:
- removed #define text from script
- added the text to gossip_menu_option
- added and renamed enum to match DB entries
- minor additional adjustments and comments

Closes #6841
(cherry picked from commit 8a0990376d)
2017-02-18 14:42:03 +01:00
Gustavo
7e57e9a91b Improve scripts for quests Breakfast Of Champions and A Bear of an Appetite (#17780)
Properly despawn the related GameObjects after use of the quest item, avoiding multiple use and summon
(cherry picked from commit 5661b4686b)

Rename 2016_08_99_99_world.sql to 2016_08_23_03_world.sql
(cherry picked from commit 831975fa34)
2017-02-18 14:40:14 +01:00
SnapperRy
2574667854 Scripts/ArgentTournament: improve training dummy script
Now the ranged and charge target dummies will cast their spells and behave correctly for the related quests
(cherry picked from commit 433beb77e3)
2017-02-18 14:38:42 +01:00
jackpoz
143f0c0e4d Core/Misc: Fix static analysis issues
(cherry picked from commit b7306f06f5)

# Conflicts:
#	src/server/game/Entities/Unit/StatSystem.cpp
2017-02-18 14:30:23 +01:00
joschiwald
c6632dc3ee Fixed build and typo 2017-02-18 13:40:03 +01:00
joschiwald
80c36f3d9c Scripts/Command: Fixed phases output in .pinfo command
Closes #19144
2017-02-17 21:54:49 +01:00
Keader
0ed67081bc Core/Spells: Fixed Chilled effect on Frostbolt, Frozen Orb and Blizzard (#19131) 2017-02-15 12:17:45 -02:00
RoG_Hannibal
23aca839fe Core/Spells: add slowing effect to Mage spell Frostbolt (#19092)
Closes #18932
2017-02-13 15:17:28 -02:00
RoG_Hannibal
d2dba9a5e0 Core/Spells: fix Priest spell Penance and Power Word: Shield (#19033)
- fix talent "The Penitent" for the spell Penance
- re-write Power Word: Shield

Closes #18520
2017-02-13 03:46:00 +01:00