Commit Graph

2341 Commits

Author SHA1 Message Date
Shauren
69e0b9a985 Core/Auras: Update AuraState enum and implement missing new ones 2021-03-16 20:48:42 +01:00
Shauren
566f9f368d Scripts/Icecrown Citadel: Corrected spell ids used by Professor Putricide 2021-03-16 18:36:40 +01:00
ariel-
6042126916 Core/Scripts: travis fixes
(cherry picked from commit ea0224e3bd)
2021-03-15 20:17:31 +01:00
ariel-
44c8ccadd7 Core/Auras: periodics refactor part 5: ported periodic trigger spell auras to scripts
(cherry picked from commit a36e804ae4)
2021-03-15 20:17:31 +01:00
ariel-
d9b145615d Core/Auras: periodics refactor part 4: ported periodic dummy auras to scripts
(cherry picked from commit 193bd3b452)
2021-03-15 20:17:31 +01:00
ariel-
97e869e8b3 Core/Auras: periodics refactor part 3: move more switch hacks to scripts
- Incidentally fixed some spells which were supposed to be removed by proc instead of healing to full

(cherry picked from commit 16e20711d2)
2021-03-15 20:17:31 +01:00
ariel-
fd786c03a3 Core/Auras: periodics refactor part 2: Move UpdatePeriodic to AuraScripts
(cherry picked from commit 0510bf7afe)
2021-03-15 20:17:31 +01:00
ariel-
5f9e0d92d5 Core/Auras: periodics refactor part 1:
- Don't skip ticks if diff is greater than amplitude
- Fixed spells without ampltude in DBC

(cherry picked from commit 5d91beb1db)
2021-03-15 20:17:31 +01:00
Golrag
fe362cf2c9 Core/Entities: Some changes to LoS z checking & MotionMaster::MoveJumpTo (PR #20970)
- Use Midsection height for LoS checking.
- Changed MotionMaster::MoveJumpTo to use correct z. This change also makes sure the _owner will jump towards the given angle. Instead of jumping to a unintended angle if the first one is not in LoS.

(cherry picked from commit 95456ab5d8)
2021-03-15 20:17:31 +01:00
Shauren
efdca47aff Core/Auras: Remove m_effIndex member of AuraEffect and always take it from SpellEffectInfo 2021-03-11 10:32:03 +01:00
ccrs
82b7f47d53 Core/AI: reorder methods in ScriptedEscortAI
plus ninja rename

(cherry picked from commit 0db5516a1a)
2021-02-25 18:50:55 +01:00
jackpoz
a01d397c3d Core/Misc: Fix static analysis issues
Fix static analysis issues reported by 3rd party tools

(cherry picked from commit 24e82fe83d)
2021-02-25 18:50:55 +01:00
Keader
2630a5288a Core/Scripts: Fixed Enervating Brand in Baltharus encounter
Closes #21027
By Mihapro

(cherry picked from commit 6598c5d2f3)
2021-02-25 18:50:55 +01:00
Keader
8581bf2815 Build fix
yes, i'm blind

(cherry picked from commit a2b191c78e)
2021-02-15 19:13:25 +01:00
Keader
232dc7e71b Scripts/Ulduar: Fixed a clang6 warning
(cherry picked from commit 80a65744bc)
2021-02-15 19:13:25 +01:00
Keader
66fa9e11cd Typo
(cherry picked from commit bd560fd160)
2021-02-15 19:13:25 +01:00
Keader
d917db5215 Scripts/Razorscale: Fixed issues related with Devouring Flame
Closes #20967

(cherry picked from commit 454a230af4)
2021-02-15 19:13:25 +01:00
Keader
6ac58c40d7 Core/Scripts: Build fix
(cherry picked from commit cc50a036df)
2021-02-15 19:13:25 +01:00
Keader
f23d1f658e Core/Scripts: Codestyle fix (Trial of Crusader)
followup: c436be6f61
(cherry picked from commit 67df45b585)
2021-02-15 19:13:25 +01:00
Keader
59417cc0f8 Core/Scripts: Updated Trial of Crusader instance model
- TODO: Bosses rewrite, instance cleanup, add missing gossips/texts, port all gossips from db.
Sniffs will be nice :/

(cherry picked from commit c436be6f61)
2021-02-15 19:13:25 +01:00
Matan Shukry
7159de62b6 Scripts/Spells: Remove const from AuraEffect argument for AuraEffectProcFn 2021-02-13 14:08:16 +01:00
jackpoz
f5dcff32cb Core/Misc: Fix static analysis issues
(cherry picked from commit 06ea65b0e6)
2021-02-06 21:41:51 +01:00
jackpoz
a68ab3241a Core/Misc: Fix static analysis issues
(cherry picked from commit 7e73f5f1ed)
2021-02-06 21:41:51 +01:00
Matan Shukry
0cae71eac5 Core/Spells: Adding SpellTargetObjectTypes to spell target checker to early-eliminate alive units (#26028)
* Added object type into checker that is used by grid search to early eliminate alive units when looking for corpses
* Removed script 'spell_hun_pet_carrion_feeder'. Ability doesn't exist anymore
2021-02-05 21:29:00 +01:00
Andrew Letson
0ec1699585 Scripts/Northrend: Move Sholazar Basin NPCs to SmartAI
(cherry picked from commit c99b89934e)
2021-01-29 19:23:53 +01:00
tkrokli
0d32a1ef0f Scripts: tabs2spaces cleanup after commit cc89428
Thanks to Wyreth for reporting the overlooked tabs.

(cherry picked from commit bbd339370e)
2021-01-21 22:30:40 +01:00
Wyreth
45dbce6d78 Scripts/Northrend: talk event for quest A Suitable Test Subject (#20462)
- When using the quest item for A Suitable Test Subject and the spell aura vanishes,
  Bloodmage Laurith should turn toward the player and whisper a line.
- This is handled via spell event for Bloodspore Ruination (45997)

(cherry picked from commit fda99b2972)
2021-01-21 22:30:40 +01:00
Malleus
8eaf992f3e Script/Quests: Fix some missing NPC spells and quest credit
(cherry picked from commit cc894288b7)
2021-01-21 22:30:40 +01:00
Gustavo
f34ee9b737 Core/Scripts: Update boss Toravon the Ice Watcher (#20395)
* Core/Scripts: Update boss Toravon the Ice Watcher

Frozen Orbs: Fixed summon delay, removed old hack, aggro behavior implemented(every 10sec they reset threat and change target)
Remove no longer needed script for the orb stalker
All timers adjusted
Update instance model
Update script register model
Fix Frostbite proc

(cherry picked from commit 5a90251ea2)
2021-01-08 21:12:11 +01:00
r00ty-tc
aebe398e56 Scripts/NPC: Minigob Manabonk update
- Despawn and stay despawned!
 - Adjusted actions to match the only video of event I could find and
   based on sniff data from 3.3.5, 12340 build.
 - Chance for event to occur is drastically reduced based on Dalaran
   population. 1-99, the population of Dalaran is the chance. 100+ means
   the event is assured.

Closes #20575

(cherry picked from commit 1750ca501f)
2020-12-31 23:23:50 +01:00
Shauren
b82a3a557a Core/DataStores: Updated db2 structures to 9.0.2
* Includes support for new character customization
2020-12-08 18:16:47 +01:00
Gustavo
5e5ca6c84a Core/Scripts: Boss Amanitar rewrite (#20283)
* Core/Scripts: Boss Amanitar rewrite

Fixes mushrooms behavior, correct and script his spell, size, spawn positions, despawn and respawn, and everything else
Fixes Mini spell cast(only re-cast if there is at least one person without the debuff)
Corrects boss initial position
Updates script register model

(cherry picked from commit 0b766db6a4)
2020-09-12 00:17:29 +02:00
Gustavo
e531beeb83 Core/Scripts: Boss Jedoga Shadowseeker rewrite (#20279)
* Core/Scripts: Boss Jedoga Shadowseeker rewrite

Added all missing spells and visuals
Added Twilight volunteers in the fight
Fixed Jedoga Controller's behavior, mostly moved to boss_prince_taldaram, where they belong
Updated script register model
Misc updates and improvements
Updated instance model

(cherry picked from commit f1ff7e642f)
2020-09-12 00:13:32 +02:00
Shauren
b231903932 Core/Misc: Port all the refactors sneaked in master to 3.3.5 include cleanup port 2020-09-04 13:38:24 +02:00
Treeston
fe938b99f8 Core/Scripts: Implemented OnlyOnceAreaTriggerScript (#20288)
(cherry picked from commit 971ed856a4)
2020-08-29 00:41:22 +02:00
Treeston
77d13a7b97 Scripts/Patchwerk: Finally fix that crash for real. Closes #20247.
(cherry picked from commit 49daef4b77)
2020-08-29 00:19:04 +02:00
Treeston
bece27ef3f Scripts/Naxxramas: Fix an edge case crash with people teleporting out of the dungeon during the Patchwerk encounter (tagging #20247)
(cherry picked from commit 50e8de103b)
2020-08-29 00:14:50 +02:00
Treeston
4a909ada55 Scripts/Naxxramas: Missing nullptr check in Patchwerk. Closes #20247.
(cherry picked from commit c9ac68d6e3)
2020-08-23 19:02:57 +02:00
Keader
b3c6330a6e Core/Scripts: Auriaya rewrite (#20204)
(cherry picked from commit f67c6a5a12)
2020-08-23 18:59:36 +02:00
Keader
68992bcd0d Core/Scripts: Removed wrong AddThreat call in Pursuit spellscript
followup 52ad0c9e5c
checked in sniffs, only ick add threat in target, wrong call in original script (why o keep it? o.o)

(cherry picked from commit f86b4e45e5)
2020-08-23 18:39:49 +02:00
Carbenium
4e44bc6ea2 Core: Fix non-PCH build
(cherry picked from commit 45cb8c90e9)
2020-08-23 17:57:07 +02:00
Keader
d0a655de12 Core/Scripts: Typo fix
(cherry picked from commit 72aa03441f)
2020-08-23 17:49:42 +02:00
Keader
0537f3bd58 Core/Script: Krick and Ick, fixed spell Pursuit
Close #2261

(cherry picked from commit 52ad0c9e5c)
2020-08-23 17:48:07 +02:00
ccrs
5d61618955 Scripts/AzjolNerub: minor corrections
ref #19072

(cherry picked from commit 80a8867332)
2020-08-23 16:25:25 +02:00
Treeston
67abc694e3 Scripts/AzjolNerub: Fix some duplicate summons after JustAppeared changes. Closes #20183.
(cherry picked from commit dcc3cd21e8)
2020-08-23 16:07:46 +02:00
ccrs
9a5e2b80b3 Core/Creature: regenerate health
There are three possible scenarios regarding regenerating health
- db lock and curhealth set to > 0
- db lock and curhealth set to 0
- dynamic lock (set in scripts and such) overriding db lock

(cherry picked from commit 91c0d49c18)
2020-08-23 15:56:21 +02:00
Keader
43f76c8cdd Core/Scripts: Updated Razorscale to new registers model
* More codestyle fixes
* Ty sirikfoll :)

(cherry picked from commit 76fc9ed635)
2020-08-23 14:44:29 +02:00
Keader
3df7e8b9fb Core/Razorscale: Codestyle Updates
* Removing spelldifficulty_dbc to make portable to master
* Updated to new Spell/Aurascript model

(cherry picked from commit 203c5f7058)
2020-08-23 14:39:20 +02:00
Foereaper
07e903a23d Scripts/Naxxramas: Fix Heigan the Unclean eruption event (#20129)
By scheduling the eruption event without cancelling the previously registered eruption events, Heigan's eruption (or dance) would overlap and cause a runaway scenario, where eruptions would not follow a proper timer.

By using Reschedule and not locking the Eruption event to the fighting phase, the dance now works as intended.

(cherry picked from commit 6f4492bc61)
2020-08-23 14:35:07 +02:00
Gustavo
e5963fda0e Core/Scripts: More fixes in boss Lich King (#20147)
* Core/Scripts: More fixes in boss Lich King

Fix Valkyr charge spell, they will no longer ignore Z position and become unreachable.
Correct height of Spirit Bomb and added the 3 seconds delay on his explosion.
Set the Trigger inside frostmourne room as active, to avoid problems with reseting the room, e.g: Spirit Bombs not despawning and Wicked Spirits stuck in evade.
Use correct InhabitType for Wicked and Vile Spirits, this avoid a situation where they could spawn falling.

(cherry picked from commit 22a7956069)
2020-08-23 01:20:27 +02:00