Souler
0f9fc672d5
Core/Grids: Traps shouldn't target unattackable units.
...
Hunter traps and Basic Campfire will no longer activate unattackable creatures.
2011-09-29 10:53:27 +02:00
QAston
8dd88fa43c
Core/Spells: fix a typo which caused to display unneeded error message (invalid target) during cast of some spells (like warrior charge).
2011-09-28 18:59:55 +02:00
Machiavelli
8cde717e76
Core/Achievements: Fix gender-specific Matron/Patron title reward.
...
Closes #1406
2011-09-28 16:27:08 +02:00
Spp
be12603150
Configuration/ConfigMgr: converted from singleton to namespace with free functions.
2011-09-28 13:00:43 +02:00
Spp
71228f90bb
Core/Weather: Move static function to WeatherMgr.
2011-09-28 11:55:25 +02:00
Machiavelli
d0ce7d2367
Scripts/Ulduar/Razorscale: Fix event starting
2011-09-28 11:49:28 +02:00
Machiavelli
18665d19b4
Core/Scripts: Add an additional parameter to DoZoneInCombat to define the max range to find a target in to engage (instead of hard coded 50 yards).
2011-09-28 11:49:25 +02:00
Spp
b93067350c
Core/WeatherMgr: singleton converted to namespace with free functions. Note how RAII saves your life and removes the need in explicit delete :)
2011-09-28 11:38:56 +02:00
Spp
cc06c41887
Core: Move FormationMgr to namespace
...
Also...
- Warning fixes
- Make Singleton constructors private
2011-09-28 11:11:38 +02:00
Spp
852ffcc139
Core/Scripting: Remove unnecesary reference in param function OnMemberRemove
2011-09-28 10:35:59 +02:00
Machiavelli
88d30aaa65
Merge pull request #3174 from Souler/pull
...
Scripts/Ulduar: Make Ignis enter evade mode if pulled out from his fight area.
2011-09-28 01:32:33 -07:00
megamage
eb946691c7
Unlink Battleground and BattlegroundMap when one of them is deleted. Fix crash #3239 .
2011-09-27 17:26:13 -04:00
QAston
5f043e6291
Core/Spells: Bring back workaround removed in cd7060c65a - it's needed for compatibility with some scripts.
2011-09-27 22:04:26 +02:00
Shauren
7040ef5877
Scripts/Icecrown Citadel: Mark of the Fallen Champion will ignore armor now
2011-09-27 21:44:29 +02:00
Machiavelli
6d4a7b3930
Scripts/Ulduar/Flame Leviathan: Use GUID in script instead of pointer
2011-09-27 19:56:45 +02:00
et2012
5bc2b4d8fd
Core/Spells: added spell effect validations
2011-09-27 19:51:51 +02:00
Machiavelli
a7d0b62195
Scripts/Ulduar/Flame Leviathan: Properly cast spell Battering Ram. TODO: Fix spell immunity on target vehicles.
2011-09-27 19:41:56 +02:00
QAston
7fa2a64290
Merge branch 'master' of https://github.com/Chaplain/TrinityCore
2011-09-27 19:19:25 +02:00
QAston
ee2af420e7
Merge pull request #3235 from Chaplain/cleanup
...
Core/Spell: Hymn of Hope fix.
2011-09-27 10:11:35 -07:00
Souler
a51e2d3ff6
Remove XT-002 area check, already fixed by @MachiavelliTrinity in 9692be4cbb
2011-09-27 11:56:08 +03:00
QAston
23ba776767
Core/Entities: use Unit::GetReactionTo in Unit::IsFriendlyTo and Unit::IsHostileTo
2011-09-27 01:29:20 +02:00
QAston
75aeb15e90
Core/Spells: Allow AOE spells to hit stealthed targets.
2011-09-27 01:13:32 +02:00
QAston
a409cc226c
Core/Spells: Fix Vanish's stealth trigger and Demonic Empowerment's invisibility trigger
...
Those spells were failing to pass default effect trigger spell due to their custom implementation (changing triggered_spell_id instead of adding serverside spells with proper targeting).
2011-09-27 00:36:23 +02:00
QAston
a2633bf7fc
Scripts: fix spell_generic_quest_update_entry script after e949ad3adb.
2011-09-27 00:12:45 +02:00
Machiavelli
c095cbb0ed
Make recent added Spellscript conform to hook name changes in e949ad3adb
2011-09-26 22:00:12 +03:00
Machiavelli
7ec351a79d
Scripts/Ulduar/Flame Leviathan: Fix Pursue spell (target selection/filtering, emote, and aggro), and clean up some atrocities in the script.
2011-09-26 20:47:51 +02:00
Machiavelli
f4ec95c752
Fixed a typo in pull request. (Edit via Github)
2011-09-26 21:05:16 +03:00
Chaplain
5bbd8dcf33
Core/Spell: Hymn of Hope fix.
...
*fixed mess with temporary increase max/current power (percent).
*thx Shocker for advice
2011-09-26 20:12:25 +03:00
Machiavelli
6a37c4056e
Merge pull request #3215 from Kapoeira/master
...
Core/Spells: Fixed glyph of Fire Blast
2011-09-26 08:49:35 -07:00
Shocker
6dc09248fd
Merge pull request #3162 from megamage/master
...
Fix incorrect logic in PetAI. Solve #3155 .
2011-09-26 06:44:33 -07:00
megamage
780747f5d3
Missing part of the previous commit.
2011-09-26 09:14:12 -04:00
megamage
a35deba186
Fix some crashes caused by spell scripts without checking unit type. Fix #3216 and #3217 .
2011-09-26 09:03:33 -04:00
Spp
7b68a6bf69
Core/Logging: Add new function to include full stacktrace.
...
Note: It only has use for devs but makes it easier to get the error with a full trace
2011-09-26 14:34:50 +02:00
Spp
8484b004dd
Core/Handler: Move couple of msgs to Debug
2011-09-26 09:52:17 +02:00
Cron
8622bedeac
Core/Spells: Fixed glyph of Fire Blast.
2011-09-25 15:53:31 -03:00
QAston
210a770958
Core/Spells: Fix totem passive area auras stacking bug.
2011-09-25 19:00:37 +03:00
Chaplain
224bb96deb
Core/Spells: Fix talent Sword Specialization.
2011-09-25 16:42:12 +03:00
Shauren
062e645637
Scripts/Spells: Bloodlust/Heroism handling changed, it is now possible to use these spells even if caster is under Sated/Exhaustion debuff
2011-09-25 15:08:48 +02:00
QAston
e949ad3adb
Core/Spells: spell effect handling improvements
...
* Call spell effect handlers in 4 modes:
- SPELL_EFFECT_HANDLE_LAUNCH - called when spell is launched (cast just finished)
- SPELL_EFFECT_HANDLE_LAUNCH_TARGET - called when spell is launched for each target in spell target map
- SPELL_EFFECT_HANDLE_HIT - called when spell hits its destination
- SPELL_EFFECT_HANDLE_HIT_TARGET - called when spell hits it's target from spell target map
*Correctly implement SPELL_EFFECT_TRIGGER_SPELL, SPELL_EFFECT_TRIGGER_SPELL_WITH_VALUE, SPELL_EFFECT_TRIGGER_MISSILE_SPELL_WITH_VALUE, SPELL_EFFECT_TRIGGER_MISSILE_SPELL
*Remove spell system hacks which became obsolete with this commit
Core/SpellScripts:
add OnEffectLaunch, OnEffectLaunchTarget, OnEffectHit, OnEffectHitTarget hooks for new effect handle modes and remove OnEffect hook.
A generic rule of thumb how to update your scripts (will work for nearly all cases) for spell system noobs:
if your spell script used GetHitXXXX function, you need to use OnEffectHitTarget, otherwise use
OnEffectHit
2011-09-25 13:29:50 +02:00
Chaplain
877579d386
Revert "Core/Spells: Fix talent Sword Specialization for melee abilities"
...
This reverts commit cdd4160157 .
2011-09-25 14:20:41 +03:00
Shauren
b07cc3751f
Core/Scripts: Added NULL checks to new target selectors, threat references aren't guaranteed to be valid always, also added (default true) player typeid check to NonTankTargetSelector
2011-09-24 23:30:11 +02:00
Shauren
da0229da8f
Core/Scripts: Implemented 2 new target selectors, one specialized for spells, checking auras, range and attributes; and the other is a very simple non-tank selection what is sufficient for most cases
2011-09-24 19:40:57 +02:00
QAston
cd7060c65a
Core/Spells: Add more generic overload for Unit::CastSpell function and make all cast functions use it as a base.
2011-09-24 16:41:50 +02:00
Machiavelli
911c7ce3cc
Scripts/Ulduar/Flame Leviathan: Fix RX-214 Repair-o-matic station.
...
Note: Due to an aura system bug, the dummy cooldown aura is refreshed every time the trap spell is cast instead of expiring like it should.
2011-09-24 13:13:15 +02:00
Shauren
29ba648fa3
Scripts/Icecrown Citadel: Fixed possible crash in npc_darnavanAI
...
Closes #3188
2011-09-24 11:29:49 +02:00
QAston
d01a761f53
Core/Spells: Drop EFFECT_IMPLICIT_TARGET_PET and use EFFECT_IMPLICIT_TARGET_EXPLICIT instead.
2011-09-24 02:02:39 +02:00
QAston
71bbbaa21b
Merge pull request #3146 from Havenard/fix0001
...
Reimplement WorldObject::IsInBetween() to work as intented.
2011-09-23 06:04:17 -07:00
Machiavelli
9692be4cbb
Scripts/Ulduar/XT-002: Add gameobject handling for XT-002 door and boundary checking during the encounter.
2011-09-23 13:20:43 +02:00
QAston
413b542cd9
Add a tempfix for trigger missile spell effects after rev 13a1d90130.
2011-09-23 13:09:31 +02:00
QAston
13a1d90130
Core/Spells: Improvements in selecting default targets based on effect type.
2011-09-23 11:58:40 +02:00