Commit Graph

14386 Commits

Author SHA1 Message Date
Giacomo Pozzoni
127455ed4c Scripts/Misc: Attempt to fix the build 2020-02-15 22:13:46 +01:00
Rushor
f0bf447cd1 Scripts/Gameobject: Journal of Jandice Barov- Convert script to SAI. (#24157)
* Scripts/Gameobject: Journal of Jandice Barov- Convert script to SAI. (Thanks to Sunwell)

* Scripts/Gameobject: Journal of Jandice Barov - Update script and move go spawn to bossscript

* Update boss_jandice_barov.cpp

Co-authored-by: Eridium <6587064+Killyana@users.noreply.github.com>
2020-02-15 20:18:58 +01:00
Rushor
596b2d1ed7 Scripts/Gameobject: Remove deprecated script for Cat Figurine (#24150)
Scripts/Gameobject: Remove deprecated script for Cat Figurine
2020-02-14 23:28:14 +01:00
Shauren
89d8180916 Core/Guilds: Don't rely on implicit guid->uint64 conversion for member lookup 2020-02-14 17:37:22 +01:00
Ujp8LfXBJ6wCPR
9264e5b6f0 Core/Misc: Remove redundant null pointer checks before delete (#24140)
* Identified by clang-tidy readability-delete-null-pointer
2020-02-14 12:45:34 +01:00
Ujp8LfXBJ6wCPR
b92e4af460 Core/Misc: Remove redundant copy constructor for Position and WorldLocation (#24151)
* Default compiler generated ones do the same
2020-02-14 10:21:51 +01:00
Rushor
a67dd6ab60 Scripts/Kalimdor: Move script of Hand of Iruxos Crystal to database. (#24141)
* Scripts/Kalimdor: Move script of Hand of Iruxos Crystal to database.

* Scripts/Kalimdor: Hand of Iruxos Crystal - Add despawn for gameobject.

* Scripts/Kalimdor: Hand of Iruxos Crystal - Add despawn for gameobject.

* Remove unneeded commentline

* Rename 9999_99_99_99_world.sql to 2020_02_11_00_world.sql

Co-authored-by: Aokromes <Aokromes@users.noreply.github.com>
2020-02-11 18:16:11 +01:00
Killyana
7450be4cfd DB/Text: Fix and remove some npc_text 2020-02-10 22:33:38 +01:00
Killyana
74a825d046 DB/Logs: Move some logs back to DB errors
Ref 38d3b35561
Ref #22282
2020-02-08 21:28:13 +01:00
Sorikoff
53657441aa Scripts/Spells: Nourish (#24057)
* Scripts/Spells: Nourish

* Rename 9999_99_99_99_world.sql to 2020_02_08_02_world.sql

* Update 2020_02_08_02_world.sql

Co-authored-by: Giacomo Pozzoni <giacomopoz@gmail.com>
2020-02-08 20:55:09 +01:00
Ovah
98d6c501d7 Core/Vehicles: implement vehicle seat addon table to specify seat ori… (#24112)
* Core/Vehicles: implement vehicle seat addon table to specify seat orientation offsets and exit positions in form of offsets or absolute positions
* converted Traveler's Tundra Mammoth to seat addon table data

* first follow batch

* whoopsie

* Core/Vehicles: go from local copies to pointers

* Update and rename 2020_99_99_99_world.sql to 2020_02_08_01_world.sql

Co-authored-by: Giacomo Pozzoni <giacomopoz@gmail.com>
2020-02-08 20:47:46 +01:00
ForesterDev
58313fc330 Core/PacketIO: update cinematic packets to new system. Implement CMSG_OPENING_CINEMATIC and CMSG_COMPLETE_MOVIE (#24135)
* Server/PacketIO: Enable SMSG_TRIGGER_CINEMATIC & SMSG_TRIGGER_MOVIE.

* Update SMSG_TRIGGER_CINEMATIC & SMSG_TRIGGER_MOVIE to new Format.

Signed-off-by: AriDEV <aridev666@gmail.com>

# Conflicts:
#	src/server/game/Entities/Player/Player.cpp
#	src/server/game/Server/Packets/MiscPackets.cpp
#	src/server/game/Server/Packets/MiscPackets.h
#	src/server/game/Server/Protocol/Opcodes.cpp

* Core/Scripts: Add server-side script support for movie completion (#18308)

# Conflicts:
#	src/server/game/Entities/Player/Player.h
#	src/server/game/Handlers/MiscHandler.cpp
#	src/server/game/Scripting/ScriptMgr.h
#	src/server/game/Server/Packets/MiscPackets.h
#	src/server/game/Server/Protocol/Opcodes.cpp
#	src/server/game/Server/WorldSession.h

* Core/PacketIO: CMSG_COMPLETE_CINEMATIC, CMSG_NEXT_CINEMATIC_CAMERA and enabled some opcodes

# Conflicts:
#	src/server/game/Server/Protocol/Opcodes.cpp
#	src/server/game/Server/WorldSession.h

* Core/Protocol: Implemented CMSG_OPENING_CINEMATIC

# Conflicts:
#	src/server/game/Handlers/GuildHandler.cpp
#	src/server/game/Server/Protocol/Opcodes.cpp
#	src/server/game/Server/WorldSession.h

* fix build

Co-authored-by: Krudor <erikstrandberg93@hotmail.com>
Co-authored-by: MitchesD <majklprofik@seznam.cz>
Co-authored-by: Kaelima <kaelima@live.se>
2020-02-08 20:37:34 +01:00
schell244
f87a4543ad Core/Scripting: fixed hourly bell sounds (#24127)
* fixed hourly bell sounds

* use switch and moved variable

* fix typo
2020-02-08 20:35:05 +01:00
Ujp8LfXBJ6wCPR
76831f1f46 Use boost::optional and boost::none instead of smelly pointer (#24134)
* Remove bad pointer usage from CharacterCache

Use TrinityCore Option type instead which is intended for this purpose. (Wrapper around boost::option until C++17 bump is finalised)

* Unify codestyle regarding TC optional type

Based upon advice from @Shauren
2020-02-08 20:29:18 +01:00
Eridium
c574972cb2 Sync npc_text naming (#24128)
* Sync npc_text naming

Ref #22287
Ref #22282
We will update the table with data from broadcast_text later

* Fix sql

* Rename 2020_99_99_99_world_335.sql to 2020_02_08_00_world_335.sql

Co-authored-by: Giacomo Pozzoni <giacomopoz@gmail.com>
2020-02-08 20:26:51 +01:00
Treeston
9304e496cb Core/Misc: Some refactoring, #23603 prep: (#23676)
- Split SpawnMetadata off from SpawnData
- No longer allocate Creature/Gameobject objects in ObjectGridLoader just to check their typeid and delete them afterwards

Co-authored-by: Giacomo Pozzoni <giacomopoz@gmail.com>
2020-02-08 20:22:37 +01:00
Keader
5fa77744e4 nopch build fix 2020-02-06 18:34:07 -03:00
Keader
ddd1a3c1ef Game/Battlegrounds: Fixed Position and Rotation of Alterac Valley Gates 2020-02-06 18:09:17 -03:00
Sorikoff
e10239311c Scripts/Spells: Gift of the Harvester (#24111)
* Scripts/Spells: Gift of the Harvester

* Scripts/Spells: nopch

* Scripts/Spells: nopch

* Scripts/Spells: validate

* Rename 9999_99_99_99_world.sql to 2020_02_01_03_world.sql

Co-authored-by: Giacomo Pozzoni <giacomopoz@gmail.com>
2020-02-01 14:55:16 +01:00
funjoker
6c85964065 Sync broadcast_text naming (#24102)
* Sync broadcast_text naming

official namings for broadcast_text

* Rename 2020_01_24_00_world_335.sql to 2020_02_01_02_world_335.sql

Co-authored-by: Giacomo Pozzoni <giacomopoz@gmail.com>
2020-02-01 14:52:59 +01:00
ForesterDev
ba1e5cd413 Core/PacketIO: convert some packets to to new packet class (#24100)
* Core/PacketIO: updated SMSG_INVALIDATE_PLAYER, SMSG_BINDER_CONFIRM, SMSG_BIND_POINT_UPDATE, SMSG_PLAYER_BOUND and SMSG_LOGIN_SET_TIME_SPEED

* small corrections
2020-02-01 14:49:38 +01:00
Giacomo Pozzoni
a9e534762f Core/Movement: Fix WaypointMovementGenerator ignoring EscortAI::SetEscortPaused() on Gossip Hello (#24005)
Fix WaypointMovementGenerator ignoring EscortAI::SetEscortPaused() when talking to a NPC, scheduling a 3 minutes pause on the WaypointMovementGenerator even if it was already disabled with no timer, waiting for the player to select a gossip entry to resume the movement.
2020-02-01 14:47:06 +01:00
ForesterDev
573ddf4d22 Core/Items: implement some helper methods for easier readability (#24113) 2020-02-01 14:45:58 +01:00
Sorikoff
8c443ae39f Scripts/Borean Tundra: Iruk (#24117)
* Scripts/Borean Tundra: Iruk

* Apply suggestions from code review

Co-Authored-By: Trond B. Krokli <38162891+illfated@users.noreply.github.com>

* Update 9999_99_99_99_world.sql

* Rename 9999_99_99_99_world.sql to 2020_02_01_01_world.sql

Co-authored-by: Trond B. Krokli <38162891+illfated@users.noreply.github.com>
Co-authored-by: Giacomo Pozzoni <giacomopoz@gmail.com>
2020-02-01 14:41:44 +01:00
Sorikoff
74d19691a5 Scripts/The Barrens: Beaten Corpse (#24124)
* Scripts/The Barrens: Beaten Corpse

* Rename 9999_99_99_99_world.sql to 2020_02_01_00_world.sql

Co-authored-by: Giacomo Pozzoni <giacomopoz@gmail.com>
2020-02-01 14:40:34 +01:00
Killyana
c86d4404c8 DB/Creature: Plagued Dragonflayer Tribesman & Plagued Dragonflayer Rune-Caster & Plagued Dragonflayer Handler
Closes #24122
2020-01-30 21:11:29 +01:00
Ovah
f0485cea39 Core/Scripting: fixed build. Re-enable ModifyVehiclePassengerExitPos for CreatureScript to allow scripted creatures that already have an AI to benefit from its functionality as well 2020-01-28 06:12:42 +01:00
Ovah
ebf116e6a3 Core/AI: call ModifyVehiclePassengerExitPos for CreatureScripts since the hook is available for that class as well 2020-01-28 05:48:10 +01:00
Killyana
0ec2a5fd74 Spell/Script: Fix Prison chain for Unworty Initiate
Closes #24089
The spell 54613 is not used in the game
2020-01-27 02:49:36 +01:00
Sorikoff
13c81f55e3 Scripts/Ebon Hold: How To Win Friends And Influence Enemies (#24090)
* Scripts/Ebon Hold: How To Win Friends And Influence Enemies

* Scripts/Ebon Hold: Improve SQL!

* Scripts/Ebon Hold: Final touch

* Scripts/Ebon Hold: Actually final touch

* Rename 9999_99_99_99_world.sql to 2020_01_26_04_world.sql

Co-authored-by: Giacomo Pozzoni <giacomopoz@gmail.com>
2020-01-26 21:15:39 +01:00
Sorikoff
552a638e31 Scripts/Borean Tundra: Plug the Sinkholes (#24085)
* Scripts/Borean Tundra: Plug the Sinkholes

* Scripts/Borean Tundra: Improve SQL

* Scripts/Borean Tundra: Remove item script

* Rename 9999_99_99_99_world.sql to 2020_01_26_03_world.sql

Co-authored-by: Giacomo Pozzoni <giacomopoz@gmail.com>
2020-01-26 21:15:00 +01:00
Kittnz
b0db728c49 Core/GameObject: Add infinite visibility GameObject check (#24074) 2020-01-23 15:33:09 +01:00
Ovah
78c1216bcf Core/Movement: improved RandomMovementGenerator wait handling to get closer to retail behaivior (#24093)
* according to observations Blizzard is letting creatures do 2 up to 10 spline movements right after each other before waiting for a couple seconds
2020-01-22 22:19:42 +01:00
Kelno
d0efd76c92 Core/Maps: cosmetic correction on comment (#24096) 2020-01-22 21:34:24 +01:00
Ovahlord
01584cb0b9 Core/Movement: reset position update interrupt info after the interrupt checks have been executed
* for discussion see: 02daf1bf3a (r36916229)
2020-01-22 20:40:09 +01:00
Ovah
02daf1bf3a Core/Movement: properly fix aura interrupts during movement (#24068)
We want our movement to be fully updated before even thinking about interrupting anything. The old logic was updating positions, interrupting stuff and afterwards updating movement generators. This way we were ending up with false interrupts.

properly fixes #22908
2020-01-22 13:32:38 +01:00
jackpoz
d293dd3782 Core/MMaps: Handle path on same position
Handle path on the same polygon between 2 very close positions as a normal path.
2020-01-20 22:48:25 +01:00
Giacomo Pozzoni
67d9d04d63 Core/PathGenerator: Fix path generator returning shortcuts when start and end are on the same polygon (#24083)
* Core/PathGenerator: Fix path generator returning shortcuts when start and end are on the same polygon

Second try of handling paths on same poly in a better way than just building a shortcut

* Fix movement generators using paths with start/end positions far from mmap polygons

* Include flag PATHFIND_FARFROMPOLY even with a normal path if start or end were far away from mmap poly
2020-01-20 08:15:31 +01:00
Killyana
c1580108f6 DB/Quest: Convert Reports from the Field to SAI 2020-01-19 22:25:56 +01:00
NoName
50d9d9196d Core/Gameobject: Rename GO_STATE_ACTIVE_ALTERNATIVE to GO_STATE_DESTROYED (#24062)
* Step 1: Rename GO_STATE_ACTIVE_ALTERNATIVE to GO_STATE_DESTROYED

* Update src/server/shared/SharedDefines.h

Co-Authored-By: Trond B. Krokli <38162891+illfated@users.noreply.github.com>

Co-authored-by: Trond B. Krokli <38162891+illfated@users.noreply.github.com>
2020-01-19 17:51:30 +01:00
Sorikoff
bfac09bbcf Scripts/Quests: Reports from the Field (#24075) 2020-01-19 16:45:05 +01:00
Sorikoff
07c0bfe11b Scripts/Violet Stand: Warmages (#24084)
* Scripts/Violet Stand: Warmages

* Rename 9999_99_99_99_world.sql to 2020_01_19_02_world.sql

Co-authored-by: Giacomo Pozzoni <giacomopoz@gmail.com>
2020-01-19 16:36:27 +01:00
Sorikoff
f20b147c71 Scripts/Transitus Shield: Warmages (#24082)
* Scripts/Transitus Shield: Warmage

* Scripts/Transitus Shield: SQL fix

* Scripts/Transitus Shield: improve SQL

* Rename 9999_99_99_99_world.sql to 2020_01_19_01_world.sql

Co-authored-by: Giacomo Pozzoni <giacomopoz@gmail.com>
2020-01-19 16:35:28 +01:00
jackpoz
9f8477cd11 Core/PathGenerator: Temporarily revert 29bf280e34
Temporarily revert 29bf280e34 since our recast implementation always expects a path to have different polygons.
A proper fix will be implemented later on, splitting a path with 1 single polygons in smaller steps in a similar way of how FindSmoothPath() works
2020-01-18 20:24:26 +01:00
jackpoz
c1df161e1d Scripts/Ulduar: Fix Ominous Clouds movements
Fix Ominous Clouds being only clockwise, now they move both clock and counter-clock wise.
Add a workaround for GenericMovementGenerator not handling correctly cyclic splines started by MoveCirclePath(), stopping the movement after a single round. The workaround code can be removed once the bug in GenericMovementGenerator is fixed.
2020-01-17 23:05:25 +01:00
NoName
b3b7f0761d Core/Spells: SPELL_AURA_48 implementation (#24054)
by xvwyh
2020-01-17 16:50:50 +01:00
Killyana
8942142286 Spell: "Fierce Lightning Stike" must hit only one target 2020-01-17 01:12:43 +01:00
Killyana
4a6ecbaec5 DB/Quest: Convert the quest "Missing in Action" to SAI
Closes #24030
2020-01-15 16:08:59 +01:00
Shauren
e660c8bc19 Scripts: Fix rbac permission for skipping default boss sequencing check 2020-01-14 23:53:08 +01:00
Kelno
2b024e8fbf Fixed PvP Combat timer never getting refreshed (#24058)
* Fixed PvP Combat timer never gets refreshed while meleeing

* Apply Treeston feedback

Co-authored-by: Giacomo Pozzoni <giacomopoz@gmail.com>
2020-01-14 21:16:23 +01:00