Commit Graph

19648 Commits

Author SHA1 Message Date
Shauren
1ca5d951f2 Scripts/Spells: Update warrior spells to modern standards 2022-03-08 15:52:49 +01:00
Shauren
7d6c7accdb Scripts/Spells: Update priest spells to modern standards 2022-03-08 15:47:20 +01:00
Ovah
60119ba850 Core/Spells: implement SpellInfo helper to filter for relevant mechanic immunities in spell_start packet (#26183)
* Core/Spells: implement SpellInfo helper to filter for relevant mechanic immunities when sending SMSG_SPELL_START packets.

According to sniff analysis Blizzard does not send all mechanic immunities of creatures but instead only the ones that are responsible for actual interrupts which are MECHANIC_INTERRUPT  and MECHANIC_SILENCE. Additionally we no longer send immunities for instant cast spells as sniffs confirm that they are not sent for spells without a cast time.

(cherry picked from commit 6215cb4e00)
2022-03-08 00:31:02 +01:00
Jan Van Buggenhout
b4f27875f3 Core/Entities: Move GridObject to its own header (#26358)
* GridObject

* Add include to more files

(cherry picked from commit 43dd1b37d6)
2022-03-08 00:14:25 +01:00
offl
e72264cfbd Core/Misc: Define / rename attributes and flags (#26315)
Co-authored-by: Trond B. Krokli <38162891+illfated@users.noreply.github.com>
(cherry picked from commit e6d9d9ead9)
2022-03-07 23:35:21 +01:00
Giacomo Pozzoni
8d7e152d28 Scripts/Commands: Add ".list auras id <aura id>" and ".list auras name <name part>" subcommands (#26346)
Add ".list auras id <aura id>" and ".list auras name <name part>" subcommands to allow filtering the auras

(cherry picked from commit 9aff21b3d5)
2022-03-07 22:46:00 +01:00
jackpoz
1039f166de Scripts/Commands: Restore ".character level" command behavior
Restore ".character level" command behavior by setting the level instead of adding the level

(cherry picked from commit 2cea7d000c)
2022-03-07 22:25:50 +01:00
Mikhail Redko
6855c81df1 Core/Player: Fix output of .additem command with negative count value (#26290)
(cherry picked from commit 6a72f9fbfd)
2022-03-07 22:17:27 +01:00
CraftedRO
033366ab11 Group repair command attempt (#26304)
* Group repair command attempt

* Update cs_group.cpp

(cherry picked from commit db69b832b9)
2022-03-07 22:06:51 +01:00
Keader
2e69b64d67 Revert "Core/Spells: Spells with Attribute SPELL_ATTR1_DISPEL_AURAS_ON_IMMUNITY should dispel snare auras. (#20621)"
This reverts commit b507acf1c0.

(cherry picked from commit c6e2b6e88c)
2022-03-07 22:05:49 +01:00
offl
4b8bd9e4bc Scripts/Quest: Rework 'Basic Orders' (25199) (#26294)
(cherry picked from commit 293ae05d31)
2022-03-07 22:04:51 +01:00
offl
f87aa64a14 Scripts/Ahn'kahet: Herald Volazj texts (#26202)
Co-authored-by: Giacomo Pozzoni <giacomopoz@gmail.com>
(cherry picked from commit 1a624cad36)
2022-03-07 20:59:28 +01:00
Jakub Cieplinski
77d320b9fc Group level up (#26139)
* First version of command handler

* Done HandleReviveAllCommand

* Moved command to group subcommonads

* Added group level up

* Removed empty line

* Added additional nullchecks

* Removed newline

* Code styling

* Added group set level command

* Removed whitespace

* Removed group set level command

* Unnecessary comma

* Added check for level lower bound

(cherry picked from commit 397d4b5d05)
2022-03-07 20:50:09 +01:00
offl
1c2d73410d DB/Quest: Rework 'Avruu's Orb' (9418)
(cherry picked from commit df8ab338c7)
2022-03-07 20:25:58 +01:00
offl
4d2c93484c DB/Quest: Rework 'A Spirit Guide' (9410)
(cherry picked from commit c905af818c)
2022-03-07 20:25:58 +01:00
offl
2c8f166414 DB/Quest: Rework 'The Road to Falcon Watch' (9375)
Closes #26233

(cherry picked from commit 43fa6698d7)
2022-03-07 20:25:58 +01:00
offl
581a573c09 Scripts/Misc: Let core take care of Feign Death related flags
(cherry picked from commit 62594c62f6)
2022-03-07 20:25:57 +01:00
offl
43f63d7631 Scripts/Spells: Feign Death & 'prevent emotes flag' spell scripts (#26198)
Closes #25842 Ref #25764

(cherry picked from commit d0b67aecb6)
2022-03-07 20:25:57 +01:00
offl
7b57dc02d1 Scripts/The Eye: Update instance script (#26190)
(cherry picked from commit 5a22cd868a)
2022-03-07 00:18:14 +01:00
offl
18beee8ba1 Core/Spells: Apply UNIT_FLAG_IMMUNE after applying SPELL_AURA_DAMAGE_IMMUNITY (#26187)
(cherry picked from commit 10304a8875)
2022-03-07 00:18:13 +01:00
offl
9ac16dc219 DB/Spells: Sayge's Carnie Buff & Buffeting Winds of Susurrus
Ref #24663

(cherry picked from commit d6c8359224)
2022-03-07 00:15:53 +01:00
Shauren
fc456f7512 Core/Units: Renamed unknown unit flag (UNIT_FLAG_UNK_29 -> UNIT_FLAG_PREVENT_EMOTES_FROM_CHAT_TEXT)
(cherry picked from commit a34519bded)
2022-03-06 23:58:00 +01:00
Keader
d9b7a40d43 Script/Ulduar: Fixed conflict with Random Aggro Periodic spell (#26184)
(cherry picked from commit 06c1f728ba)
2022-03-06 23:34:36 +01:00
Jakub Cieplinski
95ccf9fc15 Revive all command (#26127)
* First version of command handler

* Done HandleReviveAllCommand

* Moved command to group subcommonads

* removed empty row

* nullptr check for player target

(cherry picked from commit 97e41645d3)
2022-03-06 23:25:54 +01:00
jackpoz
c6c0baa25c Scripts/Ulduar: Apply renames of #25529
Apply renames of #25529 to review that PR easier

(cherry picked from commit 7635f3f948)
2022-03-06 23:08:53 +01:00
offl
99a47c40b2 DB/Instance/Gruul's Lair: Overhaul
(cherry picked from commit cdb7904182)
2022-03-06 22:48:56 +01:00
Giacomo Pozzoni
9bcff210f9 Core/Maps: Use a fixed offset instead of full collision height when retrieving floor Z (#26092)
Use a fixed offset 0.5f instead of full collision height when retrieving floor Z as a full collision height ended up on the floor above a few times. It makes more sense to cast the ray just a bit higher up than using a full collision height (which by default is 2.0f)

(cherry picked from commit f96aab2186)
2022-03-06 22:24:01 +01:00
offl
e560eb46cd DB/Instance/The Eye: Overhaul part 2
(cherry picked from commit 6ad76dd7c0)
2022-03-06 21:58:00 +01:00
Gildor
d57dd854e9 Scripts/Events: Fix achievement in Love is in the air: "Lonely?" (#26083)
* Scripts/Events: Fix achievement in Love is in the air: "Lonely?"

* apply @keader feedback ;)

* apply @jackpoz feedback ;)

* @jackpoz feedback

(cherry picked from commit ca253e4124)
2022-03-06 21:52:04 +01:00
offl
e5ddd07619 DB/Instance/The Eye: Overhaul part 1
(cherry picked from commit 2f9e38612f)
2022-03-06 21:51:35 +01:00
Engilas
8a4d731d55 Core/SmartAI: AI change on charmed (#26065)
* Fix AI refresh on charmed

* Remove unnecessary refresh

* Check SMART_EVENT_FLAG_WHILE_CHARMED flag

(cherry picked from commit f6e52f6b3d)
2022-03-06 21:40:42 +01:00
Gildor
bb34a9456e Scripts/UtgardePinnacle: Svala Sorrowgrave Ritual improvements (#25997)
* Scripts/UtgardePinnacle: Svala Sorrowgrave Ritual improvements

* remove unneded fall
thx @offl

* apply @Ovahlord feedback

* prevent svala fall (visual) when ritual start after wipe

* svala should be disarmed before teleport when ritual start

* apply @Ovahlord feedback
* Use DoCastSelf
* Remove unneded AttackStart when finish ritual
* Use SetDisableGravity properly

(cherry picked from commit 0675be4bc3)
2022-03-06 20:23:59 +01:00
jackpoz
c93d6856c7 Core/Unit: Fix crash when exiting a vehicle
Ref #25649

(cherry picked from commit b84b925063)
2022-03-06 20:01:38 +01:00
jackpoz
730a8da9e9 Core/Unit: Set stand state on damage only to players
(cherry picked from commit 4cc1f85067)
2022-03-06 20:01:25 +01:00
offl
ca76786faf Core/Scripts: Move some speed values & UNIT_FLAG_NOT_SELECTABLE to DB
(cherry picked from commit 3cb70ee62a)
2022-03-06 20:01:06 +01:00
offl
38476e51e7 DB/GameObject: Matrix Punchograph
Closes #25881

(cherry picked from commit e5518b53fa)
2022-03-06 19:41:58 +01:00
offl
cdd2875649 DB/Creature: Remove UNIT_FLAG_PACIFIED
Ref #25764

(cherry picked from commit a9c83d5566)
2022-03-06 19:39:10 +01:00
jackpoz
3886c82d0f Scripts/EoE: Attempt to fix players getting stuck after dying
Attempt to fix players getting stuck after dying caused by a hack that calls SetControlled(true, UNIT_STATE_ROOT) by calling the opposite when a dead player leaves the instance, i.e. on releasing.
Close #24458

(cherry picked from commit dc21ac342e)
2022-03-06 19:00:26 +01:00
Giacomo Pozzoni
a4a3e2e759 Core/Creature: Allow to skip Rate.Corpse.Decay.Looted when calling SetCorpseDelay() (#25989)
Add a second parameter to SetCorpseDelay() that specifies if Rate.Corpse.Decay.Looted setting should be ignored, false by default (aka don't ignore by default).
Add a second parameter to SMART_ACTION_SET_CORPSE_DELAY to specify if Rate.Corpse.Decay.Looted should be included, false by default (aka ignore by default).

(cherry picked from commit d5fc86af8b)
2022-03-06 18:59:38 +01:00
Giacomo Pozzoni
1ec33095e6 Core/Warden: Send Lua checks only when ingame (#25977)
(cherry picked from commit 3e6b3f88b0)
2022-03-06 18:54:04 +01:00
Matan Shukry
e93ef06b05 Core/Commands: Implemented command to teleport character to npc
Closes #25870

(cherry picked from commit d2be584f99)
2022-03-06 16:37:42 +01:00
offl
8e9e15629f Core/Scripts: Verify & migrate spell school immunities to DB
Some already are stored in DB. Looks like they all are still valid for master

(cherry picked from commit 1ed79d7a2e)
2022-03-06 16:30:51 +01:00
Giacomo Pozzoni
4c30b2a182 Core/SAI: Add new action SMART_ACTION_SET_HEALTH_PCT (#25932)
* Core/SAI: Add new action SMART_ACTION_SET_HEALTH_PCT

Add new action SMART_ACTION_SET_HEALTH_PCT (142) with one single parameter "percent" to set the Unit health.
Close #25317

* Do not allow 0%

(cherry picked from commit 7d6f7e4d19)
2022-03-06 01:43:57 +01:00
Meji
23d77ecb81 Core/Spells: Fixed spell effect 43 (SPELL_EFFECT_TELEPORT_UNITS_FACE_CASTER) (#25945)
(cherry picked from commit 28353e920b)
2022-03-06 01:38:14 +01:00
Giacomo Pozzoni
a66b968f91 Core/Misc: Fix static analysis issues (#25924)
* Core/Misc: Fix static analysis issues

* Fix infinite loop in ".debug send opcode"
Fix using uninitialized memory in ".debug send opcode"

(cherry picked from commit 661f554b9e)
2022-03-06 01:35:01 +01:00
jackpoz
4e3d23188e Scripts/Commands: Improve ".debug objectcount"
Include the number of SetActive objects in ".debug objectcount" command

(cherry picked from commit d0231c5a8f)
2022-03-06 01:23:14 +01:00
Giacomo Pozzoni
5180abfb19 Core/Creature: Add new db field InteractionPauseTimer (#25880)
* Core/Creature: Add new db field InteractionPauseTimer

Add new db field InteractionPauseTimer to allow to define different interaction pause timers for each creature (the previous system was a global setting in worldserver.conf Creature.MovingStopTimeForPlayer)

* Set all columns in creature_template_movement as optional (can be NULL, default NULL). Fill only the columns that should override the default C++ value

* Use the InteractionPauseTimer value throughout the code instead of Creature.MovingStopTimeForPlayer

* Handle InteractionPauseTimer set to 0 as "don't stop at all"

* Implement InteractionPauseTimer in creature_movement_override

creature_movement_override allows NULL values, in which case the values from creature_template_movement will be used for those columns that are NULL, falling back to default C++ values if creature_template_movement has NULL values too (or no rows for the creature)

* Read default InteractionPauseTimer from worldserver.conf

* Rename 2021_99_99_99_world.sql to 2021_01_22_00_world.sql

(cherry picked from commit a22bc236eb)
2022-03-06 00:56:46 +01:00
Jan Van Buggenhout
dbf528be69 Core/Misc: Fix typo in SendAuthWaitQue method name (#25887)
(cherry picked from commit a832a1fe90)
2022-03-06 00:31:02 +01:00
Jan Van Buggenhout
9df5eb27e0 Core/Misc: Update WorldSocket::OnRead to WorldSocket::ReadDataHandler in comments and logging (#25885)
(cherry picked from commit ec689e7908)
2022-03-06 00:27:11 +01:00
offl
1d09bd112a DB/Creature: Remove UNIT_FLAG_STUNNED in more cases
Ref #25764

(cherry picked from commit 7b79adf5b1)
2022-03-06 00:05:49 +01:00