Commit Graph

22956 Commits

Author SHA1 Message Date
SnapperRy
35eeb76506 Core/Unit: don't reset offhand timer for players when starting attack.
Creatures are unaffected by this change. Not sure how they should behave in this case, so leaving it alone for now.

Closes #945.

(cherry picked from commit c25f7c48b5)
2017-03-05 01:06:45 +01:00
SnapperRy
30153510e8 Script/Quest: A Cry For Help: (#18026)
- Add missing dialogue from Cowlen.
- Timers and emotes.
(cherry picked from commit 790844e72d)

Rename two SQL files.
(cherry picked from commit 283aec9656)
2017-03-05 01:06:44 +01:00
SnapperRy
8c7b3c8a2b Core/Loot: do not show unique items if player already has the maximum allowed quantity.
(cherry picked from commit 5c5b8df613)

Core/Loot: limit unique items check in LootItem::AllowedForPlayer() to bind-when-picked-up items only.

(cherry picked from commit ea6911517d)
2017-03-05 01:06:44 +01:00
SnapperRy
de8aecacbc Core/Quest: send INVALIDREASON_QUEST_ALREADY_DONE if player tries to accept a quest that is already rewarded.
(cherry picked from commit 9bca68fb56)
2017-03-05 01:06:43 +01:00
ariel-
6c099d0c26 Core/Spells: Flag of Ownership shouldn't target creatures
(cherry picked from commit b54042d68f)
2017-03-05 01:06:41 +01:00
ariel-
44d48c80ee Core/Player: correct logic for IsUsingTwoHandedWeaponInOneHand
Fixes penalty not being applied when we are using a 2H in offhand, and a unarmed MH.
MH may do unarmed attacks in this case. (reciprocal of 2H MH, unarmed OH, only uses MH normally, OH doesn't unarmed attack)

(cherry picked from commit bdf7cf6d50)
2017-03-05 01:06:40 +01:00
ariel-
062ca4ac69 Core/Spell: Add Dual Wield skill dependency to Dual Wield effect, should remove the skill properly when unlearning spell.
Closes #17196

(cherry picked from commit 405167dafd)
2017-03-05 01:06:40 +01:00
joschiwald
ddd58ddcd8 Forgot to press Ctrl+S 2017-03-04 22:54:45 +01:00
ariel-
4c0bed8283 Core/Spells: SPELL_AURA_SCHOOL_IMMUNITY auras shouldn't remove passive auras (even if negative)
Ref issue #6375

(cherry picked from commit b2fbd2c75d)
2017-03-04 20:19:09 +01:00
ariel-
3ce3acf765 Core/Player: Implemented Titan's Grip damage reduction
Closes #6375

(cherry picked from commit a4baef19dd)

Core/Player: unconditionally remove Titan's grip penalty aura on Spell removal

Was causing an issue when switching spec, because off hand weapon was still equipped
(cherry picked from commit df0f88eb80)
2017-03-04 20:18:55 +01:00
ariel-
a3832be8d6 Core/Spells: Implemented SPELL_ATTR6_NOT_RESET_SWING_IF_INSTANT.
Closes #1765

(cherry picked from commit 03e21d2fad)
2017-03-04 20:03:54 +01:00
SnapperRy
dfee7f7301 Core/Script: make creature Webbed Creature spawn creature Expedition Researcher when appropriate.
Also don't allow it to spawn a copy of itself.

(cherry picked from commit d59f111cab)
2017-03-04 19:01:47 +01:00
SnapperRy
28e9f06410 Misc/Config: fix an oversight.
Thanks tkrokli for noticing.
(cherry picked from commit a5e05d0d0c)
2017-03-04 19:01:45 +01:00
SnapperRy
c223b0dfe1 Misc/Config: enable ChatFakeMessagePreventing by default, since it's a blizzlike feature.
(cherry picked from commit 2deea99cd7)
2017-03-04 19:01:45 +01:00
SnapperRy
1006091f16 Core/Config: allow to specify daily quest reset hour in config.
Also default it to 3:00AM, as that's when daily quests used to reset during WotLK.

(cherry picked from commit e9870fb1fc)
2017-03-04 19:01:44 +01:00
SnapperRy
4f34c8c563 Core/Spell: set quest to rewarded instead of complete when targeted by SPELL_EFFECT_QUEST_COMPLETE. (#18021)
Prevents people from ending up with strange quests in their quest logs.
(cherry picked from commit 6d62f852ac)
2017-03-04 19:01:43 +01:00
SnapperRy
034ff93ba8 Core/World: properly re-initialize daily quest reset time when resetting daily quests. (#17986)
Prevents daily quests from resetting at weird times when restarting the server after a player has completed a daily quest.
(cherry picked from commit f9ea646c82)
2017-03-04 19:01:42 +01:00
SnapperRy
eb75601a0c Core/Log: move an error to DEBUG level.
Prevents console spam in case of players canceling the cinematic at characters' first login.
(cherry picked from commit 1e2d55acf0)
2017-03-04 19:01:41 +01:00
Shauren
b8db320bf1 Core/Misc: Prefix all preprocessor defines from CompilerDefs with TRINITY_ to avoid conflicts (PLATFORM_WINDOWS is used/defined by CascLib) 2017-03-04 18:46:18 +01:00
Keader
da0190f3d0 Core/Scripts: Fixed Gunship Mage cast interrupt
Closes: #14912

(cherry picked from commit 05c2fa2e02)
2017-03-04 00:05:55 +01:00
Treeston
f02ff3bd6b [3.3.5] Azjol-Nerub rewrite
* Scripts/AzjolNerub: Complete rewrite.
- Gatewatcher:
  - Trash now actually engages properly one by one
  - Fix trash spell casting
  - Add missing quotes
- Hadronox:
  - Everything. Literally.
- Anub'arak:
  - Fix add spawns
  - Fix impale
  - OK this might as well be "fix everything with every boss". Because that's pretty much what happened.
- General hack cleanup

* Update and rename 9999_99_99_99_AZJOLNERUB.sql to 2016_09_25_01_world.sql

* Update and rename 2016_09_25_01_world.sql to 2016_09_25_02_world.sql

* Rename 2016_09_25_02_world.sql to 2016_09_26_02_world.sql

(cherry picked from commit 4b990eb7d7)

# Conflicts:
#	src/server/game/Spells/SpellMgr.cpp
#	src/server/scripts/Northrend/AzjolNerub/AzjolNerub/azjol_nerub.h
#	src/server/scripts/Northrend/AzjolNerub/AzjolNerub/boss_anubarak.cpp

Update boss_hadronox.cpp
(cherry picked from commit 04ec868768)

Update boss_hadronox.cpp

I hate travis, learn from buildbot
(cherry picked from commit aeb20951bb)

I think I got all of them this time

No idea how this one got past travis.
(cherry picked from commit ae163197a7)

Fix nonPCH.
(cherry picked from commit e121d66fbb)

...for real this time (seriously - what happened to test builds before merging, Aok?)
(cherry picked from commit dbe0789eba)

.....hail PCH
(cherry picked from commit 2528194cc1)

and you get a header, and everyone gets a header...
(cherry picked from commit 5e5fe37a7e)
2017-03-04 00:05:55 +01:00
joschiwald
e465465c67 Fixed build 2017-03-03 23:28:12 +01:00
SnapperRy
6b8cb42b1e Script/Quest: Trail of Fire (#17939)
(cherry picked from commit 31e495f44c)

Rename 9999_99_99_99_world.sql to 2016_09_25_03_world.sql
(cherry picked from commit 28968c6162)

DB/SAI: fix db errors introduced in 31e495f.
(cherry picked from commit 2452fb977b)

Core/Scripts: Fix build
(cherry picked from commit 6174091d76)
2017-03-03 22:55:23 +01:00
joschiwald
2dfdaa49b4 Core/Auth: removed unneeded sub query
(cherry picked from commit ec221c5500)

# Conflicts:
#	src/server/authserver/Server/AuthSession.cpp
2017-03-03 22:48:04 +01:00
tkrokli
e13fadf8e9 Core/Scripts: move #define to enum/boss emote to DB (#17967)
boss_lurker_below.cpp : remove deprecated #define entries
- remove hardcoded text, use creature_text/broadcast_text
- move #define value & text reference to enum section
- replace TextEmote() with Talk() pointing to DB entry
(cherry picked from commit cd6fcce84b)
2017-03-03 22:31:29 +01:00
jackpoz
9d09307e34 Scripts/ICC: Fix chest loot exploit
Fix an exploit at chest loot bosses Valithria and Deathbringer that allowed the first played to hit them to leave party at low hp % and loot the whole chest alone, without the party being able to loot anything.

(cherry picked from commit c4865fe63e)

# Conflicts:
#	src/server/game/Entities/GameObject/GameObject.cpp
2017-03-03 22:31:28 +01:00
SnapperRy
df3e8cab12 Script/Quest: improvements for Let Them Eat Crow. (#17948)
(cherry picked from commit 275a53b34d)

Rename 9999_99_99_99_world.sql to 2016_09_24_06_world.sql
(cherry picked from commit 7a1f41077f)
2017-03-03 22:31:28 +01:00
SnapperRy
3897de67a4 Core/Creature: update health/mana/damage/armor when changing a creature's entry while keeping the original level.
Fixes an issue introduced in a6ef9d4.

(cherry picked from commit 3d075da504)
2017-03-03 22:01:47 +01:00
tkrokli
958665ab2e Core/Scripts: move npc_lunaclaw_spirit to SAI
This PR moves the core script `npc_lunaclaw_spirit` to SAI, removing hardcoded text.
The quests 6001 + 6002 are druid class quests to get bear form, removed in patch 4.0.3a

Changes in this PR:
- remove core script, including hardcoded text (with typo)
- use gossip_menu_option for each faction (Alliance & Horde)
- add SAI script to complete quest 6001 or 6002 based on option
- add gossip option conditions for team A (469) or team H (67)
- add gossip option conditions for quest 6001/6002 not completed

(cherry picked from commit 3ad76dea7b)
2017-03-03 21:57:23 +01:00
SnapperRy
6ad12301b4 Script/Quest: The Exorcism of Colonel Jules:
- Summoned NPCs will no longer give experience on kill.
- Require quests Fel Spirits and Digging for Prayer Beads to be completed.
- Reduce number of Foul Purges spawned in a single wave (only two should spawn each time).
- Properly give quest credit when talking with Colonel Jules after the exorcism.

(cherry picked from commit 0d70a7349d)
2017-03-03 21:55:01 +01:00
treeston
6a7ef793ca Scripts/IcecrownCitadel: Fix an issue where Deathbringer Saurfang's exit door could get stuck in a closed state. Fixes and closes #15018.
(cherry picked from commit 429700e614)
2017-03-03 21:51:36 +01:00
Keader
f6c9aff606 Core/Scripts: XT002 improvements in Hard Mode. Closes #17141. (PR #17900)
(cherry picked from commit 1f83412e4d)
2017-03-03 21:51:16 +01:00
Shauren
16698e5b25 Core/Movement: Defined many unknown MovementFlags2 2017-03-03 20:26:45 +01:00
treeston
8dc441ce49 Movement/SplineChain: Fix a potential critical bug where resume info returned during an edge case could fail an assertion when used.
(cherry picked from commit 55ac0186cc)
2017-03-02 21:13:34 +01:00
treeston
b12f19f066 Movement/SplineChain: Streamline the script workflow for resume info a bit, provide static method that does all the ugly pointer casts for you. Also prevent a nullptr dereference crash if scripts mishandle motionmaster, and canonize Chain == nullptr to signify "no resume info".
(cherry picked from commit d3214a0012)

d3214a0 follow-up for code style.
(cherry picked from commit 4deeee66bd)
2017-03-02 21:10:00 +01:00
treeston
ec9c5b19ac Map/InstanceMap: Ease up on a somewhat overzealous error message regarding instance saves.
(cherry picked from commit 820e843391)

# Conflicts:
#	src/server/game/Maps/Map.cpp
2017-03-02 21:09:24 +01:00
treeston
019fc08feb Core/Movement: Fix a DB spline chain overload I missed in 2170541
(cherry picked from commit 3ec1b2f27e)
2017-03-02 20:51:25 +01:00
treeston
205ec4c3bf Core/Unit: Standardize SetFacingTo and SetFacingToObject behavior while moving. Both now fail while moving unless arg2 bool is true.
Movement/SplineChain: Bump value range for DB chainId up to uint16 (0 to 65535) from uint8 (0 to 255). Turns out sniffs generate far more chains than I expected.

(cherry picked from commit 2170541a51)

Code style follow-up, I blame Notepad++.
(cherry picked from commit 7860da0de6)
2017-03-02 20:47:29 +01:00
treeston
b94642fb49 Instance/Naxxramas: Loatheb no longer instantly murders you. Five spam casts of Doom tend to do that to raids.
(cherry picked from commit 59527521e6)

5952752 follow-up: Member declaration now matches order of usage.
(cherry picked from commit 3298a5f65d)
2017-03-02 20:44:41 +01:00
Shauren
2c27c5b5b9 Core/DataStores: Fixed crash in hotfix packet building
Closes #19218
2017-03-02 19:48:58 +01:00
treeston
59d48ce7e4 Core/Movement: Add new SplineChainMovementGenerator that allows accurate replication of sniffed waypoints in static sequences, along with DB facilities that allow loading of waypoints from DB.
(cherry picked from commit 6d00d3f283)

Merge remote-tracking branch 'Treeston/3.3.5-splinechains' into 3.3.5 (PR #17946)
(cherry picked from commit 20f483967f)

Core/Movement: Add a convenience default ctor to SplineChainResumeInfo, and fix PCH build in some configurations (zzz why do we even keep Appveyor and Travis around).
(cherry picked from commit 4fa646c0b2)

PCH build fix. Again.

(( Alright, you made me waste 20 minutes of my life on a full nonPCH rebuild of the core now. ))
(( I hope you're happy. ))
(cherry picked from commit 4a1a460241)
2017-03-01 22:03:35 +01:00
tkrokli
e4e1f4152f Core/Scripts: simplified npc_pet_trainer gossip script
This is what the script changes should have been in PR #17746
(also updates issue #14719 with a correct solution).

- remove OnGossipHello() to use DB conditions
- replace OnGossipSelect() with sGossipSelect()
- focus script on the confirming gossip option
- let the other gossip menus be handled in DB

(cherry picked from commit a475033c76)
2017-02-28 20:40:49 +01:00
Treeston
9b4ad0022b Map/Instances: Greatly simplify PermBindAllPlayers logic. (#17940)
(cherry picked from commit cf628880d5)
2017-02-28 20:25:20 +01:00
Shauren
d4d8366131 Proper typo fix, it was too early in the morning 2017-02-28 10:58:35 +01:00
Shauren
5b4820cc0f Typo/build fix 2017-02-28 08:46:11 +01:00
SnapperRy
9da35aa3bd Core/Achievement: do not consider overkill damage for ACHIEVEMENT_CRITERIA_TYPE_DAMAGE_DONE.
(cherry picked from commit 4eb799560c)

Fix wrong copy-paste from last commit.

Sorry.
(cherry picked from commit c41b4000f9)
2017-02-27 21:59:02 +01:00
Shauren
c7cd51e8f5 Core/Movement: New names for a few spline flags 2017-02-27 19:30:44 +01:00
SnapperRy
87b6b9c27f Core/Creature: enable pet bar for TempSummons with category SUMMON_CATEGORY_PET.
Thanks @ariel- for helping with the research (although I'm two months late).
(cherry picked from commit 025002b907)
2017-02-26 21:34:05 +01:00
SnapperRy
1b288ebbdd Core/SmartAI: do not target player's group for SMART_ACTION_CALL_AREAEXPLOREDOREVENTHAPPENS.
SMART_TARGET_INVOKER_PARTY or SMART_ACTION_CALL_GROUPEVENTHAPPENS should instead be used to achieve this functionality.

(cherry picked from commit 6586885bca)
2017-02-26 21:31:16 +01:00
vincent-michael
7c12096df0 Core/PacketIO: Re-enabled SMSG_INITIAL_SETUP opcode 2017-02-26 21:06:10 +01:00