Commit Graph

18158 Commits

Author SHA1 Message Date
r00ty-tc
4c996bdf8b Core/GameEventMgr: Log error if loading GO/Creature into event that is part of pool - Only warn, still load the GO/Creature - These should be added to game_event_pool by pool ID instead
(cherry picked from commit 8bb88657f8)
2021-11-26 22:06:18 +01:00
Killyana
f7048afac1 Core: Remove wrong emotes played in combat
Ref #23152

(cherry picked from commit c52eb49f71)
2021-11-26 11:22:26 +01:00
Gustavo
b86a66c5be Core/Scripts: Fix Blood summon position (#23088)
* Core/Scripts: Fix Blood summon position

Updates #13162

(cherry picked from commit cc3293c002)
2021-11-26 11:21:24 +01:00
Gustavo
6aaf9aaf3b Core/Misc: Warning fixes (/W4) (#23149)
* Core/Misc: Warning fixes (/W4)

(cherry picked from commit 50f122de77)
2021-11-26 11:18:15 +01:00
Shauren
e538759dfd Build fix 2021-11-25 21:02:46 +01:00
Meji
b02f382ed7 Core/Trainers: Implemented learning battle pets from trainers (#27312) 2021-11-25 20:56:37 +01:00
Meji
93c668ac50 Core/BattlePets: Implemented BattlePetSpeciesFlags::NotAccountWide (#27303)
Co-authored-by: Shauren <shauren.trinity@gmail.com>
2021-11-25 20:55:12 +01:00
ModoX
52824eedd3 Core/Spells: Use Unit::Kill instead of Unit::DealDamage for SPELL_EFFECT_INSTAKILL (#27316) 2021-11-25 19:25:38 +01:00
jackpoz
721f4c6032 Core/Misc: Fix static analysis issues
Fix static analysis issues spotted by Coverity Scan

(cherry picked from commit 750d89beed)
2021-11-24 23:45:36 +01:00
jackpoz
71cb10afe0 Core/Misc: Fix static analysis issues
Fix static analysis issues spotted by Coverity Scan

(cherry picked from commit a12ea482f3)
2021-11-24 23:45:27 +01:00
jackpoz
43a41caafb Core/Misc: Fix GCC 8 warnings
(cherry picked from commit 1d04a3b216)
2021-11-24 23:40:15 +01:00
sirikfoll
dc5cab3bf4 Core/GameObject: Properly dismount players on GameObject Use
Closes #23124

(cherry picked from commit dbfc6ce773)
2021-11-24 23:34:48 +01:00
ForesterDev
b26c2f5c13 Core/Conditions: implement CONDITION_GAMEMASTER (#23108)
(cherry picked from commit 262ddaf819)
2021-11-24 22:56:14 +01:00
PolarCookie
e182a38b01 Core/Item: Item Signature (#23119)
(cherry picked from commit a926a3088d)
2021-11-24 22:42:13 +01:00
Trond B. Krokli
bc628572fe Scripts/Wailing Caverns: make Disciple of Naralex say Mutanus, not $n (#23122)
* Scripts/Wailing Caverns: make Disciple of Naralex say Mutanus the Devourer

Disciple of Naralex should say
"This Mutanus the Devourer is a minion from Naralex's nightmare no doubt!"
instead of using $n caused by a missing target in the Talk() script command.

(cherry picked from commit a040d48443)
2021-11-24 22:39:18 +01:00
Killyana
a99a60bcf3 Core/GameObject: Remove summoned game objects from the map after calling SetSpawnedByDefault(false) (#23120)
Closes #23115

(cherry picked from commit 5f04c829a8)
2021-11-24 22:27:03 +01:00
Trond B. Krokli
36feb3bfe7 Scripts/Borean Tundra: link gossip content for NPC Iruk from DB (#23118)
- remove hardcoded text (deprecated method)
- add already existing DB gossip content to enum
- correct spell enum from spell_creature_ to spell_create_
- replace case switch with if statement (only one boolean case)

Extra script file update:
- remove SD comment line 22 (outdated info, replaced by SAI)

(cherry picked from commit 7cb31aa482)
2021-11-24 22:26:05 +01:00
Jozef Dúc
70cd58765e Check player conditions to enter instance (#23117)
Check player conditions to enter before party condition.

(cherry picked from commit 62f621fcd7)
2021-11-24 22:25:12 +01:00
Killyana
e5eff88282 Core/SAI: Fix Move to position and Set run if used after a waypoint
Closes #22976

(cherry picked from commit 9ab05e2b6d)
2021-11-24 22:16:02 +01:00
Killyana
da1166db98 Core/SAI: Fix the respawn event for GameObjects (#23112)
Closes #22612

(cherry picked from commit 75a8639242)
2021-11-24 22:15:52 +01:00
Killyana
8d806f8c69 SAI/GameObject: Despawn the linked trap with the gameobject
Closes #23105

(cherry picked from commit 750be73b99)
2021-11-24 21:22:50 +01:00
Aokromes
268e0bea18 Core/Disables: Implement SPELL_DISABLE_ARENAS (#23103)
* Core/Disables: Implement SPELL_DISABLE_ARENAS and SPELL_DISABLE_BATTLEGROUNDS

By fredimachado

(cherry picked from commit 73d2e5da37)
2021-11-24 21:20:46 +01:00
Langerz82
e61266815f Spell/Script: Guard's Mark
Closes #16888

(cherry picked from commit e840d4967e)
2021-11-24 20:41:03 +01:00
PolarCookie
f7299dce97 Core/Spell: SpellAura Redux (#22794)
* typo and correction

* spell aura no longer shared between targets

_spellAura isolated

* SPELL_AURA_CONTROL_VEHICLE is not strictly single target spell

Steam Tank Control and Wyrmrest Commander

units can reseat themselves again

* Rename 9999_99_99_99_world.sql to 2019_03_08_00_world.sql

(cherry picked from commit ec3cb05d7f)
2021-11-24 20:35:19 +01:00
ccrs
67e0b25739 Scripts/Northrend: 482e0da followup
add a little bit of tolerance

(cherry picked from commit a006362615)
2021-11-24 20:35:19 +01:00
ccrs
27bc3bc7db Scripts/Northrend: 482e0da followup
(cherry picked from commit 3eecadcebf)
2021-11-24 20:35:18 +01:00
Killyana
67e702b29b Spell/Script: Specify a target for Azure Dragon: On Death Force Cast Wyrmrest Defender to Whisper to Controller - Random
(cherry picked from commit e5470ab1ee)
2021-11-24 20:35:18 +01:00
Keader
c72afc76be Creature/Script: Daegarn
Remove the incorrect SAI and move it to cpp

(cherry picked from commit 482e0dad30)
2021-11-24 20:35:18 +01:00
Killyana
48c8b650bb Spell/Script: Summon Scourged Captive
Closes #16357

(cherry picked from commit 0959f3071a)
2021-11-24 20:35:18 +01:00
Gustavo
80421d7cac Core/Players: Fix logic in CanSeeSpellClickOn (#23090)
Block SpellClick for the npc if there is no entry

(cherry picked from commit 0eacccc2cd)
2021-11-24 20:35:18 +01:00
Shauren
2be8a1f189 Core/Misc: PORT CURSED REFACTORS FROM e69570dd76
WHO ON EARTH THOUGHT IT WAS A GOOD IDEA TO ADD REFACTORS TO A CHERRY-PICK COMMIT???
2021-11-24 20:35:18 +01:00
Keader
02db59806a Scripts/Trial of the Crusader: Fixed Slime Pool visual effect
Closes #21660

(cherry picked from commit e1aafddc2e)
2021-11-24 20:35:17 +01:00
jackpoz
7a2ef47495 Core/Spells: Adjust range checks to GameObject targets
(cherry picked from commit 72052aa9a5)
2021-11-24 20:35:17 +01:00
jackpoz
71b58c2e62 Core/Spells: Adjust range checks to GameObject targets
(cherry picked from commit 270a144083)
2021-11-24 20:35:17 +01:00
jackpoz
91bbaae81e Core/LFG: Teleport players to other players instead of dungeon entrance when continuing a LFG dungeon
This feature already existed in current code but was broken by d0334bf948

(cherry picked from commit d2841d6b66)
2021-11-24 20:35:17 +01:00
Sorikoff
a57ca5cea2 Core/Movement: Allow using run when moving randomly (#23081)
* Allow run when moving randomly

(cherry picked from commit 34cfa69efd)
2021-11-24 20:35:15 +01:00
jackpoz
ace33a464f Core/Misc: Code cleanup
(cherry picked from commit 6c5d997161)
2021-11-24 20:34:56 +01:00
jackpoz
c312b926b4 Core/MMaps: MMaps logs cleanup
Move MMaps related logs from "maps" category to "maps.mmaps".
Remove newlines in logs, the log system already takes care of newlines.

(cherry picked from commit 696039cfed)
2021-11-24 20:34:56 +01:00
Keader
955ac45cf5 Spell/Script: Freezing Circle
Closes #11312
See the original issue before cherry pick

(cherry picked from commit 990ad000f8)
2021-11-24 20:34:56 +01:00
jackpoz
bd0e9e7aa8 Core/MMaps: Fix infinite loop in Detour
Fix another infinite loop in Detour caused by degenerated triangles.
Check the result of some previously ignored Detour calls.
Update recastnavigation to 3a619d773deb7e3a15ee215217c825995fe71312 and apply some more custom changes

(cherry picked from commit c602220e02)
2021-11-24 20:34:56 +01:00
Killyana
b0f10b505e Core/GameObject: Set loot state to Not ready when a gob is deactivated (#23072)
(cherry picked from commit 8dec9b97e2)
2021-11-24 20:34:56 +01:00
Sorikoff
956158d299 Core/Movement: Allow using walk when chasing v2 (#23073)
* Allow walk when chasing

(cherry picked from commit dbadb6369c)
2021-11-24 20:34:54 +01:00
sirikfoll
402e63427e Scripts/Ulduar: Mimiron improvements
Closes #23043

Fix Aerial hover
Some visual issues

(cherry picked from commit a803342029)
2021-11-24 00:02:13 +01:00
Sorikoff
b3f75852c2 Allow walk when chasing (#23069)
(cherry picked from commit c2f2db08aa)
2021-11-24 00:02:13 +01:00
jackpoz
97401a2997 Core/Commands: Don't re-add active quests with ".quest add" command
(cherry picked from commit f17120cc78)
2021-11-24 00:02:13 +01:00
jackpoz
b8396f682c Core/MapScripts: Add support to GameObjects to SCRIPT_COMMAND_DESPAWN_SELF
(cherry picked from commit da19ad117e)
2021-11-24 00:02:08 +01:00
Aokromes
49e1ff34b7 Core/mmaps: add category to 2 logs
(cherry picked from commit a2f910fe5c)
2021-11-23 23:44:00 +01:00
jackpoz
abb36a1e5b Core/Spells: Add range checks to GameObject targets
Close #23062
Patch by robinsch

(cherry picked from commit 76cc94f325)
2021-11-23 23:34:27 +01:00
Gustavo
10c915dd34 Core/Units: Only update height in SetHover if unit is bellow HoverHeight (#23061)
(cherry picked from commit 2dfea54533)
2021-11-23 23:18:58 +01:00
Ovah
2dda5fb477 Scripts/MGT: Kael'thas intro can now be skipped when not killing the trash pack in his room
Scripts/MGT: Kael'thas will now despawn at evade

Cherry picked from
f6e9ff5ca4
ed8c1830f5

(cherry picked from commit c10c8c6bba)
2021-11-23 23:17:08 +01:00