ccrs
4f49cef15c
Build: fix variable order initialization error
...
fatal error: field 'Action' will be initialized after field 'Validator' [-Wreorder]
(cherry picked from commit 71e7394b74 )
2021-12-05 18:40:20 +01:00
ccrs
36a1d00444
Core/Movement: implement MotionMasterDelayedAction validator
...
(cherry picked from commit b2b85dedb6 )
2021-12-05 18:40:11 +01:00
ccrs
86b4aa01bb
Core/AI: PetAI method reordering
...
(cherry picked from commit acbfac7b13 )
2021-12-05 18:40:05 +01:00
Killyana
cb9a1c38f1
Instance/Script: Blood Furnace
...
Ref #23285
(cherry picked from commit 9435caa8d1 )
2021-12-05 18:39:09 +01:00
ccrs
97dddac75a
Core/PetAI: apply some movement related corrections
...
Unit::StopMoving() is evil, and so is MotionMaster::Clear()
the first can really mess up existing movement generators
the second can interrupt "controlled" movements... can do it literally mid-air
(cherry picked from commit 74678b247e )
2021-12-05 18:37:57 +01:00
ccrs
6814b4d32b
Core/PlayerAI: apply some movement related corrections
...
Unit::StopMoving() is evil, and so is MotionMaster::Clear()
the first can really mess up existing movement generators
the second can interrupt "controlled" movements... can do it literally mid-air
(cherry picked from commit a4e94dcf6b )
2021-12-05 18:37:48 +01:00
ccrs
c511fa2803
Core/Misc: remove incorrect ClearUnitState calls related to movement
...
these unit states should never be removed outside motionmaster's handlings
(cherry picked from commit 79b90f9d3a )
2021-12-05 18:37:12 +01:00
Aokromes
1d22ade73f
Core/Creature: equipment_id field on creature table is not working correctly, if it's set to 0 the npc still spawn with the equipement. ( #23273 )
...
By Malcrom
Closes #16416
(cherry picked from commit 61ba477c77 )
2021-12-05 18:20:36 +01:00
ccrs
bda32dfbd1
Core/AI: couple movement related corrections in FollowerAI
...
plus EnterEvadeMode streamline
(cherry picked from commit f309b49eb1 )
2021-12-05 16:51:19 +01:00
ccrs
88f5536c43
Core/AI: streamline FollowerAI::MoveInLineOfSight with SmartAI and EscortAI
...
plus another method reorganization
(cherry picked from commit d3b8d69e38 )
2021-12-05 16:50:53 +01:00
ccrs
edbf45404b
Core/AI: streamline FollowerAI::AssistPlayerInCombatAgainst with SmartAI and EscortAI
...
plus couple method reorganizations
(cherry picked from commit 0e22d61d4a )
2021-12-05 16:50:15 +01:00
ccrs
844f969ed7
Core/AI: logs, codestyle & cosmetics standarization
...
(cherry picked from commit fdb71ce19e )
2021-12-05 16:48:58 +01:00
ccrs
672d4d6baa
Core/AI: silence a freaking annoying VS IntelliSense warning
...
(cherry picked from commit 0eb5d240fa )
2021-12-05 16:19:57 +01:00
ccrs
dd11603150
Core/AI: variable naming standarization
...
plus minimum codestyle changes
(cherry picked from commit 179c7da1fc )
2021-12-05 16:17:02 +01:00
ccrs
6efb8d2d22
Scripts/Northrend: couple cosmetic corrections after 552720a
...
(cherry picked from commit 7025b00656 )
2021-12-05 16:02:29 +01:00
Wyreth
40ec90e1f5
Scripts/Northrend: improvements for quest Get Me Outa Here! (11673) ( #20753 )
...
* Script/Quest: improvements for quest Get Me Outa Here! (11673).
* Happiness for our Travis overlord
* Update 9999_99_99_99_world_quest_get_me_outa_here.sql
* Update zone_borean_tundra.cpp
* Update 9999_99_99_99_world_quest_get_me_outa_here.sql
* Update 9999_99_99_99_world_quest_get_me_outa_here.sql
* Fix hook that got renamed
* Update 9999_99_99_99_world_quest_get_me_outa_here.sql
* Rename 9999_99_99_99_world_quest_get_me_outa_here.sql to 2019_05_11_08_world.sql
(cherry picked from commit 552720a993 )
2021-12-05 15:15:52 +01:00
Shauren
dc4b516844
Core/Movement: Use correct root check
...
(cherry picked from commit 3e9239a1e5 )
2021-12-05 14:38:39 +01:00
Shauren
34eedc2ad8
Core/Movement: Prevent rooted units from falling
...
* Fixes a client freeze
Closes #23042
(cherry picked from commit 99a9129a72 )
2021-12-05 14:38:26 +01:00
brotalnia
ab988dc982
Core/Spells: Return CheckCast result from CastSpell ( #23236 )
...
* Return CheckCast result from CastSpell
* Return cast result from UnitAI methods too.
(cherry picked from commit 49d0a5bbb6 )
2021-12-05 14:37:13 +01:00
Aokromes
8f8ea509cb
Core/Movement: Fix Warrior's Charge launch visual while jumping backw… ( #23243 )
...
* Core/Movement: Fix Warrior's Charge launch visual while jumping backwards
By Natureknight
* fix no-pch
(cherry picked from commit cc1a520299 )
2021-12-05 14:03:47 +01:00
Wyrserth
558772a0bc
Core/Quest: improve source item deletion logic for items that give quests ( #23250 )
...
* Core/Quest: improve source item deletion logic for items that give quests.
Prevent deletion of items that aren't supposed to be destroyed (like Demon Scarred Cloak).
* Whoops.
(cherry picked from commit 49dc8a8e44 )
2021-12-05 14:01:48 +01:00
Shauren
3a5f87ccb8
Core/AreaTriggers: Initialize _spawnId in constructor
2021-12-05 11:17:54 +01:00
Shauren
77ddb4da81
Core/AreaTriggers: Move ScriptName from areatrigger_template to areatrigger_create_properties and areatrigger tables
2021-12-04 23:47:40 +01:00
Shauren
759d2fdd86
Core/Spells: Initialize EffectIndex of empty effects to their proper values instead of always being 0
...
Closes #27261
2021-12-04 23:20:55 +01:00
Shauren
6e5f35a14c
Core/Quests: Allow more objects to update their dynamicflags in Player::UpdateForQuestWorldObjects
2021-12-04 21:18:46 +01:00
Shauren
eb834272cb
Core/Quests: Optimize Player::HasQuestForGO
2021-12-04 21:17:43 +01:00
Meji
198d18bef5
Core/SAI: Fixed crash when using SMART_TARGET_CLOSEST_* in areatrigger smart script ( #27336 )
...
Co-authored-by: Shauren <shauren.trinity@gmail.com >
2021-12-04 20:40:06 +01:00
Meji
0d0f9784a9
Core/Conditions: Added CONDITION_SOURCE_TYPE_TRAINER_SPELL ( #27321 )
2021-12-04 14:42:54 +01:00
Shauren
7e779a6f59
Core/Units: Send PlayHoverAnim state in CreateObject if enabled by Unit::SetPlayHoverAnim
2021-12-04 12:45:46 +01:00
Keader
0b7089a7d1
Scripts/Icecrown Citadel: Fixed a edge case in Blood Quickening quest
...
killer can be a pet
(cherry picked from commit a639a99c6c )
2021-12-04 00:37:17 +01:00
Demonid
f981b15389
Scripts/Icecrown Citadel: The Lich King's Last Stand quest kill credit ( #23239 )
...
Closes #8919
(cherry picked from commit d1c5b3c897 )
2021-12-04 00:31:32 +01:00
Trond B. Krokli
b6dc6fd742
Core/Spells: make Four Horsemen debuffs negative ( #23253 )
...
By Riztazz
Closes #23248
(cherry picked from commit 1e97dfec53 )
2021-12-04 00:31:32 +01:00
Killyana
bdb728a165
Spell/Script: Throw Torch must hit only one target
...
(cherry picked from commit ce562415ed )
2021-12-04 00:31:32 +01:00
Wyrserth
238726b824
Core/Achievement: fix mistake related to ACHIEVEMENT_CRITERIA_TYPE_OWN_ITEM. ( #23252 )
...
(cherry picked from commit b76bcc836c )
2021-12-04 00:31:32 +01:00
Wyrserth
3264ef1f75
Core/Achievement: correctly credit progress for skill-related achievements when learning a new skill. ( #23249 )
...
(cherry picked from commit 0a25069db4 )
2021-12-04 00:31:32 +01:00
jackpoz
ccc8d679d8
Core/Misc: Log Map name in asserts
...
(cherry picked from commit 991b2a11bd )
2021-12-04 00:31:32 +01:00
jackpoz
6be185e6a2
Core/Misc: Log Spell/Aura name in Spell/Auras asserts
...
(cherry picked from commit 4130384f2e )
2021-12-04 00:31:28 +01:00
jackpoz
a855e6221d
Core/Vehicles: Fix accessories disappearing on reset
...
(cherry picked from commit 6dae4a747d )
2021-12-03 22:02:13 +01:00
jackpoz
eb25fbd485
Core/Misc: Apply fatigue when flying too
...
Fix #22856
(cherry picked from commit a76d01278a )
2021-12-03 22:01:02 +01:00
Killyana
19ce65c01b
Remove deprecated code
...
(cherry picked from commit fe311260f7 )
2021-12-03 22:00:47 +01:00
Killyana
1ced6d2192
Remove Deprecated code
...
(cherry picked from commit fd166025c8 )
2021-12-03 22:00:39 +01:00
Shauren
768ed2cbdc
Core/Spells: Use 3D distance for calculating speed from movement time instead of 2D
2021-12-03 16:12:10 +01:00
Giacomo Pozzoni
910e0b70ef
Core/Vehicles: Fix multiple vehicle join events on same seat ( #23233 )
...
(cherry picked from commit d4414af2d4 )
2021-12-03 00:23:24 +01:00
Jozef Dúc
a13a765610
Core/Object: Range check vol. 2 ( #23226 )
...
* Core/Object: Fix all missing parts for #23062
* Update GameObject.cpp
(cherry picked from commit 78070163dc )
2021-12-03 00:21:19 +01:00
sirikfoll
03e03f3fc6
Core/Scripts: Fix Skadi dismount issue
...
Closes #23005
(cherry picked from commit fe3bf57aba )
2021-12-02 23:51:51 +01:00
Giacomo Pozzoni
46170fdf01
Scripts/Spells: Fix implementation of #22332 ( #23228 )
...
Change the way #22332 moved spell damage calculations from SpellEffectDMG to scripts, using OnEffectLaunchTarget and SetEffectValue instead
(cherry picked from commit 20772dbf5d )
2021-12-02 23:46:00 +01:00
jackpoz
97be87b7d5
Core/LFG: Remove dungeon cooldown when completing random dungeons
...
(cherry picked from commit 24fbbee4b9 )
2021-12-02 23:45:29 +01:00
ccrs
c22431936e
Core/Creature: couple refactors/renaming
...
(cherry picked from commit 69c15f5ae7 )
2021-12-02 23:45:14 +01:00
Killyana
5163559c1e
Quest/Script: Breakfast Of Champions
...
Set both Earthshaker Drum Events to 50%
(cherry picked from commit 14445088ea )
2021-12-02 19:35:47 +01:00
ccrs
1ba002ef3d
Core/Object: re-change faction template related logs
...
(cherry picked from commit dfa54d3bf4 )
2021-12-02 00:39:28 +01:00