Commit Graph

26679 Commits

Author SHA1 Message Date
Killyana
2de20560fe Core/GameObject: Fix wrong calculation of the spellfous distance
Closes #24177

(cherry picked from commit 828987a46a)
2021-12-21 23:57:19 +01:00
Ovahlord
a90b9abbf0 Core/SAI: SMART_ACTION_PAUSE_MOVEMENT
Closes #22346

(cherry picked from commit 6f31784979)
2021-12-21 23:55:34 +01:00
dr-j
cc1a6497e4 DB/Quest: Reconnaissance Flight
Closes #23792

(cherry picked from commit 92ac6ca0fe)
2021-12-21 23:26:38 +01:00
Sorikoff
1e93210999 [WIP] Core/AI: Pets musn't attack civilian NPC in aggressive mode (#24121)
* Core/AI: Pets musn't attack civilian NPC in aggressive mode

* Move decision to ignore civilians to PetAI, keeping the check in GridNotifiers

Co-authored-by: Giacomo Pozzoni <giacomopoz@gmail.com>
(cherry picked from commit 5f20715e2f)
2021-12-21 23:06:20 +01:00
ratkosrb
72093e98e1 Core/Creature: Use proper name for wander distance. (#24133)
* Use proper name for wander distance.

* Rename db field.

* Fix query.

* Remove underscore from chat command.

* Rename the handler too.

* Update chat command description.

* Fix remaining issues.

* Rename 2020_99_99_99_world_335.sql to 2020_02_16_01_world.sql

Co-authored-by: Giacomo Pozzoni <giacomopoz@gmail.com>
(cherry picked from commit 6176ce92ea)

# Conflicts:
#	sql/updates/world/master/2020_02_16_01_world.sql
#	src/server/database/Database/Implementation/WorldDatabase.cpp
#	src/server/game/Entities/Creature/Creature.cpp
#	src/server/game/Globals/ObjectMgr.cpp
#	src/server/game/Globals/ObjectMgr.h
#	src/server/scripts/Commands/cs_npc.cpp
2021-12-21 19:50:12 +01:00
schell244
460549799e Scripts/World: Hourly Bell sound, further improvements (#24147)
* Improvements for hourly bell sound

* TC codestyle

* added missing breaks and improve codestyle

(cherry picked from commit baa87c43ba)
2021-12-21 18:32:22 +01:00
Shauren
2c78f4dd1f Core/Misc: Resolve c++17 TODOs left in code as comments 2021-12-21 18:29:52 +01:00
Ujp8LfXBJ6wCPR
6229a6ddc1 Remove dependency on undefined behaviour (#24159)
See https://stackoverflow.com/a/4328396
Previous method works but is technically illegal.

(cherry picked from commit b089ed3b75)
2021-12-21 16:36:07 +01:00
Rushor
2326eac4f9 Scripts/Gameobject: Journal of Jandice Barov- Convert script to SAI. (#24157)
* Scripts/Gameobject: Journal of Jandice Barov- Convert script to SAI. (Thanks to Sunwell)

* Scripts/Gameobject: Journal of Jandice Barov - Update script and move go spawn to bossscript

* Update boss_jandice_barov.cpp

Co-authored-by: Eridium <6587064+Killyana@users.noreply.github.com>
(cherry picked from commit f0bf447cd1)
2021-12-21 16:33:47 +01:00
Rushor
41b10f4bb8 Scripts/Gameobject: Remove deprecated script for Cat Figurine (#24150)
Scripts/Gameobject: Remove deprecated script for Cat Figurine

(cherry picked from commit 596b2d1ed7)
2021-12-21 16:27:45 +01:00
Ujp8LfXBJ6wCPR
42ce97a74c Core/Misc: Remove redundant null pointer checks before delete (#24140)
* Identified by clang-tidy readability-delete-null-pointer

(cherry picked from commit 9264e5b6f0)
2021-12-21 16:19:13 +01:00
Rushor
1516759859 Scripts/Kalimdor: Move script of Hand of Iruxos Crystal to database. (#24141)
* Scripts/Kalimdor: Move script of Hand of Iruxos Crystal to database.

* Scripts/Kalimdor: Hand of Iruxos Crystal - Add despawn for gameobject.

* Scripts/Kalimdor: Hand of Iruxos Crystal - Add despawn for gameobject.

* Remove unneeded commentline

* Rename 9999_99_99_99_world.sql to 2020_02_11_00_world.sql

Co-authored-by: Aokromes <Aokromes@users.noreply.github.com>
(cherry picked from commit a67dd6ab60)
2021-12-21 15:56:23 +01:00
Killyana
d403e36538 DB/Text: Fix and remove some npc_text
(cherry picked from commit 7450be4cfd)
2021-12-21 15:54:36 +01:00
Ovah
a91be4995b Core/Vehicles: implement vehicle seat addon table to specify seat ori… (#24112)
* Core/Vehicles: implement vehicle seat addon table to specify seat orientation offsets and exit positions in form of offsets or absolute positions
* converted Traveler's Tundra Mammoth to seat addon table data

* first follow batch

* whoopsie

* Core/Vehicles: go from local copies to pointers

* Update and rename 2020_99_99_99_world.sql to 2020_02_08_01_world.sql

Co-authored-by: Giacomo Pozzoni <giacomopoz@gmail.com>
(cherry picked from commit 98d6c501d7)
2021-12-21 15:32:49 +01:00
schell244
eae7379417 Core/Scripting: fixed hourly bell sounds (#24127)
* fixed hourly bell sounds

* use switch and moved variable

* fix typo

(cherry picked from commit f87a4543ad)
2021-12-21 15:21:57 +01:00
Ujp8LfXBJ6wCPR
91a0fbbd71 Use boost::optional and boost::none instead of smelly pointer (#24134)
* Remove bad pointer usage from CharacterCache

Use TrinityCore Option type instead which is intended for this purpose. (Wrapper around boost::option until C++17 bump is finalised)

* Unify codestyle regarding TC optional type

Based upon advice from @Shauren

(cherry picked from commit 76831f1f46)
2021-12-21 15:21:39 +01:00
Treeston
94a79bac7a Core/Misc: Some refactoring, #23603 prep: (#23676)
- Split SpawnMetadata off from SpawnData
- No longer allocate Creature/Gameobject objects in ObjectGridLoader just to check their typeid and delete them afterwards

Co-authored-by: Giacomo Pozzoni <giacomopoz@gmail.com>
(cherry picked from commit 9304e496cb)
2021-12-21 15:16:26 +01:00
Keader
e453c632e6 Game/Battlegrounds: Fixed Position and Rotation of Alterac Valley Gates
(cherry picked from commit ddd1a3c1ef)
2021-12-21 01:19:38 +01:00
Sorikoff
6433ed6014 Scripts/Spells: Gift of the Harvester (#24111)
* Scripts/Spells: Gift of the Harvester

* Scripts/Spells: nopch

* Scripts/Spells: nopch

* Scripts/Spells: validate

* Rename 9999_99_99_99_world.sql to 2020_02_01_03_world.sql

Co-authored-by: Giacomo Pozzoni <giacomopoz@gmail.com>
(cherry picked from commit e10239311c)
2021-12-21 00:48:30 +01:00
Giacomo Pozzoni
f1f1bc01ba Core/Movement: Fix WaypointMovementGenerator ignoring EscortAI::SetEscortPaused() on Gossip Hello (#24005)
Fix WaypointMovementGenerator ignoring EscortAI::SetEscortPaused() when talking to a NPC, scheduling a 3 minutes pause on the WaypointMovementGenerator even if it was already disabled with no timer, waiting for the player to select a gossip entry to resume the movement.

(cherry picked from commit a9e534762f)
2021-12-21 00:46:32 +01:00
ForesterDev
9124fd1f1f Core/Items: implement some helper methods for easier readability (#24113)
(cherry picked from commit 573ddf4d22)
2021-12-21 00:46:13 +01:00
Sorikoff
e882635774 Scripts/Borean Tundra: Iruk (#24117)
* Scripts/Borean Tundra: Iruk

* Apply suggestions from code review

Co-Authored-By: Trond B. Krokli <38162891+illfated@users.noreply.github.com>

* Update 9999_99_99_99_world.sql

* Rename 9999_99_99_99_world.sql to 2020_02_01_01_world.sql

Co-authored-by: Trond B. Krokli <38162891+illfated@users.noreply.github.com>
Co-authored-by: Giacomo Pozzoni <giacomopoz@gmail.com>
(cherry picked from commit 8c443ae39f)
2021-12-21 00:12:13 +01:00
Sorikoff
3daeb28420 Scripts/The Barrens: Beaten Corpse (#24124)
* Scripts/The Barrens: Beaten Corpse

* Rename 9999_99_99_99_world.sql to 2020_02_01_00_world.sql

Co-authored-by: Giacomo Pozzoni <giacomopoz@gmail.com>
(cherry picked from commit 74d19691a5)
2021-12-21 00:11:39 +01:00
Killyana
e57967aa3f DB/Creature: Plagued Dragonflayer Tribesman & Plagued Dragonflayer Rune-Caster & Plagued Dragonflayer Handler
Closes #24122

(cherry picked from commit c86d4404c8)
2021-12-21 00:08:43 +01:00
Ovah
5c258c1bbd Core/Scripting: fixed build. Re-enable ModifyVehiclePassengerExitPos for CreatureScript to allow scripted creatures that already have an AI to benefit from its functionality as well
(cherry picked from commit f0485cea39)
2021-12-20 23:56:45 +01:00
Ovah
64fc549be8 Core/AI: call ModifyVehiclePassengerExitPos for CreatureScripts since the hook is available for that class as well
(cherry picked from commit ebf116e6a3)
2021-12-20 23:56:31 +01:00
Killyana
ac4df1d856 Spell/Script: Fix Prison chain for Unworty Initiate
Closes #24089
The spell 54613 is not used in the game

(cherry picked from commit 0ec2a5fd74)
2021-12-20 23:52:52 +01:00
Sorikoff
a463e7f1bd Scripts/Ebon Hold: How To Win Friends And Influence Enemies (#24090)
* Scripts/Ebon Hold: How To Win Friends And Influence Enemies

* Scripts/Ebon Hold: Improve SQL!

* Scripts/Ebon Hold: Final touch

* Scripts/Ebon Hold: Actually final touch

* Rename 9999_99_99_99_world.sql to 2020_01_26_04_world.sql

Co-authored-by: Giacomo Pozzoni <giacomopoz@gmail.com>
(cherry picked from commit 13c81f55e3)
2021-12-20 23:47:37 +01:00
Sorikoff
d37547e769 Scripts/Borean Tundra: Plug the Sinkholes (#24085)
* Scripts/Borean Tundra: Plug the Sinkholes

* Scripts/Borean Tundra: Improve SQL

* Scripts/Borean Tundra: Remove item script

* Rename 9999_99_99_99_world.sql to 2020_01_26_03_world.sql

Co-authored-by: Giacomo Pozzoni <giacomopoz@gmail.com>
(cherry picked from commit 552a638e31)
2021-12-20 23:47:37 +01:00
Ovah
cdeb752941 Core/Movement: improved RandomMovementGenerator wait handling to get closer to retail behaivior (#24093)
* according to observations Blizzard is letting creatures do 2 up to 10 spline movements right after each other before waiting for a couple seconds

(cherry picked from commit 78c1216bcf)
2021-12-20 23:47:37 +01:00
Kelno
ce8c83ef6f Core/Maps: cosmetic correction on comment (#24096)
(cherry picked from commit d0efd76c92)
2021-12-20 23:47:37 +01:00
Ovahlord
606597f4f8 Core/Movement: reset position update interrupt info after the interrupt checks have been executed
* for discussion see: 02daf1bf3a (r36916229)

(cherry picked from commit 01584cb0b9)
2021-12-20 23:47:37 +01:00
Ovah
43a7091e8a Core/Movement: properly fix aura interrupts during movement (#24068)
We want our movement to be fully updated before even thinking about interrupting anything. The old logic was updating positions, interrupting stuff and afterwards updating movement generators. This way we were ending up with false interrupts.

properly fixes #22908

(cherry picked from commit 02daf1bf3a)
2021-12-20 23:47:23 +01:00
jackpoz
0ed58b0952 Core/MMaps: Handle path on same position
Handle path on the same polygon between 2 very close positions as a normal path.

(cherry picked from commit d293dd3782)
2021-12-20 23:16:21 +01:00
Giacomo Pozzoni
1a070fd127 Core/PathGenerator: Fix path generator returning shortcuts when start and end are on the same polygon (#24083)
* Core/PathGenerator: Fix path generator returning shortcuts when start and end are on the same polygon

Second try of handling paths on same poly in a better way than just building a shortcut

* Fix movement generators using paths with start/end positions far from mmap polygons

* Include flag PATHFIND_FARFROMPOLY even with a normal path if start or end were far away from mmap poly

(cherry picked from commit 67d9d04d63)
2021-12-20 23:15:54 +01:00
Killyana
4dfaaa61ce DB/Quest: Convert Reports from the Field to SAI
(cherry picked from commit c1580108f6)
2021-12-20 23:14:55 +01:00
NoName
5e267dda71 Core/Gameobject: Rename GO_STATE_ACTIVE_ALTERNATIVE to GO_STATE_DESTROYED (#24062)
* Step 1: Rename GO_STATE_ACTIVE_ALTERNATIVE to GO_STATE_DESTROYED

* Update src/server/shared/SharedDefines.h

Co-Authored-By: Trond B. Krokli <38162891+illfated@users.noreply.github.com>

Co-authored-by: Trond B. Krokli <38162891+illfated@users.noreply.github.com>
(cherry picked from commit 50d9d9196d)
2021-12-20 23:13:47 +01:00
Sorikoff
868784636b Scripts/Quests: Reports from the Field (#24075)
(cherry picked from commit bfac09bbcf)
2021-12-20 23:08:41 +01:00
Sorikoff
a4b8371c93 Scripts/Violet Stand: Warmages (#24084)
* Scripts/Violet Stand: Warmages

* Rename 9999_99_99_99_world.sql to 2020_01_19_02_world.sql

Co-authored-by: Giacomo Pozzoni <giacomopoz@gmail.com>
(cherry picked from commit 07c0bfe11b)
2021-12-20 23:06:17 +01:00
Sorikoff
97c28f4a42 Scripts/Transitus Shield: Warmages (#24082)
* Scripts/Transitus Shield: Warmage

* Scripts/Transitus Shield: SQL fix

* Scripts/Transitus Shield: improve SQL

* Rename 9999_99_99_99_world.sql to 2020_01_19_01_world.sql

Co-authored-by: Giacomo Pozzoni <giacomopoz@gmail.com>
(cherry picked from commit f20b147c71)
2021-12-20 23:04:44 +01:00
jackpoz
4bab876fe4 Core/PathGenerator: Temporarily revert 29bf280e34
Temporarily revert 29bf280e34 since our recast implementation always expects a path to have different polygons.
A proper fix will be implemented later on, splitting a path with 1 single polygons in smaller steps in a similar way of how FindSmoothPath() works

(cherry picked from commit 9f8477cd11)
2021-12-20 23:01:40 +01:00
jackpoz
87e5b3a08c Scripts/Ulduar: Fix Ominous Clouds movements
Fix Ominous Clouds being only clockwise, now they move both clock and counter-clock wise.
Add a workaround for GenericMovementGenerator not handling correctly cyclic splines started by MoveCirclePath(), stopping the movement after a single round. The workaround code can be removed once the bug in GenericMovementGenerator is fixed.

(cherry picked from commit c1df161e1d)
2021-12-20 22:34:14 +01:00
NoName
37178ff311 Core/Spells: SPELL_AURA_48 implementation (#24054)
by xvwyh

(cherry picked from commit b3b7f0761d)
2021-12-20 22:30:41 +01:00
Killyana
ef794af489 Spell: "Fierce Lightning Stike" must hit only one target
(cherry picked from commit 8942142286)
2021-12-20 22:15:44 +01:00
Shauren
5d02739b98 Scripts: Fix rbac permission for skipping default boss sequencing check
(cherry picked from commit e660c8bc19)
2021-12-20 21:40:47 +01:00
Kelno
45585b5305 Fixed PvP Combat timer never getting refreshed (#24058)
* Fixed PvP Combat timer never gets refreshed while meleeing

* Apply Treeston feedback

Co-authored-by: Giacomo Pozzoni <giacomopoz@gmail.com>
(cherry picked from commit 2b024e8fbf)
2021-12-20 21:25:46 +01:00
Regigicas
aa81d8979f Core/SAI: Fix SMART_ACTION_SET_MOVEMENT_SPEED behavior (#24059)
(cherry picked from commit 1369620436)
2021-12-20 21:25:33 +01:00
Giacomo Pozzoni
ce25c212e0 Scripts/Ulduar: Attempt to fix Yogg-Saron not evading on wipe (#24055)
(cherry picked from commit 039534d1db)
2021-12-20 21:24:51 +01:00
Alan Deutscher
cd72ecce78 Scripts/Spells: fix Turkey Timer duration (#24048)
* spell_gen_turkey_marker::OnPeriodic: Pop expired stack timestamps from tracking list.

* Be a bit more explicit about the data type of removedCount.

* Formatting nudge.

* Remove brackets.

(cherry picked from commit a0c07655eb)
2021-12-20 21:24:37 +01:00
xvwyh
9b79d1b410 Core/DynamicObjects: Restore the ability of DynamicObjects to be world objects which was accidentally removed in f0f4a620fb breaking Far Sight (#24046)
Fixes #17081

(cherry picked from commit d4ba47a76e)
2021-12-20 21:22:37 +01:00